Re: [ovs-dev] [PATCH] ci: make linux-prepare trust system installs.

2021-10-27 Thread Ilya Maximets
On 10/26/21 20:26, Aaron Conole wrote: > Recently, the github actions CI environment has been broken due to an > incompatibility between sphinx-build and the docutils python package. > The pip3 install command will upgrade docutils to an incompatible > version. > > Since we install sphinx via pip3

Re: [ovs-dev] [RFC 00/11] python: introduce flow parsing library

2021-10-27 Thread Adrian Moreno
Thanks for you comments Eelco. On 10/21/21 11:52, Eelco Chaudron wrote: On 1 Sep 2021, at 12:00, Adrian Moreno wrote: While troubleshooting or developing new features in OVS, a considerable amount of time is spent analyzing flows (whether that's Openflow flows or datapath flows). Currently,

[ovs-dev] [PATCH v2 1/3] upcall: prevent from installing flows when inconsistence

2021-10-27 Thread lic...@chinatelecom.cn
In ovs kernel datapath upcall, the *key* and packet are passed to userspace. The key contains the fields/meta extracted from packet. Once the ovs-vswitchd receives the upcall, the packet is extracted again into *flow*. Next, the flow is used to match openflow rules to generate the wildcard(wc). A

[ovs-dev] [PATCH v2 2/3] tests: fix packet data endianness

2021-10-27 Thread lic...@chinatelecom.cn
Without this fix, flowgen.py generates bad tcp pkts. tcpdump reports "bad hdr length 4 - too short" with the pcap generated by flowgen.py This patch is to correct pkt data endianness Signed-off-by: lic121 --- tests/flowgen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[ovs-dev] [PATCH v2 3/3] upcall: considering dataofs when parsing tcp pkt

2021-10-27 Thread lic...@chinatelecom.cn
dataofs field of tcp header indicates the tcp header len. The len should be >= 20 bytes/4. This patch is to test dataofs, and don't parse layer 4 fields when meet ba dataofs. This behave is the consistent with openvswitch kenrel module. Signed-off-by: lic121 --- lib/flow.c| 18

Re: [ovs-dev] [PATCH v2 1/3] upcall: prevent from installing flows when inconsistence

2021-10-27 Thread 0-day Robot
Bleep bloop. Greetings lic...@chinatelecom.cn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author lic...@chinatelecom.cn needs to sign off. WARNING: Unexpected sign-off

Re: [ovs-dev] [PATCH v2 2/3] tests: fix packet data endianness

2021-10-27 Thread 0-day Robot
Bleep bloop. Greetings lic...@chinatelecom.cn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author lic...@chinatelecom.cn needs to sign off. WARNING: Unexpected sign-off

Re: [ovs-dev] [PATCH v2 3/3] upcall: considering dataofs when parsing tcp pkt

2021-10-27 Thread 0-day Robot
Bleep bloop. Greetings lic...@chinatelecom.cn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author lic...@chinatelecom.cn needs to sign off. WARNING: Unexpected sign-off

Re: [ovs-dev] [PATCH] TCP Stream: Use TCP keepalive by default

2021-10-27 Thread Flavio Leitner
On Mon, Oct 25, 2021 at 10:36:32AM -0400, Michael Santana wrote: > In the case that a client disables jsonrpc probes the client would fail > to detect if the connection to the server has dropped. To workaround > such case TCP keepalive is enabled. > > Signed-off-by: Michael Santana > --- Patch l

[ovs-dev] [PATCH ovn] utilities: nbctl: add --may-exist parameter to meter-add cmd

2021-10-27 Thread Lorenzo Bianconi
Add --may-exist support to meter-add command in order to update meter parameters if it has been already created Signed-off-by: Lorenzo Bianconi --- tests/ovn-nbctl.at| 6 +++-- tests/ovn-northd.at | 11 +- utilities/ovn-nbctl.c | 51 --- 3 f

Re: [ovs-dev] [PATCH] ci: make linux-prepare trust system installs.

2021-10-27 Thread Ilya Maximets
On 10/27/21 11:33, Ilya Maximets wrote: > On 10/26/21 20:26, Aaron Conole wrote: >> Recently, the github actions CI environment has been broken due to an >> incompatibility between sphinx-build and the docutils python package. >> The pip3 install command will upgrade docutils to an incompatible >>

[ovs-dev] [PATCH v3] ovs-tcpdump: Improve performance with dummy interface

2021-10-27 Thread Mike Pattrick
Currently the ovs-tcpdump utility creates a virtual tunnel to send packets to. This method functions perfectly fine, however, it can greatly impact performance of the monitored port. It has been reported to reduce packet throughput significantly. I was able to reproduce a reduction in throughput o

Re: [ovs-dev] [PATCH] ci: make linux-prepare trust system installs.

2021-10-27 Thread Numan Siddique
On Wed, Oct 27, 2021 at 11:06 AM Ilya Maximets wrote: > > On 10/27/21 11:33, Ilya Maximets wrote: > > On 10/26/21 20:26, Aaron Conole wrote: > >> Recently, the github actions CI environment has been broken due to an > >> incompatibility between sphinx-build and the docutils python package. > >> Th

Re: [ovs-dev] [PATCH] ci: make linux-prepare trust system installs.

2021-10-27 Thread Numan Siddique
On Wed, Oct 27, 2021 at 11:52 AM Numan Siddique wrote: > > On Wed, Oct 27, 2021 at 11:06 AM Ilya Maximets wrote: > > > > On 10/27/21 11:33, Ilya Maximets wrote: > > > On 10/26/21 20:26, Aaron Conole wrote: > > >> Recently, the github actions CI environment has been broken due to an > > >> incompa

[ovs-dev] [PATCH ovn v4 0/6] northd: Introduce incremental processing framework

2021-10-27 Thread Mark Gray
Add the 'inc-proc-eng' framework to northd. This does *not* add any incremental processing at this stage but provides the framework to do so. Even in this base configuration, we see an advantage as northd no longer processes the databases if it has been woken only to handle, for example, a unixctl

[ovs-dev] [PATCH ovn v4 1/6] inc-proc-eng: Allow definition of engine_node with global scope

2021-10-27 Thread Mark Gray
Refactor ENGINE_NODE() macro to not assign function pointers. This allows ENGINE_NODE() to be used outside functions, creating an engine_node with global scope (but can be statically defined within a file). This allows more flexibility in how the I-P engine can be used. Although this is not explici

[ovs-dev] [PATCH ovn v4 3/6] northd: Add n_nat_entries field to 'struct ovn_datapath'

2021-10-27 Thread Mark Gray
destroy_nat_entries() iterates over nat_entries using 'n_nat' as the number of NAT entries from the NB database. This behaviour can be incorrect as it assumes that there are 'n_nat' 'nat_entries'. 'struct ovn_datapath' should maintain a count of 'nat_entries' in 'struct ovn_datapath' rather than re

[ovs-dev] [PATCH ovn v4 2/6] northd: Introduce incremental processing for northd

2021-10-27 Thread Mark Gray
Initial implementation adds a single node (northd). This single node executes the northd processing pipeline but does not do so incrementally. In order to develop incremental processing for northd, the code will be organised with a .c/.h file for each I-P node following the naming convention en-.c

[ovs-dev] [PATCH ovn v4 5/6] northd: Add lflow node

2021-10-27 Thread Mark Gray
Add an additional node that initially does nothing. This serves as a template for how to add a new node. This node is inserted after the northd_node. This node will be updated in a later commit to generate logical flows for the SBDB. Signed-off-by: Mark Gray --- northd/automake.mk | 2 ++

[ovs-dev] [PATCH ovn v4 4/6] northd: Introduce struct northd_data

2021-10-27 Thread Mark Gray
'struct northd_data' is used to hold the global state data for the incremental processing node 'en_northd'. This structure will also hold 'struct northd_input' which will hold references to output data from its input nodes. In particular, this will hold references to database tables and indexes. In

[ovs-dev] [PATCH ovn v4 6/6] northd: Do not calculate database sequence numbers incrementally

2021-10-27 Thread Mark Gray
In order to remove the IDL loop variable from the engine context, we do not calculate the database sequence numbers incrementally. Signed-off-by: Mark Gray --- lib/inc-proc-eng.h | 2 - northd/en-northd.c | 3 +- northd/inc-proc-northd.c | 2 - northd/inc-proc-northd.h | 1 - nor

Re: [ovs-dev] [PATCH ovn v3 2/7] northd: Introduce incremental processing for northd

2021-10-27 Thread Mark Gray
On 27/10/2021 07:00, Han Zhou wrote: > I would suggest using a separate structure, such as "northd_input" (or a > better name) to include the index and tables. The data of en_northd should > only contain the data generated by the engine node (i.e. output data). > > Thanks, > Han Thanks for all yo

Re: [ovs-dev] [PATCH v3] ovs-tcpdump: Improve performance with dummy interface

2021-10-27 Thread Aaron Conole
Mike Pattrick writes: > Currently the ovs-tcpdump utility creates a virtual tunnel to send > packets to. This method functions perfectly fine, however, it can > greatly impact performance of the monitored port. > > It has been reported to reduce packet throughput significantly. I was > able to re

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Introduce struct northd_data

2021-10-27 Thread 0-day Robot
Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #1478 FILE: northd/northd.c:14488: /* XXX Having to explicit

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Introduce struct northd_data

2021-10-27 Thread Mark Gray
On 27/10/2021 18:53, 0-day Robot wrote: > Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Comment with 'xxx' marker > #14

Re: [ovs-dev] [PATCH v3 1/2] socket-util: split inet_open_active function and use connect_ex

2021-10-27 Thread Terry Wilson
On Mon, Oct 25, 2021 at 8:46 AM Timothy Redaelli wrote: > > In an upcoming patch, PyOpenSSL will be replaced with Python ssl module, > but in order to do an async connection with Python ssl module the ssl > socket must be created when the socket is created, but before the > socket is connected. >

Re: [ovs-dev] [PATCH v3 2/2] python: replace pyOpenSSL with ssl

2021-10-27 Thread Terry Wilson
On Mon, Oct 25, 2021 at 8:46 AM Timothy Redaelli wrote: > > Currently, pyOpenSSL is half-deprecated upstream and so it's removed on > some distributions (for example on CentOS Stream 9, > https://issues.redhat.com/browse/CS-336), but since OVS only > supports Python 3 it's possible to replace pyOp

Re: [ovs-dev] [PATCH] netdev-offload-tc: verify the flower rule installed

2021-10-27 Thread Ilya Maximets
On 7/14/21 13:18, Eelco Chaudron wrote: > > > On 12 Jul 2021, at 14:54, Marcelo Ricardo Leitner wrote: > >> On Mon, Jul 12, 2021 at 10:28:15AM +0200, Eelco Chaudron wrote: >>> >>> >>> On 9 Jul 2021, at 20:23, Ilya Maximets wrote: >>> On 7/9/21 10:35 AM, Eelco Chaudron wrote: > > >>>

[ovs-dev] [PATCH v2 1/1] datapath-windows:Reset PseudoChecksum value only for TX direction offload case

2021-10-27 Thread Alin-Gabriel Serdean
> While testing OVS-windows flows for the DNAT/SNAT action, the checksum in > TCP header is set incorrectly when TCP offload is enabled by default. As a > result,the packet will be dropped on the Windows VM when processing the packet > from Linux VM which has included correct checksum at first. O

Re: [ovs-dev] [PATCH v7 10/12] lib: Add infrastructure for plug providers.

2021-10-27 Thread Han Zhou
On Tue, Oct 19, 2021 at 3:14 AM Frode Nordahl wrote: > > New lib/plug-provider module contains the infrastructure for > registering plug provider classes which may be hosted inside or > outside the core OVN repository. > > New controller/plug module adds internal interface for interacting > with t

Re: [ovs-dev] [PATCH v7 11/12] ovn-controller: Prepare plug provider infrastructure.

2021-10-27 Thread Han Zhou
On Tue, Oct 19, 2021 at 3:14 AM Frode Nordahl wrote: > > Add port by interfaces index - To be able to effectively remove > ports previously plugged by us we need to look up ports by > interface records. > > Add `enable-dummy-plug` option - To enable testing of the plugging > infrastructure without

Re: [ovs-dev] [PATCH v7 10/12] lib: Add infrastructure for plug providers.

2021-10-27 Thread Han Zhou
On Wed, Oct 27, 2021 at 10:43 PM Han Zhou wrote: > > > On Tue, Oct 19, 2021 at 3:14 AM Frode Nordahl wrote: > > > > New lib/plug-provider module contains the infrastructure for > > registering plug provider classes which may be hosted inside or > > outside the core OVN repository. > > > > New con

Re: [ovs-dev] [PATCH v7 12/12] controller: Consider plugging of ports on CMS request.

2021-10-27 Thread Han Zhou
On Tue, Oct 19, 2021 at 3:14 AM Frode Nordahl wrote: > > When OVN is linked with an appropriate plugging implementation, > CMS can request OVN to plug individual lports into the local > Open vSwitch instance. > > The port and instance record will be maintained during the lifetime > of the lport an