[ovs-dev] [PATCH] doc: fix install doc

remove bad quotes Signed-off-by: lic121 --- Documentation/intro/install/dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 296ec4f..d554409 100644 ---

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix check_pkt_larger incomplete translation.

From: Numan Siddique xlate_check_pkt_larger() sets ctx->exit to 'true' at the end causing the translation to stop. This results in incomplete datapath rules. For example, for the below OF rules configured on a bridge, table=0,in_port=1

Re: [ovs-dev] [PATCH] ovsdb-idl: Use functions to apply diff in place.

On 10/21/21 11:16, Dumitru Ceara wrote: > On large scale deployments with records that contain large sets, this > significantly improves client side performance as it avoids comparing > full contents of the old and new rows. > > Signed-off-by: Dumitru Ceara > --- > lib/ovsdb-idl.c | 68

Re: [ovs-dev] [PATCH] ovsdb: transaction: Incremental reassessment of weak refs.

On 11/2/21 17:18, Dumitru Ceara wrote: > On 10/16/21 3:20 AM, Ilya Maximets wrote: >> The main idea is to not store list of weak references in the source >> row, so they all don't need to be re-checked/updated on every >> modification of that source row. The point is that source row already >>

Re: [ovs-dev] [PATCH] ovsdb-idl: Add memory report function.

On 11/2/21 20:50, Dumitru Ceara wrote: > On 10/14/21 1:46 PM, Ilya Maximets wrote: >> Added new function to return memory usage statistics for database >> objects inside IDL. Statistics similar to what ovsdb-server reports. >> Not counting _Server database as it should be small, hence doesn't >>

Re: [ovs-dev] [PATCH v2] checkpatch: check if some tags are wrongly written

On 10/4/21 16:03, David Marchand wrote: > On Fri, Sep 10, 2021 at 11:08 AM Timothy Redaelli > wrote: >> >> Currently, there are some patches with the tags wrongly written (with >> space instead of dash ) and this may prevent some automatic system or CI >> to detect them correctly. >> >> This

Re: [ovs-dev] [PATCH v2 ovn] northd: fix check_pkt_larger ingress flows with FIP

On Thu, Nov 4, 2021 at 12:07 PM Lorenzo Bianconi wrote: > > Add missing icmp{4,6}_error flows for ingress traffic destinated to FIP > associated to the interface > > Related bz: https://bugzilla.redhat.com/show_bug.cgi?id=2018179 > Tested-by: Eran Kuris > > Signed-off-by: Lorenzo Bianconi

Re: [ovs-dev] [EXTERNAL] Re: [PATCH] RFC: netdev-dpdk: Add Windows support.

The news is good, thanks! On Thu, Nov 4, 2021 at 12:09 PM Omar Cardona wrote: > Hi *Ben,* > >- Yes, definitely. C11/C17 stdatomic.h is high on the list. >- Our current critical path item for MSVC DPDK support is TLS. > > > > Hi *Thomas,* > >- I will setup some time next week to

Re: [ovs-dev] [PATCH v5 0/2] flow dumps containing igmp match cannot be restored

Hi Ilya, Per your feedback on v4, I accounted for igmp_type/code, both in the work-around in 1/2, and removing it from match.c entirely in 2/2. I was not sure the best way to proceed regarding the issue I had mentioned on v4 where ofputil_normalize_match__() fails to recognize

[ovs-dev] [PATCH v5 2/2] Match: Do not print "igmp" match keyword

From: Adrian Moreno The match keyword "igmp" is not supported in ofp-parse, which means that flow dumps cannot be restored. Previously a workaround was added to ovs-save to avoid changing output in stable branches. This patch changes the output to print igmp match in the accepted ofp-parse

[ovs-dev] [PATCH v5 1/2] ovs-save: Save igmp flows in ofp_parse syntax

match.c generates the keyword "igmp", which is not supported in ofp-parse. This means that flow dumps containing 'igmp' can not be restored. Removing the 'igmp' keyword entirely could break existing scripts in stable branches, so this patch creates a workaround within ovs-save by converting any

[ovs-dev] [PATCH v5 0/2] flow dumps containing igmp match cannot be restored

match_format() prints the keyword "igmp" for flows with the field "ip,nw_proto=2". ofp_parse_protocol does not accept this value, or the values igmp_type or igmp_code. This results in flow dump restoration failing when the ovs-save script is used by "ovs-ctl restart" on a dump of flows containing

[ovs-dev] [PATCH ovn] nb: Add support for gateway_mtu_bypass.

There are various costs (e.g., not being able to perform hardware offload in some cases) when using check_pkt_larger() so the CMS can now limit the impact by bypassing the packet length checks for specific types of traffic (e.g., TCP). Reported-at:

Re: [ovs-dev] [EXTERNAL] Re: [PATCH] RFC: netdev-dpdk: Add Windows support.

Hi Ben, * Yes, definitely. C11/C17 stdatomic.h is high on the list. * Our current critical path item for MSVC DPDK support is TLS. Hi Thomas, * I will setup some time next week to discuss alignment and share our proposed MSVC plan. From: Ben Pfaff Sent: Thursday, November 4,

Re: [ovs-dev] [EXTERNAL] Re: [PATCH] RFC: netdev-dpdk: Add Windows support.

On Thu, Nov 4, 2021 at 8:37 AM Omar Cardona wrote: > > > f. With clang support on Windows, can we remove MSVC? > > Please no. We are actively working with the MSVC team to extend support > for DPDKs dependencies > Could you get them to implement C11 atomics? The MSVC support for atomic

[ovs-dev] [PATCH] utilities: Add another GDB macro for ovs-vswitchd

This commit adds a basic packet metadata macro to the already existing macros in ovs_gdb.py, ovs_dump_packets will print out information about one or more packets. Currently, it will only extract some basic L2-4 information from Ethernet frames. However, it could easily be extended as needed for

[ovs-dev] [PATCH v2 ovn] northd: fix check_pkt_larger ingress flows with FIP

Add missing icmp{4,6}_error flows for ingress traffic destinated to FIP associated to the interface Related bz: https://bugzilla.redhat.com/show_bug.cgi?id=2018179 Tested-by: Eran Kuris Signed-off-by: Lorenzo Bianconi --- Changes since v1: - add missing northd documentation ---

Re: [ovs-dev] [PATCH] dpif-netdev: Call cpuid for x86 isa availability.

> -Original Message- > From: Ilya Maximets > Sent: Wednesday, November 3, 2021 3:32 PM > To: David Marchand ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Amber, Kumar ; Van > Haaren, Harry ; Stokes, Ian > ; Ferriter, Cian > Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Call cpuid for

Re: [ovs-dev] [EXTERNAL] Re: [PATCH] RFC: netdev-dpdk: Add Windows support.

>> (Dynamic lib still not supported yet in DPDK Windows). This is dependent on TLS support, where a workaround PoC is avail, but not yet upstreamed. > > Windows DPDK library hasn't finished all its library/driver porting to > > Windows. Our focus is primarily the DPDK libraries which support

Re: [ovs-dev] [PATCH v6 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

Hi, Eelco. Thanks for the patch! I'd like to test it a bit more on my setup before applying, but the code looks mostly OK to me. See some nits inline. Bets regards, Ilya Maximets. On 9/6/21 10:53, Eelco Chaudron wrote: > This patch adds a general way of viewing/configuring datapath > cache

Re: [ovs-dev] [PATCH] RFC: netdev-dpdk: Add Windows support.

On Thu, Nov 4, 2021 at 4:35 AM Thomas Monjalon wrote: > > 06/10/2021 19:00, William Tu: > > The patch adds OVS-DPDK supports on Windows. > [...] > > Implementation on Windows > > - > > It's harder than I thought due to my Linux only background. > > Sergey and I first need

Re: [ovs-dev] [PATCH v6 1/2] dpctl: dpif: add kernel datapath cache hit output

Hi, Eelco. Sorry for this taking so long. The patch looks good to me, just one small nit below. On 9/6/21 10:53, Eelco Chaudron wrote: > This patch adds cache usage statistics to the output: > > $ ovs-dpctl show > system@ovs-system: > lookups: hit:24 missed:71 lost:0 > flows: 0 > masks:

Re: [ovs-dev] [PATCH ovn] northd: fix check_pkt_larger ingress flows with FIP

On Nov 03, Numan Siddique wrote: > On Wed, Nov 3, 2021 at 9:49 AM Lorenzo Bianconi > wrote: > > > > Add missing icmp{4,6}_error flows for ingress traffic destinated to FIP > > associated to the interface. > > > > Signed-off-by: Lorenzo Bianconi > > --- > > northd/northd.c | 87

Re: [ovs-dev] [PATCH v2] [python] Add monitor_cond_since support

On 11/4/21 14:07, Terry Wilson wrote: > > > On Wed, Nov 3, 2021, 11:22 AM Ilya Maximets > wrote: > > On 11/3/21 01:36, Terry Wilson wrote: > > Add support for monitor_cond_since / update3 to python-ovs to > > allow more efficient reconnections when

Re: [ovs-dev] [PATCH] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

On 11/1/21 15:47, Aaron Conole wrote: > This reverts commit c645550bb249 ("odp-util: Always report > ODP_FIT_TOO_LITTLE for IGMP.") > > Always forcing a slow path action can result in some over-broad > flows which swallow all traffic and force them to userspace, as reported > in the thread at >

Re: [ovs-dev] [PATCH v2] [python] Add monitor_cond_since support

On Wed, Nov 3, 2021, 11:22 AM Ilya Maximets wrote: > On 11/3/21 01:36, Terry Wilson wrote: > > Add support for monitor_cond_since / update3 to python-ovs to > > allow more efficient reconnections when connecting to clustered > > OVSDB servers. > > > > Signed-off-by: Terry Wilson > > --- > >

Re: [ovs-dev] [PATCH] RFC: netdev-dpdk: Add Windows support.

06/10/2021 19:00, William Tu: > The patch adds OVS-DPDK supports on Windows. [...] > Implementation on Windows > - > It's harder than I thought due to my Linux only background. > Sergey and I first need to add meson build support to OVS, in order > to make compiling and

Re: [ovs-dev] [PATCH] dpif-netdev: Reset RxQ cycles history on PMD reload.

On Wed, Oct 20, 2021 at 11:04 AM Kevin Traynor wrote: > > When a PMD reload occurs, some PMD cycle measurements are reset. > In order to preserve the full cycles history of an Rxq, the RxQ > cycle measurements were not reset. > > These are both used together to display the % of a PMD that an >

Re: [ovs-dev] [PATCH 0/4] Native tunnel: Update neigh entries in tnl termination.

On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: > - Dropped the RFC tag > - Included Flavio's suggestions > - Squashed patch #5 into #2 and #3 > > The series is composed of the following patches: > > #1: Expires is modified in different contexts (revalidator, pmd-rx, bfd-tx). > It's

Re: [ovs-dev] [PATCH 4/4] Tunnel: Snoop ingress packets and update neigh cache if needed.

On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: > In case of native tunnel with bfd enabled, if the MAC address of the > remote end's interface changes (e.g. because it got rebooted, and the > MAC address is allocated dinamically), the BFD session will never be > re-established. > typo:

Re: [ovs-dev] [PATCH 3/4] Native tunnel: Do not refresh the entry while revalidating.

On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: > This is a minor issue but visible e.g. when you try to flush the neigh > cache while the ARP flow is still present in the datapath, triggering > the revalidation of the datapath flows which subsequently > refreshes/adds the entry in the cache.