On Thu, Nov 11, 2021 at 11:53 AM Mark Michelson wrote:
>
> Hello Han,
>
> The patch looks good to me, but it updates the OVS submodule commit, and
> I don't think this was done on purpose. With that corrected,
>
> Acked-by: Mark Michelson
Sorry, my mistake. With the ovs submodule commit
When a logical flow translation uses conjunction ids, it is better to
keep the conjuntion ids consistent between iterations, so that the
generated OVS flows don't change unnecessarily and avoid reinstalling
unchanged flows to OVS. The problem was partially solved when
lflow-cache was enabled but
Signed-off-by: Han Zhou
---
tests/test-utils.c | 22 ++
tests/test-utils.h | 2 ++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/tests/test-utils.c b/tests/test-utils.c
index 6a3b198ae..78e63acb7 100644
--- a/tests/test-utils.c
+++ b/tests/test-utils.c
@@
Conjunction id cache is useful to keep conjunction ids consistent between
iterations when match or expr cache is not available. However, the
current implementation caches the conjunction id whenever n_conjs > 0.
It assumes that when the lflow is reprocessed, the conjunction ids
starting from the
It is important to keep conjunction IDs consistent between runs to avoid
unnecessary OVS flows deletion and reinstallation. However, There are two
problems of the current lflow-cache based conjunction id peristent approach.
1) When n_conjs changes, the cached conj_id_ofs can overlap with other
In commit fadbc04f38db it changed the lflow-cache behavior but forgot to
update the commment.
Fixes: fadbc04f38db ("ovn-controller: Fix incremental processing for logical
port references.")
Signed-off-by: Han Zhou
---
controller/lflow-cache.h | 5 +++--
1 file changed, 3 insertions(+), 2
On Thu, Nov 11, 2021 at 3:20 PM Mark Michelson wrote:
>
> On 11/11/21 14:04, Ilya Maximets wrote:
> > On 11/11/21 19:02, Mark Michelson wrote:
> >> RHEL 9 and CentOS 9 no longer contain a pyopenssl package. Therefore,
> >> for RHEL 9 and CentOS 9 builds of OVN, we need to no longer rely on the
>
Hi Lorenzo, the patch looks good to me.
Acked-by: Mark Michelson
On 11/10/21 17:35, Lorenzo Bianconi wrote:
Properly manage ttl exceeded ICMP error messages when traffic is
directed to a FIP. The issue can be verified running traceroute from an
external device to a FIP:
$traceroute -I -z 1 -n
On 11/11/21 14:04, Ilya Maximets wrote:
On 11/11/21 19:02, Mark Michelson wrote:
RHEL 9 and CentOS 9 no longer contain a pyopenssl package. Therefore,
for RHEL 9 and CentOS 9 builds of OVN, we need to no longer rely on the
pyopenssl package. OVS's python IDL was recently updated to no longer
Hello Han,
The patch looks good to me, but it updates the OVS submodule commit, and
I don't think this was done on purpose. With that corrected,
Acked-by: Mark Michelson
On 11/10/21 19:39, Han Zhou wrote:
Currently this command assumes that if the gateway_chassis record with
expected name
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#409 FILE:
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around
On Wed, Nov 10, 2021 at 7:39 PM Han Zhou wrote:
>
> Currently this command assumes that if the gateway_chassis record with
> expected name exists it is set to the logical port, so once the record
> is found it not set to the lrp again. However, this assumption is not
> always true.
>
> An example
Hi Han, Numan,
I’ve posted a new version of this series [1] and addressed your comments and
suggestions.
I’ll appreciate if you can take a look on this please and I’d be happy if this
can be included in next OVN release.
Thanks.
1:
This patch extends Logical Router's routing functionality.
Now user may create multiple routing tables within a Logical Router
and assign them to Logical Router Ports.
Traffic coming from Logical Router Port with assigned route_table
is checked against global routes if any
Previously support for multiple routing tables was added
to northd code.
This commit expands support for multiple routing tables
by adding support of advertising and learning routes with
their routing table information.
To utilize such feature, user must:
1. create Logical Router in each AZ;
2.
In case we have ovn-ic-interconnected Logical_Routers
and install same ip_prefix route with GW in local AZ
in each LR in each AZ, this route would be learned in
other AZs and L3 loop is possible.
There could be next routes output:
[az1 ~]$ ovn-nbctl lr-route-list lr0
IPv4 Routes
Route Table
With this patch routes to directly-connected networks
have higher priority than static routes with same ip_prefix.
This brings commonly-used behaviour for routes lookup order:
1: longest prefix match
2: metric
The metric has next lookup order:
1: directly connected routes
2: static routes
This commits adds ability to save route's origin while IC learning.
Directly connected routes are saved in IC SB DB with "connected"
origin column value.
Static routes have "static" value in origin column.
This logic would be used in next patch to compute priority
for lr_in_ip_routing stage
v6 -> v7:
- Addressed Han's comments regarding saving same behaviour for route-tables
static routes as for static routes from 'global' table.
To address this 2 new patches were added (1, 2).
- "global" table terminology was replaced with ''.
v5 -> v6:
- 2 memory leak bugs were fixed
On 11/11/21 19:02, Mark Michelson wrote:
> RHEL 9 and CentOS 9 no longer contain a pyopenssl package. Therefore,
> for RHEL 9 and CentOS 9 builds of OVN, we need to no longer rely on the
> pyopenssl package. OVS's python IDL was recently updated to no longer
> depend on pyopenssl, favoring instead
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed
Hi Chris,
Chris Mi via dev writes:
> OVS_DP_F_UNALIGNED is already set, no need to set again. If restarting ovs,
> dp is already created. So dpif_netlink_dp_transact() will return EEXIST.
> No need to probe again.
>
> Signed-off-by: Chris Mi
> ---
> lib/dpif-netlink.c | 3 +--
> 1 file
RHEL 9 and CentOS 9 no longer contain a pyopenssl package. Therefore,
for RHEL 9 and CentOS 9 builds of OVN, we need to no longer rely on the
pyopenssl package. OVS's python IDL was recently updated to no longer
depend on pyopenssl, favoring instead to use the built-in SSL module.
This commit
On Thu, Nov 11, 2021 at 10:44 AM Mark Michelson wrote:
>
> Signed-off-by: Mark Michelson
Acked-by: Numan Siddique
Numan
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
On Thu, Nov 11, 2021 at 10:44 AM Mark Michelson wrote:
>
> Signed-off-by: Mark Michelson
Acked-by: Numan Siddique
Numan
> ---
> NEWS | 3 ++-
> debian/changelog | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 63d765aa4..4b0f46192
On Thu, Nov 11, 2021 at 3:22 PM Sriharsha Basavapatna
wrote:
>
> Hi Ilya,
>
> On Wed, Nov 10, 2021 at 11:31 PM Ilya Maximets wrote:
> >
> > Hi, Harsha.
> >
> > I was thinking about 3x performance drop due to enabling
> > of experimental API that you reported during the meeting
> > today. I just
Signed-off-by: Mark Michelson
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 4b0f46192..1b582ca1e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+OVN v21.09.2 - xx xxx
Mark Michelson (2):
Set release date for 21.09.1.
Prepare for 21.09.2.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions(-)
--
2.31.1
___
dev mailing list
Signed-off-by: Mark Michelson
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 63d765aa4..4b0f46192 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-OVN v21.09.1 - xx xxx
+OVN v21.09.1 - 11 Nov 2021
> -Original Message-
> From: dev On Behalf Of Ilya Maximets
> Sent: Wednesday, November 10, 2021 6:02 PM
> To: Sriharsha Basavapatna
> Cc: ovs-dev ; i.maxim...@ovn.org
> Subject: [ovs-dev] Regarding the performance issues reported during today's
> OVS+DPDK meeting.
>
> Hi, Harsha.
>
>
Hi Ilya,
On Wed, Nov 10, 2021 at 11:31 PM Ilya Maximets wrote:
>
> Hi, Harsha.
>
> I was thinking about 3x performance drop due to enabling
> of experimental API that you reported during the meeting
> today. I just want to clarify one thing to be sure that
> you're not making the same mistake
32 matches
Mail list logo
