Re: [ovs-dev] [ovs-dev v3] ipf: add ipf context

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

[ovs-dev] [ovs-dev v3] ipf: add ipf context

2021-11-12 Thread Peng He
From: Peng He ipf_postprocess will emit packets into the datapath pipeline ignoring the conntrack context, this might casuse weird issues when a packet batch has less space to hold all the fragments belonging to single packet. Given the below ruleest and consider sending a 64K ICMP packet which

[ovs-dev] [RFC ovn] northd: fix FIP traffic with distributed gw router port on the same hv

2021-11-12 Thread Lorenzo Bianconi
If the hv has FIP assigned, traffic has to be sent out using the FIP even if a distributed gw router port is scheduled on the local hv. In this particular use-case without the proposed patch, the traffic is sent out with FIP mac but using distributed gw router port IP. Related bz: https://bugzilla

Re: [ovs-dev] [PATCH ovn branch-21.09] ovs: Bump submodule to include ovsdb/IDL optimizations.

2021-11-12 Thread Numan Siddique
On Fri, Nov 12, 2021 at 10:54 AM Mark Michelson wrote: > > From: Dumitru Ceara > > There are two relevant OVS commits picked with this submodule update. > The first one significantly improves performance of OVN database clients > and the second one adds memory reporting for the OVN IDL clients. >

Re: [ovs-dev] [PATCH ovn v6 2/4] northd, utils: support for RouteTables in LRs

2021-11-12 Thread Numan Siddique
On Thu, Nov 11, 2021 at 2:18 PM Odintsov Vladislav wrote: > > Hi Han, Numan, > > I’ve posted a new version of this series [1] and addressed your comments and > suggestions. > I’ll appreciate if you can take a look on this please and I’d be happy if > this can be included in next OVN release. > >

Re: [ovs-dev] [PATCH v3] netdev-linux: Ingress policing to use matchall if basic is, not available.

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mike Pattrick needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH v4] utilities: Add another GDB macro for ovs-vswitchd

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch fragment without header at line 7: @@ -56,8 +57,15 @@ error: could not build fake anc

[ovs-dev] [PATCH v3] netdev-linux: Ingress policing to use matchall if basic is, not available.

2021-11-12 Thread Mike Pattrick
Currently ingress policing uses the basic classifier to apply traffic control filters if hardware offload is not enabled, else it uses matchall. This change enables fallback onto the matchall classifier for cases when the kernel is not built with basic support and hardware offload is not in use. Ba

Re: [ovs-dev] [PATCH v2] netdev-linux: Ingress policing to use matchall if basic is, not available.

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author mpatt...@redhat.com needs to sign off. WARNING: Unexpected sign-offs from developers who are

[ovs-dev] [PATCH v4] utilities: Add another GDB macro for ovs-vswitchd

2021-11-12 Thread Mike Pattrick
This commit adds a basic packet metadata macro to the already existing macros in ovs_gdb.py, ovs_dump_packets will print out information about one or more packets. It feeds packets into tcpdump, and the user can pass in tcpdump options to modify how packets are parsed or even write out packets to a

Re: [ovs-dev] [PATCH v1] acinclude: Provide error info when linking fails with DPDK.

2021-11-12 Thread Pai G, Sunil
Hi Michael, Thanks for the review , responses inline. > > Before: > > checking whether linking with dpdk works... no > > configure: error: Could not find DPDK library in default search path, > > update PKG_CONFIG_PATH for pkg-config to find the .pc file in > > non-standard location > > > > After:

Re: [ovs-dev] [PATCH v2] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

2021-11-12 Thread Aaron Conole
Eelco Chaudron writes: > On 9 Nov 2021, at 15:42, Aaron Conole wrote: > >> This reverts commit c645550bb249 ("odp-util: Always report >> ODP_FIT_TOO_LITTLE for IGMP.") >> >> Always forcing a slow path action can result in some over-broad >> flows which swallow all traffic and force them to usersp

Re: [ovs-dev] [PATCH v3] utilities: Add another GDB macro for ovs-vswitchd

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author mpatt...@redhat.com needs to sign off. WARNING: Unexpected sign-offs from developers who are

[ovs-dev] [PATCH v2] netdev-linux: Ingress policing to use matchall if basic is, not available.

2021-11-12 Thread mpattric
Currently ingress policing uses the basic classifier to apply traffic control filters if hardware offload is not enabled, else it uses matchall. This change enables fallback onto the matchall classifier for cases when the kernel is not built with basic support and hardware offload is not in use. Ba

[ovs-dev] [PATCH v3] utilities: Add another GDB macro for ovs-vswitchd

2021-11-12 Thread mpattric
This commit adds a basic packet metadata macro to the already existing macros in ovs_gdb.py, ovs_dump_packets will print out information about one or more packets. It feeds packets into tcpdump, and the user can pass in tcpdump options to modify how packets are parsed or even write out packets to a

Re: [ovs-dev] [PATCH v1] acinclude: Provide error info when linking fails with DPDK.

2021-11-12 Thread Michael Santana
On 11/10/21 5:07 AM, Sunil Pai G wrote: Currently the configure script provides no infomation but to update the pkg-config path on failure to link with DPDK. Fix this to provide more information to the user on failure. Before: checking whether linking with dpdk works... no configure: error: C

Re: [ovs-dev] [PATCH ovn branch-21.09] ovs: Bump submodule to include ovsdb/IDL optimizations.

2021-11-12 Thread Mark Michelson
On 11/12/21 10:59, 0-day Robot wrote: Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH ovn branch-21.09] ovs: Bump submodule to include ovsdb/IDL optimizations.

2021-11-12 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committer

[ovs-dev] [PATCH ovn branch-21.09] ovs: Bump submodule to include ovsdb/IDL optimizations.

2021-11-12 Thread Mark Michelson
From: Dumitru Ceara There are two relevant OVS commits picked with this submodule update. The first one significantly improves performance of OVN database clients and the second one adds memory reporting for the OVN IDL clients. 1bdda7b6d ovsdb-idl: Use functions to apply diff in place. 0667

Re: [ovs-dev] [PATCH ovn branch-21.09] ovs: Update submodule to include removal of pyopenssl.

2021-11-12 Thread Mark Michelson
On 11/11/21 17:08, Numan Siddique wrote: On Thu, Nov 11, 2021 at 3:20 PM Mark Michelson wrote: On 11/11/21 14:04, Ilya Maximets wrote: On 11/11/21 19:02, Mark Michelson wrote: RHEL 9 and CentOS 9 no longer contain a pyopenssl package. Therefore, for RHEL 9 and CentOS 9 builds of OVN, we need

Re: [ovs-dev] problem: long tcp session instantiation with conntrack and OOT ovs kmod

2021-11-12 Thread Vladislav Odintsov
Hi Greg, thanks for the response. I’ll be grateful if you can find a time on this. Thanks. Regards, Vladislav Odintsov > On 4 Nov 2021, at 00:48, Gregory Rose wrote: > > > > On 11/2/2021 9:50 AM, Vladislav Odintsov wrote: >> Hi, >> it’s just a quick reminder, that if you know how to debug/f

Re: [ovs-dev] [PATCH] netdev-linux: Ingress policing to use matchall if basic is not available.

2021-11-12 Thread Eelco Chaudron
One small nit on the below… On 18 Oct 2021, at 21:07, Mike Pattrick wrote: > Currently ingress policing uses the basic classifier to apply traffic > control filters if hardware offload is not enabled, else it uses > matchall. This change enables fallback onto the matchall classifier for > cases

Re: [ovs-dev] [PATCH v2] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

2021-11-12 Thread Eelco Chaudron
On 9 Nov 2021, at 15:42, Aaron Conole wrote: > This reverts commit c645550bb249 ("odp-util: Always report > ODP_FIT_TOO_LITTLE for IGMP.") > > Always forcing a slow path action can result in some over-broad > flows which swallow all traffic and force them to userspace, as reported > in the thre

Re: [ovs-dev] [PATCH] ovsdb-server: add inactivity probe arg to ovsdb server

2021-11-12 Thread Seena Fallah
Well, as like as --db-nb-create-insecure-remote=yes arg the inactivity probe can be set with args so I think the current implementation would be better to deal with this problem. (Maybe just change the arg name) I want to listen to specific IP so solution #3 won't be good for me! Creating multiple

Re: [ovs-dev] Fwd: [PATCH] build: check libibverbs deps before linking with dpdk

2021-11-12 Thread David Marchand
On Thu, Nov 11, 2021 at 2:55 AM Harold Huang wrote: > > FIY, both dpdk and ovs are built in CentOS Linux release 8.2.2004 > with a native kernel 4.18.0-193.el8.x86_64. I started a Centos 8.2 vm. No libibverbs installed by default. I compiled DPDK v20.11.3 and installed it in builddir/install Th

Re: [ovs-dev] [PATCH v2] utilities: Add another GDB macro for ovs-vswitchd

2021-11-12 Thread Eelco Chaudron
Some small remaining comments, rest looks good! On 5 Nov 2021, at 18:26, Mike Pattrick wrote: > This commit adds a basic packet metadata macro to the already existing > macros in ovs_gdb.py, ovs_dump_packets will print out information about > one or more packets. It feeds packets into tcpdump, an