Re: [ovs-dev] [PATCH v6 1/3] conntrack: select correct sport range for well-known origin sport

2021-11-13 Thread wenxu
Hi Paolo, Any suggestion for this series? BR wenxu From: we...@ucloud.cn Date: 2021-10-09 23:28:38 To: i.maxim...@ovn.org,pvale...@redhat.com Cc: d...@openvswitch.org Subject: [PATCH v6 1/3] conntrack: select correct sport range for well-known origin sport>From: wenxu > >Like the

Re: [ovs-dev] [PATCH] conntrack: support default timeout policy get/set cmd for netdev datapath

2021-11-13 Thread wenxu
Will do . Thanks Paolo From: Paolo Valerio Date: 2021-11-08 02:24:29 To: we...@ucloud.cn,i.maxim...@ovn.org,acon...@redhat.com Cc: d...@openvswitch.org Subject: Re: [PATCH] conntrack: support default timeout policy get/set cmd for netdev datapath>Hi Wenxu, > >we...@ucloud.cn writes: >

Re: [ovs-dev] [PATCH ovn v8 4/5] ic: add support for routing tables in adv/learn routes

2021-11-13 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #409 FILE:

Re: [ovs-dev] [PATCH ovn v8 3/5] northd, utils: support for RouteTables in LRs

2021-11-13 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around

Re: [ovs-dev] [PATCH ovn v6 2/4] northd, utils: support for RouteTables in LRs

2021-11-13 Thread Odintsov Vladislav
Thanks Numan, I’ve forgotten to update description according to new changes. A new patch version v8 was submitted: https://patchwork.ozlabs.org/project/ovn/cover/2023094353.17690-1-odiv...@gmail.com/ Please check it out. Regards, Vladislav Odintsov On 12 Nov 2021, at 23:07, Numan Siddique

[ovs-dev] [PATCH ovn v8 3/5] northd, utils: support for RouteTables in LRs

2021-11-13 Thread Vladislav Odintsov
This patch extends Logical Router's routing functionality. Now user may create multiple routing tables within a Logical Router and assign them to Logical Router Ports. Traffic coming from Logical Router Port with assigned route_table is checked against Logical_Router_Static_Routes with same

[ovs-dev] [PATCH ovn v8 4/5] ic: add support for routing tables in adv/learn routes

2021-11-13 Thread Vladislav Odintsov
Previously support for multiple routing tables was added to northd code. This commit expands support for multiple routing tables by adding support of advertising and learning routes with their routing table information. To utilize such feature, user must: 1. create Logical Router in each AZ; 2.

[ovs-dev] [PATCH ovn v8 5/5] ic: don't learn routes which have local GW

2021-11-13 Thread Vladislav Odintsov
In case we have ovn-ic-interconnected Logical_Routers and install same ip_prefix route with GW in local AZ in each LR in each AZ, this route would be learned in other AZs and L3 loop is possible. There could be next routes output: [az1 ~]$ ovn-nbctl lr-route-list lr0 IPv4 Routes Route Table

[ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

2021-11-13 Thread Vladislav Odintsov
With this patch routes to connected networks have higher priority than static routes with same ip_prefix. This brings commonly-used behaviour for routes lookup order: 1: longest prefix match 2: metric The metric has next lookup order: 1: connected routes 2: static routes Earlier static and

[ovs-dev] [PATCH ovn v8 1/5] ic: maintain route origin - connected/static

2021-11-13 Thread Vladislav Odintsov
This commits adds ability to save route's origin while IC learning. Directly connected routes are saved in IC SB DB with "connected" origin column value. Static routes have "static" value in origin column. This logic would be used in next patch to compute priority for lr_in_ip_routing stage

[ovs-dev] [PATCH ovn v8 0/5] Add multiple routing tables support to Logical Routers

2021-11-13 Thread Vladislav Odintsov
v7 -> v8: - Updated manpages with and commit messages according to latest changes. - Small fixes. v6 -> v7: - Addressed Han's comments regarding saving same behaviour for route-tables static routes as for static routes from 'global' table. To address this 2 new patches were added