[ovs-dev] [PATCH v2] tests: Handle endianness in netlink policy test

2021-11-18 Thread Frode Nordahl
The netlink policy unit test contains test fixture data that is subject to endianness and currently fails on big endian systems. Add helper that ensures correct byte order for the affected data. Fixes: bfee9f6c0115 ("netlink: Add support for parsing link layer address.") Signed-off-by: Frode

Re: [ovs-dev] [PATCH v6 2/3] conntrack: split the dst and src port range iterations

2021-11-18 Thread wenxu
From: Paolo Valerio Date: 2021-11-17 23:09:29 To: we...@ucloud.cn,i.maxim...@ovn.org Cc: d...@openvswitch.org Subject: Re: [PATCH v6 2/3] conntrack: split the dst and src port range iterations>Hi wenxu, > >we...@ucloud.cn writes: > >> From: wenxu >> >> Splitting the two port range

Re: [ovs-dev] [PATCH v6 2/3] conntrack: split the dst and src port range iterations

2021-11-18 Thread wenxu
From: Paolo Valerio Date: 2021-11-17 23:09:29 To: we...@ucloud.cn,i.maxim...@ovn.org Cc: d...@openvswitch.org Subject: Re: [PATCH v6 2/3] conntrack: split the dst and src port range iterations>Hi wenxu, > >we...@ucloud.cn writes: > >> From: wenxu >> >> Splitting the two port range

Re: [ovs-dev] [PATCH v3] conntrack: support default timeout policy get/set cmd for netdev datapath

2021-11-18 Thread wenxu
Hi Paolo, Any suggestion for this version. I run all the test case success. But the robot build show 1091: ofproto-dpif - controller action without megaflows FAILED (ovs-macros.at:217) Maybe there are some problem? This patch is not matter with this tescase BR wenxu From:

[ovs-dev] [PATCH] ovsdb-idl: Re-parse backrefs of inserted rows only once.

2021-11-18 Thread Ilya Maximets
While adding new rows ovsdb-idl re-parses all the other rows that references this new one. For example, current ovn-kubernetes creates load balancers and adds the same load balancer to all logical switches and logical routers. So, then a new load balancer is added, rows for all logical switches

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2021-11-18 Thread Numan Siddique
On Thu, Nov 18, 2021 at 4:49 PM Mark Michelson wrote: > > Hi Numan, > > I had one question in the code and then one small finding in the > documentation. See below: > > On 11/18/21 13:13, num...@ovn.org wrote: > > From: Numan Siddique > > > > Make of use of these new actions for the distributed

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-11-18 Thread David Christensen
On 11/18/21 11:56 AM, Murilo Opsfelder Araújo wrote: On 11/16/21 19:31, Ilya Maximets wrote: On 10/25/21 19:45, David Christensen wrote: In certain high load situations, such as when creating a large number of ports on a switch, the parameter 'sock' may be passed to nl_sock_recv__() as

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2021-11-18 Thread Mark Michelson
Hi Numan, I had one question in the code and then one small finding in the documentation. See below: On 11/18/21 13:13, num...@ovn.org wrote: From: Numan Siddique Make of use of these new actions for the distributed routers for NAT. These new actions ensure that both sNAT and dNAT happens

Re: [ovs-dev] [PATCH ovn v2 1/2] actions: Add new actions - ct_dnat_in_czone and ct_snat_in_czone.

2021-11-18 Thread Mark Michelson
Acked-by: Mark Michelson On 11/18/21 13:13, num...@ovn.org wrote: From: Numan Siddique These actions are very similar to ct_dnat and ct_snat respectively with one difference. These new actions use the same zone id for natting. Upcoming patch will make use of these actions. Signed-off-by:

Re: [ovs-dev] [PATCH v3] ofproto-dpif: Increase dp_hash default max buckets.

2021-11-18 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mike Pattrick needs to sign off. Lines checked: 75, Warnings: 0, Errors: 1

[ovs-dev] [PATCH v3] ofproto-dpif: Increase dp_hash default max buckets.

2021-11-18 Thread Mike Pattrick
Currently when a user creates an openflow group with with multiple buckets without specifying a selection type, the efficient dp_hash is only selected if the user is creating fewer than 64 buckets. But when dp_hash is explicitly selected, up to 256 buckets are supported. While up to 64 buckets

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-11-18 Thread Murilo Opsfelder Araújo
On 11/16/21 19:31, Ilya Maximets wrote: On 10/25/21 19:45, David Christensen wrote: In certain high load situations, such as when creating a large number of ports on a switch, the parameter 'sock' may be passed to nl_sock_recv__() as null, resulting in a segmentation fault when 'sock' is later

Re: [ovs-dev] [ovs-dev v3] ipf: add ipf context

2021-11-18 Thread Mike Pattrick
On Wed, Nov 17, 2021 at 10:11 PM 贺鹏 wrote: > > Hi, Michael, > > thanks for the suggestion! > the patch looks good to me, did you do the test in the patch? I wouldn't say that I did anything fancy to test it, but I did make sure that it still works, and has similar throughput. Cheers, M > Mike

[ovs-dev] [PATCH ovn v2 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2021-11-18 Thread numans
From: Numan Siddique Make of use of these new actions for the distributed routers for NAT. These new actions ensure that both sNAT and dNAT happens in the same zone. This approach solves a couple of problems: - The datapath flows generated for external traffic which requires dNAT (N -> S)

[ovs-dev] [PATCH ovn v2 1/2] actions: Add new actions - ct_dnat_in_czone and ct_snat_in_czone.

2021-11-18 Thread numans
From: Numan Siddique These actions are very similar to ct_dnat and ct_snat respectively with one difference. These new actions use the same zone id for natting. Upcoming patch will make use of these actions. Signed-off-by: Numan Siddique --- v1 -> v2 * No changes.

Re: [ovs-dev] [PATCH] tests: Handle endianness in netlink policy test

2021-11-18 Thread Frode Nordahl
tor. 18. nov. 2021, 18:22 skrev Michael Santana : > > > On 11/18/21 3:26 AM, Frode Nordahl wrote: > > The netlink policy unit test contains test fixture data that is > > subject to endianness and currently fails on big endian systems. > > > > Add helper that ensures correct byte order for the

Re: [ovs-dev] [PATCH] tests: Handle endianness in netlink policy test

2021-11-18 Thread Michael Santana
On 11/18/21 3:26 AM, Frode Nordahl wrote: The netlink policy unit test contains test fixture data that is subject to endianness and currently fails on big endian systems. Add helper that ensures correct byte order for the affected data. Fixes: bfee9f6c0115 ("netlink: Add support for parsing

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

2021-11-18 Thread Numan Siddique
Hi Vladislav, Once v9 is ready, please submit them. I'll take a look. Thanks Numan On Thu, Nov 18, 2021 at 2:58 AM Han Zhou wrote: > > Sounds good to me. > > On Wed, Nov 17, 2021 at 11:53 PM Vladislav Odintsov > wrote: > > > Thanks, Han. > > Please see inline. > > > > Regards, > > Vladislav

[ovs-dev] [PATCH] tests/flowgen: Fix length field of 802.2 data link header.

2021-11-18 Thread Ilya Maximets
Length in Data Link Header for these packets should not include source and destination MACs or the length field itself. Therefore, it should be 14 bytes less, otherwise other network tools like wireshark complains: Expert Info (Error/Malformed): Length field value goes past the end of the

[ovs-dev] [PATCH v3] checkpatch: Detect "trojan source" attack

2021-11-18 Thread Mike Pattrick
Recently there has been a lot of press about the "trojan source" attack, where Unicode characters are used to obfuscate the true functionality of code. This attack didn't effect OVS, but adding the check here will help guard against it sneaking in later. Signed-off-by: Mike Pattrick --- Changes

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix check_pkt_larger incomplete translation.

2021-11-18 Thread Numan Siddique
On Wed, Nov 17, 2021, 7:06 PM Ilya Maximets wrote: > On 11/9/21 15:48, Aaron Conole wrote: > > num...@ovn.org writes: > > > >> From: Numan Siddique > >> > >> xlate_check_pkt_larger() sets ctx->exit to 'true' at the end > >> causing the translation to stop. This results in incomplete > >>

Re: [ovs-dev] [PATCH v3 3/3] upcall: considering dataofs when parsing tcp pkt

2021-11-18 Thread Ilya Maximets
On 11/1/21 12:03, lic121 wrote: > dataofs field of tcp header indicates the tcp header len. The len > should be >= 20 bytes/4. This patch is to test dataofs, and don't > parse layer 4 fields when meet ba dataofs. This behave is the consistent > with openvswitch kenrel module. > > Signed-off-by:

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Expose per rxq/txq basic statistics.

2021-11-18 Thread Kevin Traynor
On 15/10/2021 16:04, David Marchand wrote: When troubleshooting multiqueue setups, having per queue statistics helps checking packets repartition in rx and tx queues. Per queue statistics are exported by most DPDK drivers (with capability RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS). But since OVS only

Re: [ovs-dev] [PATCH branch-2.14, v2] dpdk: Use DPDK 19.11.10 release

2021-11-18 Thread Kevin Traynor
On 03/11/2021 07:41, Suneetha Kalahasthi wrote: Modify ci linux build script to use the latest DPDK stable release 19.11.10. Modify Documentation to use the latest DPDK stable release 19.11.10. Update NEWS file to reflect the latest DPDK stable release 19.11.10. FAQ is updated to reflect the

Re: [ovs-dev] [PATCH ovn v1 1/5] manpages.mk: fix dependencies path

2021-11-18 Thread Dumitru Ceara
On 11/9/21 10:08 PM, Numan Siddique wrote: +Numan In general, I'm not completely sure about why sodepends.py needs to be part of OVN and why we can't use the OVS version? >>> OVS does not have this problem as everything is under the root tree so I >>> assumed it would be

Re: [ovs-dev] [PATCH v2] checkpatch: Detect "trojan source" attack

2021-11-18 Thread Aaron Conole
Ilya Maximets writes: > On 11/17/21 17:58, Aaron Conole wrote: >> Mike Pattrick writes: >> >>> Recently there has been a lot of press about the "trojan source" attack, >>> where Unicode characters are used to obfuscate the true functionality of >>> code. This attack didn't effect OVS, but

[ovs-dev] [PATCH ovn] controller/pinctrl: improve packet-in debuggability

2021-11-18 Thread Mohammad Heib
Improve packet-in debuggability within pinctrl module by printing basic details about each received packet-in message, those messages will be printed to the logs only when DBG log level is enabled. Also, add two coverage counters that will indicate the total packet-in messages that were received

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Expose per rxq/txq basic statistics.

2021-11-18 Thread Maxime Coquelin
Hi, On 10/15/21 17:04, David Marchand wrote: When troubleshooting multiqueue setups, having per queue statistics helps checking packets repartition in rx and tx queues. Per queue statistics are exported by most DPDK drivers (with capability RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS). But since OVS

Re: [ovs-dev] [PATCH 2/2] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-18 Thread Maxime Coquelin
Hi David, On 9/27/21 15:57, David Marchand wrote: net_pcap is not always available in DPDK (like, in a dev environment when you forgot to install the libpcap-devel). On the other hand, OVS already has its own way to inject packets into a bridge. Let's make use of it. While at it, convert

[ovs-dev] [PATCH] tests: Handle endianness in netlink policy test

2021-11-18 Thread Frode Nordahl
The netlink policy unit test contains test fixture data that is subject to endianness and currently fails on big endian systems. Add helper that ensures correct byte order for the affected data. Fixes: bfee9f6c0115 ("netlink: Add support for parsing link layer address.") Signed-off-by: Frode

Re: [ovs-dev] [PATCH] netdev-vport: Fix compilation warning

2021-11-18 Thread Roi Dayan via dev
On 2021-11-18 9:59 AM, Roi Dayan wrote: On 2021-11-17 5:45 PM, Kevin Traynor wrote: On 17/11/2021 14:44, Eelco Chaudron wrote: On 17 Nov 2021, at 14:00, Roi Dayan via dev wrote: On 2021-11-17 2:51 PM, Roi Dayan wrote: On 2021-11-17 2:42 PM, Roi Dayan wrote: On 2021-11-17 2:23 PM,