[ovs-dev] [bug][crash][ovs-dpdk] crash BUG of two hardware nic in OVS-DPDK when ONLY using `scp`.

2021-11-25 Thread Simon Jones
Hi all, Now I'm using OVS-DPDK version 2.13 in openstack environment, just like what I do in emails before ("Why could OVS-DPDK bridge use veth-pair nic? Why OVS-DPDK internal port could add IP?"). But I found a bug: 1) if I deploy OVS-DPDK like scenario-1 (detail is below), it's OK; 2) if I depl

[ovs-dev] [PATCH v4] conntrack: support default timeout policy get/set cmd for netdev datapath

2021-11-25 Thread wenxu
From: wenxu Now, the default timeout policy for netdev datapath is hard codeing. In some case show or modify is needed. Add command for get/set default timeout policy. Using like this: ovs-appctl dpctl/ct-get-default-timeout-policy [dp] ovs-appctl dpctl/ct-set-default-timeout-policy [dp] policie

[ovs-dev] [PATCH v7 1/2] conntrack: select correct sport range for well-known origin sport

2021-11-25 Thread wenxu
From: wenxu Like the kernel datapath. The sport nat range for well-konwn origin sport should limit in the well-known ports. Signed-off-by: wenxu Acked-by: Paolo Valerio --- lib/conntrack.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/conntrack.c b/lib/

[ovs-dev] [PATCH v7 2/2] conntrack: limit port clash resolution attempts

2021-11-25 Thread wenxu
From: wenxu In case almost or all available ports are taken, clash resolution can take a very long time, resulting in pmd hang in conntrack. This can happen when many to-be-natted hosts connect to same destination:port (e.g. a proxy) and all connections pass the same SNAT. Pick a random offset

Re: [ovs-dev] [PATCH v3] conntrack: support default timeout policy get/set cmd for netdev datapath

2021-11-25 Thread Paolo Valerio
wenxu writes: > Hi Paolo, > > Any suggestion for this version. I run all the test case success. > But the robot build show 1091: ofproto-dpif - controller action without > megaflows FAILED (ovs-macros.at:217) > > Maybe there are some problem? This patch is not matter with this tescase > It s

Re: [ovs-dev] [RFC PATCH ovn 0/7] northd-ddlog: Benchmark and improve Load Balancer performance.

2021-11-25 Thread Dumitru Ceara
CC: Numan, Han, Mark, and Leonid. On 11/25/21 22:33, Dumitru Ceara wrote: > This series started as an effort to port the support for > Load Balancer Groups to the DDlog version of northd. The initial > patch that did that turned out to be very simple and small but test > results were still not gr

[ovs-dev] [RFC PATCH ovn 7/7] HACK: Remove load balancer routable/unroutable logic.

2021-11-25 Thread Dumitru Ceara
This is a forceful revert, completely breaking functionality with the only goal of determining the impact of the commented out lines on performance. Signed-off-by: Dumitru Ceara --- northd/lrouter.dl| 54 +- northd/ovn_northd.dl | 23 ++

[ovs-dev] [RFC PATCH ovn 6/7] northd-ddlog: Split sb::Out_Load_Balancer relation.

2021-11-25 Thread Dumitru Ceara
TODO: this improves performance significantly. Not exactly sure why.. Is it related to FlatMap called "inline"? Is it related to group_by()? Signed-off-by: Dumitru Ceara --- northd/ovn_northd.dl | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git

[ovs-dev] [RFC PATCH ovn 5/7] northd-ddlog: HACK: Generate ARP responder flows only for reachable VIPs.

2021-11-25 Thread Dumitru Ceara
WARNING: This is a LIE, the change doesn't do what the subject line suggests. Instead we just hack it to simulate the effect of 5c4010dd7f41 ("northd: Generate ARP responder flows only for reachable VIPs.") in an ovn-kubernetes scaled deployment. Signed-off-by: Dumitru Ceara --- northd/ovn_nort

[ovs-dev] [RFC PATCH ovn 4/7] northd-ddlog: Use address sets for ARP responder flows for VIPs.

2021-11-25 Thread Dumitru Ceara
Partial port of c1e3896c0a39 ("northd: Use address sets for ARP responder flows for VIPs."); it adds a FIXME to also port beed00c9206d ("northd: Always generate valid load balancer address set names."). Signed-off-by: Dumitru Ceara --- northd/ovn_northd.dl | 26 -- 1 fi

[ovs-dev] [RFC PATCH ovn 3/7] northd-ddlog: Don't add ARP responder flows for unreachable VIPs.

2021-11-25 Thread Dumitru Ceara
Port 45d9840eae7c ("northd: Don't add ARP responder flows for unreachable VIPs."). Signed-off-by: Dumitru Ceara --- northd/ovn_northd.dl | 48 +--- 1 file changed, 5 insertions(+), 43 deletions(-) diff --git a/northd/ovn_northd.dl b/northd/ovn_north

[ovs-dev] [RFC PATCH ovn 1/7] tutorial: Add hacky load balancer stress test.

2021-11-25 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- tutorial/automake.mk|3 +- tutorial/lb-group-stress.sh | 60 +++ 2 files changed, 62 insertions(+), 1 deletion(-) create mode 100755 tutorial/lb-group-stress.sh diff --git a/tutorial/automake.mk b/tutorial/au

[ovs-dev] [RFC PATCH ovn 2/7] northd-ddlog: Add LB Group support.

2021-11-25 Thread Dumitru Ceara
Port f6aba21c9de8 ("nb: Add support for Load_Balancer_Groups."). Signed-off-by: Dumitru Ceara --- northd/lrouter.dl|7 +++ northd/lswitch.dl|6 ++ northd/ovn-nb.dlopts |1 + northd/ovn_northd.dl | 18 ++ 4 files changed, 32 insertions(+) diff --git

[ovs-dev] [RFC PATCH ovn 0/7] northd-ddlog: Benchmark and improve Load Balancer performance.

2021-11-25 Thread Dumitru Ceara
This series started as an effort to port the support for Load Balancer Groups to the DDlog version of northd. The initial patch that did that turned out to be very simple and small but test results were still not great. This series documents the incremental effort that was done to determine what

Re: [ovs-dev] [PATCH v2] tests: Handle endianness in netlink policy test

2021-11-25 Thread Mike Pattrick
Hello Frode, This patch does appear to fix the test case on big-endian systems. On Fri, 2021-11-19 at 06:08 +0100, Frode Nordahl wrote: > The netlink policy unit test contains test fixture data that is > subject to endianness and currently fails on big endian systems. > > Add helper that ensures

Re: [ovs-dev] [PATCH v2 2/4] Native tunnel: Add tnl/neigh/aging command.

2021-11-25 Thread Flavio Leitner
On Thu, Nov 25, 2021 at 05:34:27PM +0100, Paolo Valerio wrote: > Flavio Leitner writes: > > > On Wed, Nov 10, 2021 at 11:46:42AM +0100, Paolo Valerio wrote: > >> with the command is now possible to change the aging time of the > >> cache entries. > >> > >> For the existing entries the aging time

Re: [ovs-dev] [PATCH v1] configure: Allow opt-in to CPU ISA opts at compile time

2021-11-25 Thread Flavio Leitner
On Mon, Sep 13, 2021 at 02:36:41PM +, Van Haaren, Harry wrote: > > -Original Message- > > From: Eelco Chaudron > > Sent: Friday, September 10, 2021 3:41 PM > > To: Van Haaren, Harry ; i.maxim...@ovn.org; > > Stokes, Ian ; f...@sysclose.org > > Cc: Amber, Kumar ; ovs-dev@openvswitch.org

[ovs-dev] [PATCH ovn] controller: reconfigure ovs meters for ovn meters updates

2021-11-25 Thread Lorenzo Bianconi
At the moment ovs meters are reconfigured by ovn just when a new a meter is allocated while updates for an already allocated meter are ignored. This issue can be easily verified with the following reproducer: $ovn-nbctl meter-add meter0 drop 10 pktps $ovn-nbctl --log --meter=meter0 acl-add sw0 to-

Re: [ovs-dev] [PATCH v2 1/2] stream-ssl: Fix handling of default ciphers/protocols

2021-11-25 Thread Flavio Leitner
On Thu, Nov 25, 2021 at 09:22:20AM +0100, Frode Nordahl wrote: > On Wed, Nov 24, 2021 at 9:31 PM Flavio Leitner wrote: > > > > On Mon, Nov 15, 2021 at 10:40:47AM +0100, Frode Nordahl wrote: > > > On Mon, Sep 13, 2021 at 4:23 AM Frode Nordahl > > > wrote: > > > > > > > > On Sat, Sep 11, 2021 at 10

Re: [ovs-dev] [PATCH v2 2/4] Native tunnel: Add tnl/neigh/aging command.

2021-11-25 Thread Paolo Valerio
Flavio Leitner writes: > On Wed, Nov 10, 2021 at 11:46:42AM +0100, Paolo Valerio wrote: >> with the command is now possible to change the aging time of the >> cache entries. >> >> For the existing entries the aging time is updated only if the >> current expiration is greater than the new one. In

Re: [ovs-dev] [PATCH v2] dpif-netdev: Call cpuid for x86 isa availability.

2021-11-25 Thread David Marchand
On Tue, Nov 23, 2021 at 4:03 PM David Marchand wrote: > > DPIF AVX512 optimisations currently rely on DPDK availability while > they can be used without DPDK. > Besides, checking for availability of some isa only has to be done once > and won't change while a OVS process runs. > > Resolve isa avai

Re: [ovs-dev] [PATCH v2 2/3] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-25 Thread David Marchand
On Wed, Nov 24, 2021 at 5:08 PM Eelco Chaudron wrote: > > On 23 Nov 2021, at 15:15, David Marchand wrote: > > > net_pcap is not always available in DPDK (like, in a dev > > environment when you forgot to install the libpcap-devel). > > On the other hand, OVS already has its own way to inject packe

Re: [ovs-dev] [PATCH v18 7/8] netdev-offload-tc: Add offload support for sFlow

2021-11-25 Thread Chris Mi via dev
On 11/25/2021 7:27 PM, Eelco Chaudron wrote: On 15 Nov 2021, at 3:53, Chris Mi wrote: Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Sig

Re: [ovs-dev] [PATCH v18 7/8] netdev-offload-tc: Add offload support for sFlow

2021-11-25 Thread Eelco Chaudron
On 15 Nov 2021, at 3:53, Chris Mi wrote: > Create a unique group ID to map the sFlow info when offloading sFlow > action to TC. When showing the offloaded datapath flows, translate the > group ID from TC sample action to sFlow info using the mapping. > > Signed-off-by: Chris Mi > Reviewed-by:

Re: [ovs-dev] [PATCH v18 5/8] dpif-offload-netlink: Implement dpif-offload-provider API

2021-11-25 Thread Eelco Chaudron
On 15 Nov 2021, at 3:53, Chris Mi wrote: > Implement dpif-offload API for netlink datapath. And implement a > dummy dpif-offload API for netdev datapath to make tests pass. > > Signed-off-by: Chris Mi > Reviewed-by: Eli Britstein > --- > lib/automake.mk | 2 + > lib/dpif-netdev.

Re: [ovs-dev] [PATCH 0/4] dpif-netdev: Hash-based Tx packet steering

2021-11-25 Thread Maxime Coquelin
Hi, On 11/24/21 22:23, Maxime Coquelin wrote: This series introduces a new HXPS Tx mode alognside existing XPS and static modes. The goal is to provide a mode where all the transmit queues are used, whatever the number of PMD threads. This may be used with Vhost-user ports, where the guest appli

[ovs-dev] [PATCH] system-dpdk: Improve Vhost-user ping tests reliability

2021-11-25 Thread Maxime Coquelin
Instead of waiting 10 seconds for testpmd to start, this patch makes use of OVS_WAIT_UNTIL() macro to wait for the Virtio device readiness notification in ovs-vswitchd logs. Signed-off-by: Maxime Coquelin --- tests/system-dpdk.at | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [ovs-dev] [PATCH v18 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-11-25 Thread Eelco Chaudron
On 15 Nov 2021, at 3:53, Chris Mi wrote: > Some offload actions require functionality that is not netdev > based, but dpif. For example, sFlow action requires to create > a psample netlink socket to receive the sampled packets from > TC or kernel driver. > > Create dpif-offload-provider layer t

Re: [ovs-dev] [PATCH v2 1/2] stream-ssl: Fix handling of default ciphers/protocols

2021-11-25 Thread Frode Nordahl
On Wed, Nov 24, 2021 at 9:31 PM Flavio Leitner wrote: > > On Mon, Nov 15, 2021 at 10:40:47AM +0100, Frode Nordahl wrote: > > On Mon, Sep 13, 2021 at 4:23 AM Frode Nordahl > > wrote: > > > > > > On Sat, Sep 11, 2021 at 10:23 PM Flavio Leitner wrote: > > > > > > > > On Fri, Sep 10, 2021 at 06:20:4