Re: [ovs-dev] [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support

2021-12-01 Thread Pravin Shelar
On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote: > > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and > packets can be filtered using ipv6_ext flag. > > Signed-off-by: Toms Atteka > --- > include/uapi/linux/openvswitch.h | 6 ++ > net/openvswitch/flow.c | 140

[ovs-dev] [PATCH ovn] ovn-trace: honor ct state in execute_ct_lb

2021-12-01 Thread Lorenzo Bianconi
When performing CT_LB action in ovn-trace, take into account current connection tracking state provided by the user. Related bz: https://bugzilla.redhat.com/show_bug.cgi?id=1980702 Fixes: 8accd26cb2 ("OVN: add CT_LB action to ovn-trace") Signed-off-by: Lorenzo Bianconi --- tests/ovn-northd.at

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to include OVS library perf fixes.

2021-12-01 Thread Numan Siddique
On Wed, Dec 1, 2021 at 10:48 AM Dumitru Ceara wrote: > > Specifically the following commits are relevant and significantly > improve performance of OVN components: > > 91e1ff5dd ovsdb-idl: Don't reparse orphaned rows. > 79953a57e stream-ssl: Avoid unnecessary memory copies on send. >

Re: [ovs-dev] [PATCH 2/2] tc: Fix stats byte count on fragmented packets

2021-12-01 Thread Ilya Maximets
On 12/1/21 20:02, Paul Blakey wrote: > > > On Mon, 29 Nov 2021, Ilya Maximets wrote: > >> On 11/7/21 13:12, Roi Dayan via dev wrote: >>> From: Paul Blakey >>> >>> Fragmented packets with offset=0 are defragmented by tc act_ct, and >>> only when assembled pass to next action, in ovs offload

[ovs-dev] [PATCH] datapath: fix crash when ipv6 fragment pkt recalculate L4 checksum

2021-12-01 Thread zhounan (E) via dev
From: Zhou Nan When we set ipv6 addr, we need to recalculate checksum of L4 header. In our testcase, after send ipv6 fragment package, KASAN detect "use after free" when calling function update_ipv6_checksum, and crash occurred after a while. If ipv6 package is fragment, and it is not first

Re: [ovs-dev] [PATCH 2/2] tc: Fix stats byte count on fragmented packets

2021-12-01 Thread Paul Blakey via dev
On Mon, 29 Nov 2021, Ilya Maximets wrote: > On 11/7/21 13:12, Roi Dayan via dev wrote: > > From: Paul Blakey > > > > Fragmented packets with offset=0 are defragmented by tc act_ct, and > > only when assembled pass to next action, in ovs offload case, > > a goto action. Since stats are

Re: [ovs-dev] [PATCH 2/2] tc: Fix stats byte count on fragmented packets

2021-12-01 Thread Paul Blakey via dev
On Mon, 29 Nov 2021, Ilya Maximets wrote: > On 11/7/21 13:12, Roi Dayan via dev wrote: > > From: Paul Blakey > > > > Fragmented packets with offset=0 are defragmented by tc act_ct, and > > only when assembled pass to next action, in ovs offload case, > > a goto action. Since stats are

[ovs-dev] [PATCH v5] python: Add monitor_cond_since support

2021-12-01 Thread Terry Wilson
Add support for monitor_cond_since / update3 to python-ovs to allow more efficient reconnections when connecting to clustered OVSDB servers. Signed-off-by: Terry Wilson --- python/ovs/db/idl.py | 245 --- tests/ovsdb-idl.at | 2 +- 2 files changed,

Re: [ovs-dev] [PATCH v4] python: Add monitor_cond_since support

2021-12-01 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

Re: [ovs-dev] [PATCH v3] Add monitor_cond_since support

2021-12-01 Thread Dumitru Ceara
On 12/1/21 17:55, Terry Wilson wrote: > On Fri, Nov 26, 2021 at 5:38 AM Dumitru Ceara wrote: >> Nit: To be consistent with the other ifs below we should probably add >> this comment: >> >> # Database contents changed. > > Will do. > Thanks. >>> +# If 'found' is false,

[ovs-dev] [PATCH v4] python: Add monitor_cond_since support

2021-12-01 Thread Terry Wilson
Add support for monitor_cond_since / update3 to python-ovs to allow more efficient reconnections when connecting to clustered OVSDB servers. Signed-off-by: Terry Wilson --- python/ovs/db/idl.py | 245 --- tests/ovsdb-idl.at | 2 +- 2 files changed,

Re: [ovs-dev] [PATCH v3] Add monitor_cond_since support

2021-12-01 Thread Terry Wilson
On Fri, Nov 26, 2021 at 5:38 AM Dumitru Ceara wrote: > Nit: To be consistent with the other ifs below we should probably add > this comment: > > # Database contents changed. Will do. > > +# If 'found' is false, clear table rows for new > > dump > > +

Re: [ovs-dev] [PATCH ovn] controller: reconfigure ovs meters for ovn meters updates

2021-12-01 Thread Numan Siddique
On Thu, Nov 25, 2021 at 12:05 PM Lorenzo Bianconi wrote: > > At the moment ovs meters are reconfigured by ovn just when a > new a meter is allocated while updates for an already allocated meter are > ignored. This issue can be easily verified with the following reproducer: > > $ovn-nbctl

[ovs-dev] [PATCH ovn] ovs: Bump submodule to include OVS library perf fixes.

2021-12-01 Thread Dumitru Ceara
Specifically the following commits are relevant and significantly improve performance of OVN components: 91e1ff5dd ovsdb-idl: Don't reparse orphaned rows. 79953a57e stream-ssl: Avoid unnecessary memory copies on send. dec429168 ovsdb-data: Consolidate ovsdb atom and json strings.

Re: [ovs-dev] [PATCH v1] dpif-netdev.at: Improve mfex auto-validator test to cover avx512 path.

2021-12-01 Thread 0-day Robot
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

Re: [ovs-dev] [PATCH v3 0/4] Native tunnel: Update neigh entries in tnl termination.

2021-12-01 Thread Gaëtan Rivet
On Sat, Nov 27, 2021, at 00:12, Paolo Valerio wrote: > v3: > - added _S suffix to NEIGH_ENTRY_MAX_AGING_TIME (patch #2) > - Added Reported-at tag (patch #4) > > v2: > - rebased against master > - turned 'ageing' -> 'aging' > - further details of v1 -> v2 respin has been added > to each patch > >

[ovs-dev] [PATCH v1] dpif-netdev.at: Improve mfex auto-validator test to cover avx512 path.

2021-12-01 Thread Kumar Amber
AVX512 DPIF must be active in order for the MFEX AutoValidator to be executed. If the DPIF-AVX512 is not available, the unit test is skipped, as the scalar DPIF does not use the MFEX function-pointer based optimizations. This patch depends on the following patch-set:

Re: [ovs-dev] [PATCH v4] checkpatch: Detect "trojan source" attack

2021-12-01 Thread Gaëtan Rivet
On Tue, Nov 30, 2021, at 17:20, Mike Pattrick wrote: > Recently there has been a lot of press about the "trojan source" attack, > where Unicode characters are used to obfuscate the true functionality of > code. This attack didn't effect OVS, but adding the check here will help > guard against it

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-01 Thread Amber, Kumar
Hi David, Please find my replies inline. > -Original Message- > From: David Marchand > Sent: Tuesday, November 30, 2021 8:30 PM > To: d...@openvswitch.org > Cc: i.maxim...@ovn.org; Stokes, Ian ; > tredae...@redhat.com; Amber, Kumar ; > f...@sysclose.org; echau...@redhat.com;

Re: [ovs-dev] [PATCH v3] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

2021-12-01 Thread Eelco Chaudron
On 29 Nov 2021, at 22:02, Aaron Conole wrote: > This reverts commit c645550bb249 ("odp-util: Always report > ODP_FIT_TOO_LITTLE for IGMP.") > > Always forcing a slow path action can result in some over-broad > flows which swallow all traffic and force them to userspace, as reported > in the

Re: [ovs-dev] [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.

2021-12-01 Thread Amber, Kumar
Hi David, Please find the Replies inline. > -Original Message- > From: David Marchand > Sent: Wednesday, December 1, 2021 6:24 PM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian > ; tredae...@redhat.com; f...@sysclose.org; > echau...@redhat.com;

Re: [ovs-dev] [PATCH ovn 1/3] Revert "northd: support HW VTEP with stateful datapath"

2021-12-01 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 1 Dec 2021, at 16:00, 0-day Robot wrote: > > Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting.

Re: [ovs-dev] [PATCH ovn 1/3] Revert "northd: support HW VTEP with stateful datapath"

2021-12-01 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Vladislav Odintsov needs to sign off. Lines checked: 207, Warnings: 0,

[ovs-dev] [PATCH ovn 3/3] northd: support mix of stateless ACL with lower priority than stateful

2021-12-01 Thread Vladislav Odintsov
It was unsupported - to have a mix of stateless ACLs with lower than stateful priority at the same time with stateful (related) ACLs. This patch changes stateless ACLs behaviour, but this change should not be harmful for users. Likely nobody mixed rules in the described manner, so this change

[ovs-dev] [PATCH ovn 1/3] Revert "northd: support HW VTEP with stateful datapath"

2021-12-01 Thread Vladislav Odintsov
This reverts commit 62ca8b9620cc1168ace6905575b7d36438363aed. --- northd/northd.c | 14 -- northd/ovn-northd.8.xml | 28 northd/ovn_northd.dl| 33 ++--- tests/ovn-northd.at | 2 -- 4 files changed, 2

[ovs-dev] [PATCH ovn 2/3] northd: send ingress packets from HW VTEP directly to L2_LKUP table

2021-12-01 Thread Vladislav Odintsov
Recently the patch [1] fixed the ingress pipeline for packets coming from HW VTEP switch within a stateful datapath. This patch assumes the [1] is reverted and applies more efficient "next(pipeline=ingress, table=S_SWITCH_IN_L2_LKUP);" action to skip unneeded stages for such packets. 1:

[ovs-dev] [PATCH ovn 0/3] Support mixing stateless and stateful ACLs regardless of their priority

2021-12-01 Thread Vladislav Odintsov
Currently if user has a stateless and statetul ACLs (allow-stateless and allow-related) in one port group or in one logical switch simultaneously, the stateless rules whould take precedence. This patch series adds support for mixing all the ACLs types with the respect to their priority. This

Re: [ovs-dev] [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.

2021-12-01 Thread David Marchand
Hello Kumar, Thanks for looking at this series. On Wed, Dec 1, 2021 at 1:34 PM Amber, Kumar wrote: > > diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index > > 53eee185ad..fbb8fe9a71 100644 > > --- a/tests/dpif-netdev.at > > +++ b/tests/dpif-netdev.at > > @@ -635,3 +635,170 @@

Re: [ovs-dev] [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.

2021-12-01 Thread Amber, Kumar
Hi David, Thanks a lot for the patch it really does improve the testing . Please find one comment below. > -Original Message- > From: David Marchand > Sent: Tuesday, November 30, 2021 8:30 PM > To: d...@openvswitch.org > Cc: i.maxim...@ovn.org; Stokes, Ian ; > tredae...@redhat.com;

Re: [ovs-dev] [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.

2021-12-01 Thread Eelco Chaudron
On 30 Nov 2021, at 16:00, David Marchand wrote: > The MFEX code and tests do not depend on DPDK anymore. > We can move the unit tests to dpif-netdev. > > Signed-off-by: David Marchand > --- > Note: this patch depends on series >

Re: [ovs-dev] [PATCH v3 3/4] system-dpdk: Test with mlx5 devices.

2021-12-01 Thread Eelco Chaudron
On 30 Nov 2021, at 16:00, David Marchand wrote: > The DPDK unit test only runs if vfio or igb_uio kernel module is loaded: > on systems with only mlx5, this test is always skipped. > > Besides, the test tries to grab the first device listed by dpdk-devbind.py, > regardless of the PCI device

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-01 Thread Eelco Chaudron
On 30 Nov 2021, at 16:00, David Marchand wrote: > net_pcap is not always available in DPDK (like, in a dev > environment when you forgot to install the libpcap-devel). > On the other hand, OVS already has its own way to inject packets into a > bridge. Let's make use of it. > > This solution is

Re: [ovs-dev] [PATCH v3 1/4] system-dpdk: Refactor common logs matching.

2021-12-01 Thread Eelco Chaudron
On 30 Nov 2021, at 16:00, David Marchand wrote: > Move EAL logs and commonly ignored logs to a common macro. > Remove obsolete ones (like i40e [1] and timer [2] logs). > Set log level for DPDK drivers to error only: the rationale is that we are > not testing DPDK drivers in system-dpdk. >

Re: [ovs-dev] [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.

2021-12-01 Thread Maxime Coquelin
On 11/30/21 16:00, David Marchand wrote: The MFEX code and tests do not depend on DPDK anymore. We can move the unit tests to dpif-netdev. Signed-off-by: David Marchand --- Note: this patch depends on series https://patchwork.ozlabs.org/project/openvswitch/list/?series=274452 ---

Re: [ovs-dev] [PATCH v3 3/4] system-dpdk: Test with mlx5 devices.

2021-12-01 Thread Maxime Coquelin
On 11/30/21 16:00, David Marchand wrote: The DPDK unit test only runs if vfio or igb_uio kernel module is loaded: s/module is loaded/modules are loaded/ ? on systems with only mlx5, this test is always skipped. Besides, the test tries to grab the first device listed by dpdk-devbind.py,

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-01 Thread Maxime Coquelin
On 11/30/21 16:00, David Marchand wrote: net_pcap is not always available in DPDK (like, in a dev environment when you forgot to install the libpcap-devel). On the other hand, OVS already has its own way to inject packets into a bridge. Let's make use of it. This solution is slower than