Add the debug command in case lflow conjunction ids mapping needs to be
checked during trouble shooting. Also use the dump function in test
cases.
An example output:
$ ovn-appctl -t ovn-controller debug/dump-lflow-conj-ids
Conjunction IDs allocations:
lflow: 4445d4a0-3ca3-4385-a677-c0199d65ea4d,
On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote:
>
> On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote:
> >
> > On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote:
> > >
> > > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> > > packets can be filtered using ipv6_ext flag.
>
Hello Terry,
On Thu, Dec 2, 2021 at 3:52 PM Terry Wilson wrote:
>
> On Thu, Dec 2, 2021 at 2:38 PM 0-day Robot wrote:
> >
> > Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out
> > your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't
When troubleshooting multiqueue setups, having per queue statistics helps
checking packets repartition in rx and tx queues.
Per queue statistics are exported by most DPDK drivers (with capability
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS).
OVS only filters DPDK statistics, there is nothing to request in
When changing number of Rx or Tx queues, per queue basic stats can be
renumbered in DPDK ethdev layer [1].
OVS maintains an internal xstats IDs cache that was refreshed when a
cached id was not valid anymore (in netdev_dpdk_get_custom_stats) or if
a new DPDK port was created.
This did not handle
On Thu, Dec 2, 2021 at 2:38 PM 0-day Robot wrote:
>
> Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> error: Failed to merge in the
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed
When using eventlet monkey_patch()'d code, greenthreads can be
blocked on connection for several seconds while the database
contents are parsed. Eventlet recommends adding a sleep(0) call
to cooperatively yield in cpu-bound code. asyncio code has
asyncio.sleep(0). This patch adds an API method
This is a backport of the cooperative yield addition. By default it
does nothing without a user of the library overriding the method,
but it does allow fixing some issues for greenthread users. If
possible, I'd like to have it down to 2.13. It's simple enough, it
should backport pretty cleanly
On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote:
>
> On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote:
> >
> > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> > packets can be filtered using ipv6_ext flag.
> >
> > Signed-off-by: Toms Atteka
> > ---
> >
The 'if (dev)' statement already move into dev_{put , hold}, so remove
redundant if statements.
Signed-off-by: Xu Wang
---
net/openvswitch/vport-netdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
This commit adds the AVX512 implementation of the pop_vlan action.
The implementation here is auto-validated by the miniflow
extract autovalidator, hence its correctness can be easily
tested and verified.
Signed-off-by: Emma Finn
---
v2:
- Refactor to fix build warnings
---
From: Kumar Amber
This commit adds a new command to allow the user to enable
autovalidatior by default at build time thus allowing for
runnig unit test by default.
$ ./configure --enable-actions-default-autovalidator
Signed-off-by: Kumar Amber
Signed-off-by: Emma Finn
---
acinclude.m4
This commit adds the AVX512 implementation of the action functionality.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set avx512
Signed-off-by: Emma Finn
---
lib/automake.mk | 4 ++-
lib/dpdk.c| 1 +
lib/odp-execute-avx512.c | 69
From: Kumar Amber
Added separate test-case for ovs-actions get/set commands:
1023: PMD - ovs-actions configuration
The above added tests are to test the commands which are used
to either get or set the ovs-actions function pointers to
various different implementations like AVX512 or
This commit introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different action implementations against the linear
action implementation.
The autovalidator function can be triggered at runtime using the
following command:
$ ovs-appctl
This commit adds a new command to allow the user to switch
the active action implementation at runtime. A probe function
is executed before switching the implementation, to ensure
the CPU is capable of running the ISA required.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set scalar
This commit
---
v2:
- Fix the CI build issues.
---
This patchset introduces actions infrastructure changes
which allows the user to choose between different action
implementations based on CPU ISA by using different commands.
The Infrastructure also provides a way to check the correctness of
the ISA
This commit introduces the initial infrastructure required to allow
different implementations for OvS actions. The patch introduces action
function pointers which allows user to switch between different action
implementations available. This will allow for more performance and flexibility
so the
This commit removes the pop_vlan action from the large switch
and creates a separate function for batched processing. A function
pointer is also added to call the new batched function for the pop_vlan
action.
Signed-off-by: Emma Finn
---
v2:
- Refactor to fix build warnings
---
Thanks for the backport from upstream!
May I request backport patch [1] and this patch down to supported branches?
Thanks.
1:
https://github.com/openvswitch/ovs/commit/6a101a6c8372570a30e0f8edb558c8a69cc80e7d
Regards,
Vladislav Odintsov
On 12 Oct 2021, at 22:30, Ilya Maximets
On Tue, Nov 30, 2021 at 5:53 PM Van Haaren, Harry
wrote:
> > Resolve isa availability in constructors by using a simplified query
> > based on cpuid API that comes from the compiler.
>
> Using constructors instead of an init() time call is interesting, but may not
> be what we
> always want. For
On Thu, Dec 2, 2021 at 2:56 PM Van Haaren, Harry
wrote:
>
> > -Original Message-
> > From: dev On Behalf Of David Marchand
> > Sent: Thursday, December 2, 2021 12:21 PM
> > To: Amber, Kumar
> > Cc: d...@openvswitch.org; i.maxim...@ovn.org; f...@sysclose.org;
> >
> -Original Message-
> From: dev On Behalf Of David Marchand
> Sent: Thursday, December 2, 2021 12:21 PM
> To: Amber, Kumar
> Cc: d...@openvswitch.org; i.maxim...@ovn.org; f...@sysclose.org;
> maxime.coque...@redhat.com
> Subject: Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd
On Thu, Dec 2, 2021 at 1:26 PM Stokes, Ian wrote:
> > The rest is the same than dpdk-latest branch (with the experimental
> > api build check kept in dpdk-latest only).
> > So lgtm, and with those small things from above fixed, feel free to add:
>
> So the one thing I spotted was the dpdk unit
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Thu, 2 Dec 2021 07:51:48 + you wrote:
> The 'if (dev)' statement already move into dev_{put , hold}, so remove
> redundant if statements.
>
> Signed-off-by: Xu Wang
> ---
>
On 12/2/21 13:37, David Marchand wrote:
> On Thu, Dec 2, 2021 at 1:18 PM Ilya Maximets wrote:
>>
>> On 12/2/21 12:47, David Marchand wrote:
>>> I did a quick pass and caught some small things to fix:
>>>
>>> - should we list 21.11.x for 2.17.x in Documentation/faq/releases.rst table?
>>
>> This
A datapath flow generated for traffic from vxlan port to another vxlan port
looks like this:
tunnel(tun_id=0x65,src=10.10.11.3,dst=10.10.11.2,ttl=0/0,tp_dst=4789,flags(+key)),...,in_port(vxlan_sys_4789),...,
On 2021-12-02 2:36 PM, Roi Dayan wrote:
A datapath flow generated for traffic from vxlan port to another vxlan port
looks like this:
tunnel(tun_id=0x65,src=10.10.11.3,dst=10.10.11.2,ttl=0/0,tp_dst=4789,flags(+key)),...,in_port(vxlan_sys_4789),...,
On Thu, Dec 2, 2021 at 1:18 PM Ilya Maximets wrote:
>
> On 12/2/21 12:47, David Marchand wrote:
> > I did a quick pass and caught some small things to fix:
> >
> > - should we list 21.11.x for 2.17.x in Documentation/faq/releases.rst table?
>
> This will be done as part of "Prepare for 2.17.0."
A datapath flow generated for traffic from vxlan port to another vxlan port
looks like this:
tunnel(tun_id=0x65,src=10.10.11.3,dst=10.10.11.2,ttl=0/0,tp_dst=4789,flags(+key)),...,in_port(vxlan_sys_4789),...,
> On Tue, Nov 30, 2021 at 4:54 PM Ian Stokes wrote:
> >
> > This commit adds support for DPDK v21.11, it includes the following
> > changes.
> >
> > 1. ci: Install python elftools for DPDK 21.02.
> > 2. ci: Update meson requirement for DPDK 21.05.
> > 3. netdev-dpdk: Fix build with 21.05.
> > 4.
On Wed, Dec 1, 2021 at 3:52 PM Amber, Kumar wrote:
> > diff --git a/tests/genpkts.py b/tests/genpkts.py new file mode 100755 index
> > 00..f64f786ccb
> > --- /dev/null
> > +++ b/tests/genpkts.py
> > @@ -0,0 +1,56 @@
> > +#!/usr/bin/env python3
> > +
> > +import sys
> > +
> > +from
On 12/2/21 12:47, David Marchand wrote:
> I did a quick pass and caught some small things to fix:
>
> - should we list 21.11.x for 2.17.x in Documentation/faq/releases.rst table?
This will be done as part of "Prepare for 2.17.0." patch while preparing
for the actual release along with update for
On Tue, Nov 30, 2021 at 4:54 PM Ian Stokes wrote:
>
> This commit adds support for DPDK v21.11, it includes the following
> changes.
>
> 1. ci: Install python elftools for DPDK 21.02.
> 2. ci: Update meson requirement for DPDK 21.05.
> 3. netdev-dpdk: Fix build with 21.05.
> 4. ci: Compile DPDK
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please
Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
mv lib/nx-match.inc.tmp lib/nx-match.inc
depbase=`echo lib/nx-match.lo | sed
This commit adds the AVX512 implementation of the pop_vlan action.
The implementation here is auto-validated by the miniflow
extract autovalidator, hence its correctness can be easily
tested and verified.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 76
This commit adds the AVX512 implementation of the action functionality.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set avx512
Signed-off-by: Emma Finn
---
lib/automake.mk | 4 ++-
lib/dpdk.c| 1 +
lib/odp-execute-avx512.c | 68
From: Kumar Amber
Added separate test-case for ovs-actions get/set commands:
1023: PMD - ovs-actions configuration
The above added tests are to test the commands which are used
to either get or set the ovs-actions function pointers to
various different implementations like AVX512 or
From: Kumar Amber
This commit adds a new command to allow the user to enable
autovalidatior by default at build time thus allowing for
runnig unit test by default.
$ ./configure --enable-actions-default-autovalidator
Signed-off-by: Kumar Amber
Signed-off-by: Emma Finn
---
acinclude.m4
This commit introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different action implementations against the linear
action implementation.
The autovalidator function can be triggered at runtime using the
following command:
$ ovs-appctl
This commit adds a new command to allow the user to switch
the active action implementation at runtime. A probe function
is executed before switching the implementation, to ensure
the CPU is capable of running the ISA required.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set scalar
This commit
This patchset introduces actions infrastructure changes
which allows the user to choose between different action
implementations based on CPU ISA by using different commands.
The Infrastructure also provides a way to check the correctness of
the ISA optimized action version against the scalar
Improve packet-in debuggability within pinctrl module
by printing basic details about each received packet-in
message, those messages will be printed to the logs only
when DBG log level is enabled.
Also, add two coverage counters that will indicate the total
packet-in messages that were received
This commit removes the pop_vlan action from the large switch
and creates a separate function for batched processing. A function
pointer is also added to call the new batched function for the pop_vlan
action.
Signed-off-by: Emma Finn
---
lib/odp-execute.c | 29 +++--
1
This commit introduces the initial infrastructure required to allow
different implementations for OvS actions. The patch introduces action
function pointers which allows user to switch between different action
implementations available. This will allow for more performance and flexibility
so the
Modified the dplcs info-get command output to include
the count for different dpcls implementations.
$ovs-appctl dpif-netdev/subtable-lookup-prio-get
Available dpcls implementations:
autovalidator (Use count: 1, Priority: 5)
generic (Use count: 0, Priority: 1)
avx512_gather (Use count: 0,
Modified the dplcs info-get command output to include
the count for different dpcls implementations.
$ovs-appctl dpif-netdev/subtable-lookup-prio-get
Available dpcls implementations:
autovalidator (Use count: 1, Priority: 5)
generic (Use count: 0, Priority: 1)
avx512_gather (Use count: 0,
Hi Ian,
On 11/30/21 16:53, Ian Stokes wrote:
This commit adds support for DPDK v21.11, it includes the following
changes.
1. ci: Install python elftools for DPDK 21.02.
2. ci: Update meson requirement for DPDK 21.05.
3. netdev-dpdk: Fix build with 21.05.
4. ci: Compile DPDK in non developer
58 matches
Mail list logo
