[ovs-dev] [PATCH net v2 3/3] net: openvswitch: Fix matching zone id for invalid conns arriving from tc

Zone id is not restored if we passed ct and ct rejected the connection, as there is no ct info on the skb. Save the zone from tc skb cb to tc skb extension and pass it on to ovs, use that info to restore the zone id for invalid connections. Fixes: d29334c15d33 ("net/sched: act_api: fix miss set

[ovs-dev] [PATCH net v2 2/3] net/sched: flow_dissector: Fix matching on zone id for invalid conns

If ct rejects a flow, it removes the conntrack info from the skb. act_ct sets the post_ct variable so the dissector will see this case as an +tracked +invalid state, but the zone id is lost with the conntrack info. To restore the zone id on such cases, set the last executed zone, via the tc

[ovs-dev] [PATCH net v2 1/3] net/sched: Extend qdisc control block with tc control block

BPF layer extends the qdisc control block via struct bpf_skb_data_end and because of that there is no more room to add variables to the qdisc layer control block without going over the skb->cb size. Extend the qdisc control block with a tc control block, and move all tc related variables to there

[ovs-dev] [PATCH net v2 0/3] net/sched: Fix ct zone matching for invalid conntrack state

Hi, Currently, when a packet is marked as invalid conntrack_in in act_ct, post_ct will be set, and connection info (nf_conn) will be removed from the skb. Later openvswitch and flower matching will parse this as ct_state=+trk+inv. But because the connection info is missing, there is also no zone

Re: [ovs-dev] [PATCH net 0/3] net/sched: Fix ct zone matching for invalid conntrack state

On Thu, 9 Dec 2021, Jakub Kicinski wrote: > On Wed, 8 Dec 2021 19:02:37 +0200 Paul Blakey wrote: > > Currently, when a packet is marked as invalid conntrack_in in act_ct, > > post_ct will be set, and connection info (nf_conn) will be removed > > from the skb. Later openvswitch and flower

Re: [ovs-dev] [PATCH net 0/3] net/sched: Fix ct zone matching for invalid conntrack state

On Wed, 8 Dec 2021 19:02:37 +0200 Paul Blakey wrote: > Currently, when a packet is marked as invalid conntrack_in in act_ct, > post_ct will be set, and connection info (nf_conn) will be removed > from the skb. Later openvswitch and flower matching will parse this > as ct_state=+trk+inv. But

Re: [ovs-dev] [PATCH ovn v4] controller/pinctrl: improve packet-in debuggability

On Wed, Dec 8, 2021 at 9:00 AM Mohammad Heib wrote: > > Improve packet-in debuggability within pinctrl module > by printing basic details about each received packet-in > message, those messages will be printed to the logs only > when DBG log level is enabled. > > Also, add two coverage counters

[ovs-dev] [PATCH v4 1/2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.2 with Nicira Extensions

Currently OVS supports flow-monitoring for OpenFlow 1.0 and Nicira Extenstions. Any other OpenFlow versioned messages are not accepted. This checkin will allow OpenFlow1.0-1.2 Flow Monitoring wth Nicira extensions be accepted. Also made sure that flow-monitoring updates, flow monitoring pause

[ovs-dev] [PATCH v4 2/2] ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+

Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats

Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: Introduce per rxq/txq Vhost-user statistics

On Wed, Nov 24, 2021 at 10:24 PM Maxime Coquelin wrote: > @@ -2385,6 +2408,7 @@ netdev_dpdk_vhost_update_rx_counters(struct netdev_dpdk > *dev, > } > > stats->rx_bytes += packet_size; > +q_stats->bytes += packet_size; > } > > if (OVS_UNLIKELY(qos_drops)) { >

[ovs-dev] [PATCH net 2/3] net/sched: flow_dissector: Fix matching on zone id for invalid conns

If ct rejects a flow, it removes the conntrack info from the skb. act_ct sets the post_ct variable so the dissector will see this case as an +tracked +invalid state, but the zone id is lost with the conntrack info. To restore the zone id on such cases, set the last executed zone, via the tc

[ovs-dev] [PATCH net 3/3] net: openvswitch: Fix matching zone id for invalid conns arriving from tc

Zone id is not restored if we passed ct and ct rejected the connection, as there is no ct info on the skb. Save the zone from tc skb cb to tc skb extension and pass it on to ovs, use that info to restore the zone id for invalid connections. Fixes: d29334c15d33 ("net/sched: act_api: fix miss set

[ovs-dev] [PATCH net 1/3] net/sched: Extend qdisc control block with tc control block

BPF layer extends the qdisc control block via struct bpf_skb_data_end and because of that there is no more room to add variables to the qdisc layer control block without going over the skb->cb size. Extend the qdisc control block with a tc control block, and move all tc related variables to there

[ovs-dev] [PATCH net 0/3] net/sched: Fix ct zone matching for invalid conntrack state

Hi, Currently, when a packet is marked as invalid conntrack_in in act_ct, post_ct will be set, and connection info (nf_conn) will be removed from the skb. Later openvswitch and flower matching will parse this as ct_state=+trk+inv. But because the connection info is missing, there is also no zone

[ovs-dev] OvS+OVN '21 Fall Conference - Day 2 joining information

Greetings, The second day of the fall conference will be starting at 17:00 UTC. In case the joining information didn't come through via the EventBrite email, or in case you lost the joining information, here are the instructions for joining Day 2. NOTE: Day 2 uses a different event link /

Re: [ovs-dev] [PATCH ovn 0/3] Support mixing stateless and stateful ACLs regardless of their priority

Thanks Numan, I’ll wait for your comments on #3. Regards, Vladislav Odintsov > On 8 Dec 2021, at 19:13, Numan Siddique wrote: > > On Tue, Dec 7, 2021 at 11:43 AM Vladislav Odintsov wrote: >> >> Talking about patches 1 and 2 - they've got totally no negative impact, >> it's an optimization

Re: [ovs-dev] [PATCH ovn 0/3] Support mixing stateless and stateful ACLs regardless of their priority

On Tue, Dec 7, 2021 at 11:43 AM Vladislav Odintsov wrote: > > Talking about patches 1 and 2 - they've got totally no negative impact, > it's an optimization for HW VTEP scenario - I'd like them to be included > as a part of 21.12. > > For patch #3 there is absolutely no affect for users who use

Re: [ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

On 12/8/21 15:11, Mohammad Heib wrote: > > On 12/6/21 4:08 PM, Ilya Maximets wrote: >> On 12/6/21 15:01, Ilya Maximets wrote: >>> On 12/6/21 14:35, Ilya Maximets wrote: On 12/6/21 10:09, Mohammad Heib wrote: > Improve packet-in debuggability within pinctrl module > by printing basic

Re: [ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

On 12/6/21 4:08 PM, Ilya Maximets wrote: On 12/6/21 15:01, Ilya Maximets wrote: On 12/6/21 14:35, Ilya Maximets wrote: On 12/6/21 10:09, Mohammad Heib wrote: Improve packet-in debuggability within pinctrl module by printing basic details about each received packet-in message, those messages

Re: [ovs-dev] [PATCH ovn v2] controller/pinctrl: improve packet-in debuggability

Hi Numan, thank you for the review. I submitted version 4 with your proposed change + Ilya's changes. thanks, On Fri, Dec 3, 2021 at 5:13 PM Numan Siddique wrote: > On Thu, Dec 2, 2021 at 5:41 AM

[ovs-dev] [PATCH ovn v4] controller/pinctrl: improve packet-in debuggability

Improve packet-in debuggability within pinctrl module by printing basic details about each received packet-in message, those messages will be printed to the logs only when DBG log level is enabled. Also, add two coverage counters that will indicate the total packet-in messages that were received

Re: [ovs-dev] [PATCH ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

Hi Lorenzo, Typo in the subject: "strucuture". On 12/3/21 19:53, Lorenzo Bianconi wrote: > Remove global state variables and move move inc-proc code in an isolated > structure. This is a preliminary patch to add the capability to run > multiple inc-proc engines. Overall this looks OK to me;

Re: [ovs-dev] [PATCH ovn] ovn-trace: honor ct state in execute_ct_lb

Hi Lorenzo, On 12/1/21 23:18, Lorenzo Bianconi wrote: > When performing CT_LB action in ovn-trace, take into account current > connection tracking state provided by the user. > > Related bz: https://bugzilla.redhat.com/show_bug.cgi?id=1980702 The formal tag is "Reported-at:". It's actually

Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: Introduce per rxq/txq Vhost-user statistics

On Tue, Dec 7, 2021 at 11:11 PM Maxime Coquelin wrote: > On 12/7/21 21:37, David Marchand wrote: > > On Wed, Nov 24, 2021 at 10:24 PM Maxime Coquelin > > wrote: > >> > >> HXPS feature will enable steering Tx packets on transmist > > > > transmit* > > > >> queues based on their hashes. In order