[ovs-dev] [PATCH] ovs-monitor-ipsec: Fix generated strongSwan ipsec.conf for IPv6

2021-12-20 Thread Antonin Bas
Setting the local address to 0.0.0.0 (v4 address) while setting the remote address to a v6 address results in an invalid configuration. See https://github.com/strongswan/strongswan/discussions/821 Signed-off-by: Antonin Bas --- ipsec/ovs-monitor-ipsec.in | 10 +- 1 file changed, 5 inser

Re: [ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Han Zhou
On Mon, Dec 20, 2021 at 11:50 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > On Dec 20, Han Zhou wrote: > > On Mon, Dec 20, 2021 at 10:32 AM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > > > On Mon, Dec 20, 2021 at 5:53 AM Lorenzo Bianconi < > > > > lorenzo.bia

Re: [ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Lorenzo Bianconi
On Dec 20, Han Zhou wrote: > On Mon, Dec 20, 2021 at 10:32 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > > On Mon, Dec 20, 2021 at 5:53 AM Lorenzo Bianconi < > > > lorenzo.bianc...@redhat.com> wrote: > > > > > > > > Remove global state variable and move move inc-proc code in a

Re: [ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Han Zhou
On Mon, Dec 20, 2021 at 10:32 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > > On Mon, Dec 20, 2021 at 5:53 AM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > > Remove global state variable and move move inc-proc code in an isolated > > > strucuture. This is a pr

Re: [ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Lorenzo Bianconi
> On Mon, Dec 20, 2021 at 5:53 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > Remove global state variable and move move inc-proc code in an isolated > > strucuture. This is a preliminary patch to add the capability to run > > multiple inc-proc engines. > > > > Thanks Lorenzo!

Re: [ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Han Zhou
On Mon, Dec 20, 2021 at 5:53 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Remove global state variable and move move inc-proc code in an isolated > strucuture. This is a preliminary patch to add the capability to run > multiple inc-proc engines. > Thanks Lorenzo! Could you tell mo

Re: [ovs-dev] [PATCH] ofp-flow: skip flow reply if it exceeds the maximum message size

2021-12-20 Thread Eelco Chaudron
On 20 Dec 2021, at 16:33, Adrian Moreno wrote: > On 12/6/21 17:57, Eelco Chaudron wrote: >> Currently, if a flow reply results in a message which exceeds >> the maximum reply size, it will assert OVS. This would happen >> when OVN uses OpenFlow15 to add large flows, and they get read >> using Op

Re: [ovs-dev] [PATCH] ofp-flow: skip flow reply if it exceeds the maximum message size

2021-12-20 Thread Adrian Moreno
On 12/6/21 17:57, Eelco Chaudron wrote: Currently, if a flow reply results in a message which exceeds the maximum reply size, it will assert OVS. This would happen when OVN uses OpenFlow15 to add large flows, and they get read using OpenFlow10 with ovs-ofctl. This patch prevents this and adds

[ovs-dev] [PATCH v3 5/5] Documentation: Remove experimental tag for PMD ALB.

2021-12-20 Thread Kevin Traynor
PMD Auto Load Balance was introduced as an experimental feature in OVS 2.11. It is used to detect that the Rx queue to PMD assignments are no longer balanced and it would be better to reassign. It is disabled by default, and can be enabled with: $ ovs-vsctl set open_vswitch . other_config:pmd-auto

[ovs-dev] [PATCH v3 3/5] Documentation: Update PMD thread statistics.

2021-12-20 Thread Kevin Traynor
'pmd-perf-show' gives some extra information and has nicer formatting than 'pmd-stats-show'. Let the user know they can use that as well to get PMD stats. Signed-off-by: Kevin Traynor Acked-by: Sunil Pai G --- Documentation/topics/dpdk/pmd.rst | 18 ++ 1 file changed, 18 insert

[ovs-dev] [PATCH v3 4/5] Documentation: Update PMD Auto Load Balance section.

2021-12-20 Thread Kevin Traynor
Updates to the PMD Auto Load Balance section to make it more readable. No change to the core content. Signed-off-by: Kevin Traynor Acked-by: Sunil Pai G --- Documentation/topics/dpdk/pmd.rst | 75 ++- 1 file changed, 34 insertions(+), 41 deletions(-) diff --git a/D

[ovs-dev] [PATCH v3 2/5] Documentation: Minor spelling and grammar fixes.

2021-12-20 Thread Kevin Traynor
Some minor spelling and grammar fixes in pmd.rst. Signed-off-by: Kevin Traynor Acked-by: Sunil Pai G --- Documentation/topics/dpdk/pmd.rst | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Documentation/topics/dpdk/pmd.rst b/Documentation/topics/dpdk/pmd.rst i

[ovs-dev] [PATCH v3 1/5] Documentation: Fix Rx/Tx queue configuration section.

2021-12-20 Thread Kevin Traynor
ovs-vsctl is used to configure physical Rx queues, not ovs-appctl. Number of Tx queues are configured differently depending on whether physical or virtual. Present documentation does not distinguish. Fixes: 31d0dae22a0e ("doc: Add "PMD" topic document") Signed-off-by: Kevin Traynor Acked-by: Sun

[ovs-dev] [PATCH v3 0/5] PMD docs and ALB status.

2021-12-20 Thread Kevin Traynor
The first patches are small fixes and additions to the PMD documentation as was I reading it. The last patch removes the experimental tag from PMD Auto Load Balance. v3: Fixed checkpatch warning. Added Sunil's Acks. v2: Fixes as per Sunil's comments. GHA: https://github.com/kevintraynor/ovs/act

Re: [ovs-dev] [PATCH ovn] controller: fix ovn patch port incremental processing

2021-12-20 Thread Mark Michelson
Thanks, Lorenzo. Acked-by: Mark Michelson On 12/16/21 18:49, Lorenzo Bianconi wrote: If a patch port that connects a logical router to a logical switch is added in a different ovn-controller run with respect to the logical switch peer port, just the router port will be processed and ovn-contro

Re: [ovs-dev] [PATCH] netdev-dpdk: Dummy implementation of the rte_flow API for testing purposes.

2021-12-20 Thread Eli Britstein via dev
On 12/17/2021 12:06 AM, Ilya Maximets wrote: External email: Use caution opening links or attachments New 'options:dummy-rte-flow' configuration knob for netdev-dpdk ports, i.e. type=dpdk/dpdkvhostuserclient, to turn on dummy rte_flow API. This version of API will do nothing but reply with s

[ovs-dev] [PATCH v3 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Lorenzo Bianconi
Remove global state variable and move move inc-proc code in an isolated strucuture. This is a preliminary patch to add the capability to run multiple inc-proc engines. Signed-off-by: Lorenzo Bianconi --- Changes since v2: - cosmetics - move unixctl commands registration in a dedicated routine - a

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-12-20 Thread Murilo Opsfelder Araújo
Hi, Flavio. On 11/24/21 10:16, Flavio Leitner wrote: On Tue, Nov 23, 2021 at 07:58:52PM -0300, Murilo Opsfelder Araújo wrote: Hi, Flavio. On 11/23/21 15:32, Flavio Leitner wrote: On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote: Hi, Ilya Maximets. On 11/19/21 13:23, I

Re: [ovs-dev] [PATCH v2 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Lorenzo Bianconi
On Dec 20, Dumitru Ceara wrote: > On 12/9/21 17:47, Lorenzo Bianconi wrote: > > Remove global state variable and move move inc-proc code in an isolated > > strucuture. This is a preliminary patch to add the capability to run > > multiple inc-proc engines. > > > > Signed-off-by: Lorenzo Bianconi >

Re: [ovs-dev] [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs.

2021-12-20 Thread Aaron Conole
lin huang writes: > From: linhuang > > Userspace tunnel doesn't have a valid device in the kernel. So > get_ifindex() function (ioctl) always get error during > adding a port, deleting a port or updating a port status. > > The info log is > "2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl

Re: [ovs-dev] [PATCH v1 07/18] python: introduce OpenFlow Flow parsing

2021-12-20 Thread Adrian Moreno
On 12/17/21 18:19, Eelco Chaudron wrote: On 22 Nov 2021, at 12:22, Adrian Moreno wrote: Introduce OFPFlow class and all its decoders. Most of the decoders are generic (from decoders.py). Some have special syntax and need a specific implementation. Decoders for nat are moved to the common

Re: [ovs-dev] [PATCH v2 3/5] Documentation: Update PMD thread statistics.

2021-12-20 Thread Kevin Traynor
On 20/12/2021 10:14, Pai G, Sunil wrote: Hi Kevin , Hi Sunil, Thanks for adding this. + +$ ovs-appctl dpif-netdev/pmd-perf-show + +Detailed performance metrics for ``pmd-perf-show`` can also be enabled:: + +$ ovs-vsctl set Open_vSwitch . other_config:pmd-perf-metrics=true + +See th

Re: [ovs-dev] [PATCH v2 3/5] Documentation: Update PMD thread statistics.

2021-12-20 Thread Pai G, Sunil
Hi Kevin , Thanks for adding this. > + > +$ ovs-appctl dpif-netdev/pmd-perf-show > + > +Detailed performance metrics for ``pmd-perf-show`` can also be enabled:: > + > +$ ovs-vsctl set Open_vSwitch . other_config:pmd-perf-metrics=true > + > +See the `ovs-vswitchd(8)`_ manpage for more inf

Re: [ovs-dev] [PATCH v1 02/18] python: add mask, ip and eth decoders

2021-12-20 Thread Adrian Moreno
On 12/17/21 14:10, Eelco Chaudron wrote: See comments inline below. On 22 Nov 2021, at 12:22, Adrian Moreno wrote: Add more decoders that can be used by KVParser. For IPv4 and IPv6 addresses, create a new class that wraps netaddr.IPAddress. For Ethernet addresses, create a new class that wr

Re: [ovs-dev] [PATCH v2 ovn] inc-proc-eng: move inc-proc code in an isolated strucuture

2021-12-20 Thread Dumitru Ceara
On 12/9/21 17:47, Lorenzo Bianconi wrote: > Remove global state variable and move move inc-proc code in an isolated > strucuture. This is a preliminary patch to add the capability to run > multiple inc-proc engines. > > Signed-off-by: Lorenzo Bianconi > --- Hi Lorenzo, > Changes since v1: > - f

Re: [ovs-dev] [PATCH v2 4/5] Documentation: Update PMD Auto Load Balance section.

2021-12-20 Thread Pai G, Sunil
LGTM Acked-by: Sunil Pai G ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 02/18] python: add mask, ip and eth decoders

2021-12-20 Thread Adrian Moreno
On 11/22/21 14:07, Timothy Redaelli wrote: On Mon, 22 Nov 2021 12:22:40 +0100 Adrian Moreno wrote: Add more decoders that can be used by KVParser. For IPv4 and IPv6 addresses, create a new class that wraps netaddr.IPAddress. For Ethernet addresses, create a new class that wraps netaddr.EUI.

Re: [ovs-dev] [PATCH v1 01/18] python: add generic Key-Value parser

2021-12-20 Thread Adrian Moreno
On 12/10/21 16:58, Eelco Chaudron wrote: On 22 Nov 2021, at 12:22, Adrian Moreno wrote: Most of ofproto and dpif flows are based on key-value pairs. These key-value pairs can be represented in several ways, eg: key:value, key=value, key(value). Add the following classes that allow parsing

Re: [ovs-dev] [PATCH 4/5] utilities: add upcall USDT probe and associated script

2021-12-20 Thread Eelco Chaudron
On 20 Dec 2021, at 0:48, Paolo Valerio wrote: > Hi Eelco, > > the patch LGTM, just a couple of questions/nits. > > Eelco Chaudron writes: > >> Added the dpif_recv:recv_upcall USDT probe, which is used by the >> included upcall_monitor.py script. This script receives all upcall >> packets sent

Re: [ovs-dev] [PATCH v2 2/5] Documentation: Minor spelling and grammar fixes.

2021-12-20 Thread Pai G, Sunil
LGTM . Acked-by: Sunil Pai G ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/5] Documentation: Update PMD Auto Load Balance section.

2021-12-20 Thread Pai G, Sunil
Hi Kevin, > > I wonder if we could use the term 'overloaded' instead of 'above the > threshold' ? > > Don't have a strong preference tbh. > > > > I tried to avoid using 'overloaded' here because it might suggest that the CPU > is at 100% utilization processing packets, and the datapath is in som

Re: [ovs-dev] [PATCH 3/5] Documentation: add USDT documentation and bpftrace example

2021-12-20 Thread Eelco Chaudron
On 20 Dec 2021, at 0:45, Paolo Valerio wrote: > Eelco Chaudron writes: > >> Add the USDT documentation and a bpftrace example using the >> bridge run USDT probes. >> >> Signed-off-by: Eelco Chaudron >> +Scripts >> +--- >> +To not have to re-invent the wheel when trying to debug complex