Re: [ovs-dev] [PATCH] odp-util: Stop action list parsing if already oversized.

2022-01-07 Thread Ilya Maximets
On 1/6/22 15:00, Aaron Conole wrote: > Ilya Maximets writes: > >> The fuzzing target times out if the action list is too big. And we >> don't really need to fully parse all the actions just to say that they >> are too big in the end. So, check early and exit. >> >> This is a pure performance

Re: [ovs-dev] [PATCH v3] acinclude: Provide better error info when linking fails with DPDK.

2022-01-07 Thread Ilya Maximets
On 1/6/22 07:46, Pai G, Sunil wrote: > Hi Eelco, > >>> - Could not find DPDK library in default search path, update >>> + Failed to link with DPDK, check config.log for more details. >>> + Could not find working DPDK library in default search path, >>> + update >>>

Re: [ovs-dev] [PATCH v2] dpif-netdev: avoid hw_miss_packet_recover() for devices with no support

2022-01-07 Thread Ilya Maximets
On 12/21/21 19:50, Ilya Maximets wrote: > On 12/13/21 08:37, Sriharsha Basavapatna via dev wrote: >> The hw_miss_packet_recover() API results in performance degradation, for >> ports that are either not offload capable or do not support this specific >> offload API. >> >> For example, in the test

Re: [ovs-dev] [PATCH v3] dpif-netdev: Forwarding optimization for flows with a simple match.

2022-01-07 Thread Ilya Maximets
On 12/22/21 06:38, Sriharsha Basavapatna wrote: > On Tue, Nov 2, 2021 at 1:48 AM Ilya Maximets wrote: >> >> On 10/30/21 09:04, Sriharsha Basavapatna wrote: >>> On Mon, Aug 9, 2021 at 6:28 PM Ilya Maximets wrote: There are cases where users might want simple forwarding or drop rules

Re: [ovs-dev] [ovs-dev v6 3/3] ipf: ipf_preprocess_conntrack should also consider ipf_ctx

2022-01-07 Thread Mike Pattrick
On Thu, 2021-12-30 at 08:03 +, Peng He wrote: > considering a multi-thread PMD setting, when the frags are > reassembled > in one PMD, another thread might call *ipf_execute_reass_pkts* and > 'steal' > the reassembled packets into its ipf ctx, then this reassembled > packet will enter into

Re: [ovs-dev] [PATCH 4/4] ovsdb: row: Optimize row updates by applying diffs in-place.

2022-01-07 Thread Mike Pattrick
On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote: > ovsdb_datum_apply_diff_in_place() is much faster than the usual > ovsdb_datum_apply_diff() in most cases, because it doesn't clone or > compare unnecessary data. Since the original destination datum is > destroyed anyway, we might use the

Re: [ovs-dev] [PATCH 3/4] ovsdb: relay: Add transaction history support.

2022-01-07 Thread Mike Pattrick
On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote: > Even though relays can be scaled to the big number of servers to > handle a lot more clients, lack of transaction history may cause > significant load if clients are re-connecting. > E.g. in case of the upgrade of a large-scale OVN

Re: [ovs-dev] [PATCH 2/4] ovsdb: transaction: Keep one entry in the transaction history.

2022-01-07 Thread Mike Pattrick
On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote: > If a single transaction exceeds the size of the whole database (e.g., > a lot of rows got removed and new ones added), transaction history > will > be drained. This leads to sending UUID_ZERO to the clients as the > last > transaction id

Re: [ovs-dev] [PATCH 1/4] ovsdb-cs: Fix ignoring of the last id from the initial monitor reply.

2022-01-07 Thread Mike Pattrick
Hello Ilya, LGTM! Acked-by: Mike Pattrick On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote: > Current code doesn't use the last id received in the monitor reply. > That may result in re-downloading the database content if the > re-connection happened after receiving the initial monitor

Re: [ovs-dev] [PATCH v5] conntrack: support default timeout policy get/set cmd for netdev datapath

2022-01-07 Thread Paolo Valerio
we...@ucloud.cn writes: > From: wenxu > > Now, the default timeout policy for netdev datapath is hard codeing. In > some case show or modify is needed. > Add command for get/set default timeout policy. Using like this: > > ovs-appctl dpctl/ct-get-default-tp [dp] > ovs-appctl

Re: [ovs-dev] [PATCH ovn v2] northd: Add support for NAT with multiple DGP

2022-01-07 Thread Abhiram Sangana
Hi Mark, Thanks for looking into this patch. > On 5 Jan 2022, at 22:01, Mark Michelson wrote: > > Hi, > > I haven't done a full review of this patch, but I have noticed a problem > pretty early on when I started looking. > > The new ip_in_lrp_networks() function that is added here is

Re: [ovs-dev] [PATCH v2] ofp-flow: skip flow reply if it exceeds the maximum message size

2022-01-07 Thread Eelco Chaudron
On 7 Jan 2022, at 14:15, Ilya Maximets wrote: > On 1/7/22 13:43, Eelco Chaudron wrote: >> >> >> On 7 Jan 2022, at 13:34, Maxime Coquelin wrote: >> >>> Hi Eelco, >>> >>> On 1/5/22 10:48, Eelco Chaudron wrote: Currently, if a flow reply results in a message which exceeds the maximum

Re: [ovs-dev] [PATCH v2] ofp-flow: skip flow reply if it exceeds the maximum message size

2022-01-07 Thread Ilya Maximets
On 1/7/22 13:43, Eelco Chaudron wrote: > > > On 7 Jan 2022, at 13:34, Maxime Coquelin wrote: > >> Hi Eelco, >> >> On 1/5/22 10:48, Eelco Chaudron wrote: >>> Currently, if a flow reply results in a message which exceeds >>> the maximum reply size, it will assert OVS. This would happen >>> when

Re: [ovs-dev] [PATCH v4] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

2022-01-07 Thread Eelco Chaudron
On 6 Jan 2022, at 19:07, Aaron Conole wrote: > This reverts commit c645550bb249 ("odp-util: Always report > ODP_FIT_TOO_LITTLE for IGMP.") > > Always forcing a slow path action can result in some over-broad > flows which swallow all traffic and force them to userspace, as reported > in the

Re: [ovs-dev] [PATCH v2] ofp-flow: skip flow reply if it exceeds the maximum message size

2022-01-07 Thread Eelco Chaudron
On 7 Jan 2022, at 13:34, Maxime Coquelin wrote: > Hi Eelco, > > On 1/5/22 10:48, Eelco Chaudron wrote: >> Currently, if a flow reply results in a message which exceeds >> the maximum reply size, it will assert OVS. This would happen >> when OVN uses OpenFlow15 to add large flows, and they get

Re: [ovs-dev] [PATCH dpdk-latest] ci: Remove -Wno-cast-align from CI

2022-01-07 Thread Richardson, Bruce
> -Original Message- > From: David Marchand > Sent: Thursday, January 6, 2022 10:42 AM > To: Ilya Maximets > Cc: Eelco Chaudron ; Eli Britstein > ; ovs dev ; Richardson, Bruce > ; Luca Boccassi ; Thomas > Monjalon > Subject: Re: [ovs-dev] [PATCH dpdk-latest] ci: Remove

[ovs-dev] [PATCH nf-next 5/5] net: prefer nf_ct_put instead of nf_conntrack_put

2022-01-07 Thread Florian Westphal
Its the same as nf_conntrack_put(), but without the need for an indirect call. The downside is a module dependency on nf_conntrack, but all of these already depend on conntrack anyway. Cc: Paul Blakey Cc: d...@openvswitch.org Signed-off-by: Florian Westphal ---

Re: [ovs-dev] [PATCH v2] ofp-flow: skip flow reply if it exceeds the maximum message size

2022-01-07 Thread Maxime Coquelin
Hi Eelco, On 1/5/22 10:48, Eelco Chaudron wrote: Currently, if a flow reply results in a message which exceeds the maximum reply size, it will assert OVS. This would happen when OVN uses OpenFlow15 to add large flows, and they get read using OpenFlow10 with ovs-ofctl. This patch prevents this

Re: [ovs-dev] [PATCH] relay:add transaction history for relay server

2022-01-07 Thread Ilya Maximets
On 1/7/22 07:25, Wentao Jia wrote: > > relay server inherit transaction historys from cluster source server > > Signed-off-by: Wentao Jia > --- >  lib/ovsdb-cs.c       |  1 + >  lib/ovsdb-cs.h       |  1 + >  ovsdb/ovsdb-server.c |  4 +++- >  ovsdb/relay.c        | 22 -- >  

Re: [ovs-dev] [PATCH ovn 0/6] Fix UndefinedBehaviorSanitizer reported issues.

2022-01-07 Thread Dumitru Ceara
On 1/6/22 19:38, Mark Michelson wrote: > On 12/23/21 14:40, Dumitru Ceara wrote: >> On 12/21/21 21:22, Numan Siddique wrote: >>> On Tue, Dec 21, 2021 at 1:57 PM Han Zhou wrote: On Tue, Dec 21, 2021 at 9:31 AM Numan Siddique wrote: > > On Fri, Dec 17, 2021 at 4:29 PM Dumitru

Re: [ovs-dev] [PATCH] relay:probe interval of relay server

2022-01-07 Thread 0-day Robot
Bleep bloop. Greetings Wentao Jia, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #89 FILE: ovsdb/relay.c:114:

[ovs-dev] [PATCH] relay:probe interval of relay server

2022-01-07 Thread Wentao Jia
probe interval of relay server can be configured from "sb_global/nb_global options:relay_probe_interval" minimum and default value is 5s Signed-off-by: Wentao Jia --- ovsdb/relay.c | 73 +++ 1 file changed, 73 insertions(+) diff --git