[ovs-dev] [PATCH v3 2/2] ofproto-dpif-xlate: Fix packet drops with decap action on MPLS Multicast.

2022-01-19 Thread Martin Varghese
From: Martin Varghese Added PT_MPLS_MC support in function xlate_generic_decap_action to fix packet drops when decap action is applied on packets with packet_type (ns=1,type=0x8848). Fixes: 1917ace89364 ("Encap & Decap actions for MPLS packet type.") Signed-off-by: Martin Varghese --- Changes

[ovs-dev] [PATCH v3 1/2] tests: Fix cosmetic errors in system-traffic.at.

2022-01-19 Thread Martin Varghese
From: Martin Varghese Removed extra lines in multiple encap decap mpls actions & encap decap mpls actions tests. Converted title of encap decap mpls actions tests to lowercase for consistency. Fixes: 1917ace89364 ("Encap & Decap actions for MPLS packet type.") Signed-off-by: Martin Varghese

[ovs-dev] [PATCH v3 0/2] Fixes for mpls encap/decap actions

2022-01-19 Thread Martin Varghese
From: Martin Varghese This series contains fixes for the commit 1917ace89364 ("Encap & Decap actions for MPLS packet type."). Martin Varghese (2): tests: Fix cosmetic errors in system-traffic.at. ofproto-dpif-xlate: Fix packet drops with decap action on MPLS Multicast.

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Pickup Ct tuple as CT lookup key in function OvsCtSetupLookupCtx

2022-01-19 Thread Alin-Gabriel Serdean
Thank you for incorporating the comments! Will apply it on master and backport it until branch-2.13. Acked-by: Alin-Gabriel Serdean Alin. -Original Message- From: dev On Behalf Of Wilson Peng Sent: Thursday, January 20, 2022 2:32 AM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH

[ovs-dev] [PATCH v2 1/1] datapath-windows: Pickup Ct tuple as CT lookup key in function OvsCtSetupLookupCtx

2022-01-19 Thread Wilson Peng
From: Wilson Peng CT marks which are loaded in non-first commit will be lost in ovs-windows.In linux OVS, the CT mark setting with same flow could be set successfully. Currenlty Ovs-windows will create one new CT with the flowKey(Extracted from the packet itself) If the packet is already done

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Pickup Ct tuple as CT lookup key in function OvsCtSetupLookupCtx

2022-01-19 Thread Alin-Gabriel Serdean
Thanks a lot for debugging and fixing the issue. Just one small nit from my side, maybe OvsPickupCtTupleAsLookupKey shouldn't have a return value. Alin. -Original Message- From: dev On Behalf Of Wilson Peng Sent: Wednesday, January 12, 2022 6:33 PM To: d...@openvswitch.org Subject:

[ovs-dev] [PATCH] system-dpdk: Fix MFEX logs check.

2022-01-19 Thread David Marchand
Some warning logs must be waived when using the net/pcap DPDK driver. Those logs can affect different DPDK drivers (like mlx5) and the tests in system-dpdk are not testing MTU and Rx checksum, we might as well ignore those warnings from OVS. Fixes: d446dcb7e03f ("system-dpdk: Refactor common logs

Re: [ovs-dev] [PATCH OVN] ovndb-ctl:probe interval of ovndb-ctl daemon

2022-01-19 Thread Numan Siddique
On Thu, Jan 6, 2022 at 11:02 PM Wentao Jia wrote: > > > ovndb-ctl deamon mode, the connection cannot be reconnected when > connection is broken, set inactivity probe interval to make it > reconnected > > > Signed-off-by: Wentao Jia Thanks for the patch. I see one issue with using the default

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: report peer addresses running lsp-get-addresses for patch ports

2022-01-19 Thread Numan Siddique
On Thu, Dec 23, 2021 at 9:52 AM Lorenzo Bianconi wrote: > > Report logical router port addresses running lsp-get-addresses if the > logical switch port address is set to "router". > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2028040 > Signed-off-by: Lorenzo Bianconi Hi Lorenzo,

Re: [ovs-dev] [PATCH ovn] northd: Fix missing space in log warnings.

2022-01-19 Thread Numan Siddique
On Mon, Jan 17, 2022 at 7:24 PM James Troup wrote: > > Add a space between 'static route' and the UUID in logs. > > Signed-off-by: James Troup Thanks. I applied to the main branch. Numan > --- > northd/northd.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > e.g. > >

Re: [ovs-dev] [PATCH v1] conntrack: Always recalculate IP header checksum.

2022-01-19 Thread Eelco Chaudron
On 19 Jan 2022, at 14:53, Mike Pattrick wrote: > Formerly when userspace TSO was enabled but with a non-DKDK interface > without support IP checksum offloading, FTP NAT connections would fail > if the packet length changed. This can happen if the packets length > changes during L7 NAT

[ovs-dev] [PATCH ovn] controller: Use precomputed is_switch instead of querying external IDs.

2022-01-19 Thread Dumitru Ceara
We already store whether a datapath is a switch or not. No need to do an smap lookup through its external IDs every time we need this information. Signed-off-by: Dumitru Ceara --- controller/lflow.c | 25 ++--- controller/pinctrl.c | 2 +- 2 files changed, 15

[ovs-dev] [PATCH v1] conntrack: Always recalculate IP header checksum.

2022-01-19 Thread Mike Pattrick
Formerly when userspace TSO was enabled but with a non-DKDK interface without support IP checksum offloading, FTP NAT connections would fail if the packet length changed. This can happen if the packets length changes during L7 NAT translation, predominantly with FTP. This is why the "conntrack -

[ovs-dev] [PATCH ovn 2/2] ovn-ic: physical: Support multicast_group flooding on IC transit switches.

2022-01-19 Thread Dumitru Ceara
Forwarding on logical patch ports that are part of a multicast group normally happens on the local chassis. With interconnect transit switch, however, this doesn't work properly because patch ports in the local AZ might not correspond to patch ports in the remote AZ. This allows forwarding IP

[ovs-dev] [PATCH ovn 1/2] tests: Factor out multicast related helpers.

2022-01-19 Thread Dumitru Ceara
These were duplicated a few times already. Signed-off-by: Dumitru Ceara --- tests/ovn-macros.at | 193 + tests/ovn.at| 338 +++ 2 files changed, 212 insertions(+), 319 deletions(-) diff --git

[ovs-dev] [PATCH ovn 0/2] Support static IP multicast forwarding with OVN-IC.

2022-01-19 Thread Dumitru Ceara
Dumitru Ceara (2): tests: Factor out multicast related helpers. ovn-ic: physical: Support multicast_group flooding on IC transit switches. controller/local_data.c |1 controller/local_data.h |1 controller/physical.c | 20 ++ lib/ovn-util.c |6 +

Re: [ovs-dev] OVS has now branched for the 2.17 release.

2022-01-19 Thread Ilya Maximets
On 1/19/22 13:51, Ilya Maximets wrote: > Hi, everyone. > > branch-2.17 was created yesterday. Please, test it and report issues! > > Official release date according to our release process should be on > February 17 (~1 month from now). There was no pun intended, but I just realized that Feb

[ovs-dev] OVS has now branched for the 2.17 release.

2022-01-19 Thread Ilya Maximets
Hi, everyone. branch-2.17 was created yesterday. Please, test it and report issues! Official release date according to our release process should be on February 17 (~1 month from now). Best regards, Ilya Maximets. ___ dev mailing list

[ovs-dev] [PATCH v2 2/2] ofproto-dpif-xlate: Fix packet drops with decap action on MPLS Multicast.

2022-01-19 Thread Martin Varghese
From: Martin Varghese Added PT_MPLS_MC support in function xlate_generic_decap_action to fix packet drops when decap action is applied on packets with packet_type (ns=1,type=0x8848). Fixes: 1917ace89364 ("Encap & Decap actions for MPLS packet type.") Signed-off-by: Martin Varghese ---

[ovs-dev] [PATCH v2 1/2] tests: Fix cosmetic errors in system-traffic.at.

2022-01-19 Thread Martin Varghese
From: Martin Varghese Removed extra lines in multiple encap decap mpls actions & encap decap mpls actions tests. Fixes: 1917ace89364 ("Encap & Decap actions for MPLS packet type.") Signed-off-by: Martin Varghese --- tests/system-traffic.at | 2 -- 1 file changed, 2 deletions(-) diff --git

[ovs-dev] [PATCH v2 0/2] Fixes for mpls encap/decap actions

2022-01-19 Thread Martin Varghese
From: Martin Varghese This series contains fixes for the commit 1917ace89364 ("Encap & Decap actions for MPLS packet type."). Martin Varghese (2): tests: Fix cosmetic errors in system-traffic.at. ofproto-dpif-xlate: Fix packet drops with decap action on MPLS Multicast.