[ovs-dev] [PATCH ovn] Add support for port binding migration

2022-01-25 Thread Ihar Hrachyshka
When OVN moves a port binding to another node, options:requested-chassis is updated to point to a new chassis, at which point northd translates the change into SB updates; then the old chassis winds down flows related to the binding, and the new chassis configures the binding in the new location.

Re: [ovs-dev] [PATCH 2/3] ovsdb-cs: Clear last_id on reconnect if condition changes in-flight.

2022-01-25 Thread Han Zhou
On Tue, Jan 11, 2022 at 8:38 AM Dumitru Ceara wrote: > > When reconnecting, if there are condition changes already sent to the > server but not yet acked, reset the db's 'last-id', esentially clearing > the local cache after reconnect. > > This is needed because the client cannot easily

Re: [ovs-dev] [PATCH v2] ofproto-dpif: fix issue with non-reversible actions on a patch ports

2022-01-25 Thread Ilya Maximets
On 6/21/21 11:20, Eelco Chaudron wrote: > For patch ports, the is_last_action value is not propagated and is > always set to true. This causes non-reversible actions to modify the > packet, and the original content is not preserved when processing > the remaining actions. > > This patch

Re: [ovs-dev] [PATCH] NEWS: Fix some typo.

2022-01-25 Thread Ilya Maximets
On 1/24/22 14:50, Mike Pattrick wrote: > On Thu, Jan 6, 2022 at 5:51 AM David Marchand > wrote: >> >> The experimantal typo got copy/paste a few times. >> >> Fixes: be56e063d028 ("netdev-offload-dpdk: Support tunnel pop action.") >> Fixes: e098c2f966cb ("netdev-dpdk-offload: Add vxlan pattern

Re: [ovs-dev] [PATCH v3 ovn] ovn-nbctl: add the capability to specify CoPP name

2022-01-25 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #549 FILE: utilities/ovn-nbctl.c:440:

[ovs-dev] [PATCH v3 ovn] ovn-nbctl: add the capability to specify CoPP name

2022-01-25 Thread Lorenzo Bianconi
Introduce the capability to specify CoPP name in order to reuse the same CoPP reference on multiple datapaths. Introduce the following CoPP commands: - ovn-nbctl copp-add - ovn-nbctl copp-del - ovn-nbctl copp-list - ovn-nbctl ls-copp-add - ovn-nbctl lr-copp-add Introduce name and

Re: [ovs-dev] [PATCH v5 00/27] dpif-netdev: Parallel offload processing

2022-01-25 Thread Ilya Maximets
On 1/23/22 17:28, Sriharsha Basavapatna wrote: > Hi Ilya, > > On Wed, Jan 19, 2022 at 7:24 AM Ilya Maximets wrote: > >> >> I also spotted one bug where the flow stays offloaded if it gets added >> and removed shortly after that. But it's an old existing race condition, >> not introduced by

Re: [ovs-dev] [PATCH 4/4] ovsdb: row: Optimize row updates by applying diffs in-place.

2022-01-25 Thread Han Zhou
On Sun, Dec 19, 2021 at 6:09 AM Ilya Maximets wrote: > > ovsdb_datum_apply_diff_in_place() is much faster than the usual > ovsdb_datum_apply_diff() in most cases, because it doesn't clone or > compare unnecessary data. Since the original destination datum is > destroyed anyway, we might use the

Re: [ovs-dev] [PATCH 3/4] ovsdb: relay: Add transaction history support.

2022-01-25 Thread Han Zhou
On Sun, Dec 19, 2021 at 6:09 AM Ilya Maximets wrote: > > Even though relays can be scaled to the big number of servers to > handle a lot more clients, lack of transaction history may cause > significant load if clients are re-connecting. > E.g. in case of the upgrade of a large-scale OVN

Re: [ovs-dev] [PATCH] conntrack: Avoid sporadic failures during IPv6 HTTP/FTP tests

2022-01-25 Thread Mike Pattrick
On Mon, Dec 27, 2021 at 8:27 AM Paolo Valerio wrote: > > Some sporadic false positive may be visible for the following tests: > > - conntrack - IPv6 HTTP > - conntrack - FTP over IPv6 > > The failures show up randomly. > The reason appears to be source address used when performing the > request

Re: [ovs-dev] [PATCH] conntrack: Check TCP state while testing established connections pick up.

2022-01-25 Thread Mike Pattrick
On Mon, Dec 27, 2021 at 8:27 AM Paolo Valerio wrote: > > When testing if an established connection is picked up, it could be > useful to verify that the protocol state matches the expectation, that > is, it moves to ESTABLISHED, as there's a chance that code modifications > may break the TCP

Re: [ovs-dev] RFC for adding P4 Support in OVS

2022-01-25 Thread Frode Nordahl
On Fri, Jan 21, 2022 at 12:52 AM Limaye, Namrata wrote: > > Hi, > > We are working on adding P4 support to OVS and we have recently open-sourced > the patches on the IPDK github - >https://github.com/ipdk-io/ovs/tree/ovs-with-p4 > > The architecture document that explains the

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add mempool count in cmd get-mempool-info

2022-01-25 Thread Kevin Traynor
On 25/01/2022 09:41, Wan Junjie wrote: The ```rte_mempool_avail_count``` and ```rte_mempool_in_use_count``` can tell us the usage of the mempool. It could be helpful for debug on any memleak in the mempool. Add a line in the cmd's output. - Count: avail (118988), in use (12084) Hi Wan Junjie,

[ovs-dev] [PATCH] ofproto-dpif-upcall: fix n_revalidators on upcall show

2022-01-25 Thread Wan Junjie
When upcall/show is used to collect upcall statistics from a grafana collector or some agent, upcall/show can be called even during ovs restart. Occassionally ovs will crash when the revalidator thread is not really inited. Backtrace: warning: Unexpected size of section '.reg-xstate/3731535' in

[ovs-dev] [PATCH v2] netdev-dpdk: add mempool count in cmd get-mempool-info

2022-01-25 Thread Wan Junjie
The ```rte_mempool_avail_count``` and ```rte_mempool_in_use_count``` can tell us the usage of the mempool. It could be helpful for debug on any memleak in the mempool. Add a line in the cmd's output. - Count: avail (118988), in use (12084) Acked-by: Aaron Conole Signed-off-by: Wan Junjie ---

Re: [ovs-dev] [PATCH v2] ofproto: fix ipfix not always sampling on egress

2022-01-25 Thread Eelco Chaudron
On 24 Jan 2022, at 12:50, Adrian Moreno wrote: > We are currently requiring in_port to be a valid port number for ipfix > sampling even if the sampling is done on the output port (egress). > > This restriction is not really needed and can affect pipelines that > intentionally set the in_port