Re: [ovs-dev] [PATCH] netlink-socket: Make log extack messages as ERR rather than DBG

2022-02-02 Thread Abhiram R N
Hi Ilya, Thanks for your response. I understand the problem you have mentioned. Also for the rate limiting atleast we have solution as you have pointed out which can be helpful. Thanks & Regards, Abhiram R N On Wed, Feb 02, 2022 at 05:42:29PM +0100, Ilya Maximets wrote: > On 1/24/22 10:25, Abh

[ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-02 Thread Mark Michelson
It can be desirable for replies to stateful ACLs to be logged. And in some cases, it can actually be a bit confusing why they aren't logged. Consider a situation where a port group called "port_group" exists and logical switch ports swp1 and swp2 belong to it. We create the following ACL, where log

Re: [ovs-dev] [PATCH ovn v2] acl-log: Log the direction (logical pipeline) of the matching ACL.

2022-02-02 Thread Mark Michelson
Acked-by: Mark Michelson On 2/2/22 12:26, Dumitru Ceara wrote: It's useful to differentiate between ingress and egress pipelines in the ACL logs. To achieve this we expand the "log()" logical action and pass an optional direction. This behavior change is implemented in a backwards compatible

Re: [ovs-dev] [PATCH v2 ovn 3/3] controller: reconfigure ovs meters for ovn meters updates

2022-02-02 Thread Mark Michelson
I'm pretty certain that this code can miss meter updates in the southbound database. I have additional notes below. On 1/14/22 13:01, Lorenzo Bianconi wrote: At the moment ovs meters are reconfigured by ovn just when a new a meter is allocated while updates for an already allocated meter are ig

Re: [ovs-dev] [PATCH v2 ovn 2/3] lib: extend-table: add pending_id map

2022-02-02 Thread Mark Michelson
Hi Lorenzo, I think this and patch 3 should be combined. See notes below for why. On 1/14/22 13:01, Lorenzo Bianconi wrote: Introduce pending_id map used to store meter_id allocated but not yet inserted in the desired_table. This is a preliminary patch to add metering IP engine. Signed-off-by:

Re: [ovs-dev] [PATCH v2 ovn 1/3] inc-proc-eng: move inc-proc code in an isolated strucuture

2022-02-02 Thread Mark Michelson
Hi Lorenzo, I'm not opposed to allowing for multiple engines to exist, and this sort of change is one that I'd accept gladly since it allows for easier dependency injection for unit tests. That said, I don't think the follow-up patches justify this change. My comments in patch 2 will explain

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: fix n_revalidators on upcall show

2022-02-02 Thread Ilya Maximets
On 1/25/22 11:18, Wan Junjie wrote: > When upcall/show is used to collect upcall statistics from a grafana > collector or some agent, upcall/show can be called even during ovs > restart. Occassionally ovs will crash when the revalidator thread > is not really inited. Backtrace: > > warning: Unexpe

[ovs-dev] [PATCH ovn] vtep: provide option to check ovn-controller-vtep and ovn-northd versions

2022-02-02 Thread Vladislav Odintsov
Simlar to ovn-controller's behavior with checking internal version of ovn-northd and ovn-controller when option ovn-match-northd-version is defined, this commit adds same functionality for the ovn-controller-vtep daemon. This configuration option is located in the configured hardware_vtep database

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race condition in deletion of offloaded flows

2022-02-02 Thread Ilya Maximets
On 2/2/22 18:19, Sriharsha Basavapatna wrote: > On Wed, Feb 2, 2022 at 9:22 PM Ilya Maximets wrote: >> >> On 2/1/22 16:07, Gaëtan Rivet wrote: >>> On Tue, Feb 1, 2022, at 15:00, Ilya Maximets wrote: On 2/1/22 14:38, Gaëtan Rivet wrote: > On Tue, Feb 1, 2022, at 12:48, Ilya Maximets wrote:

[ovs-dev] [PATCH ovn v2] acl-log: Log the direction (logical pipeline) of the matching ACL.

2022-02-02 Thread Dumitru Ceara
It's useful to differentiate between ingress and egress pipelines in the ACL logs. To achieve this we expand the "log()" logical action and pass an optional direction. This behavior change is implemented in a backwards compatible way such that it doesn't break existing deployments even in the cas

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race condition in deletion of offloaded flows

2022-02-02 Thread Sriharsha Basavapatna via dev
On Wed, Feb 2, 2022 at 9:22 PM Ilya Maximets wrote: > > On 2/1/22 16:07, Gaëtan Rivet wrote: > > On Tue, Feb 1, 2022, at 15:00, Ilya Maximets wrote: > >> On 2/1/22 14:38, Gaëtan Rivet wrote: > >>> On Tue, Feb 1, 2022, at 12:48, Ilya Maximets wrote: > On 2/1/22 12:38, Gaëtan Rivet wrote: > >>>

Re: [ovs-dev] [PATCH] netlink-socket: Make log extack messages as ERR rather than DBG

2022-02-02 Thread Ilya Maximets
On 1/24/22 10:25, Abhiram R N wrote: > Making the log extack messages as ERR rather than DBG will help debugging > when we dont know for sure where is the issue. If it is DBG these useful > log extack messages might get lost due to excessive logs. Also these > error messages will be printed only wh

Re: [ovs-dev] [PATCH] netdev-dpdk: Update to use RTE_ETH namespace defines.

2022-02-02 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of Kevin Traynor > Sent: Thursday, January 13, 2022 9:53 PM > To: d...@openvswitch.org > Cc: david.march...@redhat.com > Subject: [ovs-dev] [PATCH] netdev-dpdk: Update to use RTE_ETH > namespace defines. > > This patch updates OVS to use DPDK R

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race condition in deletion of offloaded flows

2022-02-02 Thread Ilya Maximets
On 2/1/22 16:07, Gaëtan Rivet wrote: > On Tue, Feb 1, 2022, at 15:00, Ilya Maximets wrote: >> On 2/1/22 14:38, Gaëtan Rivet wrote: >>> On Tue, Feb 1, 2022, at 12:48, Ilya Maximets wrote: On 2/1/22 12:38, Gaëtan Rivet wrote: > On Mon, Jan 31, 2022, at 20:33, Ilya Maximets wrote: >> On 1

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Stokes, Ian
> > On 2/2/22 13:57, Stokes, Ian wrote: > > >>> -Original Message- > > >>> From: Ferriter, Cian > > >>> Sent: Friday 28 January 2022 16:32 > > >>> To: William Tu ; d...@openvswitch.org > > >>> Subject: RE: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq > compiler > > >> support. > > >

Re: [ovs-dev] Datapath downtime during OVN upgrade

2022-02-02 Thread Ilya Maximets
On 2/1/22 23:15, Vladislav Odintsov wrote: > Hi OVN and OVS folks, > > during OVN upgrade from 20.06 to 21.12 version I’ve faced with a quite long > datapath downtime (48-50 seconds). > I suppose this downtime was triggered by ovn-controller installing new > openflow rules to ovs. > There are re

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Wednesday 2 February 2022 13:57 > To: Stokes, Ian ; Ferriter, Cian > ; William Tu > ; d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler > support. > > On 2/2/22

[ovs-dev] [PATCH] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-02 Thread Cian Ferriter
The subtable search function can be used at any time by a PMD thread. Setting the subtable search function should be done atomically to prevent garbage data from being read. A dpcls_subtable_lookup_reprobe() call can happen at the same time that DPCLS subtables are being sorted. This could lead to

[ovs-dev] [PATCH] ovsdb-idl: Fix use-after-free when destroying an IDL loop.

2022-02-02 Thread Dumitru Ceara
Transactions that are still incomplete (waiting for a reply from the server) are kept in the IDL's 'outstanding_txns' map. When a transaction is destroyed, ovsdb_idl_txn_destroy() will take care of removing the transaction from the 'outstanding_txns' map if the transaction was incomplete. When de

Re: [ovs-dev] [PATCH ovn] acl-log: Log the direction (logical pipeline) of the matching ACL.

2022-02-02 Thread Dumitru Ceara
On 2/2/22 13:31, Dumitru Ceara wrote: > It's useful to differentiate between ingress and egress pipelines in the > ACL logs. To achieve this we expand the "log()" logical action and pass > an optional direction. > > This behavior change is implemented in a backwards compatible way such > that it

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Ilya Maximets
On 2/2/22 13:57, Stokes, Ian wrote: >>> -Original Message- >>> From: Ferriter, Cian >>> Sent: Friday 28 January 2022 16:32 >>> To: William Tu ; d...@openvswitch.org >>> Subject: RE: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler >> support. >>> >>> -Original Message-

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Stokes, Ian
> > -Original Message- > > From: Ferriter, Cian > > Sent: Friday 28 January 2022 16:32 > > To: William Tu ; d...@openvswitch.org > > Subject: RE: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler > support. > > > > > > > -Original Message- > > > From: dev On Behalf Of W

[ovs-dev] [PATCH ovn] acl-log: Log the direction (logical pipeline) of the matching ACL.

2022-02-02 Thread Dumitru Ceara
It's useful to differentiate between ingress and egress pipelines in the ACL logs. To achieve this we expand the "log()" logical action and pass an optional direction. This behavior change is implemented in a backwards compatible way such that it doesn't break existing deployments even in the cas

Re: [ovs-dev] [PATCH ovn] pinctrl: Avoid false positive out of bounds warning.

2022-02-02 Thread Dumitru Ceara
On 2/2/22 02:15, Numan Siddique wrote: > On Tue, Feb 1, 2022 at 11:46 AM Mark Michelson wrote: >> >> Acked-by: Mark Michelson > > Thanks. I applied this patch to the main branch and branch-21.12. Thanks! > > Do let me know if it needs to be backported further down. No, it's not needed furt

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix potential stack overflow in pinctrl_compose_ipv6().

2022-02-02 Thread Dumitru Ceara
On 2/2/22 02:13, Numan Siddique wrote: > On Tue, Feb 1, 2022 at 11:27 AM Mark Michelson wrote: >> >> Acked-by: Mark Michelson > > Thanks. I applied this patch to the main branch and branch-21.12. Thanks! > > Do let me know if it needs to be backported further down. It's not needed, older b