Re: [ovs-dev] [PATCH net 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure

2022-02-12 Thread Paul Blakey via dev
On Thu, 10 Feb 2022, Jakub Kicinski wrote: > On Thu, 10 Feb 2022 10:53:24 +0200 Paul Blakey wrote: > > > The calls seem a little heavy for single byte replacements. > > > Can you instead add a helper based on csum_replace4() maybe? > > > > > > BTW doesn't pedit have the same problem? > > > >

Re: [ovs-dev] [PATCH v2] ofproto-dpif: fix packet_execute_prepare

2022-02-12 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [PATCH v2] ofproto-dpif: fix packet_execute_prepare

2022-02-12 Thread Peng He
In the commit 1df7f7aac8c976690167261fec9a50d832ef9e7e, the packet metadata's in_port has been changed from ofp port into odp port, however, the odp->flow->in_port is still ofp_port. This patch changes the odp->flow->in_port into odp_port. Fixes: 1df7f7aac8 ("ofproto-dpif: Restore packet metadata

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: fix packet_execute_prepare

2022-02-12 Thread Peng He
Ilya Maximets 于2022年2月12日周六 05:34写道: > On 1/28/22 17:14, Aaron Conole wrote: > > From: Peng He > > > > In the commit 1df7f7aac8c976690167261fec9a50d832ef9e7e, the packet > > metadata's in_port has been changed from ofp port into odp port, > > however, the odp->flow->in_port is still ofp_port.

Re: [ovs-dev] [ovs-dev v6] ofproto: add refcount to ofproto to fix ofproto use-after-free

2022-02-12 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [ovs-dev v6] ofproto: add refcount to ofproto to fix ofproto use-after-free

2022-02-12 Thread Peng He
From hepeng: https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473 also from guohongzhi : http://patchwork.ozlabs.org/project/openvswitch/patch/20200306130555.19884-1-guohongz...@huawei.com/ also from a discussion about the mixing use of

Re: [ovs-dev] [ovs-dev v5] ofproto: add refcount to ofproto to fix ofproto use-after-free

2022-02-12 Thread Peng He
Great review! Gaëtan Rivet 于2022年2月10日周四 22:01写道: > On Sat, Feb 5, 2022, at 06:26, Peng He wrote: > > From hepeng: > > > https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473 > > > > also from guohongzhi : > > >

Re: [ovs-dev] [External] Re: [PATCH] dpif-netdev: add an option to assign pmd rxq to all numas

2022-02-12 Thread Wan Junjie
Hi Kevin, Thanks for your reply. Sorry about forgetting the cc, repost it. On Sat, Feb 12, 2022 at 1:09 AM Kevin Traynor wrote: > > Hi Wan Junjie, > > On 27/01/2022 11:43, Wan Junjie wrote: > > When assign a rxq to a pmd, the rxq will only be assigned to > > the numa it belongs. An exception