On 21 Feb 2022, at 12:29, Eelco Chaudron wrote:
> On 17 Feb 2022, at 14:10, Ilya Maximets wrote:
>
>> On 1/31/22 11:54, Eelco Chaudron wrote:
>>> Make sure to only update packet and byte counters when valid,
>>> or else this could lead to "temporarily/occasionally"
>>> out-of-sync flow counters.
On 21 Feb 2022, at 15:53, Eelco Chaudron wrote:
> On 21 Feb 2022, at 14:33, Marcelo Leitner wrote:
Don’t think this is true, it will only print if +trk and any other flags
are set.
Guess this is where the miscommunication is.>
> The message also seems to be a bit aggressiv
Hi Amber,
Thanks for reviewing and Acking!
> -Original Message-
> From: Amber, Kumar
> Sent: Tuesday 22 February 2022 06:15
> To: ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Ferriter, Cian
> Subject: RE: [PATCH] dpif-netdev: Simplify atomic function pointer stores
>
> Hi Cian,
>
+Cc Wenxu, Paul and netdev
On Tue, Feb 22, 2022 at 10:33:44AM +0100, Eelco Chaudron wrote:
>
>
> On 21 Feb 2022, at 15:53, Eelco Chaudron wrote:
>
> > On 21 Feb 2022, at 14:33, Marcelo Leitner wrote:
>
>
>
> Don’t think this is true, it will only print if +trk and any other flags
> are
On 2/21/22 15:16, Ilya Maximets wrote:
> The purpose of reconnect_deadline__() function is twofold:
>
> 1. Its result is used to tell if the state has to be changed right now
>in reconnect_run().
> 2. Its result also used to determine when the process need to wake up
>and call reconnect_ru
From: Yuan-96 <294754...@qq.com>
While the CentOS 8 requests an IPv4 DNS record, the response will be slow
without a correct IPv6 DNS record on server. It will send a DNS request(type
) message first but ovn controller will not reply. And the DNS request(type
A) message will be sent until D
Bleep bloop. Greetings 294754599--- via dev, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I
./include -I ./
From: ro...@bytheb.org
Test-Label: github-robot: Build and Test
Test-Status: fail
http://patchwork.ozlabs.org/api/patches/1595962/
_github build: failed_
Build URL: https://github.com/ovsrobot/ovn/actions/runs/1881582768
Build Logs:
---Summary of failed steps--
From: ro...@bytheb.org
Test-Label: github-robot: ovn-kubernetes
Test-Status: fail
http://patchwork.ozlabs.org/api/patches/1595962/
_github build: failed_
Build URL: https://github.com/ovsrobot/ovn/actions/runs/1881582770
Build Logs:
---Summary of failed steps--
On 1/28/22 19:51, Ilya Maximets wrote:
> If the joining server re-connects while catching up (e.g. if it crashed
> or connection got closed due to inactivity), the data we sent might be
> lost, so the server will never reply to append request or a snapshot
> installation request. At the same time,
This series fixes a bunch of TC offload-related issues found when
running the kernel data path self-test (make check-kernel) forcing
TC to be enabled. To do this manually I applied the following diff:
https://github.com/chaudron/ovs/commit/d7ff1060f371e2cbd4b2e8dee222a9eed55073c8
These changes
This patch adds more detailed debug logs on tc verify failures to
ease debugging the actual cause after the fact.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/tc.c | 79 +-
1 file changed, 73 insertions(+), 6 deletions(-
This change will set the correct VID and PCP masks, as well as the
ethernet type mask.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
v2: Fixed sparse "expected restricted ovs_be16" warning
lib/tc.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/tc.
The parse_key_and_mask_to_match() is a function to translate
a netlink formatted key/mask to match structure. And should
not consider any configuration setting when translating.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/odp-util.c | 41 -
Verify that the returned ifindex by netdev_get_ifindex() is valid.
This might not be the case in the ERSPAN port scenario, which can
not be offloaded.
Signed-off-by: Eelco Chaudron
---
v3:
- Fixed netdev reference issue on failure
- Added netdev_flow_api_equals() check
lib/netdev-offload-tc
Regardless of the traffic type, if requested, the conntrack information
should be included to keep the datapath and tc rules in sync.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/tc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/tc.c b/lib/tc
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/tc.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/lib/tc.c b/lib/tc.c
index 8cfd5aa5a..ebec097dc 100644
--- a/lib/tc.c
+++ b/lib/tc.c
@@ -939,24 +939,21 @@ nl_parse_flower_ip(struct nlattr **attrs, s
When programming NAT rules OVS only sets the minimum value for a
single IP/port value. However, responses from flower will always
return min == max for single IP/port values. This is causing the
verification to fail as the request is different than the response.
To avoid this, we will update the re
This patch checks for none offloadable ct_state match flag combinations.
If they exist force the +trk flag down to TC Flower
Signed-off-by: Eelco Chaudron
---
v3:
- Instead of warning about an invalid flag combination fix it.
lib/netdev-offload-tc.c |6 ++
1 file changed, 6 insertions(
When the same flow is programmed in the kernel and tc, they
look different due to the way they are translated. They take
the userspace approach by always including the packet type
attribute. To make the outputs the same, show the ethernet
header when the packet type is wildcarded, and not printed.
On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote:
>
> On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson wrote:
> >
> > Hi Han,
> >
> > I had a look through this series and to be honest, I probably don't have
> > the expertise to critique every line of code. However, the test cases
> > you added, plus
On Sat, Feb 19, 2022 at 1:38 AM Han Zhou wrote:
>
> On Fri, Feb 18, 2022 at 10:38 AM Vladislav Odintsov
> wrote:
> >
> > When transport node has multiple interfaces (vlans) and
> > ovn-encap-ip on different hosts need to be configured
> > from different VLANs source IP for encapsulated packet
> >
On 22 Feb 2022, at 12:36, Marcelo Leitner wrote:
> +Cc Wenxu, Paul and netdev
>
> On Tue, Feb 22, 2022 at 10:33:44AM +0100, Eelco Chaudron wrote:
>>
>>
>> On 21 Feb 2022, at 15:53, Eelco Chaudron wrote:
>>
>>> On 21 Feb 2022, at 14:33, Marcelo Leitner wrote:
>>
>>
>>
>> Don’t think this is
On 2/22/22 13:05, Dumitru Ceara wrote:
> On 2/21/22 15:16, Ilya Maximets wrote:
>> The purpose of reconnect_deadline__() function is twofold:
>>
>> 1. Its result is used to tell if the state has to be changed right now
>>in reconnect_run().
>> 2. Its result also used to determine when the proce
Thanks Numan.
Regards,
Vladislav Odintsov
> On 22 Feb 2022, at 18:41, Numan Siddique wrote:
>
> On Sat, Feb 19, 2022 at 1:38 AM Han Zhou wrote:
>>
>> On Fri, Feb 18, 2022 at 10:38 AM Vladislav Odintsov
>> wrote:
>>>
>>> When transport node has multiple interfaces (vlans) and
>>> ovn-encap-i
On 2/22/22 16:45, Ilya Maximets wrote:
> On 2/22/22 13:05, Dumitru Ceara wrote:
>> On 2/21/22 15:16, Ilya Maximets wrote:
>>> The purpose of reconnect_deadline__() function is twofold:
>>>
>>> 1. Its result is used to tell if the state has to be changed right now
>>>in reconnect_run().
>>> 2. I
On Tue, Feb 22, 2022 at 04:44:30PM +0100, Eelco Chaudron wrote:
>
>
> On 22 Feb 2022, at 12:36, Marcelo Leitner wrote:
>
> > +Cc Wenxu, Paul and netdev
> >
> > On Tue, Feb 22, 2022 at 10:33:44AM +0100, Eelco Chaudron wrote:
> >>
> >>
> >> On 21 Feb 2022, at 15:53, Eelco Chaudron wrote:
> >>
> >>> O
You'll need to rebase, the patch which made everything force inlined
got merged.
On Sun, 20 Feb 2022 15:21:14 +0200 Paul Blakey wrote:
> +static inline __wsum
> +csum_block_replace(__wsum csum, __wsum old, __wsum new, int offset)
> +{
> + return csum_block_add(csum_block_sub(csum, old, offset)
Userspace conntrack doesn't support conntrack stats for packets and
bytes. This patch implements it.
Signed-off-by: Yifeng Sun
---
lib/conntrack-private.h | 9 +
lib/conntrack.c | 28
tests/system-common-macros.at | 2 +-
tests/system-tr
Hi Selva,
Thanks for the patch. Please see my comments below.
On Tue, Feb 8, 2022 at 9:18 AM Selvaraj Palaniyappan
wrote:
>
> Hello Mark,
>
> Thanks for reviewing the diff. Please find the background info related to
this patch.
>
> "The ML2 Plugin can add some useful info to NB database of Logic
On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara wrote:
>
> On 2/11/22 00:54, Numan Siddique wrote:
> > On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara
wrote:
> >>
> >> We still need to try to ovsdb_idl_loop_commit_and_wait() on instances
> >> that are in standby mode. That's because they need to t
On 2022-02-22 5:26 PM, Eelco Chaudron wrote:
This patch checks for none offloadable ct_state match flag combinations.
If they exist force the +trk flag down to TC Flower
Signed-off-by: Eelco Chaudron
---
v3:
- Instead of warning about an invalid flag combination fix it.
lib/netdev-offlo
On 2022-02-22 5:23 PM, Eelco Chaudron wrote:
Verify that the returned ifindex by netdev_get_ifindex() is valid.
This might not be the case in the ERSPAN port scenario, which can
not be offloaded.
Signed-off-by: Eelco Chaudron
---
v3:
- Fixed netdev reference issue on failure
- Added ne
33 matches
Mail list logo
