Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to stable branch-2.17.

2022-02-24 Thread Han Zhou
On Thu, Feb 24, 2022 at 3:07 PM wrote: > > From: Numan Siddique > > The following commits are required for OVN: > > 498cedc48 reconnect: Fix broken inactivity probe if there is no other reason to wake up. > 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. > 88705f1ba ovs

Re: [ovs-dev] [PATCH ovn] Documentation: Add submodule documentation

2022-02-24 Thread Han Zhou
On Thu, Feb 24, 2022 at 9:31 AM Mark Michelson wrote: > > This provides some missing documentation about the OVS submodule. > > It also proposes a currently-unimplemented policy wherein we attempt > to base OVN releases on a stable OVS release branch instead of > arbitrary commits. > Thanks Mark.

Re: [ovs-dev] [PATCH ovn v4] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Han Zhou
On Thu, Feb 24, 2022 at 10:10 AM Mark Michelson wrote: > > It can be desirable for replies to stateful ACLs to be logged. And in > some cases, it can actually be a bit confusing why they aren't logged. > Consider a situation where a port group called "port_group" exists and > logical switch ports

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-22.03.0

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:00 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 22.03.0

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:01 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH v2 ovn] northd: introduce nat-only-router for nat-addresses option

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:23 PM Lorenzo Bianconi wrote: > > The CMS can configure the same lbs on multiple gw routers so the > same IPs/mac bindings will be adverised by multiple routers > through GARPs. > In order to fix the issue, introduce nat-only-router flag for > nat-addresses option in orde

[ovs-dev] [PATCH ovn] ovs: Bump submodule to stable branch-2.17.

2022-02-24 Thread numans
From: Numan Siddique The following commits are required for OVN: 498cedc48 reconnect: Fix broken inactivity probe if there is no other reason to wake up. 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index

Re: [ovs-dev] [PATCH ovn 0/2] ci: ovn-kubernetes: Make tests run again.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 11:06 AM Dumitru Ceara wrote: > > This series addresses two independent issues: > - ovn-kubernetes needs to be built against the NB/SB schema defined in > the OVN tree we're running the test for. > - ovn-kubernetes bumped go and k8s versions and we should do the same >

[ovs-dev] [PATCH v2 ovn] northd: introduce nat-only-router for nat-addresses option

2022-02-24 Thread Lorenzo Bianconi
The CMS can configure the same lbs on multiple gw routers so the same IPs/mac bindings will be adverised by multiple routers through GARPs. In order to fix the issue, introduce nat-only-router flag for nat-addresses option in order to advertise in GARPs packets all SNAT/DNAT configured in the conne

Re: [ovs-dev] [PATCH ovn v4] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 2:00 PM Frode Nordahl wrote: > > On Thu, Feb 24, 2022 at 7:10 PM Mark Michelson wrote: > > > > It can be desirable for replies to stateful ACLs to be logged. And in > > some cases, it can actually be a bit confusing why they aren't logged. > > Consider a situation where a

[ovs-dev] [PATCH ovn 1/2] Prepare for 22.03.0

2022-02-24 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index a309fe8df..f5fbb22ac 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -Post v21.12.0 -- +OVN v2

[ovs-dev] [PATCH ovn 2/2] Prepare for post-22.03.0

2022-02-24 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f5fbb22ac..d886c1ef7 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +Post v22.03.0 +- + OVN

Re: [ovs-dev] [PATCH v4 ovn 2/2] controller: reconfigure ovs meters for ovn meters updates

2022-02-24 Thread Mark Michelson
Hi Lorenzo, Looks good to me! Thanks a bunch for this. Acked-by: Mark Michelson On 2/24/22 05:38, Lorenzo Bianconi wrote: At the moment ovs meters are reconfigured by ovn just when a meter is allocated or removed while updates for an already allocated meter are ignored. This issue can be easi

Re: [ovs-dev] [PATCH v4 ovn 1/2] lib: limit table_id space for meters

2022-02-24 Thread Mark Michelson
Hi Lorenzo, I think a better approach to this would be to modify ovn_extend_table_id_init() to take two additional parameters: one parameter would tell the size of the extend table bitmap. The other would be an offset to add to IDs produced by the bitmap. This has a few advantages over the c

Re: [ovs-dev] [PATCH] reconnect: Fix broken inactivity probe if there is no other reason to wake up.

2022-02-24 Thread Ilya Maximets
On 2/22/22 17:00, Dumitru Ceara wrote: > On 2/22/22 16:45, Ilya Maximets wrote: >> On 2/22/22 13:05, Dumitru Ceara wrote: >>> On 2/21/22 15:16, Ilya Maximets wrote: The purpose of reconnect_deadline__() function is twofold: 1. Its result is used to tell if the state has to be changed

[ovs-dev] [PATCH] ovsdb-cluster.at: Avoid test failures due to different hashing.

2022-02-24 Thread Ilya Maximets
Depending on compiler flags and CPU architecture different hash function are used. That impacts the order of tables and columns in database representation making ovsdb report different columns in the warning about ephemeral-to-persistent conversion. Stripping out changing parts of the message to

Re: [ovs-dev] [PATCH ovn v4] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Frode Nordahl
On Thu, Feb 24, 2022 at 7:10 PM Mark Michelson wrote: > > It can be desirable for replies to stateful ACLs to be logged. And in > some cases, it can actually be a bit confusing why they aren't logged. > Consider a situation where a port group called "port_group" exists and > logical switch ports s

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Mark Michelson
On 2/24/22 11:29, Numan Siddique wrote: On Thu, Feb 24, 2022 at 11:17 AM Mark Michelson wrote: On 2/23/22 19:39, Numan Siddique wrote: On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl wrote: Hello Mark, This overall looks great, it also looks like you addressed Numan's comments from the prev

[ovs-dev] [PATCH ovn v4] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Mark Michelson
It can be desirable for replies to stateful ACLs to be logged. And in some cases, it can actually be a bit confusing why they aren't logged. Consider a situation where a port group called "port_group" exists and logical switch ports swp1 and swp2 belong to it. We create the following ACL, where log

Re: [ovs-dev] [PATCH net v5 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure

2022-02-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 23 Feb 2022 18:34:16 +0200 you wrote: > Ipv6 ttl, label and tos fields are modified without first > pulling/pushing the ipv6 header, which would have updated > the hw csum (if available). This might cause csum va

Re: [ovs-dev] [PATCH ovn] Documentation: Add submodule documentation

2022-02-24 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: New doc ovs_submodule.rst not listed in Documentation/internals/index.rst WARNING:

[ovs-dev] [PATCH ovn] Documentation: Add submodule documentation

2022-02-24 Thread Mark Michelson
This provides some missing documentation about the OVS submodule. It also proposes a currently-unimplemented policy wherein we attempt to base OVN releases on a stable OVS release branch instead of arbitrary commits. Signed-off-by: Mark Michelson --- Documentation/internals/ovs_submodule.rst |

Re: [ovs-dev] [ovs-dev v7] ofproto: add refcount to ofproto to fix ofproto use-after-free

2022-02-24 Thread Alin-Gabriel Serdean
Tested-by: Alin-Gabriel Serdean Acked-by: Alin-Gabriel Serdean -Original Message- From: dev On Behalf Of Peng He Sent: Saturday, February 19, 2022 5:26 AM To: d...@openvswitch.org Cc: i.maxim...@ovn.org; guohongzhi Subject: [ovs-dev] [ovs-dev v7] ofproto: add refcount to ofproto to fix

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 11:17 AM Mark Michelson wrote: > > On 2/23/22 19:39, Numan Siddique wrote: > > On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl > > wrote: > >> > >> Hello Mark, > >> > >> This overall looks great, it also looks like you addressed Numan's > >> comments from the previous iterat

Re: [ovs-dev] [RFC/PATCH] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-24 Thread Pieter Jansen van Vuuren
On 24/02/2022 14:06, Eelco Chaudron wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > On 24 Feb 2022, at 10:35, pieter.jansen-van-vuu...@xilinx.com wrot

Re: [ovs-dev] [PATCH ovn 1/2] ci: ovn-kubernetes: Generate DB model based on current OVN tree.

2022-02-24 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #35 FILE: .ci/ovn-kubernetes/Doc

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Mark Michelson
On 2/23/22 19:39, Numan Siddique wrote: On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl wrote: Hello Mark, This overall looks great, it also looks like you addressed Numan's comments from the previous iteration. I have added a nit in-line to save you from a conversation with 0-day / checkpatch

Re: [ovs-dev] [PATCH ovn] northd: introduce nat-only-router for nat-addresses option

2022-02-24 Thread Numan Siddique
On Thu, Feb 17, 2022 at 12:34 PM Lorenzo Bianconi wrote: > > Introduce nat-only-router flag for nat-addresses option in order to > advertise in GARPs packets all SNAT/DNAT configured in the connected > logical router but skip all configured load_balancers. > > Reported-at: https://bugzilla.redhat.

[ovs-dev] [PATCH ovn 2/2] ci: ovn-kubernetes: Bump kubernetes version to v1.23.3.

2022-02-24 Thread Dumitru Ceara
Match the kubernetes (and go) versions from upstream ovn-kubernetes, similar to: https://github.com/ovn-org/ovn-kubernetes/commit/cba7c5b4c6fc396ba3ec5ca4ba4f898b5d3e346d Suggested-by: Dan Williams Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-kubernetes.yml |4 ++-- 1 file change

[ovs-dev] [PATCH ovn 1/2] ci: ovn-kubernetes: Generate DB model based on current OVN tree.

2022-02-24 Thread Dumitru Ceara
Make sure ovn-kubernetes is compiled against the NB/SB schema from the OVN source tree. By default upstream ovn-kubernetes uses the schema from the latest released OVN version. But that doesn't work fine if in the meantime there were changes to the schema that are not yet part of a stable release

[ovs-dev] [PATCH ovn 0/2] ci: ovn-kubernetes: Make tests run again.

2022-02-24 Thread Dumitru Ceara
This series addresses two independent issues: - ovn-kubernetes needs to be built against the NB/SB schema defined in the OVN tree we're running the test for. - ovn-kubernetes bumped go and k8s versions and we should do the same because we use ovn-kubernetes master branch for testing. For the l

Re: [ovs-dev] [PATCH v1] system-dpdk.at: Add ignore warning for context switches in CI.

2022-02-24 Thread Phelan, Michael
> -Original Message- > From: Amber, Kumar > Sent: Thursday 24 February 2022 15:15 > To: ovs-dev@openvswitch.org > Cc: Phelan, Michael ; i.maxim...@ovn.org; > Stokes, Ian ; echau...@redhat.com; Van Haaren, > Harry ; Amber, Kumar > > Subject: [PATCH v1] system-dpdk.at: Add ignore warning fo

[ovs-dev] [PATCH v1] system-dpdk.at: Add ignore warning for context switches in CI.

2022-02-24 Thread Kumar Amber
Many warnings are seen from ovs on rerun due to context switching in the CI setup. This patch ingnores warnings and enables MFEX fuzzy to run on the CI. Signed-off-by: Kumar Amber --- tests/system-dpdk.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/system-dpdk.at b/tests/system

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

2022-02-24 Thread Eelco Chaudron
On 23 Feb 2022, at 12:35, Roi Dayan wrote: > On 2022-02-23 11:31 AM, Eelco Chaudron wrote: >> >> >> On 23 Feb 2022, at 8:09, Roi Dayan wrote: >> >>> On 2022-02-22 5:26 PM, Eelco Chaudron wrote: This patch checks for none offloadable ct_state match flag combinations. If they exist force

Re: [ovs-dev] [External] Re: [PATCH] dpif-netdev: add an option to assign pmd rxq to all numas

2022-02-24 Thread Kevin Traynor
Hi Jan, On 17/02/2022 14:21, Jan Scheurich wrote: Hi Kevin, We have done extensive benchmarking and found that we get better overall PMD load balance and resulting OVS performance when we do not statically pin any rx queues and instead let the auto-load-balancing find the optimal distribution

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

2022-02-24 Thread Eelco Chaudron
On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote: > On Tue, Feb 22, 2022 at 04:26:10PM +0100, Eelco Chaudron wrote: >> This patch checks for none offloadable ct_state match flag combinations. >> If they exist force the +trk flag down to TC Flower >> >> Signed-off-by: Eelco Chaudron >> --

Re: [ovs-dev] [RFC/PATCH] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-24 Thread Eelco Chaudron
On 24 Feb 2022, at 10:35, pieter.jansen-van-vuu...@xilinx.com wrote: > From: Pieter Jansen van Vuuren > > Previously when making use of the tc datapath to achieve decrement ttl, we > would > install a filter that matches on the ttl/hoplimit field and use a pedit set > action > to set the ttl/

Re: [ovs-dev] [PATCH 3/4] acinclude: Add seperate check for AVX512VBMI ISA.

2022-02-24 Thread Van Haaren, Harry
> -Original Message- > From: Ferriter, Cian > Sent: Thursday, February 24, 2022 11:57 AM > To: ovs-dev@openvswitch.org > Cc: Ferriter, Cian ; Van Haaren, Harry > > Subject: [PATCH 3/4] acinclude: Add seperate check for AVX512VBMI ISA. > > Only use the "avx512vbmi" compiler target when it

Re: [ovs-dev] [PATCH] ofproto: Use xlate map for uuid lookups

2022-02-24 Thread Alin-Gabriel Serdean
I enabled ASan on MSVC (https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-wi th-msvc/) and this patch alleviates the issues found by the CI and my local testing. Tested-by: Alin-Gabriel Serdean Acked-by: Alin-Gabriel Serdean -Original Message- From: dev On Behalf

[ovs-dev] [PATCH 4/4] acinclude: Add seperate check for AVX512VPOPCNTDQ ISA.

2022-02-24 Thread Cian Ferriter
Checking for AVX512VPOPCNTDQ separately will allow the compiler to generate other AVX512 ISA code where supported. This is relevant for GCC where AVX512VPOPCNTDQ support is added in GCC 7. In GCC 5 and 6, most AVX512 code can be generated, just without VPOPCNTDQ support. Signed-off-by: Cian Ferrit

[ovs-dev] [PATCH 2/4] acinclude: Add seperate check for AVX512BW and AVX512DQ ISA.

2022-02-24 Thread Cian Ferriter
Checking for AVX512BW and AVX512DQ separately will allow the compiler to generate some AVX512 code where it is supported. For example, in GCC 4.9 where there is just support for AVX512F, this patch will allow the AVX512 DPIF to be built. This partial support change will be effective when the -mavx

[ovs-dev] [PATCH 3/4] acinclude: Add seperate check for AVX512VBMI ISA.

2022-02-24 Thread Cian Ferriter
Only use the "avx512vbmi" compiler target when it is actually supported by the compiler. Signed-off-by: Cian Ferriter --- acinclude.m4 | 14 ++ configure.ac | 1 + lib/dpif-netdev-extract-avx512.c | 10 +- 3 files changed, 24 insertion

[ovs-dev] [PATCH 0/4] Build some AVX512 code on older compilers.

2022-02-24 Thread Cian Ferriter
Support for more AVX512 ISA was added in various compiler releases. For example in GCC, increasing AVX512 ISA support was added in GCC 4.9, 5 and then 7. Depending on the GCC version, none, some or all of the AVX512 code in OVS can be built. This patchset adds support for the "some" case, where cur

[ovs-dev] [PATCH 1/4] dpif-netdev-extract: Remove ISA compiler target for mfex.

2022-02-24 Thread Cian Ferriter
There are no instructions from this ISA used. The target is not needed. Signed-off-by: Cian Ferriter --- lib/dpif-netdev-extract-avx512.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c index c1c1fefb6..f36a6eab0 100644 ---

[ovs-dev] [PATCH v4 ovn 2/2] controller: reconfigure ovs meters for ovn meters updates

2022-02-24 Thread Lorenzo Bianconi
At the moment ovs meters are reconfigured by ovn just when a meter is allocated or removed while updates for an already allocated meter are ignored. This issue can be easily verified with the following reproducer: $ovn-nbctl meter-add meter0 drop 10 pktps $ovn-nbctl --log --meter=meter0 acl-add sw

[ovs-dev] [PATCH v4 ovn 1/2] lib: limit table_id space for meters

2022-02-24 Thread Lorenzo Bianconi
This is a preliminary patch to move metering management in IP engine. Signed-off-by: Lorenzo Bianconi --- controller/lflow.c | 2 +- lib/actions.c | 10 +- lib/extend-table.c | 6 -- lib/extend-table.h | 2 +- tests/ovn-controller.at | 6 +++--- tests/ovn

[ovs-dev] [PATCH v4 ovn 0/2] reconfigure ovs meters for ovn meters updates

2022-02-24 Thread Lorenzo Bianconi
Changes since v3: - move full meter management in the IP engine Changes since v2: - move meter ip into lflow ip - add new test in ovn-performance.at - manage metering ip full-recompute Changes since v1: - add IP refactor to the series - rebase on top of ovn master Lorenzo Bianconi (2): lib: li

[ovs-dev] [RFC/PATCH] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-24 Thread pieter.jansen-van-vuuren
From: Pieter Jansen van Vuuren Previously when making use of the tc datapath to achieve decrement ttl, we would install a filter that matches on the ttl/hoplimit field and use a pedit set action to set the ttl/hoplimit to one less than the match value. This results in a filter for each unique t

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Don't log transaction failures on standby instances.

2022-02-24 Thread Dumitru Ceara
On 2/23/22 20:06, Han Zhou wrote: > > Thanks Dumitru. Applied to main and branch-21.12. > > Han > Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Bump go version to 1.17.

2022-02-24 Thread Dumitru Ceara
On 2/23/22 23:53, Numan Siddique wrote: > On Wed, Feb 23, 2022 at 8:32 AM Dumitru Ceara wrote: >> >> Building the ovn-kubernetes images for testing was failing lately due >> to https://github.com/kubernetes/kubernetes/issues/10, so bump the >> go version to 1.17 where this is fixed. >> >> Also