On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> In the event of no pmd cores available on the local numa for
> an rxq to be assigned to, a pmd core from a non-local numa is
> selected.
>
> If there are more than one non-local numas with pmd cores they
> are RR through and checked if they
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> Rename pmd_reblance_dry_run_needed() to
> pmd_rebalance_dry_run_needed().
>
> Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
On Mon, Feb 28, 2022 at 11:23:49AM +0200, Paul Blakey wrote:
> After cited commit optimizted hw insertion, flow table entries are
> populated with ifindex information which was intended to only be used
> for HW offload. This tuple ifindex is hashed in the flow table key, so
> it must be filled for
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#29 FILE: lib/lacp.c:391:
On Tue, Mar 1, 2022 at 10:53 AM Andreas Karis wrote:
>
> Both LibreSwan and OpenSwan allow administrators to unconditionally
> force enable NAT-T for ESP. This may help to surmount restrictive
> firewalls in scenarios where IP protocol number 50 is blocked, but where
> NAT autodetection fails.
Add additional logging for debug and info level with a focus on code
related to bond members coming up, go down, and changing.
Several existing log messages were modified to handle sub 1kB log
messages with more grace. Instead of reporting 0kB of traffic load
shifting from one member to another,
Thank you, I posted a new version.
On Fri, Feb 25, 2022 at 10:17 PM Mike Pattrick wrote:
> On Thu, 2022-01-20 at 16:33 +0100, Andreas Karis wrote:
> > Both LibreSwan and OpenSwan allow administrators to unconditionally
> > force enable NAT-T for ESP. This may help to surmount restrictive
> >
PMD auto load balance currently only operates when the polling pmd core
will not change numa after reassignment. Add a unit test for this.
Signed-off-by: Kevin Traynor
---
tests/alb.at | 46 ++
1 file changed, 46 insertions(+)
diff --git
In the event of no pmd cores available on the local numa for
an rxq to be assigned to, a pmd core from a non-local numa is
selected.
If there are more than one non-local numas with pmd cores they
are RR through and checked if they have non-isolated pmds.
When successfully finding a non-local
There are currently some checks for cross-numa polling cases to
ensure that they won't effect the accuracy of the PMD ALB.
If an rxq is pinned to a pmd core by the user it will not be
reassigned by OVS, so even if it is non-local numa polled it
will not impact PMD ALB accuracy.
To establish
Some fixes found in the area of cross-numa polling
during recent code inspection and testing.
GHA: https://github.com/kevintraynor/ovs/actions/runs/1917535875
Kevin Traynor (4):
dpif-netdev: Fix typo in function name.
dpif-netdev: Fix non-local numa selection.
dpif-netdev: Fix PMD auto
Rename pmd_reblance_dry_run_needed() to
pmd_rebalance_dry_run_needed().
Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.")
Signed-off-by: Kevin Traynor
---
lib/dpif-netdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c
On Tue, Mar 1, 2022 at 7:54 AM Dumitru Ceara wrote:
>
> On 3/1/22 13:44, Adrian Moreno wrote:
> >
> >
> > On 3/1/22 12:59, Dumitru Ceara wrote:
> >> On 3/1/22 12:54, Adrian Moreno wrote:
> >>>
> >>>
> >>> On 3/1/22 10:35, Dumitru Ceara wrote:
> On 3/1/22 10:07, Adrian Moreno wrote:
> >
>
Both LibreSwan and OpenSwan allow administrators to unconditionally
force enable NAT-T for ESP. This may help to surmount restrictive
firewalls in scenarios where IP protocol number 50 is blocked, but where
NAT autodetection fails. Add a switch --force-encapsulation to expose
this feature to users
AVX512 DPIF must be active in order for the MFEX AutoValidator to be executed.
If the DPIF-AVX512 is not available, the unit test is skipped, as the
scalar DPIF does not use the MFEX function-pointer based optimizations.
Fixes: 50be6715c0 ("test/sytem-dpdk: Add unit test for mfex autovalidator")
On 3/1/22 13:44, Adrian Moreno wrote:
>
>
> On 3/1/22 12:59, Dumitru Ceara wrote:
>> On 3/1/22 12:54, Adrian Moreno wrote:
>>>
>>>
>>> On 3/1/22 10:35, Dumitru Ceara wrote:
On 3/1/22 10:07, Adrian Moreno wrote:
>
>
> On 2/25/22 18:14, Dumitru Ceara wrote:
>> For example is
On 3/1/22 12:59, Dumitru Ceara wrote:
On 3/1/22 12:54, Adrian Moreno wrote:
On 3/1/22 10:35, Dumitru Ceara wrote:
On 3/1/22 10:07, Adrian Moreno wrote:
On 2/25/22 18:14, Dumitru Ceara wrote:
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning
On 3/1/22 12:54, Adrian Moreno wrote:
>
>
> On 3/1/22 10:35, Dumitru Ceara wrote:
>> On 3/1/22 10:07, Adrian Moreno wrote:
>>>
>>>
>>> On 2/25/22 18:14, Dumitru Ceara wrote:
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning from
On 3/1/22 10:35, Dumitru Ceara wrote:
On 3/1/22 10:07, Adrian Moreno wrote:
On 2/25/22 18:14, Dumitru Ceara wrote:
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning from UndefinedBehaviorSanitizer:
lib/meta-flow.c:3210:9: runtime error:
On 3/1/22 09:30, Adrian Moreno wrote:
> Hi Dumitru,
>
Hi Adrian,
Thanks for the review!
> On 2/25/22 18:14, Dumitru Ceara wrote:
>> Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
>> replies to statistics reply messages which have a header of 12 bytes
>> and no additional
On 3/1/22 10:07, Adrian Moreno wrote:
>
>
> On 2/25/22 18:14, Dumitru Ceara wrote:
>> For example is parsing the OVN "eth.dst[40] = 1;" action, which
>> triggered the following warning from UndefinedBehaviorSanitizer:
>>
>> lib/meta-flow.c:3210:9: runtime error: member access within
>>
On 01/03/2022 08:33, Eelco Chaudron wrote:
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>
>
> On 28 Feb 2022, at 19:01, Pieter Jansen van Vuuren wrote:
>
>>
On 2/25/22 18:14, Dumitru Ceara wrote:
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning from UndefinedBehaviorSanitizer:
lib/meta-flow.c:3210:9: runtime error: member access within misaligned
address 0x00de4e36 for type 'const union
On 28 Feb 2022, at 19:01, Pieter Jansen van Vuuren wrote:
> On 25/02/2022 13:20, Eelco Chaudron wrote:
>> CAUTION: This message has originated from an External Source. Please use
>> proper judgment and caution when opening attachments, clicking links, or
>> responding to this email.
>>
>>
>>
Hi Dumitru,
On 2/25/22 18:14, Dumitru Ceara wrote:
Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
replies to statistics reply messages which have a header of 12 bytes
and no additional padding.
Also, buggy controllers might incorrectly encode actions.
When decoding
25 matches
Mail list logo
