[ovs-dev] [PATCH v6 6/6] tests/mfex: Improve pcap script for complex testing traffic

2022-03-14 Thread Kumar Amber
The mfex pcap generation script is improved for varied length traffic and also removes the hard coded mfex_pcap instead uses the script to generate complex traffic for testing. Signed-off-by: Kumar Amber --- tests/automake.mk | 1 - tests/mfex_fuzzy.py | 57

[ovs-dev] [PATCH v6 5/6] dpif-netdev/mfex: Avoid hashing when opt mfex called.

2022-03-14 Thread Kumar Amber
This patch avoids calculating the software hash of the packet again if the optimized miniflow-extract hit and has already calculated the packet hash. In cases of scalar miniflow extract, the normal hashing calculation is performed. Signed-off-by: Kumar Amber --- lib/dpif-netdev-avx512.c | 6

[ovs-dev] [PATCH v6 4/6] dpif-netdev/mfex: Add packet hash check to autovalidator.

2022-03-14 Thread Kumar Amber
This patch adds the per profile AVX512 opt hashing to autovalidator for validating the hash values against the scalar hash. Signed-off-by: Kumar Amber --- lib/dpif-netdev-private-extract.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/dpif-netdev-private-extract.c

[ovs-dev] [PATCH v6 3/6] dpif-netdev/mfex: Add ipv6 profile based hashing.

2022-03-14 Thread Kumar Amber
This commit adds IPv6 profile specific hashing which uses fixed offsets into the packet to improve hashing perforamnce. Hash value is autovalidated by MFEX autovalidator. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v4: - Use pre-defined

[ovs-dev] [PATCH v6 2/6] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-03-14 Thread Kumar Amber
This commit adds IPv4 profile specific hashing which uses fixed offsets into the packet to improve hashing perforamnce. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v4: - Use pre-defined hash length values. v3: - Fix check-patch sign-offs.

[ovs-dev] [PATCH v6 1/6] dpif-netdev/mfex: Add AVX512 ipv6 traffic profiles

2022-03-14 Thread Kumar Amber
Add AVX512 Ipv6 optimized profile for vlan/IPv6/UDP and vlan/IPv6/TCP, IPv6/UDP and IPv6/TCP. MFEX autovalidaton test-case already has the IPv6 support for validating against the scalar mfex. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v5:

[ovs-dev] [PATCH v6 0/6] MFEX Optimizations IPv6 + Hashing Optimizations

2022-03-14 Thread Kumar Amber
The patchset introuduces IPv6 optimized MFEX profiles with AVX512 which can deliver upto 20% to 30% gain in performance over the existing scalar data-path. Hashing Optimization are also included which can further improve performance by approximately 10%. --- v6: - Reorder Patches in the

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for NAT with multiple DGP

2022-03-14 Thread Mark Michelson
Hi Abhiram, I had a look through the code and I'm happy with how it looks. I also did a quick check through the testsuite and it all seems good. All that being said, I nearly acked this, but I have one question down below in the test code. It may indicate some issue in `ovn-nbctl

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

2022-03-14 Thread Ilya Maximets
On 3/14/22 19:33, Roi Dayan wrote: > > > On 2022-03-10 8:44 PM, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> Few years ago OVS user space made a strange choice in the commit [1] >>> to define types only valid for the user space inside the copy of a >>> kernel uAPI header.  '#ifndef

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

2022-03-14 Thread Roi Dayan via dev
On 2022-03-10 8:44 PM, Aaron Conole wrote: Ilya Maximets writes: Few years ago OVS user space made a strange choice in the commit [1] to define types only valid for the user space inside the copy of a kernel uAPI header. '#ifndef __KERNEL__' and another attribute was added later. This

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Monday 14 March 2022 17:09 > To: Phelan, Michael ; Amber, Kumar > ; ovs-dev > Cc: i.maxim...@ovn.org; Stokes, Ian ; Ferriter, Cian > ; Aaron Conole ; Kalahasthi, > Suneetha > Subject: Re: [ovs-build] |fail| pw1600225 [ovs-dev,

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Ilya Maximets
On 3/14/22 17:21, Phelan, Michael wrote: > >> -Original Message- >> From: Amber, Kumar >> Sent: Monday 14 March 2022 13:59 >> To: Ilya Maximets ; Phelan, Michael >> ; ovs-dev >> Cc: Stokes, Ian ; Ferriter, Cian >> ; Aaron Conole ; >> Kalahasthi, Suneetha >> Subject: RE: [ovs-build]

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Phelan, Michael
> -Original Message- > From: Amber, Kumar > Sent: Monday 14 March 2022 13:59 > To: Ilya Maximets ; Phelan, Michael > ; ovs-dev > Cc: Stokes, Ian ; Ferriter, Cian > ; Aaron Conole ; > Kalahasthi, Suneetha > Subject: RE: [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use >

Re: [ovs-dev] [PATCH v1 0/2] MFEX datapath independent Tests

2022-03-14 Thread Amber, Kumar
Hi Ilya, Thanks a lot for the valuable feedback. Please find the reply inline. > -Original Message- > From: Ilya Maximets > Sent: Saturday, March 12, 2022 3:57 AM > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; f...@sysclose.org > Subject: Re: [ovs-dev] [PATCH v1

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Amber, Kumar
Hi Ilya, Michael, Please find my reply inline. > -Original Message- > From: Ilya Maximets > Sent: Monday, March 14, 2022 5:44 PM > To: Phelan, Michael ; ovs-dev d...@openvswitch.org> > Cc: i.maxim...@ovn.org; Stokes, Ian ; Ferriter, Cian > ; Aaron Conole ; Kalahasthi, > Suneetha ;

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Ilya Maximets
On 3/14/22 12:29, Phelan, Michael wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday 11 March 2022 20:38 >> To: ovs-dev ; Phelan, Michael >> >> Cc: i.maxim...@ovn.org; Stokes, Ian ; Ferriter, Cian >> ; Aaron Conole ; >> Kalahasthi, Suneetha ; Amber, Kumar >> >> Subject:

Re: [ovs-dev] [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use DPDK 20.11.4 release

2022-03-14 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Friday 11 March 2022 20:38 > To: ovs-dev ; Phelan, Michael > > Cc: i.maxim...@ovn.org; Stokes, Ian ; Ferriter, Cian > ; Aaron Conole ; > Kalahasthi, Suneetha ; Amber, Kumar > > Subject: Re: [ovs-build] |fail| pw1600225 [ovs-dev,

[ovs-dev] [PATCH ovn] controller/pinctrl: avoid accessing invalid memory

2022-03-14 Thread Mohammad Heib
currently pinctrl main thread uses some shash lists that were supplied by ovn-controller main thread to prepare and send IPv6 RAs, those lists are not updated properly when LRP is deleted and can cause some invalid memory access in the pinctrl module. This patch handles such changes and update

Re: [ovs-dev] [PATCH] faq: Update OVS/DPDK version table for OVS 2.15/2.16

2022-03-14 Thread Stokes, Ian
> On 04/03/2022 10:12, Suneetha Kalahasthi wrote: > > FAQ is updated to reflect the latest DPDK for OVS branch 2.15 and 2.16 > > > > Signed-off-by: Suneetha Kalahasthi > > --- > > Documentation/faq/releases.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix NULL pointer dereference in xlate_normal()

2022-03-14 Thread Eelco Chaudron
On 11 Mar 2022, at 21:38, Paolo Valerio wrote: > Considering the following flows: > > ovs-ofctl dump-flows br0 > cookie=0x0, duration=2431.944s, table=0, n_packets=0, n_bytes=0, priority=0 > actions=NORMAL > > and assuming a packet originated from packet-out in this way: > > ovs-ofctl

[ovs-dev] [PATCH ovn] Added test cases with ovn-northd parallelization enabled

2022-03-14 Thread Xavier Simonart
This will more or less double the number of test cases. It is possible to select a reduce set of test cases using -k "keywords". Keyword such as dp-groups=yes dp-groups=no parallelization=yes parallelization=no ovn-northd ovn-northd-ddlog can be used