Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-27 Thread Han Zhou
On Wed, Mar 23, 2022 at 1:25 PM Numan Siddique wrote: > > On Wed, Mar 23, 2022 at 2:39 PM Han Zhou wrote: > > > > On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote: > > > > > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > > > > > > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wr

Re: [ovs-dev] [PATCH ovn v4 6/6] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-27 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #744 FILE: northd/ovn-northd.8.xml:917

Re: [ovs-dev] [PATCH ovn v4 2/6] actions: Add action ct_lb_mark.

2022-03-27 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 144 characters long (recommended limit is 79) #161 FILE: ovn-sb.xml:1992: c

Re: [ovs-dev] [PATCH ovn v4 1/6] ovn-sb.xml: Fix ct_lb documentation.

2022-03-27 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 139 characters long (recommended limit is 79) #25 FILE: ovn-sb.xml:1958: ct

[ovs-dev] [PATCH ovn v4 5/6] ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.

2022-03-27 Thread Han Zhou
Add an engine node en_northd_internal_version as an input to en_lflow_output. When this node is updated, it triggers a recompute for en_lflow_output. This node adds SB_Global as its only input, and it is updated only when SB_Global's options:northd_internal_version is updated. In a later patch the

[ovs-dev] [PATCH ovn v4 1/6] ovn-sb.xml: Fix ct_lb documentation.

2022-03-27 Thread Han Zhou
The documentation of the ct_lb action wasn't up to date. Add the description for backends and hash_fields. Fixes: 5af304e7478a ("Support selection fields in load balancer.") Signed-off-by: Han Zhou Acked-by: Numan Siddique --- ovn-sb.xml | 29 ++--- 1 file changed, 18 in

[ovs-dev] [PATCH ovn v4 4/6] ovn-northd: Improve the doc and tests for ecmp-symmetric-reply.

2022-03-27 Thread Han Zhou
1. The ovn-northd.8.xml didn't cover the flow in the lr_in_arp_resolve stage. 2. The original test didn't really test the ecmp-symmetric-reply because the option takes effect only for gateway routers. This patch set the chassis to make the router a gateway router. Also, add the check f

[ovs-dev] [PATCH ovn v4 3/6] actions: Add stack push and pop actions.

2022-03-27 Thread Han Zhou
Add two new actions push & pop for stack operations. Signed-off-by: Han Zhou --- include/ovn/actions.h | 8 + lib/actions.c | 73 +++ ovn-sb.xml| 15 + tests/ovn.at | 11 +++ utilities/ovn-trace.c | 64

[ovs-dev] [PATCH ovn v4 2/6] actions: Add action ct_lb_mark.

2022-03-27 Thread Han Zhou
Add a new action ct_lb_mark, which is the same as ct_lb except that it internally uses ct_mark to store the NAT flag, while ct_lb uses ct_label for the same purpose. This will be used later to move the masked access of ct_label to ct_mark while keeping the backward compatibility. Signed-off-by: Ha

[ovs-dev] [PATCH ovn v4 0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-27 Thread Han Zhou
Some NICs support HW offloading for datapath flows, but masked access to the 128-bit ct_label field may prevent a flow being offloaded due to HW limitations. OVN's use of ct_label currently includes: - ct_label.blocked (1 bit) - ct_label.natted (1 bit) - ct_label.ecmp_reply_port (16 bits) - ct_labe

[ovs-dev] [PATCH v1 1/1] datapath-windows: Add IPv6 conntrack support on Windows.

2022-03-27 Thread ldejing
From: ldejing Implementation on Windows: Currently, IPv4 conntrack was supported on the windows platform. In this patch we have implemented ipv6 conntrack functions according to the current logic of the IPv4 conntrack. This implementation has included TcpV6(nat and normal scenario), UdpV6(nat and

[ovs-dev] [PATCH v2 4/4] miniflow_extract: Add autovalidator support to miniflow_extract.

2022-03-27 Thread Kumar Amber
The patch adds the flag based switch between choice of using miniflow_extract in normal pipeline or select mfex_autovalidator in debug and test builds. The compile time flag used to select autoval can be done using option: ./configure CFLAGS="--enable-mfex-default-autovalidator" Signed-off-by:

[ovs-dev] [PATCH v2 3/4] Miniflow_extract: Refactor miniflow_extract into api.

2022-03-27 Thread Kumar Amber
Miniflow extract used to takes the ABI parameter struct miniflow which was removed and added inside the struct netdev_flow_key and at many places temperory structs were created inside the functions which could be cleaned in favour of a uniform API. Signed-off-by: Kumar Amber --- lib/dpif-netdev-

[ovs-dev] [PATCH v2 2/4] dpif-netdev: Refactor hashing function.

2022-03-27 Thread Kumar Amber
The changes moves the get_rss hashing function to its own .h files so that it can be used accross ovs which was previously only limited to dpif-netdev.c. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter --- lib/dpif-netdev-private-dpcls.h | 23 +

[ovs-dev] [PATCH v2 1/4] dpif-netdev: Refactor per thread recirc data allocation.

2022-03-27 Thread Kumar Amber
The refactor allows us to use *recirc_depth_get() to obtain the depth across ovs which was previously limited to only dpif-netdev.c. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter --- lib/dpif-netdev-private-dpif.c | 2 ++ lib/dpif-netdev-private-dpif.h |

[ovs-dev] [PATCH v2 0/4] Miniflow Extract Testing Improvements

2022-03-27 Thread Kumar Amber
The patch-set introduces changes which would improve the testing of miniflow_extract for AVX512 based miniflow_extract optimizations whithout affecting scalar code path. Kumar Amber (4): dpif-netdev: Refactor per thread recirc data allocation. dpif-netdev: Refactor hashing function. Miniflow