Re: [ovs-dev] [External] Re: [PATCH] add pmd scale configuration for phy port rxq

2022-03-28 Thread Wan Junjie
Hi Kevin, Thanks for your comments. On Fri, Mar 25, 2022 at 8:17 PM Kevin Traynor wrote: > > Hi Wan Junjie, > > Not a full code review, but comments on the feature below. > > On 02/03/2022 10:59, Wan Junjie wrote: > > A pmd would poll all rxqs with no weight. When a pmd has one rxq > >

Re: [ovs-dev] [EXTERNAL] Proper way to recirculate packet // OvS Crash

2022-03-28 Thread Dincer Beken
Checking further into the code, I see that even if I put the ETH header in front, the packet is not matched against a gtp-vport, since the packet will be a layer2 packet. Even if I hardcodedly fetch a gtp vport, in tnl_find or tnl_find_exact, the rule of pushing back the GTP header will not be a

Re: [ovs-dev] [EXTERNAL] Proper way to recirculate packet // OvS Crash

2022-03-28 Thread Dincer Beken
https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332897.html https://www.youtube.com/watch?v=rOp1tUGIbYs So essentially, this is what I am doing during the decapsulation, such that the OvS does not crash. An additional question would be, if I need to specify an Input VPORt, as well? D

Re: [ovs-dev] [EXTERNAL] Proper way to recirculate packet // OvS Crash

2022-03-28 Thread Dincer Beken
Hello, After looking further into the issue, after the decapsulation, the packet is a L3 packet without a L2 header anymore. If I push the ETH header manually, the received port cannot be matched anymore. Do we have to push the ETH header (some random dummy), onto the decapsulated packet, befo

[ovs-dev] Proper way to recirculate packet // OvS Crash

2022-03-28 Thread Dincer Beken
Hello, I am using the userspace OvS (2.14.) and the userspace GTP tunnel. I am decapsulating a GTP packet in table0 -> sending the decapsulated packet over to Table1, where I again want to encapsulate it again (with a different tunnel identifier) and submit to (another?) gtp port. root@RiduxV4:

Re: [ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-28 Thread Pai G, Sunil
Hi All, Please see below PDF which will be presented in the call. https://github.com/Sunil-Pai-G/OVS-DPDK-presentation-share/blob/main/OVS%20vhost%20async%20datapath%20design%202022%20session%202.pdf Thanks and Regards, Sunil -Original Appointment- From: Stokes, Ian S

Re: [ovs-dev] [PATCH] python: regenerate dirs.py when Makefile is updated

2022-03-28 Thread Ilya Maximets
On 3/25/22 20:34, Timothy Redaelli wrote: > Currently dirs.py is not generated when Makefile is updated, so if > prefix is changed dirs.py is not updated with the new prefix. > > This patch adds a Makefile dependency on dirs.py, so it's regenerated > correctly when prefix is updated. > > Fixes: 9

Re: [ovs-dev] [PATCH] python: don't ship dirs.py in tarball

2022-03-28 Thread Ilya Maximets
On 3/25/22 18:56, Timothy Redaelli wrote: > Currently dirs.py is included in released tarball (make dist), but it > should be generated during build, since it includes the prefix that may > change by configure --prefix and other options. > > This commit removes dirs.py from EXTRA_DIST so it's not

[ovs-dev] [RFC PATCH v2] dpif-netdev: Put idle PMD threads to sleep.

2022-03-28 Thread David Marchand
This is a RFC about trying to save some power, by putting the PMD threads CPU to sleep in some circumstances. This is probably not a full solution, but sending this to get feedback. DPDK ethdev ports support Rx interrupts, which are implemented by providing a file descriptor per rxq on which an ap

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-28 Thread Eelco Chaudron
On Mon, Mar 28, 2022 at 3:15 PM Eelco Chaudron wrote: > > > On 25 Mar 2022, at 18:05, Tao Liu wrote: > > > On Fri, Mar 25, 2022 at 12:08:20PM +0100, Eelco Chaudron wrote: > >> > >> > >> On 22 Mar 2022, at 13:04, Tao Liu wrote: > >> > >>> If netdev goes away(i.e. qemu with a vnet shutdown), kernel

Re: [ovs-dev] [PATCH v1] signals: Add support for sigdescr_np

2022-03-28 Thread David Marchand
On Wed, Mar 23, 2022 at 2:08 PM Mike Pattrick wrote: > > On Wed, Mar 23, 2022 at 4:23 AM David Marchand > wrote: > > > > On Tue, Mar 22, 2022 at 6:43 PM Mike Pattrick wrote: > > > > > > In glibc 2.32 sys_siglist is no longer exported. The MT-safe function > > > sigdescr_np() is now available for

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-28 Thread Eelco Chaudron
On 25 Mar 2022, at 18:05, Tao Liu wrote: > On Fri, Mar 25, 2022 at 12:08:20PM +0100, Eelco Chaudron wrote: >> >> >> On 22 Mar 2022, at 13:04, Tao Liu wrote: >> >>> If netdev goes away(i.e. qemu with a vnet shutdown), kernel delete all tc >>> filters, those tcf_id related to the netdev will be le

Re: [ovs-dev] [EXTERNAL] Re: OVS GTP-U Tunnel Termination

2022-03-28 Thread Dincer Beken
Hello Ilya, No problem. But I am still facing issues here. After I have decapsulated the packet, if it is addressed towards another UE, I want to encapsulate it back with another correct GTP header, without routing the packet first out of the OvS and then back in. When I try to do that, OvS is

[ovs-dev] [PATCH 5/5] tests: Add check_pkt_len action test to system-offload-traffic.

2022-03-28 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- tests/system-offloads-traffic.at | 413 ++ 1 file changed, 412 insertions(+), 1 deletion(-) diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at index 705a50079..4cde53e2e 100644 --- a/tests/system

[ovs-dev] [PATCH 4/5] system-offloads-traffic: Properly initialize offload before testing.

2022-03-28 Thread Eelco Chaudron
This patch will properly initialize offload, as it requires the setting to be enabled before starting ovs-vswitchd (or do a restart once configured). Signed-off-by: Eelco Chaudron --- tests/ofproto-macros.at |6 +- tests/system-kmod-macros.at |4 ++-- tests/system-offlo

[ovs-dev] [PATCH 3/5] netdev-offload-tc: Handle check_pkt_len datapath action.

2022-03-28 Thread Eelco Chaudron
This change implements support for the check_pkt_len action using the TC police action, which supports MTU checking. Signed-off-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 171 +- lib/tc.c| 455 +++ lib/tc.h

[ovs-dev] [PATCH 2/5] netdev-offload-tc: Move flower_to_match action handling to isolated function.

2022-03-28 Thread Eelco Chaudron
Move handling of the individual actions in the parse_tc_flower_to_match() function to a separate function that will make recursive action handling easier. Signed-off-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 422 +-- 1 file changed, 221 inserti

[ovs-dev] [PATCH 1/5] netdev-offload-tc: Move flow_put action handling to isolated function.

2022-03-28 Thread Eelco Chaudron
Move handling of the individual actions in the netdev_tc_flow_put() function to a separate function that will make recursive action handling easier. Signed-off-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 255 +-- 1 file changed, 138 insertions(+)

[ovs-dev] [PATCH 0/5] netdev-offload-tc: Add support for the check_pkt_len action.

2022-03-28 Thread Eelco Chaudron
This series adds support for the datapath action check_pkt_len for TC offload. It also includes some offload self-tests. Eelco Chaudron (5): netdev-offload-tc: Move flow_put action handling to isolated function. netdev-offload-tc: Move flower_to_match action handling to isolated funct