On Tue, Mar 29, 2022 at 3:19 PM Kevin Traynor wrote:
>
> This splits up the looping through each PMD thread core on a numa node
> with the check to compare cycles or rxqs.
>
> This is done so in future the compare could be reused with any group
> of PMD thread cores.
>
> There is no user visibile
On Tue, Mar 29, 2022 at 3:19 PM Kevin Traynor wrote:
>
> Previously logging about rxq scheduling was done in a code branch with
> the selection of the PMD thread core after checking that a numa was
> selected.
>
> By splitting out the logging from the PMD thread core selection, it can
> simplify t
On 4 Apr 2022, at 23:54, Paolo Valerio wrote:
> Aaron Conole writes:
>
>> Paolo Valerio writes:
>>
>>> The next header contained in the last extension header of the IPv6
>>> later frags still contain the information of the upper layer protocol
>>> number.
>>>
>>> Similarly to what OvS does fo
This series fix two revalidation triggers:
- trigger revalidation if ct_zone timeout policy changes
- avoid revalidation if lldp config doesn't change
The second patch relies on the first one because of ct test cases
lic121 (2):
ofproto-dpif: trigger revalidate if ct tp changes
ofproto-dp
If lldp didn't change, we are not supposed to trigger backer
revalidation.
Without this patch, bridge_reconfigure() always trigger udpif
revalidator because of lldp.
This patch also fix lldp memory leak bug:
lldp_create() malloc memory for lldp->lldpd->g_hardware. lldp_unref
is supposed to free th
Once ct_zone timeout policy changes, revalidator is supposed to be
triggered.
Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy
tables")
Signed-off-by: lic121
---
ofproto/ofproto-dpif.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofpr
On 4 Apr 2022, at 21:05, Ilya Maximets wrote:
> On 3/30/22 11:35, Eelco Chaudron wrote:
>>
>>
>> On 29 Mar 2022, at 13:06, Ilya Maximets wrote:
>>
>>> On 2/25/22 13:29, Marcelo Ricardo Leitner wrote:
On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote:
>
>
> On 23 Feb
On 4/5/22 12:24, Eelco Chaudron wrote:
>
>
> On 4 Apr 2022, at 21:05, Ilya Maximets wrote:
>
>> On 3/30/22 11:35, Eelco Chaudron wrote:
>>>
>>>
>>> On 29 Mar 2022, at 13:06, Ilya Maximets wrote:
>>>
On 2/25/22 13:29, Marcelo Ricardo Leitner wrote:
> On Thu, Feb 24, 2022 at 03:20:23PM +0
On 3/30/22 16:09, Bruce Richardson wrote:
> On Wed, Mar 30, 2022 at 01:41:34PM +0200, Ilya Maximets wrote:
>> On 3/30/22 13:12, Bruce Richardson wrote:
>>> On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets wrote:
On 3/30/22 12:41, Ilya Maximets wrote:
> Forking the thread to discuss
On Tue, Apr 05, 2022 at 01:29:25PM +0200, Ilya Maximets wrote:
> On 3/30/22 16:09, Bruce Richardson wrote:
> > On Wed, Mar 30, 2022 at 01:41:34PM +0200, Ilya Maximets wrote:
> >> On 3/30/22 13:12, Bruce Richardson wrote:
> >>> On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets wrote:
> On
Hello,
On the GTP-U implementation in the userspace, I see that the IP Header
Identification Field is not set in the encapsulated packets. This is not like
this in the Kernel Implementation. I don't get replies when I send these
tunneled packets.
>From the Specification, I see that this fiedl
As privately reported by Aaron Conole, and by Jeffrey Walton [0]
there's currently a number of undefined behavior instances in
the OVS code base. Running the OVS (and OVN) tests with UBSan [1]
enabled uncovers these.
This series fixes the issues reported by UBSan and, through the last
patch, enab
UB Sanitizer reports:
tests/test-hash.c:59:40: runtime error: shift exponent 64 is too large for
64-bit type 'long unsigned int'
#0 0x44c3c9 in get_range128 tests/test-hash.c:59
#1 0x44cb2e in check_hash_bytes128 tests/test-hash.c:178
#2 0x44d14d in test_hash_main tests/test-ha
This is undefined behavior and was reported by UB Sanitizer:
lib/meta-flow.c:3445:16: runtime error: member access within null pointer of
type 'struct vl_mf_field'
#0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
#1 0x6d96d7 in mf_from_oxm_header lib/nx-match.c:260
#2 0x6d9e2e
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning from UndefinedBehaviorSanitizer:
lib/meta-flow.c:3210:9: runtime error: member access within misaligned
address 0x00de4e36 for type 'const union mf_value', which requires 8 byte
alignment
0x00
Trim the ofpbuf to ensure proper alignment.
UB Sanitizer report:
lib/ofp-print.c:1218:24: runtime error: member access within misaligned
address 0x019229d2 for type 'const struct ofp_header', which requires 4
byte alignment
0x019229d2: note: pointer points here
00 00 5a 5a 05 22
Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
replies to statistics reply messages which have a header of 12 bytes
and no additional padding.
Also, buggy controllers might incorrectly encode actions.
When decoding multiple actions in ofpacts_decode(), make sure that
when a
Note: There still is an UB instance when using SSE4.2 as reported here:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-January/390904.html
Acked-by: Aaron Conole
Signed-off-by: Dumitru Ceara
---
v5:
- Rebased.
v4:
- Rebased.
v3:
- Fix typo in variable name.
- Added SSE4.2 UB note to commit
Ilya Maximets writes:
> While parsing user-provided actions, openvswitch module may dynamically
> allocate memory and store pointers in the internal copy of the actions.
> So this memory has to be freed while destroying the actions.
>
> Currently there are only two such actions: ct() and set().
Ilya Maximets writes:
> 'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
> performance optimization inside the kernel. It's added by the kernel
> while parsing user-provided actions and should not be sent during the
> flow dump as it's not part of the uAPI.
>
> The issue doesn't c
> This patch adds the scalar hash calls to the autovalidator.
> It also adds checks for comparing the scalar hash against
> the profile based hash calculated as part of AVX512 MFEX implementations.
>
> The per profile AVX512 optimized hash was added to the autovalidator
> in the last commit. The a
> -Original Message-
> From: Amber, Kumar
> Sent: Friday, April 1, 2022 12:24 PM
> To: ovs-dev@openvswitch.org
> Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian
> ; f...@sysclose.org; Van Haaren, Harry
> ; Amber, Kumar
> Subject: [PATCH v8 1/4] dpif-netdev/mfex: Add ipv4 profile
> This patch avoids calculating the software hash of the packet again
> if the optimized miniflow-extract hit. In cases of scalar miniflow
> extract, the normal hashing calculation is performed.
>
> Signed-off-by: Kumar Amber
Thanks for looking at this, seems straight forward enough. Think this
> The mfex pcap generation script is improved for varied length
> traffic and also removes the hard coded mfex_pcap and instead uses
> the script itself to generate complex traffic patterns for testing.
>
> Signed-off-by: Kumar Amber
>
So in general I think this approach is a bit more improved.
From: Florian Westphal
[ Upstream commit 408bdcfce8dfd6902f75fbcd3b99d8b24b506597 ]
Its the same as nf_conntrack_put(), but without the
need for an indirect call. The downside is a module dependency on
nf_conntrack, but all of these already depend on conntrack anyway.
Cc: Paul Blakey
Cc: d...
From: Florian Westphal
[ Upstream commit 408bdcfce8dfd6902f75fbcd3b99d8b24b506597 ]
Its the same as nf_conntrack_put(), but without the
need for an indirect call. The downside is a module dependency on
nf_conntrack, but all of these already depend on conntrack anyway.
Cc: Paul Blakey
Cc: d...
These are intended to reduce code complexity a bit and make the
code more extensible for additional features like cross-numa
polling [0].
There is no change in behaviour.
v2:
- Address minor comments from David
- Minor rebase as [1] has now merged
GHA: https://github.com/kevintraynor/ovs/actions
This splits up the looping through each PMD thread core on a numa node
with the check to compare cycles or rxqs.
This is done so in future the compare could be reused with any group
of PMD thread cores.
There is no user visible change in behaviour.
Signed-off-by: Kevin Traynor
Acked-by: David M
Previously logging about rxq scheduling was done in a code branch with
the selection of the PMD thread core after checking that a numa was
selected.
By splitting out the logging from the PMD thread core selection, it can
simplify the code complexity and make it more extendable for future
additions
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 5 April 2022 14:52
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> Phelan, Michael
> Cc: echau...@redhat.com; Ferriter, Cian ;
> f...@sysclose.org; Van Haaren, Harry
> Subject: RE: [PATCH v8 4/4] tests/mfex: Improve pcap script f
Thanks for the update Mohammad. I like this version much better.
Acked-by: Mark Michelson
On 4/3/22 07:26, Mohammad Heib wrote:
currently pinctrl uses some hash tables that were supplied
by ovn-controller to prepare and send IPv6 RAs, those
hash tables are not updated properly when a port_bind
Dumitru Ceara writes:
> This is undefined behavior and was reported by UB Sanitizer:
> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
> of type 'struct vl_mf_field'
> #0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
> #1 0x6d96d7 in mf_from_oxm_header li
Eelco Chaudron writes:
> On 4 Apr 2022, at 23:54, Paolo Valerio wrote:
>
>> Aaron Conole writes:
>>
>>> Paolo Valerio writes:
>>>
The next header contained in the last extension header of the IPv6
later frags still contain the information of the upper layer protocol
number.
Dumitru Ceara writes:
> For example is parsing the OVN "eth.dst[40] = 1;" action, which
> triggered the following warning from UndefinedBehaviorSanitizer:
>
> lib/meta-flow.c:3210:9: runtime error: member access within misaligned
> address 0x00de4e36 for type 'const union mf_value', which
Dumitru Ceara writes:
> Trim the ofpbuf to ensure proper alignment.
>
> UB Sanitizer report:
> lib/ofp-print.c:1218:24: runtime error: member access within misaligned
> address 0x019229d2 for type 'const struct ofp_header', which requires 4
> byte alignment
> 0x019229d2: note: point
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the netdev_tc_flow_put()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
> ---
> lib/netdev-offlo
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the parse_tc_flower_to_match()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
> ---
> lib/netdev
Aaron Conole writes:
> Eelco Chaudron writes:
>
>> On 4 Apr 2022, at 23:54, Paolo Valerio wrote:
>>
>>> Aaron Conole writes:
>>>
Paolo Valerio writes:
> The next header contained in the last extension header of the IPv6
> later frags still contain the information of the upper
On 3/30/22 06:40, Xavier Simonart wrote:
Hi Dumitru
On Mon, Mar 21, 2022 at 12:02 PM Dumitru Ceara wrote:
On 3/21/22 10:56, Xavier Simonart wrote:
- send gratuitous arp on localnet
- send gratuitous arp for nat ips in localnet
- dns lookup : 1 HV, 2 LS, 2 LSPs/LS -- ovn-northd -- dp-groups=y
On 4/5/22 16:41, Aaron Conole wrote:
> Dumitru Ceara writes:
>
>> This is undefined behavior and was reported by UB Sanitizer:
>> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
>> of type 'struct vl_mf_field'
>> #0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
Thanks Lorenzo,
Acked-by: Mark Michelson
On 4/1/22 17:11, Lorenzo Bianconi wrote:
Remove meters created through set_meter() action if the related entry in
the NB QoS table has been deleted.
Fixes: 885655e16 ("controller: reconfigure ovs meters for ovn meters")
Signed-off-by: Lorenzo Bianconi
On 4/5/22 17:22, Mark Michelson wrote:
> On 3/30/22 06:40, Xavier Simonart wrote:
>> Hi Dumitru
>>
>> On Mon, Mar 21, 2022 at 12:02 PM Dumitru Ceara wrote:
>>
>>> On 3/21/22 10:56, Xavier Simonart wrote:
- send gratuitous arp on localnet
- send gratuitous arp for nat ips in localnet
HI Michael Ian,
> -Original Message-
> From: Phelan, Michael
> Sent: Tuesday, April 5, 2022 7:47 PM
> To: Stokes, Ian ; Amber, Kumar
> ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; Ferriter, Cian ;
> f...@sysclose.org; Van Haaren, Harry
> Subject: RE: [PATCH v8 4/4] tests/mfex: Im
This is my favorite type of change :)
Acked-by: Mark Michelson
On 3/30/22 01:49, Han Zhou wrote:
This is not needed any more and force_crossproduct is always false.
Signed-off-by: Han Zhou
---
lib/expr.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/l
Acked-by: Mark Michelson
On 3/30/22 01:50, Han Zhou wrote:
The comment is misleading. The conjunctive match IDs always starts from
1 instead of 0.
Signed-off-by: Han Zhou
---
lib/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/expr.c b/lib/expr.c
index 47ef61
Thanks Xavier. It's amazing this issue has been around so long.
Acked-by: Mark Michelson
On 4/1/22 12:34, Xavier Simonart wrote:
On gateway routers egress packets might be both:
- unDNATted
- SNATted
Reply packets should not be SNATted (they must of course be UnDNATted
if DNAT was applied).
R
Hi. Thanks for the patch!
One general comment for the subject line:
'netdev' doesn't seem to be a correct 'area' for the change.
It should be 'ofproto-dpif-xlate' instead. And, please,
add the space after the ':'. 'summary' should preferably
start with a capital letter and end with a period.
M
Dumitru Ceara writes:
> On 4/5/22 16:41, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> This is undefined behavior and was reported by UB Sanitizer:
>>> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
>>> of type 'struct vl_mf_field'
>>> #0 0x6aad0f in mf
Hi Mohammad,
I have a few findings down below, pretty minor.
On 3/30/22 14:09, Mohammad Heib wrote:
currently, when a lport with a nonempty parent_name field
is created or updated in the NBDB the ovn-controller will
handle this port as a container lport and will do all the
required operations t
Hi Mohammad,
The change itself seems like a good idea. I have a question. This code
is only written for the incremental case, not the recompute case. Is
this because this situation can only arise in the incremental case?
On 3/31/22 07:01, Mohammad Heib wrote:
currently ovn-controller allow u
On Thu, Mar 31, 2022 at 02:03:41PM -0400, Mark Michelson wrote:
> @Ben
> Can you please change the channel topic message of #openvswitch so that the
> new meeting time is reflected? Thanks!
I've done this now.
Does anyone know how I would give someone else permission to do this
kind of thing? I
Thanks a bunch Xavier!
Acked-by: Mark Michelson
On 3/30/22 07:26, Xavier Simonart wrote:
- options:requested-chassis for logical port
- NAT and Load Balancer flows
- 2LSs IGMP and MLD
- Dynamic neighbor between LRs
- (userspace test) conntrack TCP reset
- Dont flood fill local datapaths beyond
Hi,
The subject claims this is patch 1/2, but I don't see patch 2/2 on
patchwork or on the mailing list.
Provisionally, I'm acking this patch
Acked-by: Mark Michelson
but if there's a part 2, I'd prefer that it gets reviewed before this
gets merged.
Also, I have one minor thing below.
O
On 4/5/22 15:51, Stokes, Ian wrote:
>
>
>> -Original Message-
>> From: Amber, Kumar
>> Sent: Friday, April 1, 2022 12:24 PM
>> To: ovs-dev@openvswitch.org
>> Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian
>> ; f...@sysclose.org; Van Haaren, Harry
>> ; Amber, Kumar
>> Subject: [PA
On 4/4/22 14:36, Michael Santana wrote:
> The handler and CPU mapping in upcalls are incorrect, and this is
> specially noticeable systems with cpu isolation enabled.
>
> Say we have a 12 core system where only every even number CPU is enabled
> C0, C2, C4, C6, C8, C10
>
> This means we will crea
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Mon, 4 Apr 2022 12:41:50 +0200 you wrote:
> 'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
> performance optimization inside the kernel. It's added by the kernel
> while parsing user-provided action
Hi Mark,
Initially there should be a second patch, but after sending the first I’ve
decided to send second one separately:
http://patchwork.ozlabs.org/project/ovn/patch/20220401083229.1583750-1-odiv...@gmail.com/
regards,
Vladislav Odintsov
> On 5 Apr 2022, at 23:03, Mark Michelson wrote:
>
Regarding the code style, should I resend patch or this can be fixed when the
patch gets applied?
regards,
Vladislav Odintsov
> On 5 Apr 2022, at 23:03, Mark Michelson wrote:
>
> Hi,
>
> The subject claims this is patch 1/2, but I don't see patch 2/2 on patchwork
> or on the mailing list.
>
58 matches
Mail list logo
