> -Original Message-
> From: Richardson, Bruce
> Sent: Tuesday, April 5, 2022 5:38 PM
> To: Ilya Maximets ; Chengwen Feng
> ; Radha Mohan Chintakuntla ;
> Veerasenareddy Burru ; Gagandeep Singh
> ; Nipun Gupta
> Cc: Pai G, Sunil ; Stokes, Ian
> ; Hu, Jiayu ; Ferriter, Cian
> ; Van Haaren,
Hi Ilya,
I addressed most of the review comments in my v3 patch.
I am not sure what I need to do for the fixes tag as I am not sure when this
bug was introduced.
I noticed this in ovs 2.14.
Thanks
Thilak Raj S
-Original Message-
From: Thilak Raj Surendra Babu
Sent: 06 April 2022 10:11
T
got it. thanks!
Hemanth Aramadaka 于2022年4月8日周五 00:36写道：
> Hi,
>
>
>
> Here we are not fragmenting VXLAN packets in the outer IP header.The
> packets originating from VM with the larger size than the configured MTU
>
> will get fragmented and these inner packets are encapsulated with vxlan
> he
I have some comment myself regarding the documentation:
On Wed, Apr 6, 2022 at 4:36 PM Han Zhou wrote:
>
> Whenever OpenFlow connection between ovn-controller and OVS is
> connected/reconnected, typically during ovn-controller/OVS
> restart/upgrade, ovn-controller would:
> 1. clears all the exist
On Fri, Apr 1, 2022 at 1:55 PM Mark Michelson wrote:
>
> Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality
> in ovn-northd to use a single zone for SNAT and DNAT when possible. It
> accounts for certain situations, such as hairpinned traffic, where we
> still need a separate
On Tue, Apr 5, 2022 at 10:21 AM Mark Michelson wrote:
>
> Thanks for the update Mohammad. I like this version much better.
>
> Acked-by: Mark Michelson
Thanks for the fix.
I applied this patch to the main and backported upto branch-21.09 with
the below changes as it would reduce the code.
When a packet is received over an access port that needs to be sent
over a vxlan tunnel,the access port VLAN id is used in the lookup
leading to a wrong packet being crafted and sent over the tunnel.
Clear out the flow 's VLAN field as it should not be used while
performing mac lookup for the outer
On Wed, Mar 23, 2022 at 11:35 AM Dumitru Ceara wrote:
>
> Add check to see if the LR actually has NAT entries configured.
> Otherwise we spam the log unnecessarily.
>
> Fixes: b8194738c99e ("northd: Properly warn for NAT on LR with multiple gw
> ports.")
> Signed-off-by: Dumitru Ceara
Hi Dumitr
On Mon 14 Mar 2022 at 20:40, Ilya Maximets wrote:
> On 3/14/22 19:33, Roi Dayan wrote:
>>
>>
>> On 2022-03-10 8:44 PM, Aaron Conole wrote:
>>> Ilya Maximets writes:
>>>
Few years ago OVS user space made a strange choice in the commit [1]
to define types only valid for the user space i
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Vladislav Odintsov needs to sign off.
Lines checked: 78, Warnings: 0, Erro
Hi,
I’ve faced an issue where GENEVE and VXLAN offload on RX path doesn’t work with
openvswitch OOT kernel module.
The problem reproduced at least on CentOS 7.5, 7.8 (but I think more recent
versions are affected too).
Initially the problem was observed with OVS 2.13, but it reproduces with 2.17
On Wed, Apr 6, 2022 at 12:11 PM Numan Siddique wrote:
>
> On Wed, Apr 6, 2022 at 4:58 AM Frode Nordahl
> wrote:
> >
> > On Wed, Mar 30, 2022 at 4:54 PM Numan Siddique wrote:
> > >
> > > On Wed, Mar 30, 2022 at 6:21 AM Frode Nordahl
> > > wrote:
> > > >
> > > > On Wed, Mar 30, 2022 at 11:45 AM F
Hi,
Here we are not fragmenting VXLAN packets in the outer IP header.The packets
originating from VM with the larger size than the configured MTU
will get fragmented and these inner packets are encapsulated with vxlan header
in which we have the different source ports for UDP.
Thanks,
On Thu, Apr 07, 2022 at 05:46:32PM +0200, Maxime Coquelin wrote:
>
>
> On 4/7/22 17:01, Ilya Maximets wrote:
> > On 4/7/22 16:42, Van Haaren, Harry wrote:
> > > > -Original Message-
> > > > From: Ilya Maximets
> > > > Sent: Thursday, April 7, 2022 3:40 PM
> > > > To: Maxime Coquelin ; Va
On Thu, Apr 7, 2022 at 7:26 AM Adrian Moreno wrote:
>
> Hi Mike,
>
> On 4/6/22 18:48, Mike Pattrick wrote:
> > Verify that a flow isn't adding more than 64kB in actions when an action
> > uses multiple check_pkt_larger statements. Failure to do so can cause
> > ovs-vswitchd to throw signal 6. Also
On Tue, Apr 5, 2022 at 2:18 PM Mark Michelson wrote:
>
> Thanks Xavier. It's amazing this issue has been around so long.
>
The main reason this issue has not been an actual issue is because
generally a gateway router is connected to a join switch
and E-W traffic doesn't reach the gateway router
On 4/7/22 17:01, Ilya Maximets wrote:
On 4/7/22 16:42, Van Haaren, Harry wrote:
-Original Message-
From: Ilya Maximets
Sent: Thursday, April 7, 2022 3:40 PM
To: Maxime Coquelin ; Van Haaren, Harry
; Morten Brørup ;
Richardson, Bruce
Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian
On 4/7/22 16:42, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Thursday, April 7, 2022 3:40 PM
>> To: Maxime Coquelin ; Van Haaren, Harry
>> ; Morten Brørup ;
>> Richardson, Bruce
>> Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian
>> ; Hu, Jiayu ; Ferri
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, April 7, 2022 3:40 PM
> To: Maxime Coquelin ; Van Haaren, Harry
> ; Morten Brørup ;
> Richardson, Bruce
> Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian
> ; Hu, Jiayu ; Ferriter, Cian
> ; ovs-dev@openvswitch.org; d...@dpdk.o
On 4/7/22 16:25, Maxime Coquelin wrote:
> Hi Harry,
>
> On 4/7/22 16:04, Van Haaren, Harry wrote:
>> Hi OVS & DPDK, Maintainers & Community,
>>
>> Top posting overview of discussion as replies to thread become slower:
>> perhaps it is a good time to review and plan for next steps?
>>
>> From my p
Hi Harry,
On 4/7/22 16:04, Van Haaren, Harry wrote:
Hi OVS & DPDK, Maintainers & Community,
Top posting overview of discussion as replies to thread become slower:
perhaps it is a good time to review and plan for next steps?
From my perspective, it those most vocal in the thread seem to be in
Hi OVS & DPDK, Maintainers & Community,
Top posting overview of discussion as replies to thread become slower:
perhaps it is a good time to review and plan for next steps?
>From my perspective, it those most vocal in the thread seem to be in favour of
>the clean
rx/tx split ("defer work"), with
During the revalidation, mirror could be removed. Instead of crash
the process, we can simply skip the deleted mirror.
Fixes: ec7ceaed4f3e ("ofproto-dpif: Modularize mirror code.")
Signed-off-by: lic121
---
ofproto/ofproto-dpif-xlate.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletion
Hi Mike,
On 4/6/22 18:48, Mike Pattrick wrote:
Verify that a flow isn't adding more than 64kB in actions when an action
uses multiple check_pkt_larger statements. Failure to do so can cause
ovs-vswitchd to throw signal 6. Also add a depth check to clone and
check_pkt_larger.
I think I'm lacki
On 4/7/22 10:02, Vlad Buslov wrote:
> On Mon 14 Mar 2022 at 20:40, Ilya Maximets wrote:
>> On 3/14/22 19:33, Roi Dayan wrote:
>>>
>>>
>>> On 2022-03-10 8:44 PM, Aaron Conole wrote:
Ilya Maximets writes:
> Few years ago OVS user space made a strange choice in the commit [1]
> to
Changes done in ovn-nbctl to support creation of mirror
and attach a source port for the same.
Example commands:
ovn-nbctl mirror-add mirror1 gre 0 to-lport sw0-port2
ovn-nbctl lsp-attach-mirror sw0-port1 mirror1
Changes are needed in ovn-sbctl and ovn-controller as well
to make it functional end
As the police actions with indexes of 0x1000-0x1fff are
reserved for meter offload, to provide a clean environment for OVS,
these reserved police actions should be deleted on startup. So dump
all the police actions, delete those actions with indexes in this
range.
Signed-off-by: Jianbo Liu
OVS meters are created in advance and openflow rules refer to them by
their unique ID. New tc_police API is used to offload them. By calling
the API, police actions are created and meters are mapped to them.
These actions then can be used in tc filter rules by the index.
Signed-off-by: Jianbo Liu
When offloading rule, tc should be filled with police index, instead
of meter id. As meter is mapped to police action, and the mapping is
inserted into meter_id_to_police_idx hmap, this hmap is used to find
the police index. Besides, an action cookie is added to save meter id
on rule creation, so m
Add function to parse police action from netlink message, and meter id
can be retrieved from action cockie as it will be saved there in later
patch.
Signed-off-by: Jianbo Liu
---
lib/netdev-offload-tc.c | 4 +++
lib/tc.c| 59 +
lib/tc.h
For dpif-netlink, meters are mapped by tc to police actions with
one-to-one relationship. Implement meter offload API to set/get/del
the police action, and a hmap is used to save the mappings.
An id-pool is used to manage all the available police indexes, which
are 0x1000-0x1fff, reserved o
Add helpers to add, delete and get stats of police action with
the specified index.
Signed-off-by: Jianbo Liu
---
lib/netdev-linux.c | 133 +
lib/netdev-linux.h | 6 ++
lib/tc.c | 21 +++
lib/tc.h | 6 ++
4 files changed, 1
To reuse the code for manipulating police action, move the common
initialization code to a function, and change PPS parameters as meter
pktps is in unit of packet per second.
null_police is redundant because either BPS or PPS, not both, can be
configured in one message. So the police passed in to
Add API to offload meter to HW, and the corresponding functions to be
called from dpif by the type.
The interfaces are like those related to meter in dpif_class, in order
to pass necessary info to HW.
Signed-off-by: Jianbo Liu
---
lib/netdev-offload-provider.h | 16 +
lib/netdev-offload.c
This series is to add support for tc offloading of ovs metering, and
enhance OVS to use new kernel feature which offload tc police action to
hardware.
To do the offloading, new APIs for meter are added in netdev-offload,
and OVS meters are mapped to tc police actions with one-to-one
relationship fo
On 4/5/22 14:43, Dumitru Ceara wrote:
Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
replies to statistics reply messages which have a header of 12 bytes
and no additional padding.
Also, buggy controllers might incorrectly encode actions.
When decoding multiple actions
36 matches
Mail list logo
