Hi,
with make check -C build-asan TESTSUITEFLAGS="-k meter -d"
the ovs is build with asan enabled, is this feature already in current
building system?
I did not find it. Can anyone give some hint?
Thanks !
David Marchand 于2022年4月7日周四 02:55写道：
> On Sat, Mar 26, 2022 at 3:43 AM Peng He wrote:
Before 46d44cf3b, it was technically possible to assign a monitor
condition directly to Idl.tables[table_name].condition. If done
before the connection was established, it would successfully apply
the condition (where cond_change() actually would fail).
Although this wasn't meant to be supported,
On Sat, Feb 5, 2022 at 12:12 AM Han Zhou wrote:
>
> On Fri, Feb 4, 2022 at 7:58 AM Mark Michelson wrote:
> >
> > As far as I can tell, this looks correct.
> >
> > Acked-by: Mark Michelson
>
> Thanks Mark. I applied it to the main branch.
Hi Han,
We have an issue in OVN 21.12 (and OVN 21.09)
Do not provide an error log if there is an already created stateless nat entry
with the same external_ip and if the --may-exist option is provided in
the ovn-nbctl command.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2066551
Signed-off-by: Lorenzo Bianconi
---
tests/ovn-nbctl.at
tor. 7. apr. 2022, 19:40 skrev Frode Nordahl :
> On Thu, Apr 7, 2022 at 6:51 PM Numan Siddique wrote:
> >
> > On Wed, Apr 6, 2022 at 12:11 PM Numan Siddique wrote:
> > >
> > > On Wed, Apr 6, 2022 at 4:58 AM Frode Nordahl
> > > wrote:
> > > >
> > > > On Wed, Mar 30, 2022 at 4:54 PM Numan
On Fri, Apr 8, 2022 at 10:25 AM Dumitru Ceara wrote:
>
> On 4/1/22 22:10, Xavier Simonart wrote:
> > The issue might have caused potential memory leaks or crashes in northd
> >
> > Signed-off-by: Xavier Simonart
> > ---
>
> Looks good to me, thanks!
>
> Acked-by: Dumitru Ceara
Thanks. I
On 11 Apr 2022, at 15:52, Christophe Fontaine wrote:
> Changes in v2:
> * rename parameter "all_slaves_active" to "all_members_active"
> * fix doc warnings
>
> Thanks,
> Christophe
I did not review the code, but what is clearly missing are the appropriate test
cases.
//Eelco
Changes in v2:
* rename parameter "all_slaves_active" to "all_members_active"
* fix doc warnings
Thanks,
Christophe
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
This config param allows the delivery of broadcast and multicast packets
to the secondary interface of non-lacp bonds, equivalent to the option
"all_slaves_active" for kernel bonds.
Tested with an ovs-dpdk balance-slb bond with 2 virtual functions,
and a kernel bond with LACP on 2 other virtual
Dumitru Ceara writes:
> Detected by UB Sanitizer when running system tests:
> lib/netdev-linux.c:6250:26: runtime error: member access within misaligned
> address 0x0229a204 for type 'const struct rpl_rtnl_link_stats64', which
> requires 8 byte alignment
> 0x0229a204: note: pointer
The patch adds the subtable lookup name to the existing
dp-extra-info mentioned below:
dp-extra-info:miniflow_bits(18,4), lookup(generic)
dp-extra-info:miniflow_bits(9,4), lookup(avx512_gather)
Suggested-by: Ilya Maximets
Signed-off-by: Kumar Amber
---
v2:
- Add RCU protection for
Note: There still is an UB instance when using SSE4.2 as reported here:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-January/390904.html
Acked-by: Aaron Conole
Signed-off-by: Dumitru Ceara
---
v6: Rebased.
v5: Rebased.
v4: Rebased.
v3:
- Fix typo in variable name.
- Added SSE4.2 UB note
Detected by UB Sanitizer when running system tests:
lib/netdev-linux.c:6250:26: runtime error: member access within misaligned
address 0x0229a204 for type 'const struct rpl_rtnl_link_stats64', which
requires 8 byte alignment
0x0229a204: note: pointer points here
c4 00 17 00 01 00
Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
replies to statistics reply messages which have a header of 12 bytes
and no additional padding.
Also, buggy controllers might incorrectly encode actions.
When decoding multiple actions in ofpacts_decode(), make sure that
when
Trim the ofpbuf to ensure proper alignment.
UB Sanitizer report:
lib/ofp-print.c:1218:24: runtime error: member access within misaligned
address 0x019229d2 for type 'const struct ofp_header', which requires 4
byte alignment
0x019229d2: note: pointer points here
00 00 5a 5a 05 22
For example is parsing the OVN "eth.dst[40] = 1;" action, which
triggered the following warning from UndefinedBehaviorSanitizer:
lib/meta-flow.c:3210:9: runtime error: member access within misaligned
address 0x00de4e36 for type 'const union mf_value', which requires 8 byte
alignment
This is undefined behavior and was reported by UB Sanitizer:
lib/meta-flow.c:3445:16: runtime error: member access within null pointer of
type 'struct vl_mf_field'
#0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
#1 0x6d96d7 in mf_from_oxm_header lib/nx-match.c:260
#2
UB Sanitizer reports:
tests/test-hash.c:59:40: runtime error: shift exponent 64 is too large for
64-bit type 'long unsigned int'
#0 0x44c3c9 in get_range128 tests/test-hash.c:59
#1 0x44cb2e in check_hash_bytes128 tests/test-hash.c:178
#2 0x44d14d in test_hash_main
As privately reported by Aaron Conole, and by Jeffrey Walton [0]
there's currently a number of undefined behavior instances in
the OVS code base. Running the OVS (and OVN) tests with UBSan [1]
enabled uncovers these.
This series fixes the issues reported by UBSan and, through the last
patch,
On 4/6/22 18:36, Ilya Maximets wrote:
> On 4/6/22 18:31, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> On 4/6/22 16:53, Aaron Conole wrote:
Dumitru Ceara writes:
> On 4/5/22 21:20, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> On 4/5/22 16:41, Aaron Conole
From: ldejing
Implementation on Windows:
Currently, IPv4 conntrack was supported on the windows platform.
In this patch we have implemented ipv6 conntrack functions according
to the current logic of the IPv4 conntrack. This implementation has
included TcpV6(nat and normal scenario), UdpV6(nat
References: <20220411071810.41542-1-svc.ovs-commun...@vmware.com>
Bleep bloop. Greetings ldejing, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
reading sources... [ 88%]
From: ldejing
Implementation on Windows:
Currently, IPv4 conntrack was supported on the windows platform.
In this patch we have implemented ipv6 conntrack functions according
to the current logic of the IPv4 conntrack. This implementation has
included TcpV6(nat and normal scenario), UdpV6(nat
23 matches
Mail list logo
