On 5/9/22 22:41, Mark Michelson wrote:
Hi Adrian,
Since this is an RFC series, I haven't taken a deep look at the code, so I
apologize if my comments below are not correct.
Thank you very much for the feedback Mark.
On 4/25/22 07:17, Adrian Moreno wrote:
Very often when troubleshooting
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#27 FILE: controller/physical.c:429:
The localport should always delegate traffic locally,
move the definition into consider_port_binding as
the physical_run is not evaluated during I-P.
Fixes: 3ae8470 ("I-P: Handle runtime data changes for pflow_output engine.")
Signed-off-by: Ales Musil
---
controller/physical.c | 44
When the "ovn-chassis-mac-mappings" had wrong format it would
crash the ovn-controller as it tried to deref NULL pointer.
Add check if the token is a valid pointer, if not log warning
and skip this value.
Reported-at: https://bugzilla.redhat.com/2082341
Signed-off-by: Ales Musil
---
controller/
On Mon, May 9, 2022 at 5:36 PM Xavier Simonart wrote:
>
> Hi Mark, Han
>
> Thanks for looking into this.
> Han's patch is addressing the issues I initially tried fixing with
https://patchwork.ozlabs.org/project/ovn/patch/20220401101640.1139426-1-xsimo...@redhat.com/
>
https://patchwork.ozlabs.org/
Hi Mark, Han
Thanks for looking into this.
Han's patch is addressing the issues I initially tried fixing with
https://patchwork.ozlabs.org/project/ovn/patch/20220401101640.1139426-1-xsimo...@redhat.com/
https://patchwork.ozlabs.org/project/ovn/patch/20220401101640.1139426-1-xsimo...@redhat.com/
is
When a nat rule is configured in stateless mode there is a 1:1 mapping
between external_ip and logical_ip. Do not modify dst/src ips in
S_ROUTER_IN_UNSNAT/S_ROUTER_OUT_UNDNAT stages for stateless nat entries
since they will be properly modified in S_ROUTER_IN_DNAT/S_ROUTER_OUT_SNAT
stages.
This pat
Thanks for the rebase, Lorenzo.
I pushed this to main, branch-22.03, and branch-21.12.
On 5/9/22 16:24, Lorenzo Bianconi wrote:
Use cidr_bits instead of ovs_be32 mask to compute logical flows
priority for nat rules if exempted_ext_ips is specified.
This patch fix an issue for IPv6 snat where ex
I applied this patch to main, branch-22.03, and branch-21.12.
On 4/22/22 14:28, Mark Michelson wrote:
Looks good to me Lorenzo, thanks!
Acked-by: Mark Michelson
On 4/20/22 12:15, Lorenzo Bianconi wrote:
Check if vlans are enabled on a localnet port running on the logical
switch connected to
Hi Adrian,
Since this is an RFC series, I haven't taken a deep look at the code, so
I apologize if my comments below are not correct.
On 4/25/22 07:17, Adrian Moreno wrote:
Very often when troubleshooting networking issues in an OVN cluster one
would like to know if any packet (or a specific
Use cidr_bits instead of ovs_be32 mask to compute logical flows
priority for nat rules if exempted_ext_ips is specified.
This patch fix an issue for IPv6 snat where exempted_ext_ips
configuration does not take effect.
Acked-by: Mark Michelson
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?
Based on the explanation and the code, this seems to solve the problem
of the spurious recomputes. I'd like confirmation from Xavier that this
is fixing the issue he was addressing in
https://patchwork.ozlabs.org/project/ovn/patch/20220401101640.1139426-1-xsimo...@redhat.com/
, and I'd also lik
From: Mary Manohar
Signed-off-by: Mary Manohar
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index e284704..e7dc537 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -908,7 +908,9 @@ clai
Hi Lorenzo,
I was going through old patches and noticed this one had not been
merged, even though it was acked a long time ago. The problem is that it
no longer applies cleanly. Can you please rebase this patch and post it
again? I'll merge it ASAP.
Thanks,
Mark
On 4/14/22 13:26, Mark Miche
Hi Lorenzo,
Please add the following to the commit message:
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2066990
I have a few more things below.
On 3/29/22 09:39, Lorenzo Bianconi wrote:
When a nat rule is configured in stateless mode there is a 1:1 mapping
between external_ip and
On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote:
Hi Ihar,
> On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> > Hi Abhiram,
> >
> > thanks for sending the patch.
>
> Thanks for spening time to review it.
>
> >
> > This is *not* a comprehensive review. This is an
Max allowed userspace dp conntrack entries is configurable with
'ovs-appctl dpctl/ct-set-maxconns' command. In real scenarios,
this configuration is expected to survive from host reboot, from
ovs service restart.
Signed-off-by: lic121
---
Notes:
v2:
- rename "ct-maxconns" to "userspace
On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> Hi Abhiram,
>
> thanks for sending the patch.
Thanks for spening time to review it.
>
> This is *not* a comprehensive review. This is an attempt to clarify
> the scope of the feature, its potential crossover with other pending
>
On 30 Apr 2022, at 6:47, lic121 wrote:
> ipfix cfg creation/deleting triggers revalidation. But this does
> not cover the case where ipfix options changes, which also suppose
> to trigger revalidation.
>
> Fixes: a9f5ee1199e1 ("ofproto-dpif: Trigger revalidation when ipfix config
> set.")
> Si
>From the commit 25070e045e, bundle option has be used with OpenFlow 1.3
Signed-off-by: yangchang
---
utilities/ovs-ofctl.8.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index e903ca1..35f4dea 100644
--- a/ut
On 29 Apr 2022, at 19:40, Aaron Conole wrote:
> This reverts commit c645550bb249 ("odp-util: Always report
> ODP_FIT_TOO_LITTLE for IGMP.")
>
> Always forcing a slow path action can result in some over-broad
> flows which swallow all traffic and force them to userspace, as reported
> in the thre
On 1 May 2022, at 4:17, Peng He wrote:
> add a rcu_barrier before close_dpif_backer to ensure that
> all meters has been freed before id_pool_destory meter's
> id-pool.
>
> Signed-off-by: Peng He
> Tested-by: David Marchand
> ---
> ofproto/ofproto-dpif.c | 2 ++
> 1 file changed, 2 insertion
On 1 May 2022, at 4:17, Peng He wrote:
> rcu_barrier will block the current thread until all the postponed
> rcu job has been finished. it's like the OVS's version of
> the kernel rcu_barrier()
>
> Signed-off-by: Peng He
> Co-authored-by: Eelco Chaudron
> ---
> lib/ovs-rcu.c | 28
>From the commit 25070e045e, bundle option has be used with OpenFlow 1.3
Signed-off-by: yangchang
---
utilities/ovs-ofctl.8.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index e903ca12b..35f4dea80 100644
---
24 matches
Mail list logo
