Re: [ovs-dev] [RFC] classifier: change segment 3 boundary to defer dependant processing

2022-05-11 Thread Ben Pfaff
Hi Aaron! This will move the following fields from the L4 segment to the L3 segment: struct in6_addr nd_target; /* IPv6 neighbor discovery (ND) target. */ struct eth_addr arp_sha;/* ARP/ND source hardware address. */ struct eth_addr arp_tha;/* ARP/ND target hardware address.

Re: [ovs-dev] [PATCH ovn] docs: fix a typo in bandwidth column name

2022-05-11 Thread Mark Michelson
Thanks, Ihar. I pushed this to main, branch-22.03, and branch-21.12. On 4/29/22 13:03, Ihar Hrachyshka wrote: Signed-off-by: Ihar Hrachyshka --- ovn-nb.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn-nb.xml b/ovn-nb.xml index 9010240a8..e9ad002a0 100644 ---

Re: [ovs-dev] [PATCH ovn] nb: Add Load_Balancer.options:neighbor_responder knob.

2022-05-11 Thread Mark Michelson
Thanks for this Dumitru. Acked-by: Mark Michelson On 4/28/22 11:33, Dumitru Ceara wrote: This allows CMS to tweak the way logical routers reply to ARP/ND packets targeting load balancer VIPs. By default a router only replies for VIPs that are reachable locally (they're part of a subnet

Re: [ovs-dev] [RFC PATCH ovn 0/3] Add ovn drop debugging

2022-05-11 Thread Mark Michelson
On 5/10/22 12:27, Adrian Moreno wrote: [...] Some good alternatives to using the lflow UUID as a datapath identifier would be * The value of the OXM_METADATA register. * The southbound datapath_binding UUID. If we use any of these identifiers, we would know what datapath dropped the

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Add missing socat package

2022-05-11 Thread Mark Michelson
I merged this to main, branch-22.03, and branch-21.12. On 5/11/22 07:34, Dumitru Ceara wrote: On 4/29/22 09:43, Ales Musil wrote: Signed-off-by: Ales Musil --- Acked-by: Dumitru Ceara Mark, Numan, could we get this merged soon please, it makes the ovn-kubernetes CI run green again:

[ovs-dev] [PATCH] python: use setuptools instead of distutils

2022-05-11 Thread Timothy Redaelli
On Python 3.12, distutils will be removed and it's currently (3.10+) deprecated (see PEP 632). Since the suggested and simplest replacement is setuptools, this commit replaces distutils to use setuptools instead. Signed-off-by: Timothy Redaelli --- python/setup.py | 9 - 1 file

Re: [ovs-dev] MFEX tests failing

2022-05-11 Thread Amber, Kumar
Hi Eelco, Thanks for pointing out, I have updated a patch with the fix for the two problems you were witnessing. The patch also contains improvements to the MFEX testing as well like reducing the packet generation time, Script generating more complicated traffic for testing corner cases like

[ovs-dev] [PATCH v2] tests/mfex: Improve pcap script for mfex tests.

2022-05-11 Thread Kumar Amber
The mfex pcap generation script is improved for varied length traffic and also removes the hard coded mfex_pcap and instead uses the script itself to generate complex traffic patterns for testing. Signed-off-by: Kumar Amber Acked-by: Cian Ferriter --- v2: - Add huge page test-skip. - Change

[ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

2022-05-11 Thread lmartins
From: Lucas Alvares Gomes In order to PXE boot a baremetal server using the OVN DHCP server we need to allow users to set the "next-server" (siaddr) [0] field in the DHCP header. While investigating this issue by comparing the DHCPOFFER and DHCPACK packets sent my dnsmasq and OVN we saw that

Re: [ovs-dev] [PATCH ovn v2] Do not set 'up' attribute in the port-binding table if ovn-northd is at an older version.

2022-05-11 Thread Xavier Simonart
Hi Mark This is fixing a backward compatibility issue when using an older ovn-northd. ovn-controller should only set Port_Binding.up field if the Southbound DB is aware of this field (or transaction would fail). We already do this when setting pb up through notification (if-status module). More

[ovs-dev] [RFC] classifier: change segment 3 boundary to defer dependant processing

2022-05-11 Thread Aaron Conole
During flow processing, the flow wildcards are checked as a series of stages, and these stages are intended to carry dependencies in a single direction. When the neighbor discovery processing, for example, was executed there is an incorrect dependancy chain - we need fields from stage 4 to

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix ALB 'rebalance_intvl' max hard limit.

2022-05-11 Thread 0-day Robot
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author linhuang needs to sign off. WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Fix ALB parameters type mismatch.

2022-05-11 Thread 0-day Robot
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author linhuang needs to sign off. WARNING: Unexpected sign-offs from developers who are

[ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix ALB 'rebalance_intvl' max hard limit.

2022-05-11 Thread miterv
From: linhuang Currently the pmd-auto-lb-rebal-interval's value was not been checked properly. It maybe a negative, or too big value (>2 weeks between rebalances), which will be lead to a big unsigned value. So reset it to default if the value exceeds the max permitted as described in

[ovs-dev] [PATCH v2 1/2] dpif-netdev: Fix ALB parameters type mismatch.

2022-05-11 Thread miterv
From: linhuang The ALB parameters should never be negative. So it's to use unsigned smap_get versions to get it properly. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang --- lib/dpif-netdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[ovs-dev] [PATCH v2 0/2] Fix ALB parameters type and value mismatch.

2022-05-11 Thread miterv
From: Lin Huang Changes since v1: 1. Fix the commit message and formatting. 2. Fix typo in unit tests. Lin Huang (2): dpif-netdev: Fix ALB parameters type mismatch. dpif-netdev: Fix ALB 'rebalance_intvl' max hard limit. lib/dpif-netdev.c | 20 tests/alb.at |

Re: [ovs-dev] [PATCH 2/2] dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit.

2022-05-11 Thread lin huang
Hi Kevin, Thanks for the review, much appreciated. I will send a new patch later. > -Original Message- > From: Kevin Traynor > Sent: Wednesday, May 11, 2022 12:16 AM > To: lin huang ; ovs-dev@openvswitch.org > Subject: Re: [PATCH 2/2] dpif-netdev : Fix ALB 'rebalance_intvl' max hard >

Re: [ovs-dev] OVS with AF_XDP build error

2022-05-11 Thread Eelco Chaudron
On 11 May 2022, at 12:48, Ilya Maximets wrote: > On 5/11/22 11:18, Eelco Chaudron wrote: >> Hi William, >> >> I was conducting some datapath tests and thought I could quickly include >> some af_xdp, but I ran into a build error. >> As I’m not using AF_XDP normally, I did not further

Re: [ovs-dev] [PATCH ovn] northd: Mark most of the SB columns as write-changed-only.

2022-05-11 Thread Dumitru Ceara
On 5/6/22 07:17, Han Zhou wrote: > On Wed, May 4, 2022 at 4:22 PM Han Zhou wrote: >> >> >> >> On Wed, May 4, 2022 at 3:44 PM Numan Siddique wrote: >>> >>> On Tue, May 3, 2022 at 7:32 PM Han Zhou wrote: On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara > wrote: > > This uses the

[ovs-dev] [PATCH v1 1/1] datapath-windows: Add IPv6 conntrack ip fragment support on windows

2022-05-11 Thread ldejing
From: ldejing Implementation on Windows: IPv6 conntrack ip fragment feature use a link list to store ip fragment. When ipv6 fragment module receives a fragment packet, it will store length of the fragment, until to the received length equal to the packet length before fragmented, it will

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Add missing socat package

2022-05-11 Thread Dumitru Ceara
On 4/29/22 09:43, Ales Musil wrote: > Signed-off-by: Ales Musil > --- Acked-by: Dumitru Ceara Mark, Numan, could we get this merged soon please, it makes the ovn-kubernetes CI run green again: https://github.com/ovsrobot/ovn/actions/runs/2244105281 Thanks, Dumitru >

Re: [ovs-dev] OVS with AF_XDP build error

2022-05-11 Thread Ilya Maximets
On 5/11/22 11:18, Eelco Chaudron wrote: > Hi William, > > I was conducting some datapath tests and thought I could quickly include some > af_xdp, but I ran into a build error. > As I’m not using AF_XDP normally, I did not further investigate, but it might > be something for you to look at: > >

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Add IPv6 conntrack ip fragment support on windows

2022-05-11 Thread 0-day Robot
References: <20220511101426.42195-1-svc.ovs-commun...@vmware.com> Bleep bloop. Greetings ldejing, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author ldejing needs

[ovs-dev] [PATCH v1 1/1] datapath-windows: Add IPv6 conntrack ip fragment support on windows

2022-05-11 Thread ldejing
Implementation on Windows: IPv6 conntrack ip fragment feature use a link list to store ip fragment. When ipv6 fragment module receives a fragment packet, it will store length of the fragment, until to the received length equal to the packet length before fragmented, it will reassemble fragment

Re: [ovs-dev] [PATCH 1/2] dpif-netdev : Fix ALB parameters type mismatch.

2022-05-11 Thread Kevin Traynor
On 10/05/2022 17:00, Mike Pattrick wrote: On Sat, May 7, 2022 at 1:10 PM lin huang wrote: The ALB parameters should never be negative. So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by:

[ovs-dev] OVS with AF_XDP build error

2022-05-11 Thread Eelco Chaudron
Hi William, I was conducting some datapath tests and thought I could quickly include some af_xdp, but I ran into a build error. As I’m not using AF_XDP normally, I did not further investigate, but it might be something for you to look at: /bin/sh ./libtool --tag=CC

[ovs-dev] [PATCH v2] ovs-save: Get highest ofp version error.

2022-05-11 Thread Han Ding
When setting just one ofp version to protocols of bridge, The function get_highest_ofp_version in ovs-save parse it error. For example: $ ovs-vsctl get bridge br-int protocols [OpenFlow15] $ ovs-vsctl get bridge br-int protocols | sed 's/[][]//g' | sed 's/\ //g' | awk -F ',' '{ print (NF>1)?

[ovs-dev] [PATCH v7] dpcls: Change info-get function to fetch dpcls usage stats.

2022-05-11 Thread Kumar Amber
Modified the dplcs info-get command output to include the count for different dpcls implementations. $ovs-appctl dpif-netdev/subtable-lookup-info-get Available dpcls implementations: autovalidator (Use count: 1, Priority: 5) generic (Use count: 0, Priority: 1) avx512_gather (Use count: 0,

[ovs-dev] MFEX tests failing

2022-05-11 Thread Eelco Chaudron
Hi Kumar, I’m playing around with some of the dapapath tests suites, and I noticed two problems with the MFEX tests that need fixing: If no Hughe pages are configured, two mfex tests are not skipped/passing (I do not have an MFEX machine so the MFEX Autovalidator Fuzzy might also be failing):