Re: [ovs-dev] [PATCH v3] tests/mfex: Improve pcap script for mfex tests.

Hi Eelco, Thanks again for reviews . Please find my replies inline. > > +tcp = TCP(dport=RandShort(), sport=RandShort(), flags='S', > > + dataofs=random.randint(0, 15)) > > Maybe a new line before the command, as it was before. > Fixed in next version. > > +

Re: [ovs-dev] [v4 4/8] netdev-linux: Add functions to manipulate tc police action

On Mon, 2022-05-23 at 12:12 +0200, Eelco Chaudron wrote: > > > On 17 May 2022, at 14:54, Jianbo Liu wrote: > > > On Fri, 2022-05-13 at 16:55 +0200, Eelco Chaudron wrote: > > > > > > > > > On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: > > > > > > > Add helpers to add, delete and get stats

Re: [ovs-dev] [v4 1/8] netdev-offload: Add meter offload API

On Mon, 2022-05-23 at 11:59 +0200, Eelco Chaudron wrote: > > > On 16 May 2022, at 12:31, Jianbo Liu wrote: > > > On Fri, 2022-05-13 at 13:46 +0200, Eelco Chaudron wrote: > > > > > > > > > On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: > > > > > > > Add API to offload meter to HW, and the c

Re: [ovs-dev] [PATCH] [RFC] [ovn] northd: Fix IGMP external subscriber subscribing to internal feed

> On 24 May 2022, at 00:15, Dumitru Ceara wrote: > > On 5/3/22 17:15, Alin-Gabriel Serdean wrote: >> Add localnet ports to their corresponding southbound multicast group. >> >> Update unit tests. >> >> Reported-at: https://github.com/ovn-org/ovn/issues/125 >> Reported-by: Diko Parvanov >> S

Re: [ovs-dev] [PATCH ovn branch-21.12 5/6] ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.

On Mon, May 23, 2022 at 12:39 PM Dumitru Ceara wrote: > > From: Han Zhou > > Add an engine node en_northd_internal_version as an input to > en_lflow_output. When this node is updated, it triggers a recompute for > en_lflow_output. This node adds SB_Global as its only input, and it is > updated on

Re: [ovs-dev] [PATCH] [RFC] [ovn] northd: Fix IGMP external subscriber subscribing to internal feed

On 5/3/22 17:15, Alin-Gabriel Serdean wrote: > Add localnet ports to their corresponding southbound multicast group. > > Update unit tests. > > Reported-at: https://github.com/ovn-org/ovn/issues/125 > Reported-by: Diko Parvanov > Suggested-by: Dumitru Ceara > Signed-off-by: Alin-Gabriel Serdean

Re: [ovs-dev] [PATCH] ovsdb: raft: Fix transaction double commit due to lost leadership.

On 5/23/22 01:58, Han Zhou wrote: > > > Thanks Ilya for addressing this problem! Please see some comments below: > On Thu, May 5, 2022 at 5:24 AM Ilya Maximets > wrote: >> >> While becoming a follower, the leader completes all the current > nit: The word "completes" he

Re: [ovs-dev] [PATCH ovn branch-21.12 1/6] ovn-sb.xml: Fix ct_lb documentation.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers

Re: [ovs-dev] [PATCH ovn v4 0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

On 5/23/22 20:07, Han Zhou wrote: > On Tue, Mar 29, 2022 at 3:06 PM Han Zhou wrote: >> >> >> >> On Tue, Mar 29, 2022 at 2:20 PM Numan Siddique wrote: >>> >>> On Mon, Mar 28, 2022 at 1:40 AM Han Zhou wrote: Some NICs support HW offloading for datapath flows, but masked access > to

[ovs-dev] [PATCH ovn branch-21.12 5/6] ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.

From: Han Zhou Add an engine node en_northd_internal_version as an input to en_lflow_output. When this node is updated, it triggers a recompute for en_lflow_output. This node adds SB_Global as its only input, and it is updated only when SB_Global's options:northd_internal_version is updated. In

[ovs-dev] [PATCH ovn branch-21.12 4/6] ovn-northd: Improve the doc and tests for ecmp-symmetric-reply.

From: Han Zhou 1. The ovn-northd.8.xml didn't cover the flow in the lr_in_arp_resolve stage. 2. The original test didn't really test the ecmp-symmetric-reply because the option takes effect only for gateway routers. This patch set the chassis to make the router a gateway router. Also, a

[ovs-dev] [PATCH ovn branch-21.12 3/6] actions: Add stack push and pop actions.

From: Han Zhou Add two new actions push & pop for stack operations. Signed-off-by: Han Zhou Acked-by: Numan Siddique (cherry picked from commit 8ce847737f2db7b82b2e0296ff3b39551393d839) Signed-off-by: Dumitru Ceara --- include/ovn/actions.h |8 + lib/actions.c | 73 +++

[ovs-dev] [PATCH ovn branch-21.12 2/6] actions: Add action ct_lb_mark.

From: Han Zhou Add a new action ct_lb_mark, which is the same as ct_lb except that it internally uses ct_mark to store the NAT flag, while ct_lb uses ct_label for the same purpose. This will be used later to move the masked access of ct_label to ct_mark while keeping the backward compatibility.

[ovs-dev] [PATCH ovn branch-21.12 1/6] ovn-sb.xml: Fix ct_lb documentation.

From: Han Zhou The documentation of the ct_lb action wasn't up to date. Add the description for backends and hash_fields. Fixes: 5af304e7478a ("Support selection fields in load balancer.") Signed-off-by: Han Zhou Acked-by: Numan Siddique (cherry picked from commit 9eb7b4ec75e6773eb8f1770cc03f2

[ovs-dev] [PATCH ovn branch-21.12 0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

This is a series to explicitly backport a075230e4a0f ("Use ct_mark for masked access to make flows HW-offloading friendly.") and its dependencies to branch-21.12. The conflicts were minimal, mainly due to the lack of the "ACL log-related" feature on branch-21.12. Han Zhou (6): ovn-sb.xml: F

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

On 5/19/22 20:04, Gregory Rose wrote: > > > On 4/15/2022 2:42 PM, Greg Rose wrote: >> It is time to remove support for the OVS kernel driver and push >> towards use of the upstream Linux openvswitch kernel driver >> in it's place [1]. >> >> This patch series represents a first attempt but there a

[ovs-dev] [PATCH ovn] test: Make vtep test pass more consistently.

The "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" test fails consistently on PPC. The test expects a flow with the following to be present: is_chassis_resident("cr-lrp1") || is_chassis_resident("cr-lrp2") However, on PPC, the test fails because the flow has the following instead: is_chassis_resident("cr-

Re: [ovs-dev] [PATCH ovn v4 0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

On Tue, Mar 29, 2022 at 3:06 PM Han Zhou wrote: > > > > On Tue, Mar 29, 2022 at 2:20 PM Numan Siddique wrote: > > > > On Mon, Mar 28, 2022 at 1:40 AM Han Zhou wrote: > > > > > > Some NICs support HW offloading for datapath flows, but masked access to > > > the 128-bit ct_label field may prevent

Re: [ovs-dev] [PATCH v2] handlers: Fix handlers mapping

On 5/23/22 18:03, Michael Santana wrote: > On Thu, May 19, 2022 at 8:26 PM Ilya Maximets wrote: >> >> On 5/19/22 23:02, Aaron Conole wrote: >>> Ilya Maximets writes: >>> On 5/5/22 05:52, Michael Santana wrote: > On Mon, Apr 25, 2022 at 2:32 PM Ilya Maximets wrote: >> >> On 4/19/

Re: [ovs-dev] [PATCH v2] handlers: Fix handlers mapping

On Thu, May 19, 2022 at 8:26 PM Ilya Maximets wrote: > > On 5/19/22 23:02, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> On 5/5/22 05:52, Michael Santana wrote: > >>> On Mon, Apr 25, 2022 at 2:32 PM Ilya Maximets wrote: > > On 4/19/22 05:19, Michael Santana wrote: > > On T

Re: [ovs-dev] [ovs-discuss] Commit 355fef6f2 seems to break connectivity in my setup

On 5/21/22 12:49, Frode Nordahl wrote: > On Thu, May 19, 2022 at 3:39 PM Frode Nordahl > wrote: >> >> On Sat, May 14, 2022 at 2:10 AM Ilya Maximets wrote: >>> >>> On 5/13/22 10:36, Frode Nordahl wrote: On Fri, Mar 11, 2022 at 2:04 PM Liam Young wrote: > > Hi, > > Comm

[ovs-dev] OVS+OVS '22: Call for Participation

Greetings, After a long hiatus of in-person events, we are pleased to announce that the Open vSwitch and OVN projects will host their ninth annual conference focused on Open vSwitch and OVN on November 8-10, 2022, in the Red Hat offices in Westford, Massachusetts (near Boston). We will closely mo

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

On 17 May 2022, at 13:10, Eelco Chaudron wrote: > On 12 May 2022, at 12:08, Vlad Buslov wrote: > >> On Thu 12 May 2022 at 12:19, Eelco Chaudron wrote: >>> On 7 Apr 2022, at 12:22, Ilya Maximets wrote: >>> On 4/7/22 10:02, Vlad Buslov wrote: > On Mon 14 Mar 2022 at 20:40, Ilya Maximets

Re: [ovs-dev] [PATCH ovn v2 1/2] Prepare for 22.06.0.

On 5/19/22 16:29, Numan Siddique wrote: On Thu, May 19, 2022 at 4:15 PM Mark Michelson wrote: Signed-off-by: Mark Michelson --- NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: No clone when tunnel push is last action

On 5/20/22 04:42, Rosemarie O'Riorden wrote: > When OVS sees a tunnel push with a nested list next, it will not > clone the packet, as a clone is not needed. However, a clone action will > still be created with the tunnel push encapulated inside. There is no > need to create the clone action in thi

Re: [ovs-dev] [v4 4/8] netdev-linux: Add functions to manipulate tc police action

On 17 May 2022, at 14:54, Jianbo Liu wrote: > On Fri, 2022-05-13 at 16:55 +0200, Eelco Chaudron wrote: >> >> >> On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: >> >>> Add helpers to add, delete and get stats of police action with >>> the specified index. >> >> See inline comments… This is the

Re: [ovs-dev] [v4 2/8] tc: Add support parsing tc police action

On 17 May 2022, at 11:25, Jianbo Liu wrote: > On Fri, 2022-05-13 at 14:28 +0200, Eelco Chaudron wrote: >> >> >> On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: >> >>> Add function to parse police action from netlink message, and meter >>> id >>> can be retrieved from action cockie as it will b

Re: [ovs-dev] [v4 1/8] netdev-offload: Add meter offload API

On 16 May 2022, at 12:31, Jianbo Liu wrote: > On Fri, 2022-05-13 at 13:46 +0200, Eelco Chaudron wrote: >> >> >> On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: >> >>> Add API to offload meter to HW, and the corresponding functions to >>> call >>> the meter callbacks from all the registered flo

Re: [ovs-dev] [v4 8/8] dpif-netlink: Offloading meter to tc police action

On 16 May 2022, at 12:02, Jianbo Liu wrote: > On Fri, 2022-05-13 at 11:48 +0200, Eelco Chaudron wrote: >> >> >> On 3 May 2022, at 5:08, Jianbo Liu via dev wrote: >> >>> OVS meters are created in advance and openflow rules refer to them >>> by >>> their unique ID. New tc_police API is used to off

Re: [ovs-dev] [PATCH v3] tests/mfex: Improve pcap script for mfex tests.

On 18 May 2022, at 11:34, Kumar Amber wrote: > The mfex pcap generation script is improved for varied length > traffic and also removes the hard coded mfex_pcap and instead uses > the script itself to generate complex traffic patterns for testing. > > Signed-off-by: Kumar Amber > Acked-by: Cian

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

Eelco Chaudron 于2022年5月23日周一 17:25写道： > > > On 23 May 2022, at 11:13, Peng He wrote: > > > there are two tests: > > > > 1) check the usage of this api in a normal file > > 2) if the api is defined in its own file, which is specified in the > > 'location' field in checkpatch.py, the warning should

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

On 23 May 2022, at 11:13, Peng He wrote: > there are two tests: > > 1) check the usage of this api in a normal file > 2) if the api is defined in its own file, which is specified in the > 'location' field in checkpatch.py, the warning should be skipped. > > So, either use a new macro, either mak

Re: [ovs-dev] [PATCH] ovs-save: add bindir to PATH

Hello Adrian, On Fri, May 6, 2022 at 3:52 PM Adrian Moreno wrote: > >> If openvswitch is not installed in the default system's path ovs-save > >> script will fail to find the tools it requires. > >> > >> Fix this by adding $bindir to the PATH. > > > > Seeing how we have similar code in other scri

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

there are two tests: 1) check the usage of this api in a normal file 2) if the api is defined in its own file, which is specified in the 'location' field in checkpatch.py, the warning should be skipped. So, either use a new macro, either make COMMON_PATCH_HEADER a macro with a specified filename.

Re: [ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

On Thu, May 19, 2022 at 10:05 PM Numan Siddique wrote: > > On Thu, May 19, 2022 at 4:11 AM Lucas Alvares Gomes > wrote: > > > > Hi, > > > > Thanks Numan for the review. See the replies below. > > > > On Thu, May 19, 2022 at 12:36 AM Numan Siddique wrote: > > > > > > On Wed, May 11, 2022 at 11:3

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

On 23 May 2022, at 10:56, Peng He wrote: > Eelco Chaudron 于2022年5月23日周一 16:04写道： > >> >> >> On 20 May 2022, at 12:24, Peng He wrote: >> >>> Signed-off-by: Peng He >>> Signed-off-by: Peng He >>> Acked-by: Eelco Chaudron >>> Acked-by: Aaron Conole >> >> You should remove any ACKs if you re-se

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

Eelco Chaudron 于2022年5月23日周一 16:04写道： > > > On 20 May 2022, at 12:24, Peng He wrote: > > > Signed-off-by: Peng He > > Signed-off-by: Peng He > > Acked-by: Eelco Chaudron > > Acked-by: Aaron Conole > > You should remove any ACKs if you re-send the patch with changes. In > addition only sending

[ovs-dev] [PATCH ovn 1/2] physical.c: Move localport remote output flow definition

The localport should always delegate traffic locally, move the definition into consider_port_binding as the physical_run is not evaluated during I-P. Reported-at: https://bugzilla.redhat.com/2076604 Signed-off-by: Ales Musil --- controller/physical.c | 44 ++--

[ovs-dev] [PATCH ovn 2/2] binding.c: Make sure that localport is removed from local datapath

When localport is removed from NB, and it is the last port remaining on the host, it is not part of local datapath anymore. Which can cause troubles when there is recompute happening in between the removal from NB and the removal of interface from host. The localport would stay in lport_ids set, so

[ovs-dev] [PATCH ovn 0/2] Fix localport physical flows issues.

This patch series fixes two issues with localport. The first one being that the table 37 flow is not populated on I-P updates and is being left behind on removal of localport. The second one is removal of localport from controller sets, not being removed prevent the flows to be created for newly

Re: [ovs-dev] [PATCH v5] checkpatch.py: add checks for experimental API.

On 20 May 2022, at 12:24, Peng He wrote: > Signed-off-by: Peng He > Signed-off-by: Peng He > Acked-by: Eelco Chaudron > Acked-by: Aaron Conole You should remove any ACKs if you re-send the patch with changes. In addition only sending this patch out of the series is confusing, so you need