[ovs-dev] [RFC ovn 2/2] RFC: ovn-controller: Attach XDP progs to the VIFs of the logical ports.

2022-05-30 Thread numans
From: Numan Siddique This patch attaches and detaches xdp programs by ovn-controller when it claims or releases a logical port. XDP program - ovn_xdp.c added in this patch implements basic port security and drops any packet if the port security check fails. There are still few TODOs in the port

[ovs-dev] [RFC ovn 1/2] RFC: Add basic xdp/eBPF support in OVN.

2022-05-30 Thread numans
From: Numan Siddique This patch just adds an xdp program and the support in the Makefile to compile it. A separate target is added in the Makefile. To compile, user has to run: 'make bpf'. Signed-off-by: Numan Siddique --- Makefile.am | 6 +- bpf/.gitignore | 5 +

[ovs-dev] [RFC ovn 0/2] Basic eBPF/XDP support in OVN.

2022-05-30 Thread numans
From: Numan Siddique XDP program - ovn_xdp.c added in this RFC patch series implements basic port security and drops any packet if the port security check fails. There are still few TODOs in the port security checks. Like - Make ovn xdp configurable. - Removing the ingress Openflow

Re: [ovs-dev] [PATCH ovn] ci: Add UB Sanitizer.

2022-05-30 Thread Numan Siddique
On Mon, May 30, 2022 at 3:15 PM Dumitru Ceara wrote: > > Pick up latest OVS UB fixes too, specifically: > c8c49a9db9f2 ("netdev-linux: Properly access 32-bit aligned > rtnl_link_stats64 structs.") > a5cc859a4228 ("ofp-actions: Use aligned structures when decoding ofp > actions.") >

[ovs-dev] [PATCH ovn] ci: Add UB Sanitizer.

2022-05-30 Thread Dumitru Ceara
Pick up latest OVS UB fixes too, specifically: c8c49a9db9f2 ("netdev-linux: Properly access 32-bit aligned rtnl_link_stats64 structs.") a5cc859a4228 ("ofp-actions: Use aligned structures when decoding ofp actions.") 08c3e5e37eee ("ofp-errors: Ensure parsed OFPT_ERROR messages are properly

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix internal CT state for non-recirc traffic.

2022-05-30 Thread Frode Nordahl
In some circumstances a flow may get its ct_state set without conscious intervention by the OVS user space code. Commit 355fef6f2ccbc optimizes out uneccessary ct_clear actions based on an internal struct xlate_ctx->conntracked state flag. Before this commit the xlate_ctx->conntracked state flag

Re: [ovs-dev] [Patch ovn] OVN - Add Support for Remote Port Mirroring

2022-05-30 Thread Numan Siddique
Hi Abhiram, Thanks for the patch. Please see below for some comments. On Mon, May 9, 2022 at 12:14 PM Abhiram R N wrote: > > On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote: > > Hi Ihar, > > > > > On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote: > > > Hi Abhiram,

Re: [ovs-dev] [PATCH v8 1/4] mfex_avx512: Calculate pkt offsets at compile time.

2022-05-30 Thread Van Haaren, Harry
> -Original Message- > From: Amber, Kumar > Sent: Thursday, May 26, 2022 11:09 AM > To: ovs-dev@openvswitch.org > Cc: echau...@redhat.com; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian ; > david.march...@redhat.com; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kumar > Subject:

Re: [ovs-dev] [PATCH ovn] OVN-CI: remove ddlog test cases.

2022-05-30 Thread Dumitru Ceara
On 5/30/22 10:28, Mohammad Heib wrote: > currently there is no new changes applied to the ddlog code base > in ovn and we keep skipping ddlog test cases in our ci runs which leads > to so many skips lines printed to the ci logs and that cause us to miss > some tests cases that were skipped because

Re: [ovs-dev] [ovs-discuss] Commit 355fef6f2 seems to break connectivity in my setup

2022-05-30 Thread Frode Nordahl
On Fri, May 27, 2022 at 10:04 PM Ilya Maximets wrote: > > On 5/26/22 14:53, Frode Nordahl wrote: > > > > > > tor. 26. mai 2022, 14:45 skrev Ilya Maximets > >: > > > > On 5/26/22 13:00, Frode Nordahl wrote: > > > On Wed, May 25, 2022 at 9:55 AM Frode Nordahl > >

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-05-30 Thread Roi Dayan via dev
On 2022-03-22 2:04 PM, Tao Liu wrote: If netdev goes away(i.e. qemu with a vnet shutdown), kernel delete all tc filters, those tcf_id related to the netdev will be left in ufid_to_tc hashmap. When qemu restart with a same vnet but different ifindex assigned, a dup ufid may add. Especially

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-05-30 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #41 FILE: lib/netdev-dpdk.c:1126:

[ovs-dev] [PATCH 0/3] Rework the usage of DPDK transfer flow offloads

2022-05-30 Thread Ivan Malov
DPDK has got support for offloads involving assignment of per-packet Rx metadata (flag, mark, tunnel ID and the likes). However, delivery of such metadata from the NIC to the PMD might need to be negotiated in advance. API [1] addresses that problem. Make OvS invoke this API. Another problem is

[ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-05-30 Thread Ivan Malov
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 73 ---

[ovs-dev] [PATCH 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2022-05-30 Thread Ivan Malov
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-offload-dpdk.c | 32 1 file changed, 32 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-05-30 Thread Ivan Malov
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 44 1 file changed, 44 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index f9535bfb4..45e5d26d2

Re: [ovs-dev] [PATCH v4] odp_util: Fix parse_key_and_mask_to_match() vlan parsing

2022-05-30 Thread Roi Dayan via dev
On 2022-03-22 11:35 AM, Eelco Chaudron wrote: The parse_key_and_mask_to_match() is a function to translate a netlink formatted key/mask to match structure. And should not consider any configuration setting when translating. In addition we also enforce the encap_eth_type[0] mask as it's

[ovs-dev] [PATCH ovn] OVN-CI: remove ddlog test cases.

2022-05-30 Thread Mohammad Heib
currently there is no new changes applied to the ddlog code base in ovn and we keep skipping ddlog test cases in our ci runs which leads to so many skips lines printed to the ci logs and that cause us to miss some tests cases that were skipped because of missing packages or any other reason.