Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 7 Jun 2022 21:39:55 -0700 you wrote: > Netdev reference helpers have a dev_ prefix for historic > reasons. Renaming the old helpers would be too much churn > but we can rename the tracking ones which are

Re: [ovs-dev] [PATCH ovn v2] northd: Determine gateway port for NAT when not specified

2022-06-09 Thread Abhiram Sangana
Thank you for reviewing the patch, Mark and Han. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-06-09 Thread Frode Nordahl
On Fri, Jun 3, 2022 at 4:16 PM Frode Nordahl wrote: > > On Thu, Jun 2, 2022 at 6:58 PM Ilya Maximets wrote: > > > > On 6/1/22 22:53, Gregory Rose wrote: > > > > > > > > > On 5/31/2022 12:22 PM, Frode Nordahl wrote: > > >> On Tue, May 31, 2022 at 7:05 PM Ilya Maximets wrote: > > >>> > > >>> On

Re: [ovs-dev] [PATCH ovn] Lock pinctrl_mutex for pinctrl_wait

2022-06-09 Thread Mark Michelson
Thanks Ihar, I pushed this change to main, branch-22.06, branch-22.03, and branch-21.12. On 6/3/22 16:24, Ihar Hrachyshka wrote: The function is called from main thread, and wait_* subprocedures access data structures that are managed by pinctrl thread, so make sure the access to them is

Re: [ovs-dev] [PATCH RFC ovn] nb: Remove possibility of disabling logical datapath groups.

2022-06-09 Thread Mark Michelson
I'm in agreement with Han and Numan that this is a good idea. One thing that may be worth considering (maybe as a follow-up) is a re-think of parallelization when dp groups are always enabled. With dp groups disabled, the lflows can be divided into equal parts, processed in parallel, and then

Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-09 Thread Mark Michelson
I added Ihar's Ack and my Ack to both patches and pushed them to main, branch-22.06, branch-22.03, and branch-21.12. On 6/8/22 09:29, Terry Wilson wrote: Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds

Re: [ovs-dev] [PATCH ovn v2] northd: Determine gateway port for NAT when not specified

2022-06-09 Thread Mark Michelson
Thanks, Abhiram and Han. I added my own ack and pushed this change to main. On 6/9/22 12:03, Han Zhou wrote: On Tue, May 24, 2022 at 3:31 AM Abhiram Sangana mailto:sangana.abhi...@nutanix.com>> wrote: > > If multiple distributed gateway ports (DGP) are configured on a > logical router,

Re: [ovs-dev] [PATCH ovn v2] northd: Determine gateway port for NAT when not specified

2022-06-09 Thread Han Zhou
On Tue, May 24, 2022 at 3:31 AM Abhiram Sangana wrote: > > If multiple distributed gateway ports (DGP) are configured on a > logical router, "gateway_port" column needs to be set for NAT entries > of the logical router for the rules to be applied, as part of commit > 2d942be (northd: Add support

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Eric Dumazet via dev
On Thu, Jun 9, 2022 at 4:50 AM Paolo Abeni wrote: > > On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > > IMO to encourage use of the track-capable API we could keep their names

Re: [ovs-dev] [PATCH ovn] OVN-CI: remove ddlog test cases.

2022-06-09 Thread Mohammad Heib
Hi Dumitru, thank you for reviewing this patch. On 5/30/22 18:50, Dumitru Ceara wrote: On 5/30/22 10:28, Mohammad Heib wrote: currently there is no new changes applied to the ddlog code base in ovn and we keep skipping ddlog test cases in our ci runs which leads to so many skips lines printed

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread David Ahern
On 6/8/22 8:58 AM, Jakub Kicinski wrote: > IMO to encourage use of the track-capable API we could keep their names > short and call the legacy functions __netdev_hold() as I mentioned or > maybe netdev_hold_notrack(). I like that option. Similar to the old nla_parse functions that were renamed

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Eric Dumazet via dev
On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > IMO to encourage use of the track-capable API we could keep their names > > short and call the legacy functions __netdev_hold() as I mentioned or > > maybe netdev_hold_notrack(). > > I like that

[ovs-dev] [ovn patch v2 ]OVN-CI: remove ddlog test cases.

2022-06-09 Thread Mohammad Heib
currently there is no new changes applied to the ddlog code base in ovn and we keep skipping ddlog test cases in our ci runs which leads to so many skips lines printed to the ci logs and that cause us to miss some tests cases that were skipped because of missing packages or any other reason.

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Paolo Abeni
On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > IMO to encourage use of the track-capable API we could keep their names > > > short and call the legacy functions __netdev_hold() as I

Re: [ovs-dev] [PATCH v2] tests: Add ovs-dpdk rate limiting unit tests.

2022-06-09 Thread Phelan, Michael
Hi Ilya, Sorry about the delay in getting back to you, I appreciate you taking the time to take a look at the patch, I left some responses to your comments inline below. > -Original Message- > From: Ilya Maximets > Sent: Wednesday 4 May 2022 11:33 > To: Phelan, Michael ;

Re: [ovs-dev] [PATCH v2] dpcls: add unlisted alias for subtable lookup command

2022-06-09 Thread Eelco Chaudron
On 7 Jun 2022, at 12:36, Harry van Haaren wrote: > This patch adds the old name "subtable-lookup-prio-get" as an unlisted > command, > to restore a consistency between OVS releases for testing scripts. > > Fixes 738c76a503f4 ("dpcls: Change info-get function to fetch dpcls usage > stats.") >

Re: [ovs-dev] [PATCH ovn v14] Implement RARP activation strategy for ports

2022-06-09 Thread Han Zhou
On Tue, Jun 7, 2022 at 7:06 PM Ihar Hrachyshka wrote: > > When options:activation-strategy is set to "rarp" for LSP, when used in > combination with multiple chassis names listed in > options:requested-chassis, additional chassis will install special flows > that would block all ingress and