On Tue, Jun 14, 2022 at 6:19 PM Ihar Hrachyshka wrote:
> On Tue, Jun 14, 2022 at 4:19 PM Numan Siddique wrote:
> > > > > > > If I understand correctly, the major benefit of this feature
> is to
> > > > > activate the port immediately when ready, without waiting for the
> control
> > > > > plane
When options:activation-strategy is set to "rarp" for LSP, when used in
combination with multiple chassis names listed in
options:requested-chassis, additional chassis will install special flows
that would block all ingress and egress traffic for the port until a
special activation event happens.
On Tue, Jun 14, 2022 at 4:19 PM Numan Siddique wrote:
> > > > > > If I understand correctly, the major benefit of this feature is to
> > > > activate the port immediately when ready, without waiting for the
> > > > control
> > > > plane to converge though SB DB. So I think here it shouldn't chec
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#1906 FILE: lib/packets.c:1107:
From: Flavio Leitner
The netdev receiving packets is supposed to provide the flags
indicating if the IP csum was verified and it is OK or BAD,
otherwise the stack will check when appropriate by software.
If the packet comes with good checksum, then postpone the
checksum calculation to the egress
From: Flavio Leitner
Currently 'p' and 'b' and used for packets, so use
a convention that struct dp_packet is 'p' and
struct dp_packet_batch is 'b'.
Some comments needed new formatting to not pass the
80 column.
Some variables were using 'p' or 'b' were renamed
as well.
There should be no func
From: Flavio Leitner
Use the 'NETDEV_OFFLOAD_' prefix in the flags to indicate
we are talking about hardware offloading capabilities.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Reviewed-by: David Marchand
Acked-by: Maxime Coquelin
---
v2: change
From: Flavio Leitner
Add a new command to show the offloading features of
each data path port.
Signed-off-by: Flavio Leitner
Signed-off-by: Mike Pattrick
Co-authored-by: Mike Pattrick
---
lib/dpif-netdev-unixctl.man | 5
lib/dpif-netdev.c | 58
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Signed-off-by: Mike Pattrick
Co-authored-by: Mike Pattrick
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst| 1 +
Docum
From: Flavio Leitner
This helps to identify when it is about the flags or
the packet itself.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Acked-by: Maxime Coquelin
Reviewed-by: David Marchand
---
lib/conntrack.c | 8
lib/dp-pa
From: Flavio Leitner
Rename to better represent their flags.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Acked-by: Maxime Coquelin
Reviewed-by: David Marchand
---
lib/conntrack.c| 4 ++--
lib/dp-packet.h| 14 +++---
lib/ipf.c
From: Flavio Leitner
The name correlates better with the flag names.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Acked-by: Maxime Coquelin
Reviewed-by: David Marchand
--
v2: changed title per suggestion
---
lib/conntrack.c| 8
lib/
From: Flavio Leitner
It seems csum is more common and shorter.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Acked-by: Maxime Coquelin
Reviewed-by: David Marchand
--
v2: changed title per suggestion
---
lib/dp-packet.h | 72 +
From: Flavio Leitner
Rename to dp_packet_ol_tcp_seg, because that is less
redundant and allows other protocols.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Acked-by: Maxime Coquelin
---
lib/dp-packet.h| 2 +-
lib/netdev-linux.c | 2 +-
lib/ne
On 6/3/22 17:31, Rosemarie O'Riorden wrote:
> When OVS sees a tunnel push with a nested list next, it will not
> clone the packet, as a clone is not needed. However, a clone action will
> still be created with the tunnel push encapulated inside. There is no
> need to create the clone action in this
On 6/14/22 16:26, Oz Shlomo wrote:
> Hi Ilya,
>
> On 6/14/2022 4:03 PM, Ilya Maximets wrote:
>> On 6/14/22 10:27, Oz Shlomo via dev wrote:
>>>
>>>
>>> On 6/8/2022 3:16 AM, Frode Nordahl wrote:
On Tue, Jun 7, 2022 at 12:16 AM Ilya Maximets wrote:
>
> On 5/31/22 23:48, Ilya Maximets wr
On Tue, Jun 14, 2022 at 1:26 PM Ihar Hrachyshka wrote:
>
> On Tue, Jun 14, 2022 at 1:02 PM Numan Siddique wrote:
> >
> > On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote:
> > >
> > > On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka
> > > wrote:
> > > >
> > > > On Mon, Jun 13, 2022 at 6:30 PM Han
On Tue, Jun 14, 2022 at 1:02 PM Numan Siddique wrote:
>
> On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote:
> >
> > On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote:
> > >
> > > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
> > > >
> > > >
> > > >
> > > > On Mon, Jun 13, 2022 at 11:41 AM
On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote:
>
> On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote:
> >
> > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrachyshka
> wrote:
> > > >
> > > > When options:activation-strategy
On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote:
>
>
>
> On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote:
> >
> > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrachyshka
> > > wrote:
> > > >
> > > > When options:activation-
On Mon, Jun 13, 2022 at 8:59 PM Ihar Hrachyshka wrote:
>
> FYI checked that with -fake-multinode. Also checked that if I modify
> start_northd to pass $cmd (as ovsdb-server), it also correctly matches
> it (and failing when $cmd is anything different).
Thanks for fixing this issue. The function
Hi Ilya,
On 6/14/2022 4:03 PM, Ilya Maximets wrote:
On 6/14/22 10:27, Oz Shlomo via dev wrote:
On 6/8/2022 3:16 AM, Frode Nordahl wrote:
On Tue, Jun 7, 2022 at 12:16 AM Ilya Maximets wrote:
On 5/31/22 23:48, Ilya Maximets wrote:
On 5/31/22 21:15, Frode Nordahl wrote:
On Mon, May 30, 202
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#106 FILE: controller/mac-binding-aging.c:58:
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
tests/ovn.at | 125 +++
1 file changed, 125 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index d71a08cdd..a1f3235c2 100644
--- a/tests/ovn.at
+++ b/tests/ovn.a
The new chassis column in MAC_Binding should
act as an "owner" order of that particular row.
This can be utilized by MAC binding aging mechanism,
where only single is responsible for that particular
record. In order to keep it consistent the chassis
that owns the MAC binding is the one that created
To allow fine tuning the right value for MAC binding
aging add configuration into NB global table called
"mac_binding_age_threshold" which accept threshold in
seconds. Default value being 60 if not specified.
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
controll
Add stopwatch fro MAC bidning aging so
we can observe how long are the aging
check taking.
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
controller/ovn-controller.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/controller/ovn-controller.c b/controller
Add MAC binding aging mechanism that utilizes
the ownership of MAC binding row. The controller
that "owns" the MAC binding will track idle_age
statistics for related OpenFlows (table 66 and 67).
If the idle_age exceeds the threshold value for aging
the MAC binding row is removed. The threshold is
Add MAC binding aging mechanism, that
should take care of stale MAC bindings.
The mechanism works on "ownership" of the
MAC binding row. The chassis that creates
the row is then checking if the "idle_age"
of the flow is over the aging threshold.
In that case the MAC binding is removed
from databas
On 6/14/22 10:27, Oz Shlomo via dev wrote:
>
>
> On 6/8/2022 3:16 AM, Frode Nordahl wrote:
>> On Tue, Jun 7, 2022 at 12:16 AM Ilya Maximets wrote:
>>>
>>> On 5/31/22 23:48, Ilya Maximets wrote:
On 5/31/22 21:15, Frode Nordahl wrote:
> On Mon, May 30, 2022 at 5:25 PM Frode Nordahl
>>>
>>
This commit adds support for the AVX512 implementation of the
ipv4_set_addrs action as well as an AVX512 implementation of
updating the checksums.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 210 ++
lib/odp-execute-private.c | 1 +
lib/odp-execu
This commit includes infrastructure changes for enabling set_masked_X
actions and also adds support for the AVX512 implementation of the
eth_set_addrs action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 69 +++
lib/odp-execute-private.c | 56 +
This commit adds the AVX512 implementation of the
push_vlan action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 37 +
lib/odp-execute-private.c | 1 +
lib/odp-execute.c | 22 +-
3 files changed, 51 insertions(+), 9 del
This commit adds the AVX512 implementation of the
pop_vlan action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 91
1 file changed, 91 insertions(+)
diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c
index 1fb334689..f9e2b1727 10
This commit adds the AVX512 implementation of the action functionality.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set avx512
Signed-off-by: Emma Finn
Acked-by: Harry van Haaren
---
Documentation/ref/ovs-actions.7.rst | 26 ++
Documentation/topics/testing.rst| 24 ---
This commit adds a new command to allow the user to switch
the active action implementation at runtime. A probe function
is executed before switching the implementation, to ensure
the CPU is capable of running the ISA required.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set scalar
This commit
From: Kumar Amber
This commit adds a new command to allow the user to enable the
actions autovalidator by default at build time thus allowing for
running unit test by default.
$ ./configure --enable-actions-default-autovalidator
Signed-off-by: Kumar Amber
Acked-by: Harry van Haaren
---
NEWS
This commit introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different action implementations against the linear
action implementation.
The autovalidator function can be triggered at runtime using the
following command:
$ ovs-appctl dpif-net
This commit removes the pop_vlan action from the large switch
and creates a separate function for batched processing. A function
pointer is also added to call the new batched function for the pop_vlan
action.
Signed-off-by: Emma Finn
Acked-by: Harry van Haaren
---
lib/odp-execute-private.c | 18
This commit introduces the initial infrastructure required to allow
different implementations for OvS actions. The patch introduces action
function pointers which allows user to switch between different action
implementations available. This will allow for more performance and flexibility
so the us
The IP checksum field was invalid in the input packets
for some unit tests. The unit tests will still pass without
a valid checksum, however we should still fix these.
Signed-off-by: Emma Finn
Acked-by: Eelco Chaudron
---
This was found using the autovalidator introduced later in
this series.
-
This patchset introduces actions infrastructure changes which allows the
user to choose between different action implementations based on CPU ISA
by using different commands. The infrastructure also provides a way to
check the correctness of the ISA optimized action version against the
scalar vers
This commit adds support for the AVX512 implementation of the
ipv4_set_addrs action as well as an AVX512 implementation of
updating the checksums.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 210 ++
lib/odp-execute-private.c | 1 +
lib/odp-execu
This commit includes infrastructure changes for enabling set_masked_X
actions and also adds support for the AVX512 implementation of the
eth_set_addrs action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 69 +++
lib/odp-execute-private.c | 56 +
This commit adds the AVX512 implementation of the
push_vlan action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 37 +
lib/odp-execute-private.c | 1 +
lib/odp-execute.c | 22 +-
3 files changed, 51 insertions(+), 9 del
This commit adds the AVX512 implementation of the
pop_vlan action.
Signed-off-by: Emma Finn
---
lib/odp-execute-avx512.c | 91
1 file changed, 91 insertions(+)
diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c
index 1fb334689..f9e2b1727 10
This commit adds the AVX512 implementation of the action functionality.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set avx512
Signed-off-by: Emma Finn
Acked-by: Harry van Haaren
---
Documentation/ref/ovs-actions.7.rst | 26 ++
Documentation/topics/testing.rst| 24 ---
From: Kumar Amber
This commit adds a new command to allow the user to enable the
actions autovalidator by default at build time thus allowing for
running unit test by default.
$ ./configure --enable-actions-default-autovalidator
Signed-off-by: Kumar Amber
Acked-by: Harry van Haaren
---
NEWS
This commit adds a new command to allow the user to switch
the active action implementation at runtime. A probe function
is executed before switching the implementation, to ensure
the CPU is capable of running the ISA required.
Usage:
$ ovs-appctl dpif-netdev/action-impl-set scalar
This commit
This commit introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different action implementations against the linear
action implementation.
The autovalidator function can be triggered at runtime using the
following command:
$ ovs-appctl dpif-net
This commit removes the pop_vlan action from the large switch
and creates a separate function for batched processing. A function
pointer is also added to call the new batched function for the pop_vlan
action.
Signed-off-by: Emma Finn
Acked-by: Harry van Haaren
---
lib/odp-execute-private.c | 18
This commit introduces the initial infrastructure required to allow
different implementations for OvS actions. The patch introduces action
function pointers which allows user to switch between different action
implementations available. This will allow for more performance and flexibility
so the us
The IP checksum field was invalid in the input packets
for some unit tests. The unit tests will still pass without
a valid checksum, however we should still fix these.
Signed-off-by: Emma Finn
Acked-by: Eelco Chaudron
---
This was found using the autovalidator introduced later in
this series.
-
This patchset introduces actions infrastructure changes which allows the
user to choose between different action implementations based on CPU ISA
by using different commands. The infrastructure also provides a way to
check the correctness of the ISA optimized action version against the
scalar vers
> -Original Message-
> From: Finn, Emma
> Sent: Thursday 2 June 2022 16:00
> To: Eelco Chaudron
> Cc: Van Haaren, Harry ; Amber, Kumar
> ; Stokes, Ian ;
> d...@openvswitch.org
> Subject: RE: [v6 11/11] odp-execute: Add ISA implementation of
> set_masked IPv4 action
>
>
>
> > -Orig
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday 2 June 2022 15:32
> To: Finn, Emma
> Cc: Van Haaren, Harry ; Amber, Kumar
> ; Stokes, Ian ;
> d...@openvswitch.org
> Subject: Re: [v6 07/11] odp-execute: Add ISA implementation of actions.
>
> On 10 May 2022, at 16:21, Emma
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday 2 June 2022 15:15
> To: Finn, Emma
> Cc: Van Haaren, Harry ; Amber, Kumar
> ; Stokes, Ian ;
> d...@openvswitch.org
> Subject: Re: [v6 04/11] odp-execute: Add auto validation function for
> actions.
>
> On 10 May 2022, at 16:2
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday 2 June 2022 15:00
> To: Finn, Emma
> Cc: Van Haaren, Harry ; Amber, Kumar
> ; Stokes, Ian ;
> d...@openvswitch.org
> Subject: Re: [v6 02/11] odp-execute: Add function pointers to odp-execute
> for different action implementation
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday 2 June 2022 15:06
> To: Finn, Emma
> Cc: Van Haaren, Harry ; Amber, Kumar
> ; Stokes, Ian ;
> d...@openvswitch.org
> Subject: Re: [v6 03/11] odp-execute: Add function pointer for pop_vlan
> action.
>
> On 10 May 2022, at 16:
On 6/8/2022 3:16 AM, Frode Nordahl wrote:
On Tue, Jun 7, 2022 at 12:16 AM Ilya Maximets wrote:
On 5/31/22 23:48, Ilya Maximets wrote:
On 5/31/22 21:15, Frode Nordahl wrote:
On Mon, May 30, 2022 at 5:25 PM Frode Nordahl
I've pushed the first part of the fix here:
https://mail.openvswi
60 matches
Mail list logo
