[ovs-dev] [PATCH v3] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-06-17 Thread Han Ding
Commit ba07cf222a add the feature "Handle gratuitous ARP requests and replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch the destination address of the ARP is matched against the known xbridge addresses. So the modification of commit ba07cf222a is not effective. When ovs

Re: [ovs-dev] [PATCH v3 ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-17 Thread Numan Siddique
On Tue, Jun 7, 2022 at 9:07 AM Numan Siddique wrote: > > On Mon, Jun 6, 2022 at 6:44 PM Lorenzo Bianconi > wrote: > > > > Add the capability to automatically deploy a load-balancer on each > > logical-switch connected to a logical router where the load-balancer > > has been installed by the CMS.

[ovs-dev] [PATCH ovn v19] Implement RARP activation strategy for ports

2022-06-17 Thread Ihar Hrachyshka
When options:activation-strategy is set to "rarp" for LSP, when used in combination with multiple chassis names listed in options:requested-chassis, additional chassis will install special flows that would block all ingress and egress traffic for the port until a special activation event happens.

Re: [ovs-dev] [OVN v2] OVN - Add Support for Remote Port Mirroring

2022-06-17 Thread Numan Siddique
On Mon, Jun 13, 2022 at 9:53 AM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port Mirrori

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-17 Thread Numan Siddique
' On Fri, Jun 17, 2022 at 5:26 PM Numan Siddique wrote: > > On Thu, Jun 16, 2022 at 3:50 PM Mark Michelson wrote: > > > > On 6/15/22 21:42, Ihar Hrachyshka wrote: > > > For this version, the IP engine still doesn't trigger _run functions > > > nor iterative handlers when ovsdb commit fails and n

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-17 Thread Numan Siddique
On Thu, Jun 16, 2022 at 3:50 PM Mark Michelson wrote: > > On 6/15/22 21:42, Ihar Hrachyshka wrote: > > For this version, the IP engine still doesn't trigger _run functions > > nor iterative handlers when ovsdb commit fails and no ovsdb > > transaction is available, so activation flows are not flus

[ovs-dev] How to log lots of flow matching packets efficiently?

2022-06-17 Thread Chul-Woong Yang
Hi, I use OVS as a firewall and want to log the flow-matching packets. OVS can use controller action and the OF controller can log receiving packets. This is the neutron OVS-firewall-driver way of implementing security group logging. However, when the performance bar is high, and that's always t

Re: [ovs-dev] [PATCH 1/1] ovsdb: Fix memory leak on error path in ovsdb_file_read__().

2022-06-17 Thread Mike Pattrick
On Mon, Jun 6, 2022 at 7:07 AM Yunjian Wang via dev wrote: > > Found by Coverity. > > Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered > databases.") > Signed-off-by: Yunjian Wang Looks correct to me! Acked-by: Mike Pattrick > --- > ovsdb/file.c | 1 + > 1 file chan

Re: [ovs-dev] [PATCH v5 1/2] handlers: Create additional handler threads when using CPU isolation

2022-06-17 Thread Mike Pattrick
On Mon, Jun 6, 2022 at 3:00 PM Michael Santana wrote: > > Additional threads are required to service upcalls when we have CPU > isolation (in per-cpu dispatch mode). The reason additional threads > are required is because it creates a more fair distribution. With more > threads we decrease the loa

Re: [ovs-dev] [v5 0/8] Add support for ovs metering with tc offload

2022-06-17 Thread Eelco Chaudron
On 13 Jun 2022, at 9:19, Eelco Chaudron wrote: > On 13 Jun 2022, at 3:28, Jianbo Liu wrote: > >> On Fri, 2022-05-27 at 12:02 +0200, Eelco Chaudron wrote: >>> >>> >>> On 27 May 2022, at 11:00, Jianbo Liu wrote: >>> This series is to add support for tc offloading of ovs metering, and >>>

Re: [ovs-dev] [ovn patch v2 ]OVN-CI: remove ddlog test cases.

2022-06-17 Thread Numan Siddique
On Wed, Jun 15, 2022 at 5:33 AM Dumitru Ceara wrote: > > On 6/9/22 14:27, Mohammad Heib wrote: > > currently there is no new changes applied to the ddlog code base > > in ovn and we keep skipping ddlog test cases in our ci runs which leads > > to so many skips lines printed to the ci logs and that

[ovs-dev] [PATCH v2] ovs-save: add bindir to PATH

2022-06-17 Thread Adrian Moreno
If openvswitch is not installed in the default system's path ovs-save script will fail to find the tools it requires. Fix this by adding $bindir to the PATH. Refactor common path calculation into ovs-lib. Signed-off-by: Adrian Moreno --- utilities/ovs-ctl.in | 11 +-- utilities/ovs

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-06-17 Thread Han Ding
Commit ba07cf222a add the feature "Handle gratuitous ARP requests and replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch the destination address of the ARP is matched against the known xbridge addresses. So the modification of commit ba07cf222a is not effective. When ov

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-06-17 Thread 0-day Robot
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Han Ding needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [PATCH v1] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-06-17 Thread Han Ding
Commit ba07cf222a add the feature "Handle gratuitous ARP requests and replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch the destination address of the ARP is matched against the known xbridge addresses. So the modification of commit ba07cf222a is not effective. When ov

Re: [ovs-dev] [PATCH ovn v2 2/6] Add MAC binding aging mechanism

2022-06-17 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #108 FILE: controller/mac-binding-aging.c:60:

Re: [ovs-dev] [PATCH ovn 2/5] Add MAC binding aging mechanism

2022-06-17 Thread Ales Musil
Hi Mark, thank you for the review. Everything should be addressed in v2, except the stats there reply in-line below. On Wed, Jun 15, 2022 at 8:13 PM Mark Michelson wrote: > Hi Ales, > > I have a few comments in-line below. > > On 6/14/22 09:49, Ales Musil wrote: > > Add MAC binding aging mechani

Re: [ovs-dev] [PATCH ovn 5/5] ovn.at: Add test case covering the MAC binding aging

2022-06-17 Thread Ales Musil
Hi Mark, On Wed, Jun 15, 2022 at 8:14 PM Mark Michelson wrote: > Hi Ales, > > I think this test needs to ensure that MAC bindings are not aged out > when there is active traffic on the owning chassis. As an example, you > could create a MAC_Binding on a chassis that is supposed to age out > afte

Re: [ovs-dev] [PATCH ovn 4/5] Allow the MAC binding age threshold to be configurable

2022-06-17 Thread Ales Musil
On Wed, Jun 15, 2022 at 8:13 PM Mark Michelson wrote: > On 6/14/22 09:49, Ales Musil wrote: > > To allow fine tuning the right value for MAC binding > > aging add configuration into NB global table called > > "mac_binding_age_threshold" which accept threshold in > > seconds. Default value being 6

Re: [ovs-dev] [PATCH ovn 3/5] Add stopwatch for MAC binding aging

2022-06-17 Thread Ales Musil
Hi Mark, addressed in v2. Thanks, Ales On Wed, Jun 15, 2022 at 8:13 PM Mark Michelson wrote: > On 6/14/22 09:49, Ales Musil wrote: > > Add stopwatch fro MAC bidning aging so > > we can observe how long are the aging > > check taking. > > > > Reported-at: https://bugzilla.redhat.com/2084668 > >

[ovs-dev] [PATCH ovn v2 6/6] pinctrl.c: Add delay after ARP packet

2022-06-17 Thread Ales Musil
The ovn-controller had a race condition over MAC binding table with other controllers. When multiple controllers received GARP from single source usually the one who was able to win the race put it into SB. The others got transaction error which triggered full recompute even if it's not needed. In

[ovs-dev] [PATCH ovn v2 0/6] MAC binding aging mechanism

2022-06-17 Thread Ales Musil
Add MAC binding aging mechanism, that should take care of stale MAC bindings. The mechanism works on "ownership" of the MAC binding row. The chassis that creates the row is then checking if the "idle_age" of the flow is over the aging threshold. In that case the MAC binding is removed from databas

[ovs-dev] [PATCH ovn v2 5/6] ovn.at: Add test case covering the MAC binding aging

2022-06-17 Thread Ales Musil
Reported-at: https://bugzilla.redhat.com/2084668 Signed-off-by: Ales Musil --- v2: Rebase on top of current main Extend the test case by showing that active MAC binding is not deleted. Address other comments from Mark. --- tests/ovn.at | 173 +++

[ovs-dev] [PATCH ovn v2 4/6] Allow the MAC binding age threshold to be configurable

2022-06-17 Thread Ales Musil
To allow fine tuning the right value for MAC binding aging add configuration into NB global table called "mac_binding_age_threshold" which accept threshold in seconds. Default value being 60 if not specified. Reported-at: https://bugzilla.redhat.com/2084668 Signed-off-by: Ales Musil --- v2: Rebas

[ovs-dev] [PATCH ovn v2 2/6] Add MAC binding aging mechanism

2022-06-17 Thread Ales Musil
Add MAC binding aging mechanism that utilizes the ownership of MAC binding row. The controller that "owns" the MAC binding will track idle_age statistics for related OpenFlows (table 66 and 67). If the idle_age exceeds the threshold value for aging the MAC binding row is removed. The threshold is

[ovs-dev] [PATCH ovn v2 3/6] Add stopwatch for MAC binding aging

2022-06-17 Thread Ales Musil
Add stopwatch fro MAC bidning aging so we can observe how long are the aging check taking. Reported-at: https://bugzilla.redhat.com/2084668 Signed-off-by: Ales Musil --- v2: Rebase on top of current main. Address comments from Mark. --- controller/ovn-controller.c | 6 ++ 1 file changed,

[ovs-dev] [PATCH ovn v2 1/6] Add chassis column to MAC_Binding table

2022-06-17 Thread Ales Musil
The new chassis column in MAC_Binding should act as an "owner" order of that particular row. This can be utilized by MAC binding aging mechanism, where only single is responsible for that particular record. In order to keep it consistent the chassis that owns the MAC binding is the one that created

Re: [ovs-dev] [PATCH v4] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-06-17 Thread lic121
On Wed, Jun 08, 2022 at 03:58:31PM +0530, Anurag Agarwal wrote: > From: Jan Scheurich > > Today dpif-netdev considers PMD threads on a non-local NUMA node for automatic > assignment of the rxqs of a port only if there are no local,non-isolated PMDs. > > On typical servers with both physical port