Re: [ovs-dev] [RFC PATCH ovn 0/5] Add OVN component templates.

On 8/10/22 19:54, Mark Michelson wrote: > Hi Dumitru, > Hi Mark, > I read the patch series, and I think the idea of chassis-specific > variables is a good idea to reduce the number of DB records for certain > things. Aside from load balancers, I suspect this could have a positive > impact for ot

[ovs-dev] DPDK bond device with OVS

HI Ilya & Jan, I would like to get some more clarity on this very old discussion - [ovs-dev,net-next,1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args - Patchwork (ozlabs.org)

[ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check.

Support for vpopcntdq instruction generation by the compiler was already checked in the OVS_CHECK_AVX512 AC function by checking if the compiler accepted the -mavx512vpopcntdq option. However, there can be situations where the compiler supports vpopcntdq generation but the assembler doesn't suppor

Re: [ovs-dev] [PATCH ovn v4 1/6] northd, controller: Add timestamp column to MAC_Binding table

On 8/9/22 13:05, Ales Musil wrote: > The new timestamp column in MAC_Binding is > populated with current time whenever the row is > created or the MAC address is updated. > This can be utilized by MAC binding aging mechanism, > when we can check if enough time has passed since the > creation/update

Re: [ovs-dev] [PATCH ovn v4 2/6] controller: Add mac-binding-index.c/.h files

On 8/9/22 13:05, Ales Musil wrote: > Add helper source file for creating index > over MAC binding table. > > Reported-at: https://bugzilla.redhat.com/2084668 > Acked-By: Ihar Hrachyshka > Signed-off-by: Ales Musil > --- > v3: Rebase on top of current main. > Update according to the final con

Re: [ovs-dev] [PATCH ovn v4 3/6] northd: Move struct ovn_datapath and related structs to northd.h

On 8/9/22 13:05, Ales Musil wrote: > The struct ovn_datapath could not be used outside the northd.c > move it to northd.h that it can be used by other .c files later on. > > Reported-at: https://bugzilla.redhat.com/2084668 > Acked-By: Ihar Hrachyshka > Signed-off-by: Ales Musil > --- > v3: Rebas

Re: [ovs-dev] [PATCH ovn v4 5/6] ovn.at: Add test case covering the MAC binding aging

On 8/10/22 08:08, Han Zhou wrote: > On Tue, Aug 9, 2022 at 4:05 AM Ales Musil wrote: >> >> Reported-at: https://bugzilla.redhat.com/2084668 >> Signed-off-by: Ales Musil >> --- >> v3: Rebase on top of current main. >> Update according to the final conclusion. >> v4: Rebase on top of current ma

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

On 8/10/22 18:37, Han Zhou wrote: > On Tue, Aug 9, 2022 at 11:22 PM Ales Musil wrote: >> >> >> >> On Wed, Aug 10, 2022 at 8:04 AM Han Zhou wrote: >> >> Hi Han, >> >> thank you for the review, see my reply inline below. >> >>> On Tue, Aug 9, 2022 at 4:05 AM Ales Musil wrote: Add MAC bin

Re: [ovs-dev] [PATCH ovn v4 6/6] northd: Add config to limit bulk removal of MAC binding

On 8/9/22 13:05, Ales Musil wrote: > Add configuration option into NB global table > called "mac_binding_removal_limit" defaulting to 0. > This option allows to limit number of MAC bindings > that can be removed by the aging mechanism in a single > transaction. The 0 means that the mechanism is dis

[ovs-dev] [PATCH ovn] github: ovn-kubernetes: Update go, kube and libovsdb versions.

With this they'll match the current upstream ovn-kubernetes code. Signed-off-by: Dumitru Ceara --- .ci/ovn-kubernetes/Dockerfile| 2 +- .github/workflows/ovn-kubernetes.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-

Re: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check.

> -Original Message- > From: dev On Behalf Of Cian Ferriter > Sent: Thursday, August 11, 2022 4:07 PM > To: ovs-dev@openvswitch.org > Subject: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check. > > Support for vpopcntdq instruction generation by the compiler was already > checked

Re: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check.

> > -Original Message- > > From: dev On Behalf Of Cian > Ferriter > > Sent: Thursday, August 11, 2022 4:07 PM > > To: ovs-dev@openvswitch.org > > Subject: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check. > > > > Support for vpopcntdq instruction generation by the compiler was >

[ovs-dev] [PATCH ovn v5 1/5] northd, controller: Add timestamp column to MAC_Binding table

The new timestamp column in MAC_Binding is populated with current time whenever the row is created or the MAC address is updated. This can be utilized by MAC binding aging mechanism, when we can check if enough time has passed since the creation/update. Reported-at: https://bugzilla.redhat.com/208

[ovs-dev] [PATCH ovn v5 2/5] controller: Add mac-binding-index.c/.h files

Add helper source file for creating index over MAC binding table. Reported-at: https://bugzilla.redhat.com/2084668 Acked-by: Dumitru Ceara Signed-off-by: Ales Musil --- v4: Rebase on top of current main. Address comment from Mark. Add ack from Ihar. v5: Rebase on top of current main.

[ovs-dev] [PATCH ovn v5 0/5] MAC binding aging mechanism

Add MAC binding aging mechanism, that should take care of stale MAC bindings. The mechanism is configurable per logical router, with option called "mac_binding_age_threshold", which is 0 by default. The zero also indicates that the aging mechanism is disabled. The aging is based on timestamp in M

[ovs-dev] [PATCH ovn v5 3/5] northd: Move struct ovn_datapath and related structs to northd.h

The struct ovn_datapath could not be used outside the northd.c move it to northd.h that it can be used by other .c files later on. Reported-at: https://bugzilla.redhat.com/2084668 Acked-by: Dumitru Ceara Signed-off-by: Ales Musil --- v4: Rebase on top of current main. Add ack from Ihar. v5:

[ovs-dev] [PATCH ovn v5 4/5] northd: Add MAC binding aging mechanism

Add MAC binding aging mechanism, that utilizes the timestamp column of MAC_Binding table. When the MAC binding exceeds the threshold it is removed from SB DB, this is postponed only in case we receive update ARP with update to MAC address. The threshold is configurable via option "mac_binding_age_

[ovs-dev] [PATCH ovn v5 5/5] northd: Add config to limit bulk removal of MAC binding

Add configuration option into NB global table called "mac_binding_removal_limit" defaulting to 0. This option allows to limit number of MAC bindings that can be removed by the aging mechanism in a single transaction. The 0 means that the mechanism is disabled. If the limit is reached next removal w

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote: > On 8/10/22 18:37, Han Zhou wrote: > > On Tue, Aug 9, 2022 at 11:22 PM Ales Musil wrote: > >> > >> > >> > >> On Wed, Aug 10, 2022 at 8:04 AM Han Zhou wrote: > >> > >> Hi Han, > >> > >> thank you for the review, see my reply inline below. > >

Re: [ovs-dev] [PATCH ovn v5 4/5] northd: Add MAC binding aging mechanism

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #98 FILE: northd/inc-proc-northd.c:227: /* XXX: The "en_ma

Re: [ovs-dev] [PATCH ovn v5 5/5] northd: Add config to limit bulk removal of MAC binding

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #126 FILE: ovn-nb.xml:166:

[ovs-dev] [PATCH] bond: Avoid deadlock while updating post recirculation rules.

If the PACKET_OUT from controller ends up with sending packet to a bond interface, the main thread will take locks in the following order: handle_openflow --> take ofproto_mutex handle_packet_out packet_xlate output_normal bond_update_post_recirc_rules --> take rwlock in bond.c If at

Re: [ovs-dev] [PATCH ovn 0/5] debian: Update debian package source.

Hi Frode, Much like Numan said in his reply to patch 4, I don't have much expertise in the realm of debian packaging. I took a look through the series, just looking for anything that was obviously incorrect, and I couldn't find it. I trust that if there are issues, you will likely follow up w

Re: [ovs-dev] [PATCH ovn v5 1/5] northd, controller: Add timestamp column to MAC_Binding table

Acked-by: Mark Michelson On 8/11/22 10:19, Ales Musil wrote: The new timestamp column in MAC_Binding is populated with current time whenever the row is created or the MAC address is updated. This can be utilized by MAC binding aging mechanism, when we can check if enough time has passed since t

Re: [ovs-dev] [PATCH ovn v5 3/5] northd: Move struct ovn_datapath and related structs to northd.h

Acked-by: Mark Michelson On 8/11/22 10:19, Ales Musil wrote: The struct ovn_datapath could not be used outside the northd.c move it to northd.h that it can be used by other .c files later on. Reported-at: https://bugzilla.redhat.com/2084668 Acked-by: Dumitru Ceara Signed-off-by: Ales Musil -

Re: [ovs-dev] [PATCH ovn v5 4/5] northd: Add MAC binding aging mechanism

Hi Ales, the patch overall looks good, but I'm curious why both mac_binding_aging_run() and mac_binding_aging_waker_run() will call poll_timer_wait_until(). On 8/11/22 10:20, Ales Musil wrote: Add MAC binding aging mechanism, that utilizes the timestamp column of MAC_Binding table. When the

Re: [ovs-dev] [PATCH ovn v5 2/5] controller: Add mac-binding-index.c/.h files

Acked-by: Mark Michelson On 8/11/22 10:19, Ales Musil wrote: Add helper source file for creating index over MAC binding table. Reported-at: https://bugzilla.redhat.com/2084668 Acked-by: Dumitru Ceara Signed-off-by: Ales Musil --- v4: Rebase on top of current main. Address comment from M

Re: [ovs-dev] [PATCH ovn v5 5/5] northd: Add config to limit bulk removal of MAC binding

Acked-by: Mark Michelson On 8/11/22 10:44, 0-day Robot wrote: Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters

Re: [ovs-dev] [PATCH ovn 4/5] debian: Update debian package source.

On 8/5/22 22:39, Frode Nordahl wrote: > Ilya and Numan, > > I preemptively added your names to the commit message because the > patch contains your work as detailed in the commit message. > > I hope this is ok. Fine by me. See some comments inline regarding things I spotted on a first read. Be

Re: [ovs-dev] [PATCH ovn v5 4/5] northd: Add MAC binding aging mechanism

On Thu, Aug 11, 2022 at 9:08 PM Mark Michelson wrote: > Hi Ales, the patch overall looks good, but I'm curious why both > mac_binding_aging_run() and mac_binding_aging_waker_run() will call > poll_timer_wait_until(). > > Hi Mark, mac_binding_aging_run calls because we figured out how long we sho

Re: [ovs-dev] [PATCH ovn v5 4/5] northd: Add MAC binding aging mechanism

On 8/11/22 15:35, Ales Musil wrote: On Thu, Aug 11, 2022 at 9:08 PM Mark Michelson > wrote: Hi Ales, the patch overall looks good, but I'm curious why both mac_binding_aging_run() and mac_binding_aging_waker_run() will call poll_timer_wait_until(). Hi

Re: [ovs-dev] [PATCH branch-2.14 1/2] github: Remove kernels that fail to build with newer compilers.

On 8/10/22 15:43, Aaron Conole wrote: > Ilya Maximets writes: > >> Kernels 5.0, 4.20, 4.18, 4.17, 4.16 are not longterm kernels and >> didn't receive updates for a long time. They are failing build >> with compilers provided with ubuntu 20.04. Removing them from the >> test matrix since we need

Re: [ovs-dev] [PATCH branch-2.14 2/2] github: Move CI to ubuntu 20.04 base image.

On 8/10/22 15:43, Aaron Conole wrote: > Ilya Maximets writes: > >> 18.04 image is deprecated and will disappear soon. Also some >> slowdowns and brownouts are planned to push users away from >> this deprecated version: >> >> https://github.com/actions/virtual-environments/issues/6002 >> >> Mov

Re: [ovs-dev] [PATCH] ovsdb: Fix copying weak references into transaction history.

On 8/2/22 15:38, Dumitru Ceara wrote: > On 8/2/22 15:23, Ilya Maximets wrote: >> Transaction history is used only to construct row data updates for >> clients, it's not used for checking data integrity, hence it doesn't >> need a copy of weak references. >> >> Not copying this data saves a lot of C

Re: [ovs-dev] [PATCH v2] python: Do not send non-zero flag for a SSL socket

On 8/10/22 11:37, Timothy Redaelli wrote: > On Mon, 8 Aug 2022 12:32:42 -0500 > Miro Tomaska wrote: > >> Python std library SSLSocket.send does not allow non-zero value for the >> optional flag. >> >> pyOpenSSL was recently switched for the Python standard library ssl module >> commit 68543dd52

Re: [ovs-dev] [PATCH] packets: Fix misaligned access to ip6_hdr

On 7/25/22 16:08, Ales Musil wrote: > The ip6_hdr is aligned to 4 bytes, but the pointer > from dp_packet_l3 is aligned to 2 bytes. Use > ovs_16aligned_ip6_hdr instead to get 2 bytes alignment. > > Signed-off-by: Ales Musil > --- > lib/packets.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 del