This is started from the issue with broken ERSPAN tunnel
reported by Eelco, but turned out a much wider problem with
ignoring different tunnel keys and flags while constructing
TC flower. Some of that can be fixed, some can't be fixed
due to lack of support from kernel. Strictly speaking, we
shou
'wc.masks.tunnel.metadata.present.len' must be a mask for the same
field in the flow key, but in the tc_flower structure it's the real
length of metadata masks.
That is correctly handled for the individual opt->length, setting all
the masks to 0x1f like it's done in the tun_metadata_to_geneve_mask
netdev_tc_flow_put() ignores the tunnel.tp_dst mask. That results
in the exact match on the value. TC supports the masked match on
this field and it does return the mask back during the flow dump
even if it wasn't provided initially. OVS should correctly handle
that. There is a problem though.
If the key is zero, it doesn't mean we don't need to match on it.
Masks should be checked instead.
Fixes: 49a7961fca65 ("lib/tc: Avoid matching on tunnel ttl or tos if not
needed")
Reviewed-by: Roi Dayan
Signed-off-by: Ilya Maximets
---
lib/netdev-offload-tc.c | 6 +++---
1 file changed, 3 ins
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSPAN tunnels to not work, because
flow is offloaded, but ERSPAN options are not provided to TC.
There is a number of tunnel keys, wh
netdev_tc_flow_put() "consumes" the tunnel.tp_src value, but
it's never passed down to TC, and not parsed back. Fix that.
Reviewed-by: Roi Dayan
Signed-off-by: Ilya Maximets
---
lib/netdev-offload-tc.c | 6 ++
lib/tc.c| 17 +
2 files changed, 23 insertions(
On 8/5/22 13:00, Roi Dayan wrote:
>
>
> On 2022-08-04 6:20 PM, Ilya Maximets wrote:
>> On 8/2/22 09:13, Roi Dayan wrote:
>>>
>>>
>>> On 2022-08-02 9:53 AM, Roi Dayan wrote:
On 2022-08-01 9:31 AM, Roi Dayan wrote:
>
>
> On 2022-07-29 5:53 PM, Ilya Maximets wrote:
>>
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#44 FILE: lib/netdev-offload-tc.c:2033:
/* XXX: We
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#120 FILE: lib/netdev-offload-tc.c:1447:
/* XXX
On Thu, Aug 11, 2022 at 4:07 AM Ihar Hrachyshka wrote:
>
> Numan, thank you!
>
> Is it backport material? I know there may be some conflicts and am
> happy to handle them if we agree this fix can be backported.
@Mark Michelson @Han Zhou Any comments or any objections on this ?
Thanks
Numan
>
On Fri, Aug 12, 2022 at 12:21 AM Ales Musil wrote:
>
> On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote:
>
> > On 8/10/22 18:37, Han Zhou wrote:
> > > On Tue, Aug 9, 2022 at 11:22 PM Ales Musil wrote:
> > >>
> > >>
> > >>
> > >> On Wed, Aug 10, 2022 at 8:04 AM Han Zhou wrote:
> > >>
> > >> H
On Wed, Aug 10, 2022 at 8:17 PM Ales Musil wrote:
>
> On Wed, Aug 10, 2022 at 10:04 AM Dumitru Ceara wrote:
>
> > It doesn't really need the load balancer applied on the logical router.
> > As a matter of fact, load balancers are not supported on distributed
> > routers without distributed gatewa
On Thu, Aug 11, 2022 at 11:27 PM Dumitru Ceara wrote:
>
> With this they'll match the current upstream ovn-kubernetes code.
>
> Signed-off-by: Dumitru Ceara
Thanks. Applied to main. Do we need to backport this too ?
Numan
> ---
> .ci/ovn-kubernetes/Dockerfile| 2 +-
> .github/workfl
On Wed, Aug 10, 2022 at 6:15 PM Dumitru Ceara wrote:
>
> On 8/10/22 09:21, Ales Musil wrote:
> > The update of having other_config instead of external_ids
> > for configuration has been in place for some time.
> > Version that released with this change was 20.06, that
> > is plenty of time so we d
On Wed, Aug 10, 2022 at 6:10 PM Dumitru Ceara wrote:
>
> On 8/10/22 09:32, Ales Musil wrote:
> > Signed-off-by: Ales Musil
> > ---
> > controller/chassis.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/controller/chassis.c b/controller/chassis.c
> > index 92850fc
The update of having other_config instead of external_ids
for configuration has been in place for some time.
Version that released with this change was 20.06, that
is plenty of time so we don't have to keep the compatibility
anymore. Remove the updates of external_ids it will be stored
only in othe
On Mon, Aug 15, 2022 at 5:44 AM Numan Siddique wrote:
> On Wed, Aug 10, 2022 at 6:15 PM Dumitru Ceara wrote:
> >
> > On 8/10/22 09:21, Ales Musil wrote:
> > > The update of having other_config instead of external_ids
> > > for configuration has been in place for some time.
> > > Version that rel
On Sun, Aug 14, 2022 at 8:30 PM Numan Siddique wrote:
>
> On Fri, Aug 12, 2022 at 12:21 AM Ales Musil wrote:
> >
> > On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote:
> >
> > > On 8/10/22 18:37, Han Zhou wrote:
> > > > On Tue, Aug 9, 2022 at 11:22 PM Ales Musil
wrote:
> > > >>
> > > >>
> > >
"
On Mon, Aug 15, 2022 at 3:34 PM Han Zhou wrote:
>
> On Sun, Aug 14, 2022 at 8:30 PM Numan Siddique wrote:
> >
> > On Fri, Aug 12, 2022 at 12:21 AM Ales Musil wrote:
> > >
> > > On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote:
> > >
> > > > On 8/10/22 18:37, Han Zhou wrote:
> > > > > On T
19 matches
Mail list logo
