Hi, Mike
by changing it into the function, you mean relax the checking if the state
is
either EVICTED or DELETED?
Mike Pattrick 于2022年8月15日周一 20:16写道：
> On Sat, Jun 4, 2022 at 11:19 AM Peng He wrote:
> >
> > There is a race condition between the revalidator threads and
> > the handler/pmd th
Hi Alin,
I have made some modification according to your suggestion and new patch will
come out soon.
Regards
Dejing
From: Alin-Gabriel Serdean
Date: Tuesday, August 9, 2022 at 9:22 PM
To: d...@openvswitch.org
Cc: Dejing Liu
Subject: [ovs-dev] [PATCH v1 1/1] datapath-windows: support meter a
Dejing,
Looking forward to it.
Alin.
From: Dejing Liu
Sent: Tuesday, August 16, 2022 1:00 PM
To: Alin-Gabriel Serdean ; d...@openvswitch.org
Cc: Frank Guo ; Wilson Peng ; Lina
Li
Subject: Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: support meter action
initial version
Hi Alin,
The local_datapath->peer_ports list contains peers pointers
to lsp<-->lrp ports that are supposed to be router end ports,
those pointers are added and deleted to the local_datapath->peer_ports
when logical switch port of type router are added or deleted from the database.
The deletion and creatio
On 8/16/22 08:33, Ales Musil wrote:
> Add helper source file for creating index
> over MAC binding table.
>
> Reported-at: https://bugzilla.redhat.com/2084668
> Acked-by: Dumitru Ceara
> Acked-by: Mark Michelson
> Acked-by: Han Zhou
> Signed-off-by: Ales Musil
> ---
> v4: Rebase on top of curr
On 8/16/22 08:33, Ales Musil wrote:
> The struct ovn_datapath could not be used outside the northd.c
> move it to northd.h that it can be used by other .c files later on.
>
> Reported-at: https://bugzilla.redhat.com/2084668
> Acked-by: Dumitru Ceara
> Acked-by: Mark Michelson
> Acked-by: Han Zho
On 8/16/22 08:33, Ales Musil wrote:
> Add MAC binding aging mechanism, that utilizes
> the timestamp column of MAC_Binding table.
> When the MAC binding exceeds the threshold it is
> removed from SB DB, this is postponed only in case
> we receive update ARP with update to MAC address.
>
> The thre
On 8/16/22 08:33, Ales Musil wrote:
> Add configuration option into NB global table
> called "mac_binding_removal_limit" defaulting to 0.
> This option allows to limit number of MAC bindings
> that can be removed by the aging mechanism in a single
> transaction. The 0 means that the mechanism is di
On 8/16/22 08:33, Ales Musil wrote:
> It can happen that northd and SB DB are updated before ovn-controller
> in that case the new MAC binding would be added with timestamp=0.
> In combination with enabled MAC binding aging, the affected rows
> would be deleted over and over until the controller is
From: ldejing
Implementation on Windows:
IPv6 conntrack ip fragment feature use a link list to store ip
fragment. When ipv6 fragment module receives a fragment packet,
it will store length of the fragment, until to the received length
equal to the packet length before fragmented, it will reassemb
From: ldejing
This patch implemented meter action, currently, meter only support drop
method and only support one band. The overall implementation is, when a
packet comes in, it will first lookup meter according to the meter id,
then get the band->rates and delta time since last access the same m
On 8/16/22 13:05, Dumitru Ceara wrote:
> On 8/16/22 08:33, Ales Musil wrote:
>> Add MAC binding aging mechanism, that utilizes
>> the timestamp column of MAC_Binding table.
>> When the MAC binding exceeds the threshold it is
>> removed from SB DB, this is postponed only in case
>> we receive update
On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSPAN tunnels to not work, because
flow is offloaded, but ERSPAN options are not prov
Hi! We discovered a memory leak in ovn-northd, which grows quickly, caused by
commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 (dated Wed Feb 23 09:30:00 2022
+). We also found a fix for it. I am however not familiar with this code,
so when I looked a bit further, I wondered if a different vari
Hi! We discovered a memory leak in ovn-northd, which grows quickly, caused by
commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 (dated Wed Feb 23 09:30:00 2022
+). We also found a fix for it. I am however not familiar with this code,
so when I looked a bit further, I wondered if a different va
On 8/16/22 13:42, Roi Dayan wrote:
>
>
> On 2022-08-14 5:46 PM, Ilya Maximets wrote:
>> Current offloading code supports only limited number of tunnel keys
>> and silently ignores everything it doesn't understand. This is
>> causing, for example, offloaded ERSPAN tunnels to not work, because
>>
References: <20220816111632.24236-1-svc.ovs-commun...@vmware.com>
Bleep bloop. Greetings ldejing, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author ldejing needs to
On 8/16/22 13:57, Ilya Maximets wrote:
> On 8/16/22 13:42, Roi Dayan wrote:
>>
>>
>> On 2022-08-14 5:46 PM, Ilya Maximets wrote:
>>> Current offloading code supports only limited number of tunnel keys
>>> and silently ignores everything it doesn't understand. This is
>>> causing, for example, offl
On 2022-08-16 2:57 PM, Ilya Maximets wrote:
On 8/16/22 13:42, Roi Dayan wrote:
On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSP
On 8/16/22 14:37, Ilya Maximets wrote:
> On 8/16/22 13:57, Ilya Maximets wrote:
>> On 8/16/22 13:42, Roi Dayan wrote:
>>>
>>>
>>> On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't unde
Chaoyong He says:
This PR is the updates rte_flow phases 1 and 2 for OVS-DPDK:
* Support offload of set IPv4/IPv6 DSCP action
* Support offload of IPv6 tunnel
* Add flow_api support for netdev geneve vports
* Support offload of the decap action of geneve tunnel
Chaoyong He (5):
netdev-offload-
From: Chaoyong He
Add the support of offload of set IPv4 DSCP action.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-
From: Chaoyong He
Add support of IPv6 tunnel.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 28017091f680..d1c5
From: Chaoyong He
Add the support of offload of set IPv6 DSCP action.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 7
From: Chaoyong He
Add the acceptance of geneve devices to
netdev_dpdk_flow_api() API, to allow offloading of
DPDK geneve devices.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.
From: Chaoyong He
This commit add support of geneve decap action logic, but the
GENEVE OPT is not support for now.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 67 +++
1 file changed, 67 insertions(+)
diff --git a/
On 2022-08-16 3:39 PM, Ilya Maximets wrote:
On 8/16/22 14:37, Ilya Maximets wrote:
On 8/16/22 13:57, Ilya Maximets wrote:
On 8/16/22 13:42, Roi Dayan wrote:
On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores
References: <20220816125009.508053-2-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20220816125009.508053-3-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20220816125009.508053-4-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20220816125009.508053-5-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20220816125009.508053-6-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
On 8/16/22 14:50, Simon Horman wrote:
> Chaoyong He says:
>
> This PR is the updates rte_flow phases 1 and 2 for OVS-DPDK:
>
> * Support offload of set IPv4/IPv6 DSCP action
> * Support offload of IPv6 tunnel
> * Add flow_api support for netdev geneve vports
> * Support offload of the decap actio
On 8/16/22 15:15, Ilya Maximets wrote:
> On 8/16/22 14:50, Simon Horman wrote:
>> Chaoyong He says:
>>
>> This PR is the updates rte_flow phases 1 and 2 for OVS-DPDK:
>>
>> * Support offload of set IPv4/IPv6 DSCP action
>> * Support offload of IPv6 tunnel
>> * Add flow_api support for netdev geneve
On Tue, Aug 16, 2022 at 03:15:38PM +0200, Ilya Maximets wrote:
> On 8/16/22 14:50, Simon Horman wrote:
> > Chaoyong He says:
> >
> > This PR is the updates rte_flow phases 1 and 2 for OVS-DPDK:
> >
> > * Support offload of set IPv4/IPv6 DSCP action
> > * Support offload of IPv6 tunnel
> > * Add f
On Tue, Aug 16, 2022 at 4:04 AM Peng He wrote:
>
> Hi, Mike
>
> by changing it into the function, you mean relax the checking if the state is
> either EVICTED or DELETED?
>
In my testing code, I changed it to this:
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index
Reported by UndefinedBehaviorSanitizer when running in a sandbox:
controller/ovn-controller.c:374:21: runtime error: null pointer passed as
argument 2, which is declared to never be null
/usr/include/string.h:44:28: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer:
This commit also fixes some output issues due to truncated lines
within f-strings or acl log lines that include trailing whitespace
in check_acl_log.py. It also implicitly fixes the flake8 reported
issue:
tests/check_acl_log.py:94:80: E501 line too long (80 > 79 characters)
Signed-off-by: Dumit
We currently use f-strings in some of the test tools. These are
supported only starting with python version 3.6.
Given that python version 3.4 is EOL since March 2019, it's about
time to bump the required version to 3.6:
https://www.python.org/downloads/release/python-3410/
Signed-off-by: Dumit
On Tue, Aug 16, 2022 at 1:50 PM Olaf Seibert via dev <
ovs-dev@openvswitch.org> wrote:
> Hi! We discovered a memory leak in ovn-northd, which grows quickly, caused
> by
> commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 (dated Wed Feb 23 09:30:00
> 2022
> +). We also found a fix for it. I am h
On Wed, Aug 17, 2022 at 12:58 AM Ales Musil wrote:
>
> On Tue, Aug 16, 2022 at 1:50 PM Olaf Seibert via dev <
> ovs-dev@openvswitch.org> wrote:
>
> > Hi! We discovered a memory leak in ovn-northd, which grows quickly, caused
> > by
> > commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 (dated Wed Feb
On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSPAN tunnels to not work, because
flow is offloaded, but ERSPAN options are not prov
On 2022-08-14 5:45 PM, Ilya Maximets wrote:
'wc.masks.tunnel.metadata.present.len' must be a mask for the same
field in the flow key, but in the tc_flower structure it's the real
length of metadata masks.
That is correctly handled for the individual opt->length, setting all
the masks to 0x1f
43 matches
Mail list logo
