[ovs-dev] [PATCH] raft: Fix unnecessary periodic compactions.

While creating a new database file and storing a new snapshot into it, raft module by mistake updates the base offset for the old file. So, the base offset of a new file remains zero. Then the old file is getting replaced with the new one, copying new offsets as well. In the end, after a full

Re: [ovs-dev] [PATCH ovn v3 0/5] Avoid unnecessary deletion & recreation during restart.

On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > > When ovn-controller is restarted, it may need multiple iterations of > main loop before completely download all related data from SB DB, > especially when ovn-monitor-all=false, so after restart, before it sees > the related localnet ports from

Re: [ovs-dev] [PATCH ovn v3 3/5] ovn-controller: Add a generic way to check if the daemon started recently.

On Fri, Aug 19, 2022 at 12:40 PM Dumitru Ceara wrote: > > On 8/19/22 17:42, Han Zhou wrote: > > On Fri, Aug 19, 2022 at 3:07 AM Dumitru Ceara wrote: > >> > >> On 8/19/22 02:20, Han Zhou wrote: > >>> In some cases we need to know if ovn-controller started long enough and > >>> has enough

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

On Fri, Aug 19, 2022 at 12:40 PM Dumitru Ceara wrote: > > On 8/19/22 17:35, Han Zhou wrote: > > On Fri, Aug 19, 2022 at 3:06 AM Dumitru Ceara wrote: > >> > >> On 8/19/22 11:10, Numan Siddique wrote: > >>> On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: > > On Thu, Aug 18, 2022 at

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: rely on new actions for ecmp-symmetric routing

On Fri, Aug 19, 2022 at 12:48 PM Dumitru Ceara wrote: > > On 8/19/22 17:37, Lorenzo Bianconi wrote: > >> On Fri, Jul 15, 2022 at 4:35 AM Lorenzo Bianconi < > >> lorenzo.bianc...@redhat.com> wrote: > >>> > >>> Rely on the following new actions for ecmp-symmetric routing: > >>> - chk_ecmp_nh_mac >

[ovs-dev] [PATCH] netdev-offload-tc: Parse tunnel options only for geneve ports.

Cited commit correctly fixed the issue of incorrect reporting of zero-length geneve option matches as wildcarded. But as a side effect, exact match on the metadata length was added to every tunnel flow match, even if the tunnel is not geneve. That doesn't generate any functional issues, but it

Re: [ovs-dev] [PATCH v3 4/5] netdev-offload-tc: Fix ignoring unknown tunnel keys.

On 8/17/22 08:28, Roi Dayan wrote: > > > On 2022-08-14 5:46 PM, Ilya Maximets wrote: >> Current offloading code supports only limited number of tunnel keys >> and silently ignores everything it doesn't understand.  This is >> causing, for example, offloaded ERSPAN tunnels to not work, because >>

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: rely on new actions for ecmp-symmetric routing

On 8/19/22 17:37, Lorenzo Bianconi wrote: >> On Fri, Jul 15, 2022 at 4:35 AM Lorenzo Bianconi < >> lorenzo.bianc...@redhat.com> wrote: >>> >>> Rely on the following new actions for ecmp-symmetric routing: >>> - chk_ecmp_nh_mac >>> - chk_ecmp_nh >>> - commit_ecmp_nh >>> >>> In this way OVN is able

Re: [ovs-dev] [PATCH ovn v3 3/5] ovn-controller: Add a generic way to check if the daemon started recently.

On 8/19/22 17:42, Han Zhou wrote: > On Fri, Aug 19, 2022 at 3:07 AM Dumitru Ceara wrote: >> >> On 8/19/22 02:20, Han Zhou wrote: >>> In some cases we need to know if ovn-controller started long enough and >>> has enough iterations of input processing, primarily to ensure it has >>> downloaded and

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

On 8/19/22 17:35, Han Zhou wrote: > On Fri, Aug 19, 2022 at 3:06 AM Dumitru Ceara wrote: >> >> On 8/19/22 11:10, Numan Siddique wrote: >>> On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > > When handling port_binding changes,

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: rely on new actions for ecmp-symmetric routing

On Fri, Aug 19, 2022 at 8:37 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > > On Fri, Jul 15, 2022 at 4:35 AM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > > Rely on the following new actions for ecmp-symmetric routing: > > > - chk_ecmp_nh_mac > > > -

Re: [ovs-dev] [PATCH ovn v5] controller: avoid recomputes triggered by SBDB Port_Binding updates.

Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the

[ovs-dev] [PATCH ovn] binding: fix missing localnet for local datapath

When a lrp option is set to always-redirect=false ("bridged" redirect type), local datapaths are properly updated. However, in some cases, when I+P is used, localnet ports attached to those datapaths were not properly updated. This results in missing flows and packets not going trough. This issue

Re: [ovs-dev] [PATCH ovn v3 3/5] ovn-controller: Add a generic way to check if the daemon started recently.

On Fri, Aug 19, 2022 at 3:07 AM Dumitru Ceara wrote: > > On 8/19/22 02:20, Han Zhou wrote: > > In some cases we need to know if ovn-controller started long enough and > > has enough iterations of input processing, primarily to ensure it has > > downloaded and handled a complete initial view of

[ovs-dev] [PATCH ovn v5] controller: avoid recomputes triggered by SBDB Port_Binding updates.

When VIF ports are claimed on a chassis, SBDB Port_Binding table is updated. If the SBDB IDL is still is read-only ("in transaction") when such a update is required, the update is not possible and recompute is triggered through I+P failure. This situation can happen: - after updating

Re: [ovs-dev] [PATCH ovn v4] controller: avoid recomputes triggered by SBDB Port_Binding updates.

Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: .git/rebase-apply/patch:788: new blank line at EOF. + warning: 1 line adds whitespace errors.

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: rely on new actions for ecmp-symmetric routing

> On Fri, Jul 15, 2022 at 4:35 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > Rely on the following new actions for ecmp-symmetric routing: > > - chk_ecmp_nh_mac > > - chk_ecmp_nh > > - commit_ecmp_nh > > > > In this way OVN is able to keep up if for any reason the ECMP

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

On Fri, Aug 19, 2022 at 3:06 AM Dumitru Ceara wrote: > > On 8/19/22 11:10, Numan Siddique wrote: > > On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: > >> > >> On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > >>> > >>> When handling port_binding changes, it is possible that new > >>>

[ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

CRIU is preserving ifindexes of net devices after restoration. However, current Open vSwitch API does not allow to target ifindex, so we cannot correctly restore OVS configuration. Use ovs_header->dp_ifindex during OVS_DP_CMD_NEW as desired ifindex. Use OVS_VPORT_ATTR_IFINDEX during

[ovs-dev] [PATCH net-next v2 2/3] openvswitch: fix memory leak at failed datapath creation

ovs_dp_cmd_new()->ovs_dp_change()->ovs_dp_set_upcall_portids() allocates array via kmalloc. If for some reason new_vport() fails during ovs_dp_cmd_new() dp->upcall_portids must be freed. Add missing kfree. Kmemleak example: unreferenced object 0x88800c382500 (size 64): comm "dump_state",

[ovs-dev] [PATCH net-next v2 3/3] openvswitch: add OVS_DP_ATTR_PER_CPU_PIDS to get requests

CRIU needs OVS_DP_ATTR_PER_CPU_PIDS to checkpoint/restore newest openvswitch versions. Add pids to generic datapath reply. Adjust reply allocation to reserve memory for pids and move it under ovs_lock() to ensure than number of pids is unchanged while we adding them to nlmsg. Signed-off-by:

[ovs-dev] [PATCH net-next v2 0/3] openvswitch: allow specifying ifindex of new interfaces

Hi! CRIU currently do not support checkpoint/restore of OVS configurations, but there was several requests for it. For example, https://github.com/lxc/lxc/issues/2909 The main problem is ifindexes of newly created interfaces. We realy need to preserve them after restore. Current openvswitch API

Re: [ovs-dev] [PATCH ovn v4] controller: avoid recomputes triggered by SBDB Port_Binding updates.

This patch requires a rebase on the latest main, which I'll send as v5 (I sent v4 to highlight the real differences with v3). -Xavier On Fri, Aug 19, 2022 at 5:18 PM Xavier Simonart wrote: > When VIF ports are claimed on a chassis, SBDB Port_Binding table is > updated. > If the SBDB IDL is

[ovs-dev] [PATCH ovn v4] controller: avoid recomputes triggered by SBDB Port_Binding updates.

When VIF ports are claimed on a chassis, SBDB Port_Binding table is updated. If the SBDB IDL is still is read-only ("in transaction") when such a update is required, the update is not possible and recompute is triggered through I+P failure. This situation can happen: - after updating

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: rely on new actions for ecmp-symmetric routing

On Fri, Jul 15, 2022 at 4:35 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Rely on the following new actions for ecmp-symmetric routing: > - chk_ecmp_nh_mac > - chk_ecmp_nh > - commit_ecmp_nh > > In this way OVN is able to keep up if for any reason the ECMP traffic > source changes

Re: [ovs-dev] [PATCH ovn v2 2/2] Prepare for post-22.09.0

On 8/19/22 15:45, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) LGTM, Acked-by: Ilya Maximets ___

Re: [ovs-dev] [PATCH ovn v2 1/2] Prepare for 22.09.0.

On 8/19/22 15:45, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > v2: Updated OVS reference from 2.18 to 3.0 > --- > NEWS | 6 +++--- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn v3] binding.c: update ld->peers when lsp type updated

OK, thanks for the explanation, Mohammad. I added the following comment to the test to explain what is being tested. # The below commands change the LSP from "router" type in order to ensure that # no incorrect memory accesses occur. The test passes because there is no crash # in

Re: [ovs-dev] [PATCH v2 ovn 0/3] Improve ECMP symmetric routing reliability

I have merged all the patches into main and branch-22.06 On 7/25/22 17:01, Mark Michelson wrote: For all patches in the series, Acked-by: Mark Michelson There are still references to internal concepts in the docs (OFTABLE_ECMP_NH_MAC, OFTABLE_ECMP_NH, and REGBIT_KNOWN_ECMP_NH, for

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 22.09.0.

On 8/19/22 09:14, Ilya Maximets wrote: On 8/19/22 14:50, Mark Michelson wrote: Signed-off-by: Mark Michelson --- NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index

[ovs-dev] [PATCH ovn v2 1/2] Prepare for 22.09.0.

Signed-off-by: Mark Michelson --- v2: Updated OVS reference from 2.18 to 3.0 --- NEWS | 6 +++--- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 0f12b6abf..fd8a59793 100644 --- a/NEWS +++ b/NEWS @@

[ovs-dev] [PATCH ovn v2 2/2] Prepare for post-22.09.0

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index fd8a59793..bb2441d75 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +Post v22.09.0 +- +

[ovs-dev] [PATCH] openvswitch: move from strlcpy with unused retval to strscpy

Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wolfram Sang

Re: [ovs-dev] [PATCH ovn 1/2] tests: Fix tests/check_acl_log.py outputs.

Thanks for fixing my janky code, Dumitru :) Acked-by: Mark Michelson On 8/16/22 10:53, Dumitru Ceara wrote: This commit also fixes some output issues due to truncated lines within f-strings or acl log lines that include trailing whitespace in check_acl_log.py. It also implicitly fixes the

Re: [ovs-dev] [PATCH ovn 2/2] Bump required python version to 3.6.

Acked-by: Mark Michelson On 8/16/22 10:53, Dumitru Ceara wrote: We currently use f-strings in some of the test tools. These are supported only starting with python version 3.6. Given that python version 3.4 is EOL since March 2019, it's about time to bump the required version to 3.6:

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 22.09.0.

On 8/19/22 14:50, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/NEWS b/NEWS > index 0f12b6abf..0cfe6d85b 100644 > --- a/NEWS >

[ovs-dev] [PATCH ovn 1/2] Prepare for 22.09.0.

Signed-off-by: Mark Michelson --- NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index 0f12b6abf..0cfe6d85b 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -Post v22.06.0 -- +OVN

[ovs-dev] [PATCH ovn 2/2] Prepare for post-22.09.0

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0cfe6d85b..8a9e1528f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +Post v22.09.0 +- +

Re: [ovs-dev] [PATCH 1/5] netdev-offload-dpdk: Support offload of set IPv4 DSCP action

On 8/16/2022 3:50 PM, Simon Horman wrote: From: Chaoyong He Add the support of offload of set IPv4 DSCP action. Signed-off-by: Chaoyong He Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git

Re: [ovs-dev] [PATCH 3/5] netdev-offload-dpdk: Add support of IPv6 tunnel

On 8/16/2022 3:50 PM, Simon Horman wrote: From: Chaoyong He Add support of IPv6 tunnel. IPv6 tunnel is already supported. The missing setting of is_ipv6 field affects only if using a dpdk PMD that would return restore info flags with RTE_FLOW_RESTORE_INFO_TUNNEL on, but

Re: [ovs-dev] [PATCH ovn v3 3/5] ovn-controller: Add a generic way to check if the daemon started recently.

On 8/19/22 02:20, Han Zhou wrote: > In some cases we need to know if ovn-controller started long enough and > has enough iterations of input processing, primarily to ensure it has > downloaded and handled a complete initial view of the SB DB (and of > course the local OVS DB), so that it won't

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

On 8/19/22 11:10, Numan Siddique wrote: > On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: >> >> On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: >>> >>> When handling port_binding changes, it is possible that new >>> local_datapaths are added, and the fields of the local_datapath, such as >>>

Re: [ovs-dev] [PATCH ovn v3 1/5] binding.c: Avoid checking OVSDB tracking status in handle_updated_port.

On 8/19/22 11:06, Numan Siddique wrote: > On Fri, Aug 19, 2022 at 10:21 AM Han Zhou wrote: >> >> xxx_is_deleted() is an interface that is expected to be used for OVSDB >> tracked changes only, but handle_updated_port() function handles both >> tracked and untracked rows. It may happen to behave

Re: [ovs-dev] [PATCH v2 4/4] netdev-dpdk: Add flow_api support for netdev geneve vports

References: <20220819090119.199177-5-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

Re: [ovs-dev] [PATCH v2 3/4] netdev-offload-dpdk: Add support of IPv6 tunnel

References: <20220819090119.199177-4-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

Re: [ovs-dev] [PATCH v2 2/4] netdev-offload-dpdk: Support offload of set IPv6 DSCP action

References: <20220819090119.199177-3-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

Re: [ovs-dev] [PATCH v2 1/4] netdev-offload-dpdk: Support offload of set IPv4 DSCP action

References: <20220819090119.199177-2-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: > > On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > > > > When handling port_binding changes, it is possible that new > > local_datapaths are added, and the fields of the local_datapath, such as > > localnet_port, external_ports, etc. need to be

Re: [ovs-dev] [PATCH ovn v3 1/5] binding.c: Avoid checking OVSDB tracking status in handle_updated_port.

On Fri, Aug 19, 2022 at 10:21 AM Han Zhou wrote: > > xxx_is_deleted() is an interface that is expected to be used for OVSDB > tracked changes only, but handle_updated_port() function handles both > tracked and untracked rows. It may happen to behave as expected in this > case but it is risky if

[ovs-dev] [PATCH v2 4/4] netdev-dpdk: Add flow_api support for netdev geneve vports

From: Chaoyong He Add the acceptance of geneve devices to netdev_dpdk_flow_api() API, to allow offloading of DPDK geneve devices. Signed-off-by: Chaoyong He Reviewed-by: Louis Peens Signed-off-by: Simon Horman --- lib/netdev-dpdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH v2 3/4] netdev-offload-dpdk: Add support of IPv6 tunnel

From: Chaoyong He Add support of IPv6 tunnel. Signed-off-by: Chaoyong He Reviewed-by: Louis Peens Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/netdev-offload-dpdk.c

[ovs-dev] [PATCH v2 0/4] netdev-offload-dpdk: update rte_flow phases 1 and 2

This patch series add some logics about rte_flow to ovs-dpdk, includes: * Support offload of set IPv4/IPv6 DSCP action. * Support offload of IPv6 tunnel. Changes since v1: * Revise the warning of checkpatch script. * Drop the Geneve decap patch, deferred for future Chaoyong He (4):

[ovs-dev] [PATCH v2 2/4] netdev-offload-dpdk: Support offload of set IPv6 DSCP action

From: Chaoyong He Add the support of offload of set IPv6 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Louis Peens Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/netdev-offload-dpdk.c

[ovs-dev] [PATCH v2 1/4] netdev-offload-dpdk: Support offload of set IPv4 DSCP action

From: Chaoyong He Add the support of offload of set IPv4 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Louis Peens Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git

Re: [ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

Regards, Vladislav Odintsov > On 19 Aug 2022, at 04:05, Han Zhou wrote: > > > > On Thu, Aug 18, 2022 at 12:50 PM Vladislav Odintsov > wrote: > > > Regards, > Vladislav Odintsov > >> On 18 Aug 2022, at 20:07, Han Zhou mailto:hz...@ovn.org>> >> wrote: >> >> >>

Re: [ovs-dev] [PATCH ovn v3] controller: Fix wrong controller action definition

On Thu, Aug 18, 2022 at 11:16 PM Ales Musil wrote: > > The controller action had a wrong userdata_len due to > missing subtraction of previous data len. The pointer to oc > was not moved correctly, as result it could point to wrong > memory. In order to fix that expose encode_controller_op and >

[ovs-dev] [PATCH ovn v2] controller: Fix wrong controller action definition

Han, Ales， yes, the commit has a problem, Thanks for finding and fix! wangchuanlei On Fri, Aug 19, 2022 atAs the 7:53 AM Han Zhou https://mail.openvswitch.org/mailman/listinfo/ovs-dev> > wrote: > > > On Thu, Aug 18, 2022 at 7:40 AM Mark Michelson

Re: [ovs-dev] [PATCH ovn v2] controller: Fix wrong controller action definition

On Fri, Aug 19, 2022 atAs the 7:53 AM Han Zhou wrote: > > > On Thu, Aug 18, 2022 at 7:40 AM Mark Michelson > wrote: > > > > Thanks for the fix, Ales. > > > > Acked-by: Mark Michelson > > > > On 8/18/22 05:41, Ales Musil wrote: > > > The controller action had a wrong wrong userdata_len due to >

[ovs-dev] [PATCH ovn v3] controller: Fix wrong controller action definition

The controller action had a wrong userdata_len due to missing subtraction of previous data len. The pointer to oc was not moved correctly, as result it could point to wrong memory. In order to fix that expose encode_controller_op and use it instead of manually creating the action. At the same time