On 8/19/22 15:17, Mark Michelson wrote:
> Thanks for fixing my janky code, Dumitru :)
>
> Acked-by: Mark Michelson
>
Thanks Mark for the review!
Any chance we can get this merged to main and all stable branches down
to 22.03 LTS? It's not a feature, it's just a minor change to the test
tools
On 8/30/22 12:02, Dumitru Ceara wrote:
> On 8/29/22 13:30, Xavier Simonart wrote:
>> active_v4_flows count was intialized when the northd node was computed.
>> However, neither sb_multicast_group nor en_sb_igmp_group causes northd
>> updates. Hence this count could keep increasing while processing
On 8/25/22 11:03, Dumitru Ceara wrote:
> On 8/24/22 18:32, Ilya Maximets wrote:
>> On 8/24/22 17:57, Dumitru Ceara wrote:
>>> On 8/24/22 17:49, Ilya Maximets wrote:
On 8/24/22 17:43, Ilya Maximets wrote:
> On 8/23/22 16:42, Dumitru Ceara wrote:
>> After removing the possibility of disa
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397558.html
Reported-by: Han Zhou
Signed-off-by: Dumitru Ceara
---
Note: this is a branch-22.03 specific commit in order to avoid conflicts
when cherry picking 8f841ecbe28e ("tests: Factor out reset_pcap_file()
helper.").
On 9/9/22 02:16, Han Zhou wrote:
> On Tue, Aug 9, 2022 at 3:21 AM Numan Siddique wrote:
>>
>> On Tue, Aug 9, 2022 at 5:21 PM Ales Musil wrote:
>>>
>>> On Wed, Aug 3, 2022 at 1:21 PM Dumitru Ceara wrote:
>>>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2077306
Signed-off-by:
Hi,
recently I’ve submitted two small fixes [1] and [2]. I’m wonder whether they
can be considered for the inclusion to upcoming release 22.09.0.
Also, I guess they can be treated as a bug-fixes or enhancement (not a feature)
for backport.
1:
https://patchwork.ozlabs.org/project/ovn/patch/2022
whem vm migrating from node A to node B. One ovs interface is
created on B , and attached to br-int. At this time, vm is
still on node A. On node B, In procedure of pinctrl_run,
function send_grap_rarp_prepare notice the created interface,
then send a grap, which will lead the mac table on network
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 7 Sep 2022 12:03:46 +0800 you wrote:
> Delete the redundant word 'is'.
>
> Signed-off-by: Jilin Yuan
> ---
> net/openvswitch/flow_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here
Ilya Maximets writes:
> On 8/4/22 18:07, Paolo Valerio wrote:
>> This patch avoids to show flags_orig/flags_reply key if they have no value.
>> E.g., the following:
>>
>> NEW tcp,orig=([...]),reply=([...]),id=1800618864,
>> status=CONFIRMED|SRC_NAT_DONE|DST_NAT_DONE,timeout=120,
>> protoinfo=(st
On 9/9/22 07:26, Han Zhou wrote:
> Thanks for the review and sorry for the late response.
>
> On Tue, Aug 23, 2022 at 5:22 AM Dumitru Ceara wrote:
>>
>> Hi Han,
>>
>> On 8/23/22 06:44, Han Zhou wrote:
>>> On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote:
The column was not tracked before
On Fri, Sep 9, 2022 at 2:11 AM Ales Musil wrote:
>
> On Fri, Sep 9, 2022 at 7:43 AM Han Zhou wrote:
>
> >
> >
> > On Tue, Sep 6, 2022 at 6:02 AM Ales Musil wrote:
> > >
> > > The current behavior is that load balancers
> > > default to tcp protocol if it is not specified.
> > > However, this is
On Fri, Sep 9, 2022 at 2:40 PM Numan Siddique wrote:
> On Fri, Sep 9, 2022 at 2:11 AM Ales Musil wrote:
> >
> > On Fri, Sep 9, 2022 at 7:43 AM Han Zhou wrote:
> >
> > >
> > >
> > > On Tue, Sep 6, 2022 at 6:02 AM Ales Musil wrote:
> > > >
> > > > The current behavior is that load balancers
> >
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
While Mirror creation just creates the mirror, the lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
OVS already supports Port Mirroring.
Note: This is targeted to mirror to destinations anywhere
On 9/9/22 14:46, Ales Musil wrote:
> On Fri, Sep 9, 2022 at 2:40 PM Numan Siddique wrote:
>
>> On Fri, Sep 9, 2022 at 2:11 AM Ales Musil wrote:
>>>
>>> On Fri, Sep 9, 2022 at 7:43 AM Han Zhou wrote:
>>>
On Tue, Sep 6, 2022 at 6:02 AM Ales Musil wrote:
>
> The current beh
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1959 FILE: utilities/ovn-nbctl.c:275:
mirror-a
At some point in OVS history, some virtio features were announced as
supported (ECN and UFO virtio features).
The userspace TSO code, which has been added later, does not support
those features and tries to disable them.
This breaks OVS upgrades: if an existing VM already negotiated such
features
On Tue, Jul 12, 2022 at 9:54 AM Maxime Coquelin
wrote:
>
>
>
> On 7/11/22 23:06, David Marchand wrote:
> > On Wed, Jul 6, 2022 at 11:00 PM David Marchand
> > wrote:
> >>
> >> On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick wrote:
> >>>
> >>> From: Flavio Leitner
> >>>
> >>> Now that there is a seg
On 9/7/22 22:26, Ilya Maximets wrote:
> ovn_northd_lb_lookup() takes significant percent of northd runtime
> in scenarios with large number of load balancers. In many cases,
> like in ovn-kubernetes, a lot of load balancers are actually groupped
> and applied to most of the switches and routers.
On 9/7/22 22:26, Ilya Maximets wrote:
> Filling arrays of switches and routers for load balancers
> one-by-one is not very efficient. Copying them in bulk
> allows to save a noticeable amount of time in setups with
> large load balancer groups.
>
> Signed-off-by: Ilya Maximets
> ---
> lib/lb.c
On 9/7/22 22:26, Ilya Maximets wrote:
> Options like 'add_route' and 'neighbor_responder' are looked up
> in the smap for each load balancer for each datapath and it takes
> significant amount of time. Checking them only once to speed up
> processing. 'skip_snat' and 'event' are not that critical
On 9/7/22 22:26, Ilya Maximets wrote:
> If the same load balancer group is attached to multiple routers,
> IP sets will be constructed for each of them by sequentially calling
> sset_add() for each IP for each load balancer for each router.
> Instead of doing that, we can create IP sets for load ba
Greetings,
This is to let you know that we are executing upgrades today for the open
0-day robot that we run for OVS and DPDK projects. We don't expect that
the robot will be offline for a very long time, but just note that there
will be some down time as we bring the systems back online.
Upgrad
On 8/1/22 20:48, Timothy Redaelli wrote:
> Since on CentOS/RHEL the builds are based on stable branches and not on
> tags for debugging purpose it's better to have the downstream version as
> version so it's easier to know which commits are included in a build.
That makes sense to me. See some co
On 8/2/22 06:01, we...@chinatelecom.cn wrote:
> From: wenxu
>
> There is a big scope ct_lock for new conn setup. The
> ct_lock should be hold only for conns map insert and
> expire rculist insert.
>
> Signed-off-by: wenxu
> ---
> lib/conntrack.c | 32
> 1 file
On 9/7/22 15:15, Aaron Conole wrote:
> With 'netfilter: remove nf_conntrack_helper sysctl toggle' applied, the
> nf_conntrack_helper sysctl knob is removed. The testsuite has been forcibly
> disabling this knob anyway, but the use of sysctl will still error out
> on an invalid key. By adding 'e'
On 9/8/22 13:15, Michael Phelan wrote:
> CI Linux build script updated to use DPDK version 21.11.2.
> Documentation updated to use DPDK version 21.11.2.
> NEWS entry added for DPDK 21.11.2 validation.
> Updated FAQ to recommend use of DPDK version 21.11.2.
>
> Signed-off-by: Michael Phelan
> ---
On 9/8/22 09:37, Daniel Ding wrote:
> If ovs-tcpdump received HUP or TERM signal, mirror and mirror
> interface should be destroyed. This often happens, when
> controlling terminal is closed, like ssh session closed, and
> other users use kill to terminate it.
>
> Acked-by: Mike Pattrick
> Signed
Hi David,
Thanks for working on this patch!
It seems possible to change this patch later when the other TSO series
gets merged to disable TSO only on the affected port.
Mike, any thoughts?
I made a couple comments below.
On Fri, Sep 9, 2022 at 10:57 AM David Marchand
wrote:
> At some point in
On Fri, Sep 9, 2022 at 1:08 AM Dumitru Ceara wrote:
>
> Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397558.html
> Reported-by: Han Zhou
> Signed-off-by: Dumitru Ceara
> ---
> Note: this is a branch-22.03 specific commit in order to avoid conflicts
> when cherry pic
On Fri, Sep 9, 2022 at 1:09 AM Dumitru Ceara wrote:
>
> On 9/9/22 02:16, Han Zhou wrote:
> > On Tue, Aug 9, 2022 at 3:21 AM Numan Siddique wrote:
> >>
> >> On Tue, Aug 9, 2022 at 5:21 PM Ales Musil wrote:
> >>>
> >>> On Wed, Aug 3, 2022 at 1:21 PM Dumitru Ceara
wrote:
> >>>
> Reported-at:
The column was not tracked before while it should. The column includes
many ovn-controller global configurations that could impact the way
flows are computed. It worked before because lots of the configurations
are also populated to OVN-SB DB's chassis table, and as a result the SB
DB change would
This patch adjusts the order of adding tracked and untracked columns
to monitoring, to workaround a problem in OVS IDL that could end up
overwriting the track flag. A XXX comment is added for future
improvement.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c | 26 ---
On Fri, Sep 9, 2022 at 4:41 AM Dumitru Ceara wrote:
>
> On 9/9/22 07:26, Han Zhou wrote:
> > Thanks for the review and sorry for the late response.
> >
> > On Tue, Aug 23, 2022 at 5:22 AM Dumitru Ceara wrote:
> >>
> >> Hi Han,
> >>
> >> On 8/23/22 06:44, Han Zhou wrote:
> >>> On Tue, Jul 5, 2022
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#26 FILE: controller/ovn-controller.c:931:
* XXX: when the s
13.1 got released in May and now we have problems updating
some packages in 13.0 and CI is failing.
Update to 13.1 to unblock the CI.
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index b686bdbf2..e3c1c
On 9/9/22 17:08, Dumitru Ceara wrote:
> On 9/7/22 22:26, Ilya Maximets wrote:
>> ovn_northd_lb_lookup() takes significant percent of northd runtime
>> in scenarios with large number of load balancers. In many cases,
>> like in ovn-kubernetes, a lot of load balancers are actually groupped
>> and ap
Filling arrays of switches and routers for load balancers
one-by-one is not very efficient. Copying them in bulk
allows to save a noticeable amount of time in setups with
large load balancer groups.
Acked-by: Dumitru Ceara
Signed-off-by: Ilya Maximets
---
lib/lb.c| 27 +
Re-compute of 'northd' node in ovn-northd may take almost half of the
total processing time in case there is a big number of load balancers
applied to multiple switches/routers or if there are huge load balancer
groups applied to them. The latter is a common case for ovn-kubernetes
clusters.
This
Options like 'add_route' and 'neighbor_responder' are looked up
in the smap for each load balancer for each datapath and it takes
significant amount of time. Checking them only once to speed up
processing. 'skip_snat' is not that critical, but it's better to
get all of them in a single place.
Al
ovn_northd_lb_lookup() takes significant percent of northd runtime
in scenarios with large number of load balancers. In many cases,
like in ovn-kubernetes, a lot of load balancers are actually groupped
and applied to most of the switches and routers. So, instead of
looking up all the same load ba
If the same load balancer group is attached to multiple routers,
IP sets will be constructed for each of them by sequentially calling
sset_add() for each IP for each load balancer for each router.
Instead of doing that, we can create IP sets for load balancer
groups and clone them. That will avoid
Hi David,
We had a similar thought process and interested in this patch.
Wondering if we could help you out on making progress on this patch ?
Thanks
Thilak Raj S
-Original Message-
From: dev On Behalf Of David Marchand
Sent: 28 March 2022 07:18
To: d...@openvswitch.org
Subject: [ovs-dev
42 matches
Mail list logo
