Re: [ovs-dev] [RFC PATCH] netdev-dpdk: add control plane protection support

2022-09-21 Thread Robin Jarry
Hi Thilak, Thilak Raj Surendra Babu, Sep 22, 2022 at 07:16: > Could we call rte_flow_validate() before calling flow_create ? At first, I thought it would not be necessary hence skipped the validation and I am only relying on the driver to reject the rule if not supported. However, it may be a bit

Re: [ovs-dev] [PATCH ovn 1/3] controller: Remove unnecessary IDL table casts.

2022-09-21 Thread Han Zhou
On Wed, Sep 14, 2022 at 6:09 AM Dumitru Ceara wrote: > > There's no need to explicitly cast the result of EN_OVSDB_GET() to the IDL > table type. The only thing we need is to match constness. That's also > fine because, as a matter of fact, IDL table objects should never be > changed by IDL clie

Re: [ovs-dev] [PATCH ovn 2/3] controller: Avoid building dhcp/nd_ra/controller_event opt maps every time.

2022-09-21 Thread Han Zhou
On Wed, Sep 14, 2022 at 6:09 AM Dumitru Ceara wrote: > Thanks Dumitru for the improvement. > The nd_ra_opts and controller_event_ops are actually static they never > change at runtime. DHCP records can instead be computed when populating > the lflow "input context" to be used during incremental

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: add control plane protection support

2022-09-21 Thread Thilak Raj Surendra Babu
Hi Robin, Nice! I have been also working on a similar line but in a different context of steering the flows toward the right RXQ based on the guest MAC-address. Will send out a patch in a day or two. Please find some comments inline for my understanding. Thanks Thilak Raj S -Original Messag

Re: [ovs-dev] [RFC PATCH ovn 0/5] Add OVN component templates.

2022-09-21 Thread Han Zhou
Thanks Dumitru for this promising optimization! On Thu, Aug 11, 2022 at 1:03 AM Dumitru Ceara wrote: > > On 8/10/22 19:54, Mark Michelson wrote: > > Hi Dumitru, > > > > Hi Mark, > > > I read the patch series, and I think the idea of chassis-specific > > variables is a good idea to reduce the numb

[ovs-dev] [PATCH] db-ctl-base: Use partial map/set updates for last add/set commands.

2022-09-21 Thread Ilya Maximets
Currently, command to add one item into a large set generates the transaction with the full new content of that set plus 'wait' operation for the full old content of that set. So, if we're adding one new load-balancer into a load-balancer group in OVN using ovn-nbctl, transaction will include all

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Alin-Gabriel Serdean
Congrats, Dumitru ! Alin. -Original Message- From: dev On Behalf Of Numan Siddique Sent: Wednesday, September 21, 2022 7:49 PM To: Dumitru Ceara Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara. On Wed, Sep 21, 2022 at 11:33 AM Dumitru Ceara w

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Numan Siddique
On Wed, Sep 21, 2022 at 11:33 AM Dumitru Ceara wrote: > > On 9/21/22 16:03, Mark Michelson wrote: > > Acked-by: Mark Michelson > > > > Congrats, Dumitru! Thanks. Applied to main. Congrats, Dumitru ! Numan > > > > On 9/21/22 07:20, num...@ovn.org wrote: > >> From: Numan Siddique > >> > >> Du

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: add control plane protection support

2022-09-21 Thread 0-day Robot
Bleep bloop. Greetings Robin Jarry, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #133 FILE: Documentation/topics/dp

[ovs-dev] [RFC PATCH] netdev-dpdk: add control plane protection support

2022-09-21 Thread Robin Jarry
Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of such protocols is dropped, it can cause li

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Dumitru Ceara
On 9/21/22 16:03, Mark Michelson wrote: > Acked-by: Mark Michelson > > Congrats, Dumitru! > > On 9/21/22 07:20, num...@ovn.org wrote: >> From: Numan Siddique >> >> Dumitru was elected by the OVN committers on 20-Sep-2022.  Welcome to the >> team, Dumitru! >> >> Signed-off-by: Numan Siddique >>

Re: [ovs-dev] [v3] dpdk: Use DPDK 21.11.2 release.

2022-09-21 Thread 0-day Robot
Bleep bloop. Greetings Michael Phelan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 102 characters long (recommended limit is 79) #111 FILE: NEWS:19: ht

[ovs-dev] [v3] dpdk: Use DPDK 21.11.2 release.

2022-09-21 Thread Michael Phelan
Update OVS CLI and relevant documentation to use DPDK 21.11.2. DPDK 21.11.2 contains fixes for the CVEs listed below: CVE-2022-28199 [1] CVE-2022-2132 [2] A bug was introduced in DPDK 21.11.1 by the commit 01e3dee29c02 ("vhost: fix unsafe vring addresses modifications"). This bug can cause a dea

Re: [ovs-dev] [PATCH ovn] tests: Add missing ovn_wait_remote_input_flows() implementation.

2022-09-21 Thread Dumitru Ceara
On 9/1/22 22:20, Dumitru Ceara wrote: > On 9/1/22 22:17, Dumitru Ceara wrote: >> This implementation was removed by accident between V4 [0] and V5 [1] >> of a7c7d4519e50 ("controller: avoid recomputes triggered by SBDB >> Port_Binding updates."). >> >> [0] >> https://patchwork.ozlabs.org/project/o

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-09-21 Thread Paolo Valerio
Hello Han, "Han Ding" writes: > Commit ba07cf222a add the feature "Handle gratuitous ARP requests and > replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch > the destination address of the ARP is matched against the known xbridge > addresses. > So the modification of co

Re: [ovs-dev] [PATCH] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-21 Thread Flavio Leitner
On Tue, Sep 20, 2022 at 2:21 PM David Marchand wrote: > On Mon, Sep 12, 2022 at 4:47 PM Flavio Leitner wrote: > > On Mon, Sep 12, 2022 at 5:52 AM David Marchand < > david.march...@redhat.com> wrote: > >> On Fri, Sep 9, 2022 at 7:58 PM Flavio Leitner wrote: > >> > > >> > Thanks for working on th

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Mark Michelson
Acked-by: Mark Michelson Congrats, Dumitru! On 9/21/22 07:20, num...@ovn.org wrote: From: Numan Siddique Dumitru was elected by the OVN committers on 20-Sep-2022. Welcome to the team, Dumitru! Signed-off-by: Numan Siddique --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) di

[ovs-dev] [PATCH ovn] spec: require python3-openvswitch for ovn-detrace

2022-09-21 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- rhel/ovn-fedora.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in index 821eb03cc..57dc977c1 100644 --- a/rhel/ovn-fedora.spec.in +++ b/rhel/ovn-fedora.spec.in @@ -65,6 +65,7 @@ BuildRequires: tcpdum

[ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread numans
From: Numan Siddique Dumitru was elected by the OVN committers on 20-Sep-2022. Welcome to the team, Dumitru! Signed-off-by: Numan Siddique --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index fff2cd977..a4012a5cf 100644 --- a/MAINTA

Re: [ovs-dev] [v2] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-09-21 Thread David Marchand
On Tue, Sep 20, 2022 at 3:19 PM Emma Finn wrote: > > This commit adds support for the AVX512 implementation of the > ipv6_set_addrs action as well as an AVX512 implementation of > updating the L4 checksums. > > Signed-off-by: Emma Finn > > --- > v2: > - Added check for availbility of s6_addr32

Re: [ovs-dev] [ovs-dev, ovs-dev, v2, 4/4] dpif-netdev: fix inconsistent processing between ukey and megaflow

2022-09-21 Thread 王志克
Hi Hepeng, Can you please explain the sequence that how this inconsistence could happen? Why you believe the current actions in existing netdev_flow is old? Thanks. Br, wangzhike

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Cleanup mempool selection code.

2022-09-21 Thread Pai G, Sunil
Hi David, Generally, looks good, one minor nit inline. > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Thursday, August 25, 2022 3:55 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH 3/3] netdev-dpdk: Cleanup mempool selection > code. > > Propagating per_

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Move DPDK netdev related configuration.

2022-09-21 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Thursday, August 25, 2022 3:55 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH 2/3] netdev-dpdk: Move DPDK netdev related > configuration. > > vhost related configuration and per port memory are netdev-dpdk > c

Re: [ovs-dev] [PATCH v2] utilities: Add revalidator measurement script and needed USDT probes.

2022-09-21 Thread Eelco Chaudron
On 21 Sep 2022, at 11:17, Eelco Chaudron wrote: > On 20 Sep 2022, at 20:52, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>> This patch adds a Python script that can be used to analyze the >>> revalidator runs by providing statistics (including some real time >>> graphs). >>> >>> The USDT

Re: [ovs-dev] [PATCH v2] utilities: Add revalidator measurement script and needed USDT probes.

2022-09-21 Thread Eelco Chaudron
On 20 Sep 2022, at 20:52, Aaron Conole wrote: > Eelco Chaudron writes: > >> This patch adds a Python script that can be used to analyze the >> revalidator runs by providing statistics (including some real time >> graphs). >> >> The USDT events can also be captured to a file and used for >> late

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Cleanup code when DPDK is disabled.

2022-09-21 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Thursday, August 25, 2022 3:55 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH 1/3] netdev-dpdk: Cleanup code when DPDK is > disabled. > > Remove one unused stub: netdev_dpdk_register() can't be called if DP