Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-10 Thread Wentao Jia
Hi, Numan The previous patch is wrong, because the snat lflow is added to the lr_out_undnat stage and action is ct_dnat_in_czone.(table=1 lflow) table=3 (lr_out_snat), priority=153 , match=(ip && ip4.src == 192.168.200.0/24 && outport == "lrp-0e701852-85a0-4c57-8014-77a8607a9406" &&

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-10 Thread Numan Siddique
On Sun, Oct 9, 2022 at 5:03 AM Wentao Jia wrote: > > Hi, Numan > > Sorry for long delay > > Base on your suggestions, lflow ct_snat_in_czone is split into 2 lflows,one > lflow for ct.new, and other for ct.est. > table=3 (lr_out_snat), priority=154 , match=(ct.est && ip && > ip4.src

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Fix bond port unable to capture jumbo frames.

2022-10-10 Thread Aaron Conole
mit...@outlook.com writes: > From: Lin Huang > > Currently the ovs-tcpdump utility creates a tap port to capture the > frames of a bond port. > > If a user want to capture the packets from the bond port which member > interface's mtu is more than 1500. By default the utility creates a > tap port

[ovs-dev] [PATCH AUTOSEL 4.9 02/16] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 4.9 01/16] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 4.14 03/23] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 4.14 02/23] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 4.19 03/25] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 4.19 02/25] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 5.4 04/29] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 5.4 05/29] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 5.15 07/46] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 5.10 04/34] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 5.15 06/46] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 5.10 05/34] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 5.19 09/73] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

[ovs-dev] [PATCH AUTOSEL 5.19 08/73] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 6.0 09/77] openvswitch: Fix double reporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit 1100248a5c5ccd57059eb8d02ec077e839a23826 ] Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for

[ovs-dev] [PATCH AUTOSEL 6.0 10/77] openvswitch: Fix overreporting of drops in dropwatch

2022-10-10 Thread Sasha Levin
From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller

Re: [ovs-dev] [PATCH ovn v3 2/3] northd: add drop-debug-mode to add explicit drops

2022-10-10 Thread Dumitru Ceara
On 10/10/22 17:55, Adrian Moreno wrote: > > > On 10/10/22 13:56, Dumitru Ceara wrote: >> On 9/27/22 09:31, Adrian Moreno wrote: >>> Add a new config flag called "drop-debug-mode" that makes northd add an >>> explicit default drop to all tables that currently do not have a default >>> (prio=0,

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix bond port unable to capture jumbo frames.

2022-10-10 Thread lin huang
Hi Aaron, Pls review my patch. Thanks a lot. > -Original Message- > From: dev On Behalf Of > mit...@outlook.com > Sent: Wednesday, October 5, 2022 8:12 PM > To: ovs-dev@openvswitch.org; i.maxim...@ovn.org; ktray...@redhat.com > Cc: Lin Huang > Subject: [ovs-dev] [PATCH] ovs-tcpdump:

Re: [ovs-dev] [PATCH ovn v3 2/3] northd: add drop-debug-mode to add explicit drops

2022-10-10 Thread Adrian Moreno
On 10/10/22 13:56, Dumitru Ceara wrote: On 9/27/22 09:31, Adrian Moreno wrote: Add a new config flag called "drop-debug-mode" that makes northd add an explicit default drop to all tables that currently do not have a default (prio=0, match=1) lflow. In the controller side, also add explicit

Re: [ovs-dev] [PATCH] json: Fix deep copy of objects and arrays.

2022-10-10 Thread Dumitru Ceara
On 7/1/22 13:11, Ilya Maximets wrote: > When reference counting for json objects was introduced the > old json_clone() function became json_deep_clone(), but it > still calls shallow json_clone() while cloning objects and > arrays not really producing a deep copy. > > Fixing that by making other

Re: [ovs-dev] [PATCH] ovsdb: Fix race for datum JSON string reference counter.

2022-10-10 Thread Dumitru Ceara
On 10/10/22 15:11, Ilya Maximets wrote: > Compaction thread supposed to not change anything in the database > it is working on, since the same data can be accessed by the main > thread at the same time. However, while converting database rows > to JSON objects, strings in the datum will be cloned

Re: [ovs-dev] [PATCH ovn v3 1/3] actions: add sample action

2022-10-10 Thread Adrian Moreno
On 10/10/22 14:10, Dumitru Ceara wrote: On 9/27/22 09:31, Adrian Moreno wrote: sample ovn action encodes into the OFPACT_SAMPLE ovs action. OVN action allows the following parameters: - obs_domain_id: 8-bit integer that identifies the sampling application. This value will be combined

[ovs-dev] [PATCH] ovsdb: Fix race for datum JSON string reference counter.

2022-10-10 Thread Ilya Maximets
Compaction thread supposed to not change anything in the database it is working on, since the same data can be accessed by the main thread at the same time. However, while converting database rows to JSON objects, strings in the datum will be cloned using json_clone(), which is a shallow copy,

Re: [ovs-dev] [PATCH ovn v3 1/3] actions: add sample action

2022-10-10 Thread Dumitru Ceara
On 9/27/22 09:31, Adrian Moreno wrote: > sample ovn action encodes into the OFPACT_SAMPLE ovs action. > > OVN action allows the following parameters: > > - obs_domain_id: 8-bit integer that identifies the sampling application. > This value will be combined with the datapath's tunnel_id to form

Re: [ovs-dev] [PATCH ovn v3 2/3] northd: add drop-debug-mode to add explicit drops

2022-10-10 Thread Dumitru Ceara
On 9/27/22 09:31, Adrian Moreno wrote: > Add a new config flag called "drop-debug-mode" that makes northd add an > explicit default drop to all tables that currently do not have a default > (prio=0, match=1) lflow. > > In the controller side, also add explicit default drop rules on physical >

Re: [ovs-dev] [PATCH dpdk-latest v2 2/3] netdev-dpdk: Drop reference to Rx header split.

2022-10-10 Thread Pai G, Sunil
> -Original Message- > From: David Marchand > Sent: Friday, October 7, 2022 4:46 PM > To: d...@openvswitch.org > Cc: Stokes, Ian ; ktray...@redhat.com; > maxime.coque...@redhat.com; Pai G, Sunil > Subject: [PATCH dpdk-latest v2 2/3] netdev-dpdk: Drop reference to Rx > header split. >

Re: [ovs-dev] [ovs-dev v3 3/4] ofproto-dpif-upcall: new ukey needs to take the old ukey's dump seq

2022-10-10 Thread Eelco Chaudron
On 8 Oct 2022, at 7:31, Peng He wrote: > Hi,Eelco, > > Which kernel version you have tested on? I’m on Fedora 35, Linux ebuild 5.15.7-200.fc35.x86_64 > I've also tested the #50 for several hundreds times, but only get 0 packets > once. Odd, not sure what’s going on, might just rebuild my

Re: [ovs-dev] [PATCH v4 3/3] dpif-netdev: fix inconsistent processing between ukey and megaflow

2022-10-10 Thread Eelco Chaudron
On 8 Oct 2022, at 5:27, Peng He wrote: > Hi,Eelco > > after a second thought, I think this patch is not needed neither, > the code here is trying to find a rule which cover the packet, > it does not mean the match and action of rule equals to the ones > of the ukey. > > So the code here is just

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Update tunnel neighbor when receive gratuitous arp.

2022-10-10 Thread Han Ding
Thanks for reviewing. I will change them in next version. -- Han Ding >Hello Han, > >"Han Ding" writes: > >> Commit ba07cf222a add the feature "Handle gratuitous ARP requests and >> replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch >> the destination