Re: [ovs-dev] [PATCH v2 3/3] dpif-netlink: Move meter features reset from wrapper

> On Nov 3, 2022, at 3:38 PM, Ilya Maximets wrote: > > On 11/3/22 09:47, Roi Dayan wrote: >> >> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c >> index a620a6ec52dd..2bdd2137af36 100644 >> --- a/lib/dpif-netlink.c >> +++ b/lib/dpif-netlink.c >> @@ -4105,7 +4105,7 @@

Re: [ovs-dev] [PATCH v2 3/3] dpif-netlink: Move meter features reset from wrapper

On 11/3/22 09:47, Roi Dayan wrote: > Remove the redundant null pointer assignment and move > the features reset from wrapper caller to the get features > function to be consistent that dpif wrappers just call > the dpif class implemented callback and not doing > anything else. > > CC: Justin

Re: [ovs-dev] [PATCH] flow: Consistent VXLAN UDP src ports for fragmented packets

On 11/3/22 13:11, Hemanth Aramadaka via dev wrote: > Issue: > > The src-port for UDP is based on RSS hash in the packet metadata. > In case of packets coming from VM it will be 5-tuple, if available, > otherwise just IP addresses.If the VM fragments a large IP packet > and sends the fragments to

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

You could probably detect the version automatically: if there's a ":" char in the address, then it's 6. On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > >

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On Thu, Nov 3, 2022 at 1:16 PM Ilya Maximets wrote: > > > > > > On 11/3/22 13:11, David Marchand wrote: > > > > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets > > wrote: > > > >> Can we bump meson to that new version on all branches? > > > > > > > > I would not expect an issue, but I did not test

[ovs-dev] [PATCH] ci: Update meson requirement for DPDK.

The current version of meson used for building DPDK is 0.49.2. This has the restriction of holding the required python version to 3.9. A recent change [1] in DPDK bumped requirements on meson to 0.53.2. Update the version of meson used to build DPDK to 0.53.2 to remove the restriction. [1]

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

> On Thu, Nov 3, 2022 at 1:16 PM Ilya Maximets wrote: > > > > On 11/3/22 13:11, David Marchand wrote: > > > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets > wrote: > > >> Can we bump meson to that new version on all branches? > > > > > > I would not expect an issue, but I did not test it. > > >

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

On Thu, Nov 3, 2022 at 7:10 AM Xavier Simonart wrote: > > On Wed, Nov 2, 2022 at 3:31 PM Dumitru Ceara wrote: > > > On 11/2/22 15:21, Numan Siddique wrote: > > > On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart > > wrote: > > >> > > >> Hi Numan, Dumitru > > >> > > >> Thanks for looking at this

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On Thu, Nov 3, 2022 at 1:16 PM Ilya Maximets wrote: > > On 11/3/22 13:11, David Marchand wrote: > > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets wrote: > >> Can we bump meson to that new version on all branches? > > > > I would not expect an issue, but I did not test it. > > Do you want me to

[ovs-dev] [PATCH] flow: Consistent VXLAN UDP src ports for fragmented packets

Issue: The src-port for UDP is based on RSS hash in the packet metadata. In case of packets coming from VM it will be 5-tuple, if available, otherwise just IP addresses.If the VM fragments a large IP packet and sends the fragments to ovs, only the first fragment will contain the L4 header.

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On 11/3/22 13:11, David Marchand wrote: > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets wrote: >> Can we bump meson to that new version on all branches? > > I would not expect an issue, but I did not test it. > Do you want me to have a try? If you have time, that would be nice. Thanks! > >>

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets wrote: > Can we bump meson to that new version on all branches? I would not expect an issue, but I did not test it. Do you want me to have a try? > > The old meson holds us at old python 3.9. We will be able > to remove that restriction after

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On 11/3/22 09:57, Stokes, Ian wrote: >> On Thu, Nov 3, 2022 at 12:50 AM Ian Stokes wrote: >>> >>> A recent change [1] in DPDK bumped requirements on meson to 0.53.2. >>> >>> [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e >>> >>> Signed-off-by: Ian Stokes >> >> Now that rc2 is out, I was

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On Thu, Nov 3, 2022 at 9:57 AM Stokes, Ian wrote: > > > On Thu, Nov 3, 2022 at 12:50 AM Ian Stokes wrote: > > > > > > A recent change [1] in DPDK bumped requirements on meson to 0.53.2. > > > > > > [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e > > > > > > Signed-off-by: Ian Stokes > > >

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

On Wed, Nov 2, 2022 at 3:31 PM Dumitru Ceara wrote: > On 11/2/22 15:21, Numan Siddique wrote: > > On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart > wrote: > >> > >> Hi Numan, Dumitru > >> > >> Thanks for looking at this patch and for your feedback. > >> > >> > >> On Tue, Nov 1, 2022 at 10:41 PM

Re: [ovs-dev] [PATCH v2] tc: On last action use drop action attribute instead of pipe

On Wed, Nov 02, 2022 at 08:22:30AM -0700, Han Zhou wrote: > On Wed, Nov 2, 2022 at 5:59 AM Simon Horman > wrote: ... > > Backport applied to branch-3.0 > > > > * eb8ebf8c43b5 ("doc: Add meter offload topic document") > > https://github.com/openvswitch/ovs/commit/eb8ebf8c43b5 > > This seems

Re: [ovs-dev] [PATCH ovn 2/2] northd: Allow related traffic through LB

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #107 FILE:

Re: [ovs-dev] [PATCH ovn v2 4/4] pinctrl: Send RARPs for external ipv6 interfaces

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn v2 3/4] ovn-macros: support ipv6 in ovn_attach

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn v2 2/4] northd: handle own rarps like garps

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn v2 1/4] logical-fields: add rarp fields

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH ovn 1/2] actions: Add new action called ct_commit_nat

Add action called ct_commit_nat, that performs NAT while committing the connection. This is useful for related traffic on which we need to perform NAT, mainly ICMP. We need to commit due to design decision of OvS[0]: "Connections identified as rel are separate from the originating connection and

[ovs-dev] [PATCH ovn 2/2] northd: Allow related traffic through LB

In order to allow realted traffic use the new action ct_commit_nat, which ensures that the traffic is commited and NATted. In combination with match on ct.rel it allows the related traffic to go through with correct NAT being applied. Reported-at: https://bugzilla.redhat.com/2126083

[ovs-dev] [PATCH ovn 0/2] Allow related traffic for LB

The related traffic wasn't correctly forwarded through the LB, the main issue was that the traffic was not NATted. This series allows the NAT to be applied and the traffic should arrive with correct addresses. Ales Musil (2): actions: Add new action called ct_commit_nat northd: Allow related

[ovs-dev] [PATCH ovn v2 2/4] northd: handle own rarps like garps

Previously graceful rarps sent from ovn-controller were handled as normal packets and flooded to other routers. As the other routers should already have that information, we can skip flooding (just like it is done for GARPs already) and thereby mitigate ovs refusing to send the packet because of

[ovs-dev] [PATCH ovn v2 4/4] pinctrl: Send RARPs for external ipv6 interfaces

previously garps/rarps were only sent for NAT IPs if these had an ipv4 address attached. For lsp's on gateway routers that do not have an ipv4 address assigned (e.g. if they are ipv6 only) no rarps where send out. This causes traffic outages when changing the priority of a gateway chassis as the

[ovs-dev] [PATCH ovn v2 3/4] ovn-macros: support ipv6 in ovn_attach

in order to easily add future ipv6 test cases the common `ovn_attach` function should also support ipv6 addresses. Acked-by: Numan Siddique Signed-off-by: Felix Huettner --- tests/ovn-macros.at | 9 + tests/ovn.at| 22 +++--- 2 files changed, 16 insertions(+),

[ovs-dev] [PATCH ovn v2 0/4] Send Rarps for ipv6 router lsp

previously garps/rarps where only sent for "external" lsp's if these had an ipv4 address attached. For lsp's on gateway routers that do not have an ipv4 address assigned (e.g. if they are ipv6 only) no rarps were send out. This causes traffic outages when changing the priority of a gateway

[ovs-dev] [PATCH ovn v2 1/4] logical-fields: add rarp fields

We need to be able to handle rarp fields in order to ensure we can handle rarp messages we send ourselves. This will be used by the next patch in the series. Acked-by: Numan Siddique Signed-off-by: Felix Huettner --- lib/logical-fields.c | 8 lib/ovn-util.c | 2 +- ovn-sb.xml

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

> On Thu, Nov 3, 2022 at 12:50 AM Ian Stokes wrote: > > > > A recent change [1] in DPDK bumped requirements on meson to 0.53.2. > > > > [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e > > > > Signed-off-by: Ian Stokes > > Now that rc2 is out, I was about to resend my dpdk-latest series

Re: [ovs-dev] [PATCH 3/3] dpif-netlink: Fix reset meter features

On 03/11/2022 10:06, Roi Dayan wrote: > > > On 03/11/2022 7:28, Justin Pettit wrote: >> >>> On Nov 2, 2022, at 5:54 AM, Roi Dayan wrote: >>> >>> Fix reset features if probe for meter support fails. >>> >>> Fixes: 92d0d515d67b ("dpif-netlink: Probe for broken Linux meter >>>

[ovs-dev] [PATCH v2 2/3] tc: Fix coverity dereference null return value

CID 550702 (#1 of 1): Dereference null return value (NULL_RETURNS) 7. dereference: Dereferencing a pointer that might be NULL ex_type when calling nl_attr_get_u16. Signed-off-by: Roi Dayan --- lib/tc.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/tc.c b/lib/tc.c index

[ovs-dev] [PATCH v2 3/3] dpif-netlink: Move meter features reset from wrapper

Remove the redundant null pointer assignment and move the features reset from wrapper caller to the get features function to be consistent that dpif wrappers just call the dpif class implemented callback and not doing anything else. CC: Justin Pettit Signed-off-by: Roi Dayan --- Notes: v2:

[ovs-dev] [PATCH v2 1/3] tc: Pass tun_metadata by reference

Fix coverity big parameter passed by value CID 549858 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE) pass_by_value: Passing parameter metadata of type struct tun_metadata (size 272 bytes) by value, which exceeds the medium threshold of 256 bytes Signed-off-by: Roi Dayan --- lib/tc.c

[ovs-dev] [PATCH v2 0/3] Small fixes found with coverity tool

Hi, The following are fixes to small issues found with coverity tool. Thanks, Roi Roi Dayan (3): tc: Pass tun_metadata by reference tc: Fix coverity dereference null return value dpif-netlink: Move meter features reset from wrapper lib/dpif-netlink.c | 2 +- lib/dpif.c | 1 -

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

On Thu, Nov 3, 2022 at 12:50 AM Ian Stokes wrote: > > A recent change [1] in DPDK bumped requirements on meson to 0.53.2. > > [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e > > Signed-off-by: Ian Stokes Now that rc2 is out, I was about to resend my dpdk-latest series [1] for 22.11 with

Re: [ovs-dev] [PATCH 3/3] dpif-netlink: Fix reset meter features

On 03/11/2022 7:28, Justin Pettit wrote: > >> On Nov 2, 2022, at 5:54 AM, Roi Dayan wrote: >> >> Fix reset features if probe for meter support fails. >> >> Fixes: 92d0d515d67b ("dpif-netlink: Probe for broken Linux meter >> implementations.") >> CC: Justin Pettit >> Signed-off-by: Roi Dayan

Re: [ovs-dev] [PATCH v2] tc: On last action use drop action attribute instead of pipe

On 02/11/2022 17:33, Ilya Maximets wrote: > On 11/2/22 16:22, Han Zhou wrote: >> >> >> On Wed, Nov 2, 2022 at 5:59 AM Simon Horman > > wrote: >>> >>> On Wed, Nov 02, 2022 at 12:07:22PM +0100, Simon Horman wrote: On Wed, Nov 02, 2022 at 10:18:03AM +0200, Roi