[ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-14 Thread Xavier Simonart
In the following scenario: - interface "old" is created and external_ids:iface-id is set (to lp) - interface "new" is created and external_ids:iface-id is set (to same lp) - interface "old" is deleted flows related to lp were deleted. Note that after "new" interface is created, flows use "new" ofp

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add control plane protection support

2022-11-14 Thread Kevin Traynor
Fixing To: to add back in OVS ML. +cc Ori, as mlx5 operation discussed below. On 11/11/2022 18:15, Kevin Traynor wrote: Hi Robin, On 21/10/2022 15:53, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not size

Re: [ovs-dev] [PATCH] debian, rhel: Enable Werror option in spec files

2022-11-14 Thread Simon Horman
On Sun, Nov 13, 2022 at 04:46:23PM +0200, Eli Britstein wrote: > Following resolving DPDK cast align warnings as stated in [1], enforce > -Werror for RPM builds too. > > [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") > > Signed-off-by: Eli Britstein Reviewed-by: Simon Horman I'll le

Re: [ovs-dev] [PATCH] debian, rhel: Enable Werror option in spec files

2022-11-14 Thread Eli Britstein via dev
>-Original Message- >From: Simon Horman >Sent: Monday, 14 November 2022 12:44 >To: Eli Britstein >Cc: d...@openvswitch.org; Ilya Maximets ; Simon >Horman ; Salem Sol >Subject: Re: [PATCH] debian, rhel: Enable Werror option in spec files > >External email: Use caution opening links or

Re: [ovs-dev] [PATCH] debian, rhel: Enable Werror option in spec files

2022-11-14 Thread Simon Horman
On Mon, Nov 14, 2022 at 10:46:40AM +, Eli Britstein wrote: > > > >-Original Message- > >From: Simon Horman > >Sent: Monday, 14 November 2022 12:44 > >To: Eli Britstein > >Cc: d...@openvswitch.org; Ilya Maximets ; Simon > >Horman ; Salem Sol > >Subject: Re: [PATCH] debian, rhel: Ena

[ovs-dev] [PATCH ovn] tests: Fix flaky test "IPv6 Neighbor Solicitation for unknown MAC"

2022-11-14 Thread Xavier Simonart
Fixes: 9ac548524218 ("pinctrl: Send RARPs for external ipv6 interfaces") Signed-off-by: Xavier Simonart --- tests/ovn.at | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 6552681bd..3131b8d02 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add control plane protection support

2022-11-14 Thread Robin Jarry
Hi Kevin, Kevin Traynor, Nov 11, 2022 at 19:15: > > +reta_conf_size = (dev->reta_size / RTE_ETH_RETA_GROUP_SIZE) > > +* sizeof(struct rte_eth_rss_reta_entry64); > > In dpdk_eth_dev_init, we get reta_size from driver, > > mlx5_ethdev.c > > 333├>info->reta_size = priv->reta_idx_n

Re: [ovs-dev] [RFC PATCH ovn] northd, controller: Commit flows dropped by ACLs in a separate CT zone

2022-11-14 Thread Adrian Moreno
Hi, On 10/20/22 15:49, Abhiram Sangana wrote: Hi Dumitru, Thanks for reviewing the patch. On 19 Oct 2022, at 14:09, Dumitru Ceara wrote: Hi Abhiram, Thanks for the patch! I only skimmed the changes so this is not a full review but more of a discussion starter. On 10/18/22 17:33, Abhiram

Re: [ovs-dev] [PATCH] vswitchd: Publish per iface received multicast packets.

2022-11-14 Thread Mike Pattrick
On Wed, Nov 9, 2022 at 3:32 PM David Marchand wrote: > > The count of received multicast packets has been computed internally, > but not exposed to ovsdb. Fix this. > > Signed-off-by: David Marchand Acked-by: Mike Pattrick > --- > Strictly speaking, nothing was broken so I put no Fixes: tag. >

[ovs-dev] [PATCH ovn v2 0/2] northd IP for address sets

2022-11-14 Thread numans
From: Numan Siddique This patch series adds incremental processing of address sets in ovn-northd. v1 -> v2 --- - Added the test case in ovn-northd.at - Full recompute function of address sets will also use mutate instead of setting all the addresses of the address set. Numan Siddiq

[ovs-dev] [PATCH ovn v2 1/2] northd IP: Add a new engine node 'en_sb_sync' to sync SB tables.

2022-11-14 Thread numans
From: Numan Siddique A sub-engine node 'en_address_set_sync' is added with-in the 'en_sb_sync' node to sync the Address_Set table in the SB database. To start with, it falls back to full recompute all the time. Upcoming patch will add the incremental processing support to sync the SB Address_Se

[ovs-dev] [PATCH ovn v2 2/2] northd: Add I-P for syncing SB address sets.

2022-11-14 Thread numans
From: Numan Siddique Updates to NB address sets and NB port groups are handled incrementally for syncing the SB address sets. This patch doesn't support syncing the SB Address sets for the router load balancer vips incrementally, instead a full recompute is triggered for any changes to NB load b

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-14 Thread Numan Siddique
On Wed, Nov 9, 2022 at 4:15 PM Numan Siddique wrote: > > On Wed, Nov 9, 2022 at 4:11 PM Han Zhou wrote: > > > > On Tue, Nov 8, 2022 at 7:51 AM venu.iyer wrote: > > > > > > Currently, even stateless flows are subject to connection tracking when > > there are > > > LB rules (for DNAT). However, if

[ovs-dev] [PATCH v2] rhel: move conf.db to /var/lib/openvswitch, using symlinks

2022-11-14 Thread Timothy Redaelli
conf.db is by default at /etc/openvswitch, but it should be at /var/lib/openvswitch like on Debian or like ovnnb_db.db and ovnsb_db.db. If conf.db already exists in /etc/openvswitch then it's moved to /var/lib/openvswitch. Symlinks are created for conf.db and .conf.db.~lock~ into /etc/openvswitch

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add I-P for syncing SB address sets.

2022-11-14 Thread Mark Michelson
Hi Numan, I have just one minor suggestion below. On 11/14/22 11:48, num...@ovn.org wrote: From: Numan Siddique Updates to NB address sets and NB port groups are handled incrementally for syncing the SB address sets. This patch doesn't support syncing the SB Address sets for the router load b

Re: [ovs-dev] [PATCH ovn v2 1/2] northd IP: Add a new engine node 'en_sb_sync' to sync SB tables.

2022-11-14 Thread Mark Michelson
Acked-by: Mark Michelson On 11/14/22 11:47, num...@ovn.org wrote: From: Numan Siddique A sub-engine node 'en_address_set_sync' is added with-in the 'en_sb_sync' node to sync the Address_Set table in the SB database. To start with, it falls back to full recompute all the time. Upcoming patch

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add I-P for syncing SB address sets.

2022-11-14 Thread Numan Siddique
On Mon, Nov 14, 2022 at 3:23 PM Mark Michelson wrote: > > Hi Numan, I have just one minor suggestion below. > > On 11/14/22 11:48, num...@ovn.org wrote: > > From: Numan Siddique > > > > Updates to NB address sets and NB port groups are handled > > incrementally for syncing the SB address sets. T

[ovs-dev] [PATCH v3] utilities/ofctl: add-meters for save and restore

2022-11-14 Thread Wan Junjie
put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v3: add '--oneline' option for dump-meter(s) command v2: fix failed testcases, as dump-meters format changes -

Re: [ovs-dev] [PATCH ovn] tests: Fix flaky test "IPv6 Neighbor Solicitation for unknown MAC"

2022-11-14 Thread Ales Musil
On Mon, Nov 14, 2022 at 11:51 AM Xavier Simonart wrote: > Fixes: 9ac548524218 ("pinctrl: Send RARPs for external ipv6 interfaces") > > Signed-off-by: Xavier Simonart > --- > tests/ovn.at | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/ovn.at b/tests/ovn.at >

Re: [ovs-dev] [PATCH v3 ovn] controller: improve buffered packets management

2022-11-14 Thread Ales Musil
On Mon, Oct 24, 2022 at 11:29 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Improve buffered packet management in ovn-controller avoid useless loop > in run_buffered_binding routine and using datapath key and output port > key as buffered_packets_map hashmap hash. Add new selftest fo

Re: [ovs-dev] [PATCH ovn] controller: Fix QoS for ports with undetected or too low link speed.

2022-11-14 Thread Ales Musil
On Tue, Nov 1, 2022 at 3:01 PM Ilya Maximets wrote: > If netdev_set_qos() is called without specifying max-rate, it will > use reported link speed of that interface instead as a ceil. > > If OVS libraries are not able to detect the link speed, the 100 Mbps > will be used. Also, TAP interfaces do

Re: [ovs-dev] [PATCH ovn] pinctrl: Use 16-aligned 32-bit fields in bfd_msg.

2022-11-14 Thread Ales Musil
On Wed, Nov 2, 2022 at 2:33 PM Dumitru Ceara wrote: > This avoids misaligned accesses as flagged by UBSan when running CoPP > system tests: > > controller/pinctrl.c:7129:28: runtime error: member access within > misaligned address 0x61b627be for type 'const struct bfd_msg', which > requires

[ovs-dev] [PATCH v2] openvswitch: Add support to count upall packets

2022-11-14 Thread wangchuanlei
Added the total number of upcalls and the total of upcall failures. Due to ovs-userspace do not support NLA_NESTED, here still use the "struct ovs_vport_upcall_stats" Thank you wangchuanlei On 14 Sep 2022, at 14:14, wangchuanlei wrote: > Add support to count upcall packets on every interface. >

Re: [ovs-dev] [PATCH v2] openvswitch: Add support to count upall packets

2022-11-14 Thread Eelco Chaudron
On 15 Nov 2022, at 8:28, wangchuanlei wrote: > Added the total number of upcalls and the total of upcall failures. > Due to ovs-userspace do not support NLA_NESTED, here still use the > "struct ovs_vport_upcall_stats" I guess that was the idea, we should start using the NLA_NESTED attribute ra