On 23 Nov 2022, at 10:18, wangchuanlei wrote:
> Add support to count upall packets, when kmod of openvswitch
> upcall to userspace , here count the number of packets for
> upcall succeed and failed, which is a better way to see how
> many packets upcalled to userspace(ovs-vswitchd) on every
> i
Thank you for incorporating the comments.
Applied on master!
--
Alin.
-Original Message-
From: dev On Behalf Of Wilson Peng
Sent: Wednesday, November 9, 2022 3:35 AM
To: d...@openvswitch.org
Subject: [ovs-dev] [PATCH v2 1/1] datapath-windows: Check the condition to
reset pseudo header c
On 23/11/2022 13:21, Eelco Chaudron wrote:
> The goal was to run 200 successful tc tests in a row. To do this the
> following was run:
>
> for i in {1..200}; do make check-offloads || break; \
> echo "ALL_200_OK: $i"; done;
>
> Unfortunately, a bunch of test cases showed occasional failu
Improve the affinity code to reuse ds buffers as much as possible
without constantly repeating some parts. Add ct.new for the LB flows
so it is clear that the commit happens only when we have a new
connection.
Signed-off-by: Ales Musil
---
northd/northd.c | 162 ++
From: Flavio Leitner
The netdev receiving packets is supposed to provide the flags
indicating if the L4 checksum was verified and it is OK or BAD,
otherwise the stack will check when appropriate by software.
If the packet comes with good checksum, then postpone the
checksum calculation to the eg
From: Flavio Leitner
The netdev receiving packets is supposed to provide the flags
indicating if the IP checksum was verified and it is GOOD or BAD,
otherwise the stack will check when appropriate by software.
If the packet comes with good checksum, then postpone the
checksum calculation to the
From: Flavio Leitner
This patch introduces a command to display the current checksum offload
status by port, allowing the user to gain insight into where checksum
offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Reviewed-by: David
This is a subset of the larger TSO patchset with various checksum
improvements. This set includes additional documentation, new appctl
command "dpif-netdev/offload-show" to display interface offload
support, and improvements to tracking when an updated checksum is
required.
In a simple iperf test
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
Documentation/automake.mk| 1 +
Documentation/topic
Hi,
Thank you for review! I will give a new verson of patch based on your
comments,
and i give a explanation on every comments from you, please see below!
Best reagrds!
wangchuanlei
From: Alexander Lobakin [mailto:alexandr.loba...@intel.com]
To: wangchuan...@inspur.com
> From: wangchuanlei
Hi,
Thank you for review! I will give a new verson of patch based on your
comments,
and i give a explanation on every comments from you, please see below!
Best reagrds!
wangchuanlei
From: Alexander Lobakin [mailto:alexandr.loba...@intel.com]
To: wangchuan...@inspur.com
> From: wangchuanlei
To: d...@openvswitch.org
If there is a pipe behind ovs-tcpdump(such as ovs-tcpdump -i eth0
| grep "192.168.1.1"), the child process (grep "192.168.1.1") may
exit first and close the pipe when received SIGTERM. When farther
process(ovs-tcpdump) exit, stdout is flushed into broken pipe, and
then rec
So do we need this patch or not??
Guessing it's quite rare in the real production environment that we have
two datapaths at the same time
And I am more curious that even though we have 2 datapaths, should the port
id be different? Is one
port capable of being assigned to 2 datapaths at the sa
Eelco Chaudron 于2022年11月24日周四 00:08写道：
>
>
> On 22 Nov 2022, at 2:44, Peng He wrote:
>
> > Hi,
> >
> > After a second thought, I think maybe keeping INCONSISTENT just for the
> > modify (修改) error is a better option.
> >
> > With current patch (补丁) :
> > 1.
> > the modify (修改) error case:
> > OPE
On 11/4/22 14:43, Hemanth Aramadaka via dev wrote:
> Issue:
>
> The src-port for UDP is based on RSS hash in the packet metadata.
> In case of packets coming from VM it will be 5-tuple, if available,
> otherwise just IP addresses.If the VM fragments a large IP packet
> and sends the fragments to o
On Wed, Nov 23, 2022 at 4:21 PM Marcelo Ricardo Leitner
wrote:
>
> On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote:
> > On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner
> > wrote:
> > >
> > > On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> > > > On Wed, Nov 23, 2022 at
The value is right-justified after the string parsing with
parse_int_string(), i.e. it is in BE byte order and aligned
to the right side of the array.
For example, the 0x10011 value in a 4-byte field will look
like 0x00 0x01 0x00 0x11.
However, value copy to the resulted ofpact is performed
from
On 11/22/22 15:03, Aaron Conole wrote:
> When processing upcall commands, two groups of data are available to
> userspace for processing: the actual packet data and the kernel
> sw flow key data. The inclusion of the flow key allows the userspace
> avoid running through the dissection again.
>
>
On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> > > On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
> > > wrote:
> > > >
> > > > On Wed, Nov 23,
On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner
wrote:
>
> On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> > On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
> > wrote:
> > >
> > > On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> > > > On Wed, Nov 23, 2022 at
From: wangchuanlei
Date: Wed, 23 Nov 2022 04:18:43 -0500
> Add support to count upall packets, when kmod of openvswitch
> upcall to userspace , here count the number of packets for
> upcall succeed and failed, which is a better way to see how
> many packets upcalled to userspace(ovs-vswitchd) on
On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> > > On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
> > > wrote:
> > > >
> > > > On Wed, Nov 23
On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
wrote:
>
> On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> > On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
> > wrote:
> > >
> > > On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> > > > On Tue,
On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> --- a/net/netfilter/Makefile
> +++ b/net/netfilter/Makefile
> @@ -52,7 +52,7 @@ obj-$(CONFIG_NF_CONNTRACK_SANE) += nf_conntrack_sane.o
> obj-$(CONFIG_NF_CONNTRACK_SIP) += nf_conntrack_sip.o
> obj-$(CONFIG_NF_CONNTRACK_TFTP) += nf_conntra
On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> > > On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> > > > +int nf_ct_nat(stru
On Tue, Oct 25, 2022 at 4:39 PM Lorenzo Bianconi
wrote:
>
> In the current codebase ct_commit {} action clears ct_state metadata of
> the incoming packet. This behaviour introduces an issue if we need to
> check the connection tracking state in the subsequent pipeline stages,
> e.g. for hairpin tr
On Tue, Nov 22, 2022 at 5:31 PM Lorenzo Bianconi
wrote:
>
> > Thanks Lorenzo!
> >
> > Acked-by: Mark Michelson
> >
> > The only question I have is why you converted to a shash instead of a smap?
>
> Hi Mark,
>
> Thx for the review. Do you mean shash instead of sset?
>
> Regards,
> Lorenzo
>
Than
On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
wrote:
>
> On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> > On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> > > +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct,
> > > + enum ip_conntrack
On 11/23/22 16:33, Numan Siddique wrote:
> On Fri, Nov 18, 2022 at 10:11 AM Dumitru Ceara wrote:
>>
>> Signed-off-by: Dumitru Ceara
>
> Acked-by: Numan Siddique
>
> Numan
>
Thanks! I pushed this patch to the main branch.
Regards,
Dumitru
___
dev
On 11/23/22 16:21, Ilya Maximets wrote:
> On 11/8/22 19:15, Simon Horman wrote:
>> On Sat, Nov 05, 2022 at 11:11:53AM +0100, Ilya Maximets wrote:
>>> The value is right-justified after the string parsing with
>>> parse_int_string(), i.e. it is in BE byte order and aligned
>>> to the right side of t
On 22 Nov 2022, at 2:44, Peng He wrote:
> Hi,
>
> After a second thought, I think maybe keeping INCONSISTENT just for the
> modify error is a better option.
>
> With current patch:
> 1.
> the modify error case:
> OPERATIONAL -> INCONSISTENT -> EVICTING -> EVICTED
> 2.
> the delete error case:
>
On 11/21/22 17:12, Adrian Moreno wrote:
> Very often when troubleshooting networking issues in an OVN cluster one
> would like to know if any packet (or a specific one) is being dropped by
> OVN.
>
> Currently, this cannot be known because of two main reasons:
>
> 1 - Implicit drops: Some tables
On 19 Nov 2022, at 1:46, Peng He wrote:
> Eelco Chaudron 于2022年11月18日周五 15:38写道：
>
>>
>>
>> On 18 Nov 2022, at 2:57, Peng He wrote:
>>
>>> Since there are possible race conditions (between the kernel (内核)
>> datapath and
>>> userspace datapath),
>>> I guess this patch (补丁) is now needed again?
On Thu, Nov 17, 2022 at 7:38 AM Dumitru Ceara wrote:
>
> Move the submodule to the tip of OVS branch3.0. This picks up:
> 6690ed80c netdev-linux: Fix inability to apply QoS on ports with custom
> qdiscs.
>
> Signed-off-by: Dumitru Ceara
Acked-by: Numan Siddique
Numan
> ---
> Note: This pa
On Fri, Nov 18, 2022 at 10:11 AM Dumitru Ceara wrote:
>
> Signed-off-by: Dumitru Ceara
Acked-by: Numan Siddique
Numan
> ---
> .github/workflows/test.yml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
> index 88c48dd2c2..818
On Mon, Nov 21, 2022 at 11:13 AM Adrian Moreno wrote:
>
> Two new options are added to NB_Global table that enable drop
> sampling by specifying the collector_set_id and the obs_domain_id of
> the sample actions added to all drop flows.
>
> For drops coming from an lflow, the sample has the follow
On Mon, Nov 21, 2022 at 11:13 AM Adrian Moreno wrote:
>
> By default, traffic that doesn't match any configured flow will be dropped.
> But having that behavior implicit makes those drops more difficult to
> visualize.
>
> Make default drops explicit both as default logical flows and as default
>
On Mon, Nov 21, 2022 at 11:13 AM Adrian Moreno wrote:
>
> sample ovn action encodes into the OFPACT_SAMPLE ovs action.
>
> OVN action allows the following parameters:
>
> - obs_domain_id: 8-bit integer that identifies the sampling application.
> This value will be combined with the datapath's tu
On 11/8/22 19:15, Simon Horman wrote:
> On Sat, Nov 05, 2022 at 11:11:53AM +0100, Ilya Maximets wrote:
>> The value is right-justified after the string parsing with
>> parse_int_string(), i.e. it is in BE byte order and aligned
>> to the right side of the array.
>>
>> For example, the 0x10011 value
As stated by the Github CI:
"Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-
actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16:
actions/checkout@v2, actions/setup-p
On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> > +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct,
> > + enum ip_conntrack_info ctinfo, int *action,
> > + const struct nf_nat_range2 *range,
On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct,
> + enum ip_conntrack_info ctinfo, int *action,
> + const struct nf_nat_range2 *range, bool commit)
> +{
> + enum nf_nat_manip_type maniptype;
> + int err,
On 11/23/22 15:32, Lorenzo Bianconi wrote:
> On Nov 23, Dumitru Ceara wrote:
>> On 11/23/22 15:26, Lorenzo Bianconi wrote:
>>> /* Called with in the pinctrl_handler thread context. */
>>> static int
>>> pinctrl_handle_buffered_packets(struct dp_packet *pkt_in,
>>>
On Nov 23, Dumitru Ceara wrote:
> On 11/23/22 15:26, Lorenzo Bianconi wrote:
> > /* Called with in the pinctrl_handler thread context. */
> > static int
> > pinctrl_handle_buffered_packets(struct dp_packet *pkt_in,
> > const struct match *md, bool
On 11/23/22 15:26, Lorenzo Bianconi wrote:
> /* Called with in the pinctrl_handler thread context. */
> static int
> pinctrl_handle_buffered_packets(struct dp_packet *pkt_in,
> const struct match *md, bool is_arp)
> OVS_REQUIRES(pinctrl_m
> On 11/15/22 10:44, Lorenzo Bianconi wrote:
> >> On Mon, Oct 24, 2022 at 11:29 AM Lorenzo Bianconi <
> >> lorenzo.bianc...@redhat.com> wrote:
> >>
> >>> Improve buffered packet management in ovn-controller avoid useless loop
> >>> in run_buffered_binding routine and using datapath key and output p
There's a typo in the subject here, s/is net/is not/ .
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Nov 22, 2022 at 12:32:19PM -0500, Xin Long wrote:
> This patch changes to return NF_ACCEPT when fails to add nat
> ext before doing NAT in tcf_ct_act_nat(), to keep consistent
> with OVS' processing in ovs_ct_nat().
>
> Reviewed-by: Saeed Mahameed
> Signed-off-by: Xin Long
> ---
> net/s
On 23 Nov 2022, at 15:05, Van Haaren, Harry wrote:
>> -Original Message-
>> From: dev On Behalf Of Eelco Chaudron
>> Sent: Wednesday, November 23, 2022 1:55 PM
>> To: Finn, Emma
>> Cc: d...@openvswitch.org; david.march...@redhat.com; i.maxim...@ovn.org
>> Subject: Re: [ovs-dev] [v3] o
> -Original Message-
> From: dev On Behalf Of Eelco Chaudron
> Sent: Wednesday, November 23, 2022 1:55 PM
> To: Finn, Emma
> Cc: d...@openvswitch.org; david.march...@redhat.com; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v3] odp-execute: Add ISA implementation of set_masked
> IPv6
> ac
On Wed, Nov 23, 2022 at 5:03 AM Adrian Moreno wrote:
>
I believe the commit message was cut out.
> Signed-off-by: Adrian Moreno
> ---
> python/ovs/flow/kv.py| 17 ++---
> python/ovs/flow/ofp.py | 7 ---
> python/ovs/tests/test_ofp.py | 15 +++
> 3 fil
On 11/21/22 16:54, Adrian Moreno wrote:
>
>
> On 11/4/22 15:25, Ilya Maximets wrote:
>> Some macros for rculist have no users and there are no unit tests
>> specific to that library as well, so broken code wasn't spotted
>> while updating to multi-variable iterators.
>>
>> Fixing multiple problem
On 22 Nov 2022, at 16:10, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday 17 November 2022 09:21
>> To: Finn, Emma
>> Cc: d...@openvswitch.org; david.march...@redhat.com;
>> i.maxim...@ovn.org
>> Subject: Re: [ovs-dev] [v3] odp-execute: Add ISA impleme
On Wed, Nov 23, 2022 at 5:03 AM Adrian Moreno wrote:
>
> We currently auto-generate a dictionary of field names and decoders.
> However, sometimes fields can be specified by their cannonical NXM or
> OXM names.
>
> Modify gen_ofp_field_decoders to also generate a dictionary of aliases
> so it's ea
On 11/23/22 12:52, Ian Stokes wrote:
> This commit add support to for DPDK v22.11, it includes the following
> changes.
>
> 1. ci: Reduce DPDK compilation time.
> 2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07.
>
>http://patchwork.ozlabs.org/project/openvswitch/list/?seri
On 11/15/22 10:44, Lorenzo Bianconi wrote:
>> On Mon, Oct 24, 2022 at 11:29 AM Lorenzo Bianconi <
>> lorenzo.bianc...@redhat.com> wrote:
>>
>>> Improve buffered packet management in ovn-controller avoid useless loop
>>> in run_buffered_binding routine and using datapath key and output port
>>> key
On Tue, Nov 22, 2022 at 12:32:16PM -0500, Xin Long wrote:
> The changes in the patchset:
>
> "net: add helper support in tc act_ct for ovs offloading"
>
> had moved some common ct code used by both OVS and TC into netfilter.
Please give me today to review this patchset.
Thanks,
Marcelo
__
On 23/11/2022 13:15, Eelco Chaudron wrote:
> This patch adds a delay before dumping the conntrack table because with
> tc it takes a bit longer before it gets synced.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/system-common-macros.at |3 +
> tests/system-offloads.at | 25 +
On 23/11/2022 13:14, Eelco Chaudron wrote:
> The revalidator/purge commands in the system test cases sometimes
> get called immediately after a partial test is completed. This
> could cause the revalidator thread to log an error that it can
> not find/delete a flow due to the slower flow install
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#112 FILE: Documentation/intro/inst
This commit add support to for DPDK v22.11, it includes the following
changes.
1. ci: Reduce DPDK compilation time.
2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07.
http://patchwork.ozlabs.org/project/openvswitch/list/?series=316528
3. system-dpdk: Update vhost tests to be
The goal was to run 200 successful tc tests in a row. To do this the
following was run:
for i in {1..200}; do make check-offloads || break; \
echo "ALL_200_OK: $i"; done;
Unfortunately, a bunch of test cases showed occasional failures.
For now, they are excluded from the test cases and need
With some datapaths, read TC, it takes a bit longer to update the
OpenFlow statistics. Rather than adding an additional delay, try
to read the counters multiple times until we get the desired value.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.at |2 --
tests/
If a tc flow was installed but has not yet been used, report it as such.
In addition, add a delay to the "IGMP - flood under normal action" test
case to make it work with many repetitions. This delay is also present
in other ICMP/IGMP tests.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
Make the order of the Netlink attributes for odp_flow_key_from_flow__()
the same as the kernel will return them.
This will make sure the attributes displayed in the dpctl/dump-flows
output appear in the same order for all datapath.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/odp-
tc does not include ethernet header length in packet byte count.
This fix will allow the packets that go trough tc to be 14 bytes less.
This difference in the TC implementation is already described in
tc-offload.rst.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.a
The tc conntrack implementation does not support the timeout option.
The current implementation is silently ignoring the timeout option
by adding a general conntrack entry.
This patch will skip the related test by overriding the support macro.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
-
tc does not support conntrack ALGs. Even worse, with tc enabled, they
should not be used/configured at all. This is because even though TC
will ignore the rules with ALG configured, i.e., they will flow through
the kernel module, return traffic might flow through a tc conntrack
rule, and it will no
Flush datapath flows as TC flows take some more time to be flushed out.
The flush speeds this up.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.at |2 --
tests/system-traffic.at |6 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/test
This change fixes the "conntrack - floating" test for the TC
offload case. In this scenario, the connection might move to
CLOSE_WAIT, which would fail the test as it only accepts
TIME_WAIT. However, both indicate the connection was
established, so the test should pass.
Signed-off-by: Eelco Chaudro
This patch adds a delay before dumping the conntrack table because with
tc it takes a bit longer before it gets synced.
Signed-off-by: Eelco Chaudron
---
tests/system-common-macros.at |3 +
tests/system-offloads.at | 25 +
tests/system-traffic.at | 198 +
The revalidator/purge commands in the system test cases sometimes
get called immediately after a partial test is completed. This
could cause the revalidator thread to log an error that it can
not find/delete a flow due to the slower flow installation nature
of TC.
This patch uses a macro to call t
tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
commit was requested. This patch will fix this.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/netdev-offload-tc.c | 13 +++--
tests/system-offloads.at |1 -
2 files changed, 11 insertions(+), 3 deletio
TC flower does not allow the push of the implicit null labels (RFC3032).
Avoid the use of such labels in the MPLS test cases.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.at |2 --
tests/system-traffic.at |8
2 files changed, 4 insertions(+), 6 d
Include and run the system-traffic.at tests as part of the system offload
testsuite. Exclude all the tests that will not run without any special
modifications.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/automake.mk |1
tests/system-offloads-testsuite.at |
When the test description is part of the OVS_TEST_SKIP_LIST
variable, the test is skipped.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/ofproto-macros.at |5 -
tests/ovs-macros.at |7 +++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/ofp
This series makes it possible to include system-traffic.at tests into
"make check-offloads" tests.
The last patch of the series explains which tests are still not passing
and might need some more work.
I'll try to work on the remaining failing test cases or find someone
who can work on them.
v5
On 11/23/22 09:10, Ales Musil wrote:
> On Tue, Nov 22, 2022 at 9:24 PM Xavier Simonart wrote:
>
>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2144084
>>
>> Signed-off-by: Xavier Simonart
>> ---
>> lib/features.c | 16 ++--
>> tests/ovn.at | 18 ++
>>
Hi Pravin,
Any update feedback on this?
//Eelco
On 15 Nov 2022, at 17:16, Eelco Chaudron wrote:
> Hi Pravin,
>
> It looks like a previous fix you made, 190aa3e77880 ("openvswitch: Fix
> Frame-size larger than 1024 bytes warning."), is breaking stuff. With this
> change, the actual flow looku
On 23 Nov 2022, at 11:39, Eelco Chaudron wrote:
> This series makes it possible to include system-traffic.at tests into
> "make check-offloads" tests.
>
> The last patch of the series explains which tests are still not passing
> and might need some more work.
>
> I'll try to work on the remainin
The tc conntrack implementation does not support the timeout option.
The current implementation is silently ignoring the timeout option
by adding a general conntrack entry.
This patch will skip the related test by overriding the support macro.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
-
tc does not support conntrack ALGs. Even worse, with tc enabled, they
should not be used/configured at all. This is because even though TC
will ignore the rules with ALG configured, i.e., they will flow through
the kernel module, return traffic might flow through a tc conntrack
rule, and it will no
Flush datapath flows as TC flows take some more time to be flushed out.
The flush speeds this up.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.at |2 --
tests/system-traffic.at |6 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/test
This change fixes the "conntrack - floating" test for the TC
offload case. In this scenario, the connection might move to
CLOSE_WAIT, which would fail the test as it only accepts
TIME_WAIT. However, both indicate the connection was
established, so the test should pass.
Signed-off-by: Eelco Chaudro
This patch adds a delay before dumping the conntrack table because with
tc it takes a bit longer before it gets synced.
Signed-off-by: Eelco Chaudron
---
tests/system-common-macros.at |3 +
tests/system-offloads.at | 25 +
tests/system-traffic.at | 198 +
tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
commit was requested. This patch will fix this.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/netdev-offload-tc.c | 13 +++--
tests/system-offloads.at |1 -
2 files changed, 11 insertions(+), 3 deletio
The revalidator/purge commands in the system test cases sometimes
get called immediately after a partial test is completed. This
could cause the revalidator thread to log an error that it can
not find/delete a flow due to the slower flow installation nature
of TC.
This patch uses a macro to call t
TC flower does not allow the push of the implicit null labels (RFC3032).
Avoid the use of such labels in the MPLS test cases.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads.at |2 --
tests/system-traffic.at |8
2 files changed, 4 insertions(+), 6 d
Include and run the system-traffic.at tests as part of the system offload
testsuite. Exclude all the tests that will not run without any special
modifications.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/automake.mk |1
tests/system-offloads-testsuite.at |
When the test description is part of the OVS_TEST_SKIP_LIST
variable, the test is skipped.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/ofproto-macros.at |5 -
tests/ovs-macros.at |7 +++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/ofp
I have a few nits on my own patch.
Noting them here for now.
In case there is no further comment on the patch, I will send a new revision.
On Wed, Nov 9, 2022 at 9:39 PM David Marchand wrote:
> @@ -2845,8 +2779,7 @@ netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
> stats.tx_retries
This series makes it possible to include system-traffic.at tests into
"make check-offloads" tests.
The last patch of the series explains which tests are still not passing
and might need some more work.
I'll try to work on the remaining failing test cases or find someone
who can work on them.
v4
On Fri, Nov 18, 2022 at 4:16 PM Maxime Coquelin
wrote:
> On 11/9/22 21:38, David Marchand wrote:
> > The DPDK vhost-user library maintains more granular per queue stats
> > which can replace what OVS was providing for vhost-user ports.
> >
> > The benefits for OVS:
> > - OVS can skip parsing packe
On 23 Nov 2022, at 11:24, Ferriter, Cian wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Monday 21 November 2022 14:34
>> To: Ferriter, Cian
>> Cc: ovs-dev@openvswitch.org; kumar.am...@intel.com
>> Subject: Re: [ovs-dev] [PATCH v7 0/9] DPIF + MFEX Inner AVX512
>>
>> On 1
> -Original Message-
> From: Eelco Chaudron
> Sent: Monday 21 November 2022 14:34
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; kumar.am...@intel.com
> Subject: Re: [ovs-dev] [PATCH v7 0/9] DPIF + MFEX Inner AVX512
>
> On 12 Oct 2022, at 13:55, Cian Ferriter wrote:
>
> > This S
Sometimes we don't want to return the result of a nested key-value
decoding as a dictionary but as a list of dictionaries. This happens
when we parse actions where keys can be repeated.
Refactor code that already takes that into account from ofp_act.py to
kv.py and use it for datapath action "clon
Create a small helper script and check that flows used in ofp-actions.at
are parseable.
Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
---
tests/automake.mk | 2 ++
tests/ofp-actions.at | 18 +
tests/test-ofparse.py | 45 +++
3
Create a small helper script and check that flows tested in odp.at are
parseable.
Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
---
tests/automake.mk | 2 ++
tests/odp.at | 12 +++-
tests/test-dpparse.py | 45 +++
3 files chan
returning None in a constructor does not make sense and is just error
prone. Removing what was a lefover from an attempt to handle a common
error case of trying to parse what is commonly outputted by ovs-ofctl.
This should be done by the caller anyway.
Signed-off-by: Adrian Moreno
Acked-by: Mike
clone-like actions can also output to ports by specifying the port name.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/ofp.py | 6 --
python/ovs/tests/test_ofp.py | 13 +
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/python/ovs/flow/ofp.py b/python/ovs
1 - 100 of 109 matches
Mail list logo
