Re: [ovs-dev] [PATCH] [PATCH v5 net-next] net: openvswitch: Add support to count upcall packets

On 30 Nov 2022, at 8:25, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch > upcall to userspace , here count the number of packets for > upcall succeed and failed, which is a better way to see how > many packets upcalled to userspace(ovs-vswitchd) on every > in

[ovs-dev] [PATCH] [PATCH v5 net-next] net: openvswitch: Add support to count upcall packets

Add support to count upall packets, when kmod of openvswitch upcall to userspace , here count the number of packets for upcall succeed and failed, which is a better way to see how many packets upcalled to userspace(ovs-vswitchd) on every interfaces. Here modify format of code used by comments of v

Re: [ovs-dev] [PATCH 1/2] ofp, dpif: Allow CT flush based on partial match

On Mon, Nov 28, 2022 at 1:46 PM Paolo Valerio wrote: > Hi Ales, > > the patch lgtm, and works as expected. > There are some nit/remarks below, but other than that, I'm ok with the > change. > Hi Paolo, thank you for the review. I'll wait with v2 a bit, just to see if there are any additional co

Re: [ovs-dev] [PATCH] [openvswitch v4] openvswitch: Add support to count upcall packets

Hi,Eelco Chaudron > +struct ovs_vport_upcall_stats { > + uint64_t upcall_success; /* total packets upcalls succeed */ > + uint64_t upcall_fail; /* total packets upcalls failed */ > +}; This is no longer a user API data structure, so it should be removed from this includ

Re: [ovs-dev] [PATCH] [openvswitch v4] openvswitch: Add support to count upcall packets

Hi,Eelco Chaudron > +struct ovs_vport_upcall_stats { > + uint64_t upcall_success; /* total packets upcalls succeed */ > + uint64_t upcall_fail; /* total packets upcalls failed */ > +}; This is no longer a user API data structure, so it should be removed from this includ

Re: [ovs-dev] [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading

On Mon, Nov 29, 2022 at 8:35 PM , Eelco Chaudron wrote: > > On 28 Nov 2022, at 14:33, Marcelo Leitner wrote: > > > On Mon, Nov 28, 2022 at 02:17:40PM +0100, Eelco Chaudron wrote: > >> > >> > >> On 28 Nov 2022, at 14:11, Marcelo Leitner wrote: > >> > >>> On Mon, Nov 28, 2022 at 07:11:05AM +,

[ovs-dev] [PATCH ovn v7 7/7] Document experimental support for co-hosted controllers

Acked-by: Mark Michelson Signed-off-by: Ihar Hrachyshka --- NEWS| 2 ++ controller/ovn-controller.8.xml | 12 2 files changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 672efb749..c6a5d6264 100644 --- a/NEWS +++ b/NEWS @@ -5,6 +5,8 @@ Post v22.09.

[ovs-dev] [PATCH ovn v7 6/7] Add connectivity test for 2 controllers on the same host

Signed-off-by: Ihar Hrachyshka --- tests/ovn-macros.at | 30 ++ tests/ovn.at| 137 ++-- 2 files changed, 137 insertions(+), 30 deletions(-) diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index ef7191c6a..1f57293d1 100644 --- a/test

[ovs-dev] [PATCH ovn v7 2/7] Support ovn-...- specific global ovsdb options

Before the patch, all controller instances were reading configuration from the same external-ids:ovn-* options. This patch adds support for distinct config otions for different chassis names stored in the same ovsdb global config object. To configure an option for a distinct chassis name, an admin

[ovs-dev] [PATCH ovn v7 4/7] Support passing chassis name via CLI

This patch adds support for the desired system-id (chassis name) to be passed via CLI: $ ovn-controller -n If passed, CLI overrides any settings stored in ovsdb or in system-id-override file. This may be useful when running multiple controller instances using the same vswitchd instance. Signed

[ovs-dev] [PATCH ovn v7 5/7] Don't touch tunnel ports from a different br-int

When multiple controllers are running using the same vswitchd, controllers should delete only those tunnel ports that belong to the integration bridge that is managed by the controller instance. This makes sure multiple controllers don't step on each other when running using the same vswitchd inst

[ovs-dev] [PATCH ovn v7 1/7] Include "chassis index" into tunnel port name

This is in preparation to support multiple separate controller instances with distinct chassis names operating on the same vswitchd instance. To avoid conflicts, this patch introduces a unique "index" (from 0-9a-z range) into the port name. Each chassis allocates a separate index for itself on sta

[ovs-dev] [PATCH ovn v7 0/7] Support 2+ controllers on the same vswitchd

This series adds support to run multiple ovn-controller instances using the same vswitchd instance. This may be used to reuse a single host level vswitchd installation to run multiple CMS (e.g. k8s and openstack), each having its own OVN stack running on a separate integration bridge. This setup m

[ovs-dev] [PATCH ovn v7 3/7] Allow to override system-id via file

Before the patch, system-id could be configured via a global config option in ovsdb. This patch adds another option - configure system-id via a file. This is achieved by writing the desired system-id into the following file location: ${OVN_SYSCONFDIR}/system-id-override. The file is read on contro

Re: [ovs-dev] [PATCH v6 ovn 6/7] Add connectivity test for 2 controllers on the same host

On Mon, Nov 21, 2022 at 3:01 PM Mark Michelson wrote: > > On 10/18/22 14:33, Ihar Hrachyshka wrote: > > Signed-off-by: Ihar Hrachyshka > > --- > > tests/ovn.at | 130 +++ > > 1 file changed, 130 insertions(+) > > > > diff --git a/tests/ovn.at b/t

Re: [ovs-dev] [PATCH v9 0/4] Enhance support for checksum offloading

Hi, The code freeze is approaching fast and there are holidays and PTOs in between. We kindly ask you to review and/or test if possible as soon as you can to unblock the second part of it. Thanks, fbl On Thu, Nov 24, 2022 at 12:30:45AM -0500, Mike Pattrick wrote: > This is a subset of the la

Re: [ovs-dev] [PATCH v6 ovn 5/7] Don't touch tunnel ports from a different br-int

On Mon, Nov 21, 2022 at 3:00 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > Do you have any idea why we were iterating through all OVS bridges to > remove tunnels? The only reason I could think of is if the "ovn-bridge" > setting changed between runs of ovn-controller. Then we'd be sur

Re: [ovs-dev] [PATCH v6 ovn 2/7] Support ovn-...- specific global ovsdb options

On Mon, Nov 21, 2022 at 3:00 PM Mark Michelson wrote: > > On 10/18/22 14:33, Ihar Hrachyshka wrote: > > Before the patch, all controller instances were reading configuration > > from the same external-ids:ovn-* options. This patch adds support for > > distinct config otions for different chassis n

Re: [ovs-dev] [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading

On 28/11/2022 13:11, Marcelo Leitner wrote: > Exactly. Then, when this patchset (or similar) come up, it won't > update all actions with the same stats anymore. It will require a set > of stats from hw for the gact with PIPE action here. But if drivers > are ignoring this action, they can't have sp

Re: [ovs-dev] [PATCH ovn v3 5/5] tutorial: Add scripts to simulate node-port ovn-k8s services.

On Tue, Nov 29, 2022 at 5:16 AM Dumitru Ceara wrote: > > On 11/29/22 09:14, Han Zhou wrote: > > > > > Better to add a brief help message for the .sh itself. Otherwise, it > > invokes the .py and outputs the help message of the .py, which is a little > > misleading (although it is fairly easy to fi

Re: [ovs-dev] [PATCH ovn v3 4/5] lb: Support using templates.

On Tue, Nov 29, 2022 at 5:16 AM Dumitru Ceara wrote: > > On 11/29/22 09:14, Han Zhou wrote: > > On Tue, Nov 22, 2022 at 6:15 AM Dumitru Ceara wrote: > >> > >> Allow the CMS to configure template LBs. The following configurations are > >> supported: > >> - VIPs of the form: ^vip_variable[:^port_v

Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

On 11/29/22 17:35, Phelan, Michael wrote: > >> -Original Message- >> >> I'm also wondering why CI didn't catch that... >> >> There might be 2 reasons: >> >> 1. Actions autovalidator is not enabled in CI, or 2. CI system doesn't have >> avx512vbmi. >> >> Michael, could you check that? > >

Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

> -Original Message- > From: Ilya Maximets > Sent: Tuesday 29 November 2022 15:07 > To: Finn, Emma ; d...@openvswitch.org; Phelan, > Michael > Cc: i.maxim...@ovn.org; Eelco Chaudron ; Van > Haaren, Harry ; Stokes, Ian > > Subject: Re: [ovs-dev] [v5] odp-execute: Add ISA implementation

[ovs-dev] OVN branch 22.12 has been created

Hi all, Today I created branch-22.12 in github for OVN: https://github.com/ovn-org/ovn/tree/branch-22.12 . The expected day of release is two Fridays from now on 9 December, 2022. At this point, the soft freeze has hardened, meaning that, with a few exceptions, we are only merging bug-fixes

Re: [ovs-dev] [OVN v17 2/3] OVN Remote Port Mirroring: northd changes to sync NB and SB

On 11/29/22 08:27, Abhiram R N wrote: Hi Mark, Thanks for your review. Please see replies inline below. On Tue, Nov 29, 2022 at 3:23 AM Mark Michelson > wrote: On 11/27/22 15:14, Abhiram R N wrote: > Changes which syncs the NB port mirrors with SB port mir

Re: [ovs-dev] [RFC PATCH v2] dpif-netdev: Put idle PMD threads to sleep.

Hello, On Fri, Sep 9, 2022 at 11:48 PM Thilak Raj Surendra Babu wrote: > > Hi David, > We had a similar thought process and interested in this patch. > Wondering if we could help you out on making progress on this patch ? We have been working on the power saving topic for a while and Kevin had p

Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

On 11/29/22 15:09, Finn, Emma wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday 25 November 2022 17:22 >> To: Finn, Emma ; d...@openvswitch.org >> Cc: i.maxim...@ovn.org; Eelco Chaudron >> Subject: Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of >> set_ma

Re: [ovs-dev] [PATCH] netdev: Assume default link speed to be 10 Gbps instead of 100 Mbps.

On Tue, Oct 25, 2022 at 12:38 PM Ilya Maximets wrote: > > 100 Mbps was a fair assumption 13 years ago. Modern days 10 Gbps seems > like a good value in case no information is available otherwise. > > The change mainly affects QoS which is currently limited to 100 Mbps if > the user didn't specify

Re: [ovs-dev] [PATCH] odp-util: Fix reporting unknown keys as keys with bad length.

Ilya Maximets writes: > check_attr_len() currently reports all unknown keys as keys with bad > length. For example, IPv6 extension headers are printed out like this > in flow dumps: > > eth_type(0x86dd),ipv6(...) > (bad key length 2, expected -1)(00 00/(bad mask length 2, expected -1)(00 >

Re: [ovs-dev] [RFC net-next 1/6] openvswitch: exclude kernel flow key from upcalls

Ilya Maximets writes: > On 11/22/22 15:03, Aaron Conole wrote: >> When processing upcall commands, two groups of data are available to >> userspace for processing: the actual packet data and the kernel >> sw flow key data. The inclusion of the flow key allows the userspace >> avoid running throu

Re: [ovs-dev] [RFC net-next 1/6] openvswitch: exclude kernel flow key from upcalls

Adrian Moreno writes: > On 11/25/22 16:51, Ilya Maximets wrote: >> On 11/25/22 16:29, Adrian Moreno wrote: >>> >>> >>> On 11/23/22 22:22, Ilya Maximets wrote: On 11/22/22 15:03, Aaron Conole wrote: > When processing upcall commands, two groups of data are available to > userspace for

Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

On 29 Nov 2022, at 15:09, Finn, Emma wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday 25 November 2022 17:22 >> To: Finn, Emma ; d...@openvswitch.org >> Cc: i.maxim...@ovn.org; Eelco Chaudron >> Subject: Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of >> se

Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

> -Original Message- > From: Ilya Maximets > Sent: Friday 25 November 2022 17:22 > To: Finn, Emma ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Eelco Chaudron > Subject: Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of > set_masked IPv6 action > > On 11/25/22 17:23, Emma F

Re: [ovs-dev] Patch "openvswitch: Fix Frame-size larger than 1024 bytes warning" not correct.

Ilya Maximets writes: > On 11/15/22 17:16, Eelco Chaudron wrote: >> Hi Pravin, >> >> It looks like a previous fix you made, 190aa3e77880 ("openvswitch: >> Fix Frame-size larger than 1024 bytes warning."), is breaking >> stuff. With this change, the actual flow lookup, >> ovs_flow_tbl_lookup(), i

[ovs-dev] [PATCH] dpif-netdev: Load based PMD sleeping.

Sleep for an incremental amount of time if none of the Rx queues assigned to a PMD have at least half a batch of packets (i.e. 16 pkts) on an polling iteration of the PMD. Upon detecting >= 16 pkts on an Rxq, reset the sleep time to zero. Sleep time will be increased by 1 uS on each iteration whe

Re: [ovs-dev] [RFC PATCH ovn] expr: Use sset for nested expr instead of list

On Tue, Nov 29, 2022 at 2:46 PM Dumitru Ceara wrote: > On 11/28/22 15:25, Ales Musil wrote: > > To speed up search of possible recursive symbols > > use sset. This also prevents the dangling pointer > > warning wtih GCC 12 [0]. > > > > [0] https://bugzilla.redhat.com/2145107 > > Signed-off-by: Al

[ovs-dev] [PATCH ovn v2] northd: Refactor build_lrouter_nat_flows_for_lb function

To make it easier to add flows to this stage, refactor the function. This also has the benefit that we should see fewer allocations due to rearranging how we create flows and how we manipulate the match string. Signed-off-by: Ales Musil --- northd/northd.c | 397 ++---

Re: [ovs-dev] [RFC PATCH ovn] expr: Use sset for nested expr instead of list

On 11/28/22 15:25, Ales Musil wrote: > To speed up search of possible recursive symbols > use sset. This also prevents the dangling pointer > warning wtih GCC 12 [0]. > > [0] https://bugzilla.redhat.com/2145107 > Signed-off-by: Ales Musil > --- Hi Ales, I think this makes sense but I have a few

Re: [ovs-dev] [OVN v17 3/3] OVN Remote Port Mirroring: controller changes to create ovs mirrors

Hi Mark, Thanks for your review. Agreed. I will remove the 'allow_engine_recompute' related changes in the next patch set. Thanks & Regards, Abhiram R N On Tue, Nov 29, 2022 at 3:24 AM Mark Michelson wrote: > On 11/27/22 15:14, Abhiram R N wrote: > > Mirror creation just creates the mirror. Th

Re: [ovs-dev] [OVN v17 2/3] OVN Remote Port Mirroring: northd changes to sync NB and SB

Hi Mark, Thanks for your review. Please see replies inline below. On Tue, Nov 29, 2022 at 3:23 AM Mark Michelson wrote: > On 11/27/22 15:14, Abhiram R N wrote: > > Changes which syncs the NB port mirrors with SB port mirrors. > > Also test added to check the NB and SB sync > > > > Co-authored-b

Re: [ovs-dev] [PATCH ovn v3 5/5] tutorial: Add scripts to simulate node-port ovn-k8s services.

On 11/29/22 09:14, Han Zhou wrote: > > Better to add a brief help message for the .sh itself. Otherwise, it > invokes the .py and outputs the help message of the .py, which is a little > misleading (although it is fairly easy to figure out by just looking into > the .sh script :) ) > > Acked-by:

Re: [ovs-dev] [PATCH ovn v3 4/5] lb: Support using templates.

On 11/29/22 09:14, Han Zhou wrote: > On Tue, Nov 22, 2022 at 6:15 AM Dumitru Ceara wrote: >> >> Allow the CMS to configure template LBs. The following configurations are >> supported: >> - VIPs of the form: ^vip_variable[:^port_variable|:port] >> - Backends of the form: >> > ^backendip_variable1[

Re: [ovs-dev] [PATCH ovn v3 3/5] controller: Add support for templated actions and matches.

On 11/29/22 09:14, Han Zhou wrote: > > Acked-by: Han Zhou > Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3 2/5] Add NB and SB Template_Var tables.

On 11/29/22 09:13, Han Zhou wrote: > > nit: for the commit title: s/Template_Var/Chassis_Template_Var > Good point, I updated it. > Acked-by: Han Zhou mailto:hz...@ovn.org>> > Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswit

Re: [ovs-dev] [OVN v17 1/3] OVN Remote Port Mirroring: Add new Schemas in NB and SB

Hi Mark, Thanks for your review. Please see replies inline below On Tue, Nov 29, 2022 at 3:24 AM Mark Michelson wrote: > Hi, since this patch series doesn't have a cover letter, I figure I > would make some top-level comments on the series here on patch 1. First > off, I suggest running all of

Re: [ovs-dev] [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading

On 28 Nov 2022, at 14:33, Marcelo Leitner wrote: > On Mon, Nov 28, 2022 at 02:17:40PM +0100, Eelco Chaudron wrote: >> >> >> On 28 Nov 2022, at 14:11, Marcelo Leitner wrote: >> >>> On Mon, Nov 28, 2022 at 07:11:05AM +, Tianyu Yuan wrote: > ... Furthermore, I think the current stats

[ovs-dev] [PATCH] Makefile: Add USDT scripts to make install and fedora test rpm.

This change will install all the USDT scripts to the {_datadir}/openvswitch/scripts/usdt directory with the make install command. In addition it will also add them to the Fedora openvswitch-test rpm. Signed-off-by: Eelco Chaudron --- Makefile.am |2 ++ rhel/openvswitch-f

Re: [ovs-dev] [PATCH ovn v2] northd: Improve the LB affinity code

On 11/28/22 19:12, Mark Michelson wrote: > Thanks for the changes, Ales and Dumitru. > > Acked-by: Mark Michelson > Thanks! I pushed this to main branch and to branch-22.12. Regards, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.op

Re: [ovs-dev] [PATCH ovn v3 5/5] tutorial: Add scripts to simulate node-port ovn-k8s services.

On Tue, Nov 22, 2022 at 6:15 AM Dumitru Ceara wrote: > > In a sandbox run: > > $ ./ovn-lb-benchmark.sh > > to simulate an ovn-k8s-like topology with N nodes, VIPS NodePort services > applied to all nodes. Each service has BACKENDS backends. > > If USE_TEMPLATES is "yes" then the configuration

Re: [ovs-dev] [PATCH ovn v3 4/5] lb: Support using templates.

On Tue, Nov 22, 2022 at 6:15 AM Dumitru Ceara wrote: > > Allow the CMS to configure template LBs. The following configurations are > supported: > - VIPs of the form: ^vip_variable[:^port_variable|:port] > - Backends of the form: > ^backendip_variable1[:^port_variable1|:port],^backendip_variable2[

Re: [ovs-dev] [PATCH ovn v3 3/5] controller: Add support for templated actions and matches.

On Tue, Nov 22, 2022 at 6:14 AM Dumitru Ceara wrote: > > Expand SB.Template_Var records in two stages: > 1. first expand them to local values in match/action strings > 2. then reparse the expanded strings > > For the case when a lflow references a Chassis_Template_Var > also track references (simi

Re: [ovs-dev] [PATCH ovn v3 2/5] Add NB and SB Template_Var tables.

nit: for the commit title: s/Template_Var/Chassis_Template_Var Acked-by: Han Zhou On Tue, Nov 22, 2022 at 6:14 AM Dumitru Ceara wrote: > > Propagate the contents of the NB table to the Southbound. > > Signed-off-by: Dumitru Ceara > --- > Note: > - ovn-trace doesn't support template variables (