Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-02 Thread wangchuanlei
Hi eelco, thanks for review again , i will give a new version base on your comments, here, i don't undestand what "Alignment is off" mean, can you give a explanation? thank you! > true }, > +[OVS_VPORT_ATTR_UPCALL_STATS] = { .type = NL_A_NESTED, > +

[ovs-dev] OVS "soft freeze" for 3.1 is in effect.

2023-01-02 Thread Ilya Maximets
Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" state: During the freeze, we ask committers to refrain from applying patches that add new features unless those patches were already being publicly discussed and reviewed before the freeze began.

Re: [ovs-dev] [PATCH v5 1/1] userspace: Add SRv6 tunnel support.

2023-01-02 Thread Ilya Maximets
On 10/11/22 08:11, Nobuhiro MIKI wrote: > SRv6 (Segment Routing IPv6) tunnel vport is responsible > for encapsulation and decapsulation the inner packets with > IPv6 header and an extended header called SRH > (Segment Routing Header). See spec in: > > https://datatracker.ietf.org/doc/html/rfc8754

[ovs-dev] [PATCH v6] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-02 Thread Eelco Chaudron
This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. The following blog explains the Open vSwitch revalidator implementation

Re: [ovs-dev] [PATCH v4] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-02 Thread Eelco Chaudron
On 23 Dec 2022, at 18:00, Adrian Moreno wrote: > On 12/23/22 11:39, Eelco Chaudron wrote: >> >> >> On 23 Dec 2022, at 11:09, Adrian Moreno wrote: >> >>> On 12/22/22 18:42, Adrian Moreno wrote: Hi Eelco, I am not done reviewing this patch. I'm still tyring to figure why I can't

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps

2023-01-02 Thread Roi Dayan via dev
On 21/12/2022 11:34, Eelco Chaudron wrote: > Depending on the driver implementation it can take up to 2 seconds before > offloaded flow statistics are updated. This is causing a problem with > min-revalidate-pps, as old statistic values are used during this period. > > This fix will wait for

Re: [ovs-dev] [PATCH v4] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-02 Thread Eelco Chaudron
On 23 Dec 2022, at 18:05, Adrian Moreno wrote: > On 12/23/22 10:49, Eelco Chaudron wrote: >> >> >> On 22 Dec 2022, at 18:42, Adrian Moreno wrote: >> >>> Hi Eelco, >>> >>> I am not done reviewing this patch. I'm still tyring to figure why I can't >>> make the pahole thing work so I'll continue

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-02 Thread Eelco Chaudron
On 28 Dec 2022, at 3:41, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch upcall to > count the number of packets for upcall succeed and failed, which is a > better way to see how many packets upcalled on every interfaces. See my comments below. Also, let’s

[ovs-dev] [PATCH v2] tests: add unit tests to rculist

2023-01-02 Thread Adrian Moreno
Low test coverage on this area caused some errors to remain unnoticed. Add basic functional test of rculist. Signed-off-by: Adrian Moreno --- Changes since v1: - Fix Windows build --- tests/automake.mk| 1 + tests/library.at | 5 + tests/test-rculist.c | 214