OVN checks whether ovn-installed is already present (in OVS) before updating it.
This might cause ovn-installed related issues in the following case:
- (1) ovn-installed is present
- (2) we claim the interface
- (3) we update ovs, removing ovn-installed and start installing flows
- (4) (next loop),
When interface was unbound, the port was not always set down and the
port_binding->chassis not always removed.
Fixes: a7c7d4519e50 ("controller: avoid recomputes triggered by SBDB
Port_Binding updates.")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2150905
Signed-off-by: Xavier Simon
On 3 Jan 2023, at 21:03, Ilya Maximets wrote:
> On 1/3/23 20:42, William Zhao wrote:
>> Hi Ilya and Eelco,
>>
>> I have seen udpif->dump_duration in revalidate_ukey() go as high as ~2
>> seconds . But the dump duration is very random and sporadic. Most
>> likely a function of how busy the CPU is
Tests was (unluckily) failing as grepping 10.0.0.11 (and expecting an IP)
and catching a UUID such as 103090811468
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 56c1
On 3 Jan 2023, at 19:24, Ilya Maximets wrote:
> On 1/3/23 18:13, Eelco Chaudron wrote:
>> When the ukey's action set changes, it could caus the flow to use a
>> different datapath, for example, when it moves from tc to kernel.
>> This will cause the the cached previous datapath statistics to be
On 12/22/22 16:55, Mike Pattrick wrote:
> Currently tc offload flow packet counters will roll over every ~4
> billion packets. This is because the packet counter in struct
> tc_stats provided by TCA_STATS_BASIC is a 32bit integer.
>
> Now we check for the optional TCA_STATS_PKT64 attribute which p
On 1/2/23 09:58, Adrian Moreno wrote:
> Low test coverage on this area caused some errors to remain unnoticed.
> Add basic functional test of rculist.
>
> Signed-off-by: Adrian Moreno
>
> ---
> Changes since v1:
> - Fix Windows build
Hi, Adrian. Thanks for the update.
I have one big comment a
Most load balancing system tests were randomly failing from time to time
as they were checking that, after 20 requests sent to load balancer, all
backends were at least reached once.
Statistically, this was failing from time to time.
Now, if after 10 requests we did not get the expected distributio
On 12/22/22 14:14, Eelco Chaudron wrote:
> The dpif_execute_helper_cb() function is supposed to add the
> OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the
> list of actions when passing it down to the kernel.
>
> This function was only checking if the IPv4 destination
> address was set, no
The dpif_execute_helper_cb() function is supposed to add the
OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the
list of actions when passing it down to the kernel.
This function was only checking if the IPv4 destination
address was set, not both. This patch fixes this, including
a datapath t
On 4 Jan 2023, at 14:58, Ilya Maximets wrote:
> On 12/22/22 14:14, Eelco Chaudron wrote:
>> The dpif_execute_helper_cb() function is supposed to add the
>> OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the
>> list of actions when passing it down to the kernel.
>>
>> This function was onl
On 1/4/23 11:33, Eelco Chaudron wrote:
>
>
> On 3 Jan 2023, at 19:24, Ilya Maximets wrote:
>
>> On 1/3/23 18:13, Eelco Chaudron wrote:
>>> When the ukey's action set changes, it could caus the flow to use a
>>> different datapath, for example, when it moves from tc to kernel.
>>> This will cause
On 1/4/23 16:28, Eelco Chaudron wrote:
> The dpif_execute_helper_cb() function is supposed to add the
> OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the
> list of actions when passing it down to the kernel.
>
> This function was only checking if the IPv4 destination
> address was set, not
On 12/27/22 22:41, wangchuanlei wrote:
Add support to count upall packets, when kmod of openvswitch upcall to
count the number of packets for upcall succeed and failed, which is a
better way to see how many packets upcalled on every interfaces.
Signed-off-by: wangchuanlei
Hi wangchuanlei,
Currently tc offload flow packet counters will roll over every ~4
billion packets. This is because the packet counter in struct
tc_stats provided by TCA_STATS_BASIC is a 32bit integer.
Now we check for the optional TCA_STATS_PKT64 attribute which provides
the full 64bit packet counter if the 32bit
On 12/22/22 03:58, Eelco Chaudron wrote:
Instead of using all zero stats when executing a revalidate for missed
dp flows, use the last known stats to avoid odd statistics being used.
This feels like it's missing some context. What kind of statistics are
you seeing with using all zeros?
Sign
On 1/4/23 19:15, Mike Pattrick wrote:
> Currently tc offload flow packet counters will roll over every ~4
> billion packets. This is because the packet counter in struct
> tc_stats provided by TCA_STATS_BASIC is a 32bit integer.
>
> Now we check for the optional TCA_STATS_PKT64 attribute which pro
On 1/4/23 10:43, Eelco Chaudron wrote:
>
>
> On 3 Jan 2023, at 21:03, Ilya Maximets wrote:
>
>> On 1/3/23 20:42, William Zhao wrote:
>>> Hi Ilya and Eelco,
>>>
>>> I have seen udpif->dump_duration in revalidate_ukey() go as high as ~2
>>> seconds . But the dump duration is very random and sporad
On 1/4/23 22:58, Ilya Maximets wrote:
> On 1/4/23 10:43, Eelco Chaudron wrote:
>>
>>
>> On 3 Jan 2023, at 21:03, Ilya Maximets wrote:
>>
>>> On 1/3/23 20:42, William Zhao wrote:
Hi Ilya and Eelco,
I have seen udpif->dump_duration in revalidate_ukey() go as high as ~2
seconds . B
Add support to count upall packets, when kmod of openvswitch upcall to
count the number of packets for upcall succeed and failed, which is a
better way to see how many packets upcalled on every interfaces.
Signed-off-by: wangchuanlei
---
Since v1:
- Patch of add support
Since v2:
- Modify format
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Acked-by: Ilya Maximets
Signed-off-by: Han Ding
---
lib/flow.h | 3 ++-
ofproto/ofprot
On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov wrote:
>
> From: Igor Zhukov
>
> Found at https://docs.ovn.org/en/latest/internals/maintainers.html
>
> Signed-off-by: Igor Zhukov
>
> ---
> MAINTAINERS.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS.rst
22 matches
Mail list logo
