[ovs-dev] [PATCH] system-dpdk: Fix error message in ping vhost-user ports.

In some environments, ovs-vswitchd gets shutdown before the pkill of testpmd has been completed, which results in the following error messages: Removing port 'dpdkvhostuser0' while vhost device still attached. To restore connectivity after re-adding of port, VM on socket '' must be restarted.

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

Oh, sorry. You're right. The links don't work on github. For some reason I thought it works. Yes, I don't know what should we do. Broken links are bad. For both github and https://docs.ovn.org/ ___ dev mailing list d...@openvswitch.org https://mail.ope

Re: [ovs-dev] [PATCH] system-dpdk: Fix error message in ping vhost-user ports.

On Thu, Jan 5, 2023 at 10:46 AM Eelco Chaudron wrote: > > In some environments, ovs-vswitchd gets shutdown before the pkill of > testpmd has been completed, which results in the following error messages: > > Removing port 'dpdkvhostuser0' while vhost device still attached. > To restore connect

Re: [ovs-dev] [PATCH v3] dpif: Fix tunnel key set for IPv6 tunnels with SLOW_ACTION.

On 4 Jan 2023, at 18:57, Ilya Maximets wrote: > On 1/4/23 16:28, Eelco Chaudron wrote: >> The dpif_execute_helper_cb() function is supposed to add the >> OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the >> list of actions when passing it down to the kernel. >> >> This function was only c

Re: [ovs-dev] [PATCH] system-dpdk: Fix error message in ping vhost-user ports.

On 5 Jan 2023, at 11:05, David Marchand wrote: > On Thu, Jan 5, 2023 at 10:46 AM Eelco Chaudron wrote: >> >> In some environments, ovs-vswitchd gets shutdown before the pkill of >> testpmd has been completed, which results in the following error messages: >> >> Removing port 'dpdkvhostuser0'

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

On 4 Jan 2023, at 19:36, Michael Santana wrote: > On 12/22/22 03:58, Eelco Chaudron wrote: >> Instead of using all zero stats when executing a revalidate for missed >> dp flows, use the last known stats to avoid odd statistics being used. > This feels like it's missing some context. What kind o

[ovs-dev] [RFC PATCH ovn] utilities: Add simple container automation

Add simple script that allows user to run tests and builds using container. At the same time add example Dockerfile for Fedora 37. Basic usage is: ./utilities/containers/ci.sh This will compile the project with GCC, it expects podman as container platform with default image being "ovn-org/ovn-tes

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

On 1/5/23 11:48, Eelco Chaudron wrote: > > > On 4 Jan 2023, at 19:36, Michael Santana wrote: > >> On 12/22/22 03:58, Eelco Chaudron wrote: >>> Instead of using all zero stats when executing a revalidate for missed >>> dp flows, use the last known stats to avoid odd statistics being used. >> This

[ovs-dev] [PATCH v4] dpif: Fix tunnel key set for IPv6 tunnels with SLOW_ACTION.

The dpif_execute_helper_cb() function is supposed to add the OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the list of actions when passing it down to the kernel. This function was only checking if the IPv4 destination address was set, not both. This patch fixes this, including a datapath t

[ovs-dev] [PATCH] cirrus: Update to use FreeBSD 12.4.

12.4 was released in December. That means that 12.3 will become unavailable in a near future. Updating. Signed-off-by: Ilya Maximets --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index e3c1cd581..952d96431 100644 --- a/.cirrus.yml

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

On 5 Jan 2023, at 12:42, Ilya Maximets wrote: > On 1/5/23 11:48, Eelco Chaudron wrote: >> >> >> On 4 Jan 2023, at 19:36, Michael Santana wrote: >> >>> On 12/22/22 03:58, Eelco Chaudron wrote: Instead of using all zero stats when executing a revalidate for missed dp flows, use the last

[ovs-dev] [PATCH v2] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

Instead of using all zero stats when executing a revalidate for missed dp flows, use the last known stats to avoid odd statistics being used. As these zero stats are stored in the ukey, the next time revalidate_ukey() is called the delta between the new stats and the zero stats is used, which woul

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Reset ukey's last stats value if the datapath changed.

On 4 Jan 2023, at 17:42, Ilya Maximets wrote: > On 1/4/23 11:33, Eelco Chaudron wrote: >> >> >> On 3 Jan 2023, at 19:24, Ilya Maximets wrote: >> >>> On 1/3/23 18:13, Eelco Chaudron wrote: When the ukey's action set changes, it could caus the flow to use a different datapath, for exampl

Re: [ovs-dev] [PATCH v5 1/2] netdev-dpdk: Add per virtqueue statistics.

Hi Ilya, On Thu, Dec 22, 2022 at 12:18 AM Ilya Maximets wrote: > > On 12/19/22 16:03, David Marchand wrote: > > The DPDK vhost-user library maintains more granular per queue stats > > which can replace what OVS was providing for vhost-user ports. > > > > The benefits for OVS: > > - OVS can skip p

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps

On 4 Jan 2023, at 23:02, Ilya Maximets wrote: > On 1/4/23 22:58, Ilya Maximets wrote: >> On 1/4/23 10:43, Eelco Chaudron wrote: >>> >>> >>> On 3 Jan 2023, at 21:03, Ilya Maximets wrote: >>> On 1/3/23 20:42, William Zhao wrote: > Hi Ilya and Eelco, > > I have seen udpif->dump_dur

Re: [ovs-dev] [PATCH v5 1/2] netdev-dpdk: Add per virtqueue statistics.

On 1/5/23 14:31, David Marchand wrote: > Hi Ilya, > > On Thu, Dec 22, 2022 at 12:18 AM Ilya Maximets wrote: >> >> On 12/19/22 16:03, David Marchand wrote: >>> The DPDK vhost-user library maintains more granular per queue stats >>> which can replace what OVS was providing for vhost-user ports. >>>

[ovs-dev] [PATCH] treewide: Don't use non-portable '==' with test command.

'==' is not defined by POSIX and not supported by some shells. This is causing test failures and potential other issues: ./tests/testsuite: 54: test: X2: unexpected operator ./tests/testsuite: 54: test: X157: unexpected operator ./tests/testsuite: 54: test: X116: unexpected operator Reporte

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

We also can copy the content of maintainers.rst with new links instead of ` include:: ../../MAINTAINERS.rst ` so https://github.com/ovn-org/ovn/blob/main/MAINTAINERS.rst and https://github.com/ovn-org/ovn/blob/main/Documentation/internals/maintainers.rst will be independent. But then we need t

Re: [ovs-dev] [PATCH] [ovs-dev v4] dpctl: Add support to count upcall packets

On 5 Jan 2023, at 2:52, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch upcall to > count the number of packets for upcall succeed and failed, which is a > better way to see how many packets upcalled on every interfaces. > > Signed-off-by: wangchuanlei The co

Re: [ovs-dev] [PATCH v5 1/2] netdev-dpdk: Add per virtqueue statistics.

On Thu, Jan 5, 2023 at 2:59 PM Ilya Maximets wrote: > > I did some experiments with a simple mono directionnal setup like: > > virtio-user testpmd/txonly --> ovs --> virtio-user testpmd/rxonly > > I had to restart testpmd between each restart of OVS: it looks like > > virtio-user (as server) recon

Re: [ovs-dev] [PATCH v5 1/2] netdev-dpdk: Add per virtqueue statistics.

On 1/5/23 17:54, David Marchand wrote: > On Thu, Jan 5, 2023 at 2:59 PM Ilya Maximets wrote: >>> I did some experiments with a simple mono directionnal setup like: >>> virtio-user testpmd/txonly --> ovs --> virtio-user testpmd/rxonly >>> I had to restart testpmd between each restart of OVS: it loo

Re: [ovs-dev] [PATCH ovn v2] docs: Extend upgrade documentation.

On Tue, Dec 6, 2022 at 7:34 AM Frode Nordahl wrote: > > As uncovered during the OVSCON'22 open discussion forum on > upgrades, there are some challenges in upgrading from older > versions of OVN. > > Document version requirements for performing a controller first > rolling upgrade. > > Add a secti

[ovs-dev] [PATCH] Documentation: Fix links in the DPDK guide on physical ports.

The text enclosed in '<...>' supposed to be an actual link and not the name of the link. This generates incorrect links that lead nowhere. Also, a single underscore supposed to be used for external links. Signed-off-by: Ilya Maximets --- Documentation/topics/dpdk/phy.rst | 14 +++--- 1

Re: [ovs-dev] [PATCH] Documentation: Fix links in the DPDK guide on physical ports.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 94 characters long (recommended limit is 79) #39 FILE: Documentation/topics/d

[ovs-dev] [PATCH] Documentation: Fix links in maintainers.rst.

GitHub and Sphinx are parsing links differently. Sphinx knows about the overall documentation structure and all the sections defined in other docs, while GitHub is using direct rst 2 html conversion and doesn't know any of that. Sphinx wants links to sections in other docs to be defined with a :d

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

On 1/5/23 08:36, Han Zhou wrote: > On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov wrote: >> >> From: Igor Zhukov >> >> Found at https://docs.ovn.org/en/latest/internals/maintainers.html >> >> Signed-off-by: Igor Zhukov >> >> --- >> MAINTAINERS.rst | 6 +++--- >> 1 file changed, 3 insertions(+), 3

Re: [ovs-dev] [PATCH] [ovs-dev v4] dpctl: Add support to count upcall packets

On 1/5/23 16:40, Eelco Chaudron wrote: > > > On 5 Jan 2023, at 2:52, wangchuanlei wrote: > >> Add support to count upall packets, when kmod of openvswitch upcall to >> count the number of packets for upcall succeed and failed, which is a >> better way to see how many packets upcalled on every in

Re: [ovs-dev] [PATCH] Documentation: Fix links in maintainers.rst.

On Thu, Jan 5, 2023 at 11:42 AM Ilya Maximets wrote: > > GitHub and Sphinx are parsing links differently. Sphinx knows about > the overall documentation structure and all the sections defined in > other docs, while GitHub is using direct rst 2 html conversion and > doesn't know any of that. Sphi

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

On 1/5/23 02:36, Han Zhou wrote: On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov > wrote: > > From: Igor Zhukov mailto:ivzhu...@sbercloud.ru>> > > Found at https://docs.ovn.org/en/latest/internals/maintainers.html

Re: [ovs-dev] [PATCH ovn v2] docs: Extend upgrade documentation.

On 12/13/22 16:55, Mark Michelson wrote: On 12/9/22 09:21, Dumitru Ceara wrote: On 12/6/22 16:34, Frode Nordahl wrote: As uncovered during the OVSCON'22 open discussion forum on upgrades, there are some challenges in upgrading from older versions of OVN. Document version requirements for perfo

[ovs-dev] [PATCH v6 1/2] netdev-dpdk: Add per virtqueue statistics.

The DPDK vhost-user library maintains more granular per queue stats which can replace what OVS was providing for vhost-user ports. The benefits for OVS: - OVS can skip parsing packet sizes on the rx side, - dev->stats_lock won't be taken in rx/tx code unless some packet is dropped, - vhost-user

[ovs-dev] [PATCH v6 2/2] netdev-dpdk: Drop coverage counter for vhost IRQs.

The vhost library now provides finegrained statistics for guest notifications: - notifications for buffer reclaim by the guest, - notifications for buffer availability to the guest, Example before this patch: $ ovs-appctl coverage/show | grep vhost_notification vhost_notification 0.0/sec

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

On Thu, Jan 5, 2023 at 12:13 PM Mark Michelson wrote: > > On 1/5/23 02:36, Han Zhou wrote: > > > > > > On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov > > wrote: > > > > > > From: Igor Zhukov > > > > > > > Found at https://docs.ovn.org/en/latest/internals/maintainers.htm

[ovs-dev] [PATCH v9] tc: Add support for TCA_STATS_PKT64

Currently tc offload flow packet counters will roll over every ~4 billion packets. This is because the packet counter in struct tc_stats provided by TCA_STATS_BASIC is a 32bit integer. Now we check for the optional TCA_STATS_PKT64 attribute which provides the full 64bit packet counter if the 32bit

[ovs-dev] [PATCH ovn 0/4] Add support for OVSDB Relay in OVN SB DB

This patch series adds support to run utilize OVSDB Relay functionality in OVN: - add new commands to ovn-ctl script - add new systemd-unit ovn-db@.service to manage ovsdb-servers - add support to run against non-leader to ovn-controller-vtep - add documentation about OVSDB Relay usage in OVN Vlad

[ovs-dev] [PATCH ovn 1/4] rhel, ovn-ctl: add support to run OVN SB relay

New ovn-ctl commands were added: - start_sb_relay_ovsdb - stop_sb_relay_ovsdb - restart_sb_relay_ovsdb Required configuration parameters are: --db-sb-relay-remote - needed to supply upstream cluster/server remote. Optionally user may pass next parameters: --db-sb-relay-sock --db-sb-relay-pidfile

[ovs-dev] [PATCH ovn 2/4] rhel: add ovn-db@.service systemd-unit

With this universal systemd unit users, which run ovsdb-servers with systemd, will be able to run different OVSDB server instances within separate systemd-units. Now it is possible to run all commands from ovn-ctl script, which start and end with "start_/stop_" and "_ovsdb" respectively. Current l

[ovs-dev] [PATCH ovn 3/4] vtep: set SB DB ovsdb_idl to no_leader_only mode

This adds capability to run ovn-controller-vtep against OVN Southbound OVSDB server running in relay mode. Signed-off-by: Vladislav Odintsov --- controller-vtep/ovn-controller-vtep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/controller-vtep/ovn-controller-vtep.c b/controller-vtep/ovn-

Re: [ovs-dev] [PATCH ovn 1/4] rhel, ovn-ctl: add support to run OVN SB relay

Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 100 characters long (recommended limit is 79) #49 FILE: utilities/ovn-ct

Re: [ovs-dev] [PATCH ovn 2/4] rhel: add ovn-db@.service systemd-unit

Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #98 FILE: rhel/usr_lib_syst

Re: [ovs-dev] [PATCH ovn 4/4] docs: add tutorial for ovsdb relay usage

Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #5176 FILE: Documentation/t

Re: [ovs-dev] [PATCH ovn v2] ovn-sbctl: Fix removal of Chassis_Private record on chassis-del.

On Wed, Dec 14, 2022 at 12:11 PM Frode Nordahl wrote: > > After commit 4adc10f58127e, the ovn-controller will populate both > Chassis and Chassis_Private tables on registration. > > The `ovn-sbctl chassis-del` command exists so that an administrator > can manually remove a chassis record when need

Re: [ovs-dev] [PATCH] ovsdb: Fix database statistics during the database replacement.

On Tue, Jan 3, 2023 at 8:22 AM Ilya Maximets wrote: > > The counter for the number of atoms has to be re-set to the number from > the new database, otherwise the value will be incorrect. For example, > this is causing the atom counter doubling after online conversion of > a clustered database. >

Re: [ovs-dev] [PATCH] system-dpdk: Fix error message in ping vhost-user ports.

On Thu, Jan 5, 2023 at 11:17 AM Eelco Chaudron wrote: > On 5 Jan 2023, at 11:05, David Marchand wrote: > > On Thu, Jan 5, 2023 at 10:46 AM Eelco Chaudron wrote: > >> > >> In some environments, ovs-vswitchd gets shutdown before the pkill of > >> testpmd has been completed, which results in the fol