Using a bitmap makes the id-pool use less memory and be more
cache-friendly. It theoretically should be faster since hashes do not
have to be computed.
This takes the approach of expanding the bitmap when necessary rather
than allocating the entire space at once. This makes the approach less
On 1/12/23 18:17, Ales Musil wrote:
> Add extension that allows to flush connections from CT
> by specifying fields that the connections should be
> matched against. This allows to match only some fields
> of the connection e.g. source address for orig direction.
>
> Reported-at:
On 1/12/23 18:17, Ales Musil wrote:
> Currently, the CT can be flushed by dpctl only by specifying
> the whole 5-tuple. This is not very convenient when there are
> only some fields known to the user of CT flush. Add new struct
> ofputil_ct_match which represents the generic filtering that can
>
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see
Signed-off-by: Vladislav Odintsov
---
controller-vtep/ovn-controller-vtep.c | 33 ++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/controller-vtep/ovn-controller-vtep.c
b/controller-vtep/ovn-controller-vtep.c
index df20816ff..26f8fd115 100644
---
On Tue, Oct 18, 2022 at 8:03 AM Adrian Moreno wrote:
>
> Add options to the IPFIX table configure the interval to send statistics
> and template information.
>
> Signed-off-by: Adrian Moreno
Looks good!
Acked-by: Mike Pattrick
> ---
> NEWS | 2 ++
>
On 1/13/23 14:30, David Marchand wrote:
> On Fri, Jan 13, 2023 at 1:58 PM Ilya Maximets wrote:
>>
>> On 1/12/23 21:55, David Marchand wrote:
>>> As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock
>>> and OVS dev->mutex when OVS main thread refreshes statistics, while a
>>>
Some control protocols are used to maintain link status between
forwarding engines (e.g. LACP). When the system is not sized properly,
the PMD threads may not be able to process all incoming traffic from the
configured Rx queues. When a signaling packet of such protocols is
dropped, it can cause
On 1/12/23 21:09, Dumitru Ceara wrote:
> On 1/12/23 21:08, Mark Michelson wrote:
>> On 1/12/23 15:03, Dumitru Ceara wrote:
>>> On 1/12/23 20:58, Mark Michelson wrote:
I made the change Dumitru suggested (checkout@v3 instead of checkout@v2)
and merged both patches to main.
On 1/11/23 20:40, Mark Michelson wrote:
> Acked-by: Mark Michelson
>
Thanks Ales, Mark! I applied this to the main branch.
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/11/23 20:40, Mark Michelson wrote:
> Thanks, Ales,
>
> Acked-by: Mark Michelson
>
Thanks Ales, Mark! I applied this to the main branch.
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
On Fri, Jan 13, 2023 at 1:58 PM Ilya Maximets wrote:
>
> On 1/12/23 21:55, David Marchand wrote:
> > As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock
> > and OVS dev->mutex when OVS main thread refreshes statistics, while a
> > vring state change event is being processed for
Kevin Traynor, Jan 12, 2023 at 14:56:
> > +(void) dpdk_cp_prot_rss_configure(dev, dev->up.n_rxq);
>
> I'm wondering is this needed? It is allowing traffic go to the extra
> cp-proto queue that the user has not request for general traffic until
> later when it is stopped. I don't see a need to
Kevin Traynor, Jan 13, 2023 at 12:05:
> Hi Robin - not sure if you saw the test report from Intel:
> https://mail.openvswitch.org/pipermail/ovs-build/2023-January/027792.html
>
> There is a problem with adding vhost port, existing before cp-prot is
> enabled. see below,
>
> 5500│ /* Enable TX
References: <20230113124423.242017-1-sangana.abhi...@nutanix.com>
Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82
On 1/12/23 21:55, David Marchand wrote:
> As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock
> and OVS dev->mutex when OVS main thread refreshes statistics, while a
> vring state change event is being processed for a same vhost port.
>
> To break from this situation, move
When a flow gets modified, i.e. the actions are changes, the tc layer will
remove, and re-add the flow. This is causing all the counters to be reset.
This patch will remember the previous tc counters and adjust any requests
for statistics. This is done in a similar way as the rte_flow
On 12 Jan 2023, at 18:29, Michael Santana wrote:
> On 12/15/22 09:52, Eelco Chaudron wrote:
>> When a flow gets modified, i.e. the actions are changes, the tc layer will
>> remove, and re-add the flow. This is causing all the counters to be reset.
>>
>> This patch will remember the previous tc
This patch commits connections dropped/rejected by ACLs with label
(introduced in 0e0228be (northd: Add ACL label)) to the connection
tracking table. The dropped connections are committed in a separate
conntrack zone so that they can be managed independently and do not
interact with the connection
Bleep bloop. Greetings dheeraj, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author dheeraj needs to sign off.
WARNING: Unexpected sign-offs from developers who are not
Hi team ,
I have addressed all the comments . Please review .
Regards ,
Dheeraj
-Original Message-
From: Ilya Maximets
Sent: 22 December 2022 02:41
To: Dheeraj Kumar ; ovs-dev@openvswitch.org
Cc: i.maxim...@ovn.org; Kevin Traynor
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Optimize
Problem Statement:
Before OVS 2.12 the OVS-DPDK datapath transmitted processed rx packet batches
directly to the wanted tx queues. In OVS 2.12 each PMD stores the processed
packets in an intermediate buffer per output port and flushes these output
buffers in a separate step. This buffering was
On Fri, Jan 13, 2023 at 10:52 AM Dumitru Ceara wrote:
> Otherwise it's hard to tell which ones are applied before and which ones
> are applied after load balancing.
>
> Signed-off-by: Dumitru Ceara
> ---
> tests/ovn-nbctl.at| 9 +
> utilities/ovn-nbctl.c | 7 +++
> 2 files
On Wed, Jan 11, 2023 at 11:46 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Rely on IP protocol from the incoming packet for learn action
> in table 68 if it has not specified in the related load-balancer.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2157846
>
On 12/01/2023 13:56, Kevin Traynor wrote:
On 11/01/2023 11:19, Robin Jarry wrote:
Some control protocols are used to maintain link status between
forwarding engines (e.g. LACP). When the system is not sized properly,
the PMD threads may not be able to process all incoming traffic from the
Hi Dumitru,
just one small comment below.
On Thu, Dec 15, 2022 at 10:29 PM Dumitru Ceara wrote:
> To do this we factor the memory trimming code out into its own module,
> memory-trim. We use this now for both the lflow cache (in
> ovn-controller) and for ovn-northd.
>
> Signed-off-by: Dumitru
On Thu, Dec 15, 2022 at 10:29 PM Dumitru Ceara wrote:
> Signed-off-by: Dumitru Ceara
> ---
> northd/ovn-northd.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index 82d2874d66..3a575b02a5 100644
> ---
On Wed, Dec 14, 2022 at 7:22 PM Xavier Simonart wrote:
> The first ping from pod to external (through patch port) might fail.
> The icmp packet is properly sent by pinctrl (after L2 resolution) to OVS,
> and OVS receives the packet with in_port set to the patch port (on br-int
> side).
> OVS
Thanks for the review Mike,
I'll update the patch.
On 1/13/23 06:55, Mike Pattrick wrote:
On Tue, Oct 18, 2022 at 8:02 AM Adrian Moreno wrote:
IPFIX templates have to be sent for each Observation Domain ID.
Currently, a timer is kept at each dpif_ipfix_exporter to send them.
This works fine
On 1/6/23 20:15, Mark Michelson wrote:
For the code change itself,
Acked-by: Mark Michelson
I have a note about the commit message.
On 12/19/22 11:18, Adrian Moreno wrote:
The default zero value can lead to sampling errors if the pipeline sets
an the input port to OFP_NONE during flow
Otherwise it's hard to tell which ones are applied before and which ones
are applied after load balancing.
Signed-off-by: Dumitru Ceara
---
tests/ovn-nbctl.at| 9 +
utilities/ovn-nbctl.c | 7 +++
2 files changed, 16 insertions(+)
diff --git a/tests/ovn-nbctl.at
On 12/01/2023 19:00, Ilya Maximets wrote:
On 1/11/23 11:24, David Marchand wrote:
On Wed, Jan 11, 2023 at 10:35 AM Kevin Traynor wrote:
Sleep for an incremental amount of time if none of the Rx queues
assigned to a PMD have at least half a batch of packets (i.e. 16 pkts)
on an polling
On 1/6/23 20:15, Mark Michelson wrote:
The code change on its own is fine, so
Acked-by: Mark Michelson
I have a note down below.
On 12/19/22 11:18, Adrian Moreno wrote:
Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental
in terms of performance) if a
On Fri, Jan 13, 2023 at 10:19 AM Maxime Coquelin
wrote:
> > +static void
> > +netdev_dpdk_vhost_run(const struct netdev_class *netdev_class OVS_UNUSED)
> > +{
> > +struct mpsc_queue_node *node;
> > +
> > +mpsc_queue_acquire(_state_change_queue);
> > +MPSC_QUEUE_FOR_EACH_POP (node,
On 1/2/23 16:30, Eelco Chaudron wrote:
This patch adds a Python script that can be used to analyze the
revalidator runs by providing statistics (including some real time
graphs).
The USDT events can also be captured to a file and used for
later offline analysis.
The following blog explains
Hi David,
On 1/12/23 21:55, David Marchand wrote:
As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock
and OVS dev->mutex when OVS main thread refreshes statistics, while a
vring state change event is being processed for a same vhost port.
To break from this situation, move
On 1/12/23 20:59, Han Zhou wrote:
> On Thu, Jan 12, 2023 at 9:50 AM Dumitru Ceara wrote:
>>
>> Until now we only mentioned it on the ovn.org releases page:
>> https://www.ovn.org/en/releases/
>>
>> Signed-off-by: Dumitru Ceara
>> ---
>> Documentation/internals/release-process.rst | 1 +
>> 1
37 matches
Mail list logo
