Re: [ovs-dev] [PATCH v8] netdev-dpdk: add control plane protection support

Hi Kevin, Kevin Traynor, Jan 17, 2023 at 19:38: > I saw in patchwork that there was a CI fail but I didn't examine it. > Perhaps you could check and confirm about it. Yes I saw it and I didn't understand what went wrong: 2023-01-13T15:44:29.422Z|1|dpif_netdev(revalidator75)|ERR|internal erro

Re: [ovs-dev] [PATCH v4 ovn] northd: move hairpin stages before acl_after_lb

On Tue, Jan 17, 2023 at 8:11 AM Dumitru Ceara wrote: > > On 12/15/22 07:37, Han Zhou wrote: > > On Wed, Dec 14, 2022 at 2:52 PM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > >> > >> In the current codebase ct_commit {} action clears ct_state metadata of > >> the incoming packet. Thi

Re: [ovs-dev] [PATCH v8] netdev-dpdk: add control plane protection support

Hi Robin, A few additional comments below. I saw in patchwork that there was a CI fail but I didn't examine it. Perhaps you could check and confirm about it. thanks, Kevin. On 13/01/2023 14:58, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding eng

Re: [ovs-dev] [PATCH] ovsdb: Fix database statistics during the database replacement.

On Tue, Jan 17, 2023 at 10:13 AM Ilya Maximets wrote: > > On 1/6/23 07:35, Han Zhou wrote: > > > > > > On Tue, Jan 3, 2023 at 8:22 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> The counter for the number of atoms has to be re-set to the number from > >> the new database, otherwise

Re: [ovs-dev] [PATCH ovn] utilities: Do not send 'set-db-change-aware' for non-daemon mode tools.

On Tue, Jan 17, 2023 at 4:49 AM Dumitru Ceara wrote: > > On 1/17/23 07:34, Han Zhou wrote: > > On Tue, Jan 10, 2023 at 6:09 PM Han Zhou wrote: > >> > >> This is to avoid annoying error logs from NB/SB/IC DB servers. > >> > >> Reported-by: Girish Moodalbail > >> Reported-at: > > https://mail.open

Re: [ovs-dev] [PATCH] ovsdb: Fix database statistics during the database replacement.

On 1/6/23 07:35, Han Zhou wrote: > > > On Tue, Jan 3, 2023 at 8:22 AM Ilya Maximets > wrote: >> >> The counter for the number of atoms has to be re-set to the number from >> the new database, otherwise the value will be incorrect.  For example, >> this is causing the a

[ovs-dev] [PATCH] sparse: Fix numa.h for libnuma >= 2.0.13.

Current numa.h header for sparse re-defines functions in a way that breaks the header from libnuma 2.0.13+, because the original issue was fixed in that version: https://github.com/numactl/numactl/commit/25dcde021dd4f1a1dcac2ba0094f1cb441a2e4a5 Sparse errors as a result: lib/netdev-afxdp.c:

Re: [ovs-dev] [PATCH ovn] controller-vtep: monitor only needed SB tables

Hi Dumitru, yes, it was based on my OVSDB Relay support series, I thought it would be accepted first :) Thanks! Regards, Vladislav Odintsov > On 17 Jan 2023, at 19:11, Dumitru Ceara wrote: > > On 1/13/23 21:03, Vladislav Odintsov wrote: >> Signed-off-by: Vladislav Odintsov >> --- >> control

Re: [ovs-dev] [PATCH v4 ovn] northd: move hairpin stages before acl_after_lb

On 12/15/22 07:37, Han Zhou wrote: > On Wed, Dec 14, 2022 at 2:52 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: >> >> In the current codebase ct_commit {} action clears ct_state metadata of >> the incoming packet. This behaviour introduces an issue if we need to >> check the connectio

Re: [ovs-dev] [PATCH ovn 1/2] ovn-northd: Add IDL memory usage information.

On 1/13/23 11:29, Ales Musil wrote: > On Thu, Dec 15, 2022 at 10:29 PM Dumitru Ceara wrote: > >> Signed-off-by: Dumitru Ceara >> --- >> northd/ovn-northd.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c >> index 82d2874

Re: [ovs-dev] [PATCH ovn] controller-vtep: monitor only needed SB tables

On 1/13/23 21:03, Vladislav Odintsov wrote: > Signed-off-by: Vladislav Odintsov > --- > controller-vtep/ovn-controller-vtep.c | 33 ++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/controller-vtep/ovn-controller-vtep.c > b/controller-vtep/ovn-contro

Re: [ovs-dev] [PATCH ovn] nbctl: Display "apply-after-lb" information when listing ACLs.

On 1/13/23 12:20, Ales Musil wrote: > On Fri, Jan 13, 2023 at 10:52 AM Dumitru Ceara wrote: > >> Otherwise it's hard to tell which ones are applied before and which ones >> are applied after load balancing. >> >> Signed-off-by: Dumitru Ceara >> --- >> tests/ovn-nbctl.at| 9 + >> uti

Re: [ovs-dev] [PATCH ovn 2/2] northd: Add automatic memory trimming when idle.

On 1/13/23 12:02, Ales Musil wrote: > Hi Dumitru, > just one small comment below. > > On Thu, Dec 15, 2022 at 10:29 PM Dumitru Ceara wrote: > >> To do this we factor the memory trimming code out into its own module, >> memory-trim. We use this now for both the lflow cache (in >> ovn-controller)

Re: [ovs-dev] [PATCH ovn] ovn-trace: Use the original ovnact for execute_load

On 12/15/22 10:13, Ales Musil wrote: > Compiling with GCC and -fsanitize=undefined throws > a warning [0]. To avoid that, use the original > ovnact pointer with the inner size rather than getting > the inner "struct ovnact" from the "struct ovnact_load". > > At the same time simplify the computati

Re: [ovs-dev] [PATCH ovn 2/2] northd: Add automatic memory trimming when idle.

On 1/12/23 20:26, Mark Michelson wrote: > Thanks for this Dumitru, > > Acked-by: Mark Michelson > > I have one note down below, however I don't think it's critical enough > not to ack the patch. > > On 12/15/22 16:25, Dumitru Ceara wrote: >> To do this we factor the memory trimming code out int

Re: [ovs-dev] [PATCH ovn] controller: Fix missing first ping from pod to external

On 1/13/23 11:27, Ales Musil wrote: > On Wed, Dec 14, 2022 at 7:22 PM Xavier Simonart wrote: > >> The first ping from pod to external (through patch port) might fail. >> The icmp packet is properly sent by pinctrl (after L2 resolution) to OVS, >> and OVS receives the packet with in_port set to th

Re: [ovs-dev] [PATCH ovn] doc: Explicitly mention the current LTS release.

On 1/17/23 04:02, Dumitru Ceara wrote: On 1/16/23 22:56, Mark Michelson wrote: On 1/13/23 03:01, Dumitru Ceara wrote: On 1/12/23 20:59, Han Zhou wrote: On Thu, Jan 12, 2023 at 9:50 AM Dumitru Ceara wrote: Until now we only mentioned it on the ovn.org releases page: https://www.ovn.org/en/re

Re: [ovs-dev] [PATCH v21 0/8] Add offload support for sFlow

On 3/17/22 02:12, Chris Mi wrote: > This patch set adds offload support for sFlow. > > Psample is a genetlink channel for packet sampling. TC action act_sample > uses psample to send sampled packets to userspace. > > When offloading sample action to TC, userspace creates a unique ID to > map sFlo

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

On 1/17/23 10:19, Eelco Chaudron wrote: This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. The following blog explains t

Re: [ovs-dev] [PATCH ovn] utilities: Do not send 'set-db-change-aware' for non-daemon mode tools.

On 1/17/23 07:34, Han Zhou wrote: > On Tue, Jan 10, 2023 at 6:09 PM Han Zhou wrote: >> >> This is to avoid annoying error logs from NB/SB/IC DB servers. >> >> Reported-by: Girish Moodalbail >> Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-July/050343.html >> Signed-off-by

Re: [ovs-dev] [PATCH ovn] northd, controller: Commit flows dropped by ACLs to conntrack

Hi Mark, Thanks for reviewing the patch. > On 16 Jan 2023, at 21:34, Mark Michelson wrote: > > Hello Abhiram, > > I haven't taken a close look at every line of the series, but I have two > high-level questions/observations. > > First, what is the benefit of using this compared to ACL logging

Re: [ovs-dev] [PATCH] netdev-offload-tc: del ufid mapping if device not exist

On 12 Jan 2023, at 7:55, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The traffic will tri

[ovs-dev] [PATCH v7 1/1] userspace: Add SRv6 tunnel support.

SRv6 (Segment Routing IPv6) tunnel vport is responsible for encapsulation and decapsulation the inner packets with IPv6 header and an extended header called SRH (Segment Routing Header). See spec in: https://datatracker.ietf.org/doc/html/rfc8754 This patch implements SRv6 tunneling in userspace d

Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

On 1/16/23 21:00, Mike Pattrick wrote: On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote: From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling wher

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall.c: Add counters for reasons of DP flow deletions.

On 17 Jan 2023, at 4:11, Han Zhou wrote: > On Mon, Jan 16, 2023 at 7:36 AM Eelco Chaudron wrote: >> >> >> >> On 18 Oct 2022, at 18:11, Adrian Moreno wrote: >> >>> On 10/14/22 20:07, Han Zhou wrote: On Thu, Oct 13, 2022 at 11:51 PM Adrian Moreno > wrot

Re: [ovs-dev] [PATCH 1/2] Revalidator: Allow min-revalidator-pps to be 0 (disabled).

On 17 Jan 2023, at 4:08, Han Zhou wrote: > On Mon, Jan 16, 2023 at 7:14 AM Eelco Chaudron wrote: >> >> >> >> On 18 Oct 2022, at 18:08, Adrian Moreno wrote: >> >>> On 10/14/22 19:49, Han Zhou wrote: On Thu, Oct 13, 2022 at 11:43 PM Adrian Moreno > wro

Re: [ovs-dev] [PATCH v2] Revalidator: Allow min-revalidator-pps to be 0.

On 17 Jan 2023, at 4:01, Han Zhou wrote: > Today the minimum value for this setting is 1. This patch allows it to > be 0, meaning not checking pps at all, and always do revalidation. > > This is particularly useful for environments where some of the > applications with long-lived connections ma

[ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. The following blog explains the Open vSwitch revalidator implementation a

Re: [ovs-dev] [PATCH v6] utilities: Add revalidator measurement script and needed USDT probes.

On 13 Jan 2023, at 10:22, Adrian Moreno wrote: > On 1/2/23 16:30, Eelco Chaudron wrote: >> This patch adds a Python script that can be used to analyze the >> revalidator runs by providing statistics (including some real time >> graphs). >> >> The USDT events can also be captured to a file and us

Re: [ovs-dev] [PATCH ovn] doc: Explicitly mention the current LTS release.

On 1/16/23 22:56, Mark Michelson wrote: > On 1/13/23 03:01, Dumitru Ceara wrote: >> On 1/12/23 20:59, Han Zhou wrote: >>> On Thu, Jan 12, 2023 at 9:50 AM Dumitru Ceara wrote: Until now we only mentioned it on the ovn.org releases page: https://www.ovn.org/en/releases/ Sign

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fix deadlock due to virtqueue stats retrieval.

Hi David, On 1/17/23 09:04, David Marchand wrote: As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock and OVS dev->mutex when OVS main thread refreshes statistics, while a vring state change event is being processed for a same vhost port. To break from this situation, move vr

[ovs-dev] [PATCH v6 1/1] userspace: Add SRv6 tunnel support.

SRv6 (Segment Routing IPv6) tunnel vport is responsible for encapsulation and decapsulation the inner packets with IPv6 header and an extended header called SRH (Segment Routing Header). See spec in: https://datatracker.ietf.org/doc/html/rfc8754 This patch implements SRv6 tunneling in userspace d

[ovs-dev] [PATCH v2] netdev-dpdk: Fix deadlock due to virtqueue stats retrieval.

As Ilya reported, we have a ABBA deadlock between DPDK vq->access_lock and OVS dev->mutex when OVS main thread refreshes statistics, while a vring state change event is being processed for a same vhost port. To break from this situation, move vring state change notifications handling from the vhos