Re: [ovs-dev] Wrong unix socket file permissions

2023-01-25 Thread Vladislav Odintsov
Regards, Vladislav Odintsov > On 25 Jan 2023, at 19:16, Ilya Maximets wrote: > > On 1/25/23 16:15, Vladislav Odintsov wrote: >> Hi, >> >> I’m a bit confused about linux unix socket files permissions, created by ovs >> daemons. >> >> From source code [0] I see it sets 0770 fchmod on file des

Re: [ovs-dev] Wrong unix socket file permissions

2023-01-25 Thread Ilya Maximets
On 1/25/23 16:15, Vladislav Odintsov wrote: > Hi, > > I’m a bit confused about linux unix socket files permissions, created by ovs > daemons. > > From source code [0] I see it sets 0770 fchmod on file descriptor prior to > socket bind(), assuming that sock file when creates will inherit FD’s >

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-25 Thread Simon Horman
On Tue, Jan 24, 2023 at 12:22:43PM +0100, Ilya Maximets wrote: ... > I did some research that might answer or maybe clarify the questions above. > Namely reading ARP-related RFCs - 826 and 5227. From these I carried > following: > > - Gratuitous ARP / ARP Announcement messages are generally li

Re: [ovs-dev] [PATCH v2 1/2] ofproto-ipfix: use per-domain template timeouts

2023-01-25 Thread Simon Horman
On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote: > From: Adrian Moreno > > IPFIX templates have to be sent for each Observation Domain ID. > Currently, a timer is kept at each dpif_ipfix_exporter to send them. > This works fine for per-bridge sampling where there is only one > Obser

[ovs-dev] Wrong unix socket file permissions

2023-01-25 Thread Vladislav Odintsov
Hi, I’m a bit confused about linux unix socket files permissions, created by ovs daemons. From source code [0] I see it sets 0770 fchmod on file descriptor prior to socket bind(), assuming that sock file when creates will inherit FD’s permissions. So, I expect that after unix socket files crea

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix misaligned access to ct label.

2023-01-25 Thread Eelco Chaudron
On 25 Jan 2023, at 14:48, Ilya Maximets wrote: > UndefinedBehaviorSanitizer: > > lib/netdev-offload-tc.c:1356:50: runtime error: >member access within misaligned address 0x6071a89c for type >'const struct (unnamed struct at lib/netdev-offload-tc.c:1350:27)', >which requires

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix misaligned access to ct label.

2023-01-25 Thread Simon Horman
On Wed, Jan 25, 2023 at 02:48:52PM +0100, Ilya Maximets wrote: > UndefinedBehaviorSanitizer: > > lib/netdev-offload-tc.c:1356:50: runtime error: >member access within misaligned address 0x6071a89c for type >'const struct (unnamed struct at lib/netdev-offload-tc.c:1350:27)', >wh

[ovs-dev] OVS data-path warm-up for latency sensitive protocols

2023-01-25 Thread Yossi Kuperman via dev
Hello OVS community, OVS is packet driven and rules are configured to the data-path upon packet arrival; first packet is handled by user-space and subsequent packets are processed by the kernel data-path or by the hardware. We encounter an issue with latency sensitive protocols such as PTP/eCPR

[ovs-dev] [PATCH] netdev-offload-tc: Fix misaligned access to ct label.

2023-01-25 Thread Ilya Maximets
UndefinedBehaviorSanitizer: lib/netdev-offload-tc.c:1356:50: runtime error: member access within misaligned address 0x6071a89c for type 'const struct (unnamed struct at lib/netdev-offload-tc.c:1350:27)', which requires 8 byte alignment 0x6071a89c: note: pointer points here

Re: [ovs-dev] [PATCH] system-traffic.at: Skip the 'ICMP6 Related' test if nc is missing.

2023-01-25 Thread Simon Horman
On Tue, Jan 24, 2023 at 05:15:53PM +0100, David Marchand wrote: > On Mon, Jan 23, 2023 at 3:50 PM Simon Horman > wrote: > > > > On Mon, Jan 23, 2023 at 03:29:50PM +0100, David Marchand wrote: > > > On Mon, Jan 23, 2023 at 3:05 PM Ilya Maximets wrote: > > > > > > > > Test fails is 'nc' is not ava

[ovs-dev] [PATCH ovn 2/2] chassis: Remove unsupported config option

2023-01-25 Thread Ales Musil
Remove unsupported config option from other_config in chassis. This should prevent an issue when user upgrades past certain feature and then decides to downgrade for whatever reason. Without the removal the feature flag would stay in the DB causing northd to produce unsupported logical flows. Repo

[ovs-dev] [PATCH ovn 1/2] chassis: Remove unreachable code

2023-01-25 Thread Ales Musil
The parsing functions were always returning true so the negative condition branch couldn't be ever reached. The same applies for non-null ovnsb_idl_txn inside "chassis_private_get_record" this is called under condition that the ovnsb_idl_txn is not null thus the inner condition is redundant. Signe

Re: [ovs-dev] [PATCH ovn] northd, controller: Commit flows dropped by ACLs to conntrack

2023-01-25 Thread Abhiram Sangana
Hi Mark, I have replied to your comments. Can you please have a look when you get a chance? Thanks, Abhiram Sangana > On 17 Jan 2023, at 12:37, Abhiram Sangana wrote: > > Hi Mark, > > Thanks for reviewing the patch. > >> On 16 Jan 2023, at 21:34, Mark Michelson wrote: >> >> Hello Abhiram,