When adding a route with ovs/route/add command, the source address
in "ovs_router_entry" structure is always the FIRST address that the
interface has. See "ovs_router_get_netdev_source_address"
function for more information.
If an interface has multiple ipv4 and/or ipv6 addresses, there are use
ca
We can use the "ip route add ... src ..." command to set the preferred
source address for each entry in the kernel FIB. OVS has a mechanism to
cache the FIB, but the preferred source address is ignored and
calculated with its own logic. This patch resolves the difference
between kernel FIB and OVS
With this series, the preferred source address in ovs-router is obtained
from both ovs/route/add command and kernel FIB.
v2:
* Add NEWS
Nobuhiro MIKI (2):
ovs-router: Introduce src option in ovs/route/add command.
route-table: Retrieving the preferred source address from Netlink.
NEWS
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski :
On Sun, 5 Feb 2023 09:35:37 +0800 you wrote:
> Use actual CPU number instead of hardcoded value to decide the size
> of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>
> 'struct cpumask cpu_used_mask'
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#26 FILE: lib/flow.h:1136:
if
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Signed-off-by: Han Ding
---
lib/flow.h | 15 +--
ofproto/ofproto-dpif-xla
Redefine clear_vlan to initialize one struct vlan_head
Define clear_vlans to initialize key.eth.vlan and key.eth.cvlan
Calls the revised functions accurately
Reasoning:
For vlan packet, current code calls clear_vlan unnecessarily,
since parse_vlan sets key->eth.vlan and key->eth.cvlan correctly
On Mon 2/6/2023 7:35 PM, Eelco Chaudron wrote:
>
> On 6 Feb 2023, at 8:48, Tianyu Yuan wrote:
>
> > On Fri 2/3/2023 8:35 PM, Eelco Chaudron wrote:
> >>
> >> On 30 Jan 2023, at 17:42, Simon Horman wrote:
> >>
> >>> From: Tianyu Yuan
> >>>
> >>> Allow revalidator to continuously delete police in k
Hi all,
I think you can disregard the request below. I made the silly mistake of
forgetting that logical routers and logical switches don't use registers
the same way. There are several general purpose registers that switches
can use, and so there is no need to do any of the items suggested be
Move string_is_valid() to the header for wider use.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
include/linux/string_helpers.h | 5 +
net/tipc/netlink_compat.c | 6 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
net/netlink/genetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
net/openvswitch/conntrack.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
> On 3 Feb 2023, at 16:08, Mark Michelson wrote:
>
> On 1/25/23 05:36, Abhiram Sangana wrote:
>> Hi Mark,
>> I have replied to your comments. Can you please have a look when you get a
>> chance?
>
> I had a look at the code itself, and from a purely mechanical perspective, I
> can't see anyt
Hi everyone,
I am currently implementing
https://bugzilla.redhat.com/show_bug.cgi?id=2134138 , a request for
hierarchical ACLs. I am at a point in the design where I would like to
reach out for developer opinions about how to proceed. I'm going to
leave out some details for the sake of keepin
On 2/4/23 08:31, wushao...@chinatelecom.cn wrote:
> From: Shaohua Wu
>
> description:
> Using the command line to delete flow tables is a risky behavior.
> When the netdev flow table was deleted, only the dpflow was deleted.
> The ukey associated with the dpflow is not deleted.
> When the packet
On Tue, Jan 31, 2023 at 11:21:16AM -0500, Mark Michelson wrote:
> Using a bitmap makes the id-pool use less memory and be more
> cache-friendly. It theoretically should be faster since hashes do not
> have to be computed.
>
> This takes the approach of expanding the bitmap when necessary rather
>
Ales Musil writes:
> On Sun, Feb 5, 2023 at 7:17 PM Paolo Valerio wrote:
>
> Ales Musil writes:
>
> > The inner header was not handled properly.
> > Simplify the code which allows proper handling
> > of the inner headers.
> >
> > Reported-at: https://bugzilla.redhat.com/
On 2/2/23 13:35, Ilya Maximets wrote:
> While running tests with ovn-heater it was observed that locking and
> unlocking dpg_lock can take more than 20% of CPU cycles in northd even
> without any contention.
>
> This series is trying to address that issue and add thread safety
> static analysis.
>
The inner header was not handled properly.
Simplify the code which allows proper handling
of the inner headers.
Reported-at: https://bugzilla.redhat.com/2137754
Signed-off-by: Ales Musil
---
v6: Rebase on top of current master.
Address comments from Paolo:
- Add test case for ICMP related
On 2/3/23 17:17, Mark Michelson wrote:
> Hi Ales,
>
> Thanks for providing the diff between v5 and v6, that made it a lot
> easier to go through the changes.
>
> Acked-by: Mark Michelson
>
Thanks, Ales and Mark! I pushed this to the main branch.
Regards,
Dumitru
On 6 Feb 2023, at 8:48, Tianyu Yuan wrote:
> On Fri 2/3/2023 8:35 PM, Eelco Chaudron wrote:
>>
>> On 30 Jan 2023, at 17:42, Simon Horman wrote:
>>
>>> From: Tianyu Yuan
>>>
>>> Allow revalidator to continuously delete police in kernel tc datapath
>>> until it is deleted.
>>>
>>> In current impl
Yes, Eelco, this is the last revision and no further comments for
revision came in
eddy
On 2023/2/6 19:21, Eelco Chaudron wrote:
On 5 Feb 2023, at 2:35, Eddy Tao wrote:
Use actual CPU number instead of hardcoded value to decide the size
of 'cpu_used_mask' in 'struct sw_flow'. Below is the r
On 5 Feb 2023, at 2:35, Eddy Tao wrote:
> Use actual CPU number instead of hardcoded value to decide the size
> of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>
> 'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
> Its size is hardcoded to CONFIG_NR_CPUS bits, which ca
On 1/30/23 23:04, Mike Pattrick wrote:
> UB Sanitizer report:
>
> lib/hash.h:219:17: runtime error: load of misaligned address
> 0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
> alignment
>
> #0 in hash_words_inline lib/hash.h:219
> #1 in hash_words lib/hash.h:297
> [
On Fri, Feb 3, 2023 at 4:13 PM Ilya Maximets wrote:
>
> On 2/2/23 10:21, David Marchand wrote:
> > On Wed, Feb 1, 2023 at 5:54 PM David Marchand
> > wrote:
> >>
> >> rte_vect.h pulls some AVX512 instrinsics headers added in GCC 12 [1]
> >> trigger a lot of warnings:
> >>
> >> libtool: compile:
When adding a route with ovs/route/add command, the source address
in "ovs_router_entry" structure is always the FIRST address that the
interface has. See "ovs_router_get_netdev_source_address"
function for more information.
If an interface has multiple ipv4 and/or ipv6 addresses, there are use
ca
We can use the "ip route add ... src ..." command to set the preferred
source address for each entry in the kernel FIB. OVS has a mechanism to
cache the FIB, but the preferred source address is ignored and
calculated with its own logic. This patch resolves the difference
between kernel FIB and OVS
With this series, the preferred source address in ovs-router is obtained
from both ovs/route/add command and kernel FIB.
Nobuhiro MIKI (2):
ovs-router: introduce src param in ovs/route/add.
route-table: retrieving the preferred source address from Netlink.
lib/ovs-router.c | 83
On 1/31/23 17:30, Mike Pattrick wrote:
On Tue, Jan 31, 2023 at 10:45 AM Phelan, Michael
wrote:
-Original Message-
From: Ilya Maximets
Sent: Tuesday 31 January 2023 12:23
To: Phelan, Michael ; Mike Pattrick
; Adrián Moreno
Cc: i.maxim...@ovn.org; d...@openvswitch.org; Stokes, Ian
On Sun, Feb 5, 2023 at 7:17 PM Paolo Valerio wrote:
> Ales Musil writes:
>
> > The inner header was not handled properly.
> > Simplify the code which allows proper handling
> > of the inner headers.
> >
> > Reported-at: https://bugzilla.redhat.com/2137754
> > Signed-off-by: Ales Musil
> > ---
>
30 matches
Mail list logo
